From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB4EEC001DC for ; Wed, 26 Jul 2023 09:22:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F39B6B0071; Wed, 26 Jul 2023 05:22:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A3DE6B0074; Wed, 26 Jul 2023 05:22:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 393266B0075; Wed, 26 Jul 2023 05:22:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 295E36B0071 for ; Wed, 26 Jul 2023 05:22:19 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 90BB11C9EE3 for ; Wed, 26 Jul 2023 09:22:18 +0000 (UTC) X-FDA: 81053221956.29.1FDB92C Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf26.hostedemail.com (Postfix) with ESMTP id A10F2140017 for ; Wed, 26 Jul 2023 09:22:16 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jAMndxc3; spf=pass (imf26.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690363336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xHFf+qIXuXcHU2hnpeM9isQldhnSqSauyHf1oBu4R8I=; b=3VatFImEg1xsmz1yyQ1vtwjTe9h16F5S5C3uI1x4+XdsQgm72hOGSclnUZ9FZqazYInx3q BOAoZVnOmenJHFHlTehiCUInZLKCZW70ZmQhC02lgYQfsNADEfC0Nj0N7pjbp3LuHWRXHo Afn8+GhbnHf+Oz16ATBBPt4TzvSoKpM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jAMndxc3; spf=pass (imf26.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690363336; a=rsa-sha256; cv=none; b=Shhm8W9g2b+SNa9Lpxpv5cZrZcFWZMrTg24LpwjYsH1AjYA6bxd3Jya102Mur7p0QztErw KC+qq3YCPl16sO9Lxwwzmiy/uMGierJUyoFmYFo7ImcKGv8kqlaP4UMFaCCl2J0j4DbO2G LIOROeg4D0dzL3dfzM4mgRr0y4QvKIg= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-66d6a9851f3so1487679b3a.0 for ; Wed, 26 Jul 2023 02:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690363335; x=1690968135; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xHFf+qIXuXcHU2hnpeM9isQldhnSqSauyHf1oBu4R8I=; b=jAMndxc3vAfZ9MlugwiN2m1td4+ENgo1ZcEkULNu4w0l2e+7SjL15Aj8xsnH/hg6mq Yuh7Pj+WIpy+9FKbmqcmIZPowwXwCsZ/HE/uYPa/USpf5RWRvsmKXdX1EOhGqDHtCRhA 5Tx4ycmmPjyUjagwQ6weN00EPkG2yYEGVkFAeT+5NL38WWOxpIAWxDe7x+TtdzGSmFXw AaN6OIhFdWcuFQV9AajQEHTHNR/HQhAWIjBkgsz+1GmBQBDd2nNKfKbDgsLcpETIdF18 CdbQtqtDxhcETBnzscklNfC8QDSVXvKpexDlKf4G6IIrjU6vkXpbe5y1T2yEBA/OqHN2 vBww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690363335; x=1690968135; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xHFf+qIXuXcHU2hnpeM9isQldhnSqSauyHf1oBu4R8I=; b=kv3g/4bBGQdUIywP2czxN3Yj7adk6pC3seTd6FIA3ZKTE+GPzZrdB/WdQ2zNXQiv7J l8LGJ8inUHHCYLUf/zNR96gLSL2JddtojeoYAzhTAhFW3uHc2V7wNZAjfkXKhYeY3Kac VSFmz29XTd+axTbSfHq3gEXcXUR7hUxdTo0XbQBe7U3REcT/oWmFcj4WnaFkPt3+BA+h ansDFiQQtmadri3kdNtvXYtFBk6xI5HDK69ezoWJtK2+0L1DMLd+l6atKz5/5pDHY6RZ 8KVSwP+/9uZC+60yN4sCNliOEFlhanRyPDUOxtcBGeDz5C9iesqEtlc4Ezz+3ZaXqqvK I78g== X-Gm-Message-State: ABy/qLbGIznWKXuSTaF6RKbCBWzUR0V8sKe/hk0FxgvHhOCxXJp9Svin x7WnAaLHQlJuxoRmHDp1NKxApw== X-Google-Smtp-Source: APBJJlGzKLkoeooTK7rnc1fJ6mfD6dUCrzzNETRC7Ci4c1Yh8zXhisYlXfajH5gn3qqQbLizO8XVQA== X-Received: by 2002:a05:6a20:729a:b0:100:b92b:e8be with SMTP id o26-20020a056a20729a00b00100b92be8bemr1779967pzk.2.1690363335131; Wed, 26 Jul 2023 02:22:15 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id k11-20020aa790cb000000b006827c26f147sm10955045pfk.138.2023.07.26.02.22.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 02:22:14 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 17:22:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 11/47] gfs2: dynamically allocate the gfs2-qd shrinker Content-Language: en-US To: Muchun Song Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-12-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A10F2140017 X-Rspam-User: X-Stat-Signature: yybnmukbagr8qqrkqggixir48mx66i6y X-Rspamd-Server: rspam01 X-HE-Tag: 1690363336-223488 X-HE-Meta: U2FsdGVkX19flEqkCmdT6eEvEnQ5rz2+6qk6qoxXCLQFJpddDWYO9vUTWLHGOg8YTQmpf1vTCjw5Rm7nAEOiTh83RAJrXS41AzTLixyGZapURoEaQu2+KwQmAVtYvavPXIU6MfMAskG8WGWpwjZTmc+WBLmVupkh9FGDfVxng8taq54F0jKfNPi+44JXO50ok7hOIMK3qpKCYeAPBYiP4u6pyBIIHXQ2PcqxKEYmTJz6CP+DHYH5tmVagdcibLgXYT0UXcaIDjus98yZwj8s2k6ZMVM0ry2i/k/FP2ph7PKuTl15Bc7InfKxLTFLXlZ4dy6EoDNcnZdZps3OAyN5QqcJVpoCl7nOb9QujGpjZkgDjayaqqWNt4dPTszDrbqO8VHypXEZrqgG/zdxK2o/6Qlox6/aEQsmdbBWBVQUxGaUDlqTH2oAd6rncZFIjo7Vmk4lVvezr5DRrRb6I557z4pu636wqB0jpgCo8Uy51+r4gVdq1UQShqNnQNEsG4e7qFnxUVKltN/xQxw1lDDKAx6TnCTlYbuBnyut05GNW/sbTlDB372o1H9gTAsaoar9s6uH1zBTvDlktS8Qh8L7EGq1an0f7Nr6VQsa1jW/UVQaDh01ZvWF4CPFgsNLy8X5PIXmTx2UEWtb92y9gkSRpdWc7oBwMCfSOLbSdliHADqV9+Xqwfn8gbeQ0gihEklmjjhA2myR+SKLE9yhqc01+LB31i6R3moCLPFGRApTjvb4vZmkw49IvYFfWavD0BdXaCY3qJX95orwylXuaOlwtqBN04j0nttqX3WLkOfzUrIl/ySFcWQ5L5WENRjLKzjGCT0uWMprSYKtHbIGfVk/eVPWHVO3JclTxmvZmtpxuqG4X1K2OoJ56HS7oQSYgCXS8YPXBSQp7OTFr6UlXU10FsitjXasuJLPm3IXwbgm6K28caYXo4U4V6XyjHiFb5sStmW5CiPOjKxk1emtxhc HsNMkC57 ZL/9pHK+OpYSuKodekkM8E2iFz6EGsIqcDBPWdeVZEG2iRxNNyJsTmbnKcS/ydqFxG76XsBn8E4LZoNyg7Q/rl4q52u9T7c5z/J4kJufHx+Bs09bSyuM9EGfcLD1uv5rOMoUBGhtJJCIKCfi92vLtIidsIELLvh+wHDFVUnq+oS8t/enTjPvB3YK6DsZC0VWiqT1K+Ta6La5TYQgjDaGh4Jg+IuM1Up+e9Nj255I+pkBVqHge/wgjVDM2KR1HgNgSOeIhm06MKW9PMKWUmvCFYNygbCKwYxUFEGAP3oJvleXWF/dA2vPt3sZ/cfutkokedFGyjcUT/oezmlpCfv+hma5lDbwqhgqpQOHNYLF0Zs+UlEDkgI1vV4NiErN2wBzsQjJDXkftUFfntmM0OjG4oHLvrvR/n2yOe759ETPYAACUZx6subMDW97McKUTKSAryQK8SQdxAzUnbMBnWkB4JBD0+lBg7kj0K8mA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/26 14:49, Muchun Song wrote: > > > On 2023/7/24 17:43, Qi Zheng wrote: >> Use new APIs to dynamically allocate the gfs2-qd shrinker. >> >> Signed-off-by: Qi Zheng >> --- >>   fs/gfs2/main.c  |  6 +++--- >>   fs/gfs2/quota.c | 26 ++++++++++++++++++++------ >>   fs/gfs2/quota.h |  3 ++- >>   3 files changed, 25 insertions(+), 10 deletions(-) >> >> diff --git a/fs/gfs2/main.c b/fs/gfs2/main.c >> index afcb32854f14..e47b1cc79f59 100644 >> --- a/fs/gfs2/main.c >> +++ b/fs/gfs2/main.c >> @@ -147,7 +147,7 @@ static int __init init_gfs2_fs(void) >>       if (!gfs2_trans_cachep) >>           goto fail_cachep8; >> -    error = register_shrinker(&gfs2_qd_shrinker, "gfs2-qd"); >> +    error = gfs2_qd_shrinker_init(); >>       if (error) >>           goto fail_shrinker; >> @@ -196,7 +196,7 @@ static int __init init_gfs2_fs(void) >>   fail_wq2: >>       destroy_workqueue(gfs_recovery_wq); >>   fail_wq1: >> -    unregister_shrinker(&gfs2_qd_shrinker); >> +    gfs2_qd_shrinker_exit(); >>   fail_shrinker: >>       kmem_cache_destroy(gfs2_trans_cachep); >>   fail_cachep8: >> @@ -229,7 +229,7 @@ static int __init init_gfs2_fs(void) >>   static void __exit exit_gfs2_fs(void) >>   { >> -    unregister_shrinker(&gfs2_qd_shrinker); >> +    gfs2_qd_shrinker_exit(); >>       gfs2_glock_exit(); >>       gfs2_unregister_debugfs(); >>       unregister_filesystem(&gfs2_fs_type); >> diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c >> index 704192b73605..bc9883cea847 100644 >> --- a/fs/gfs2/quota.c >> +++ b/fs/gfs2/quota.c >> @@ -186,13 +186,27 @@ static unsigned long gfs2_qd_shrink_count(struct >> shrinker *shrink, >>       return vfs_pressure_ratio(list_lru_shrink_count(&gfs2_qd_lru, sc)); >>   } >> -struct shrinker gfs2_qd_shrinker = { >> -    .count_objects = gfs2_qd_shrink_count, >> -    .scan_objects = gfs2_qd_shrink_scan, >> -    .seeks = DEFAULT_SEEKS, >> -    .flags = SHRINKER_NUMA_AWARE, >> -}; >> +static struct shrinker *gfs2_qd_shrinker; >> + >> +int gfs2_qd_shrinker_init(void) > > It's better to declare this as __init. OK, Will do. > >> +{ >> +    gfs2_qd_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "gfs2-qd"); >> +    if (!gfs2_qd_shrinker) >> +        return -ENOMEM; >> + >> +    gfs2_qd_shrinker->count_objects = gfs2_qd_shrink_count; >> +    gfs2_qd_shrinker->scan_objects = gfs2_qd_shrink_scan; >> +    gfs2_qd_shrinker->seeks = DEFAULT_SEEKS; >> + >> +    shrinker_register(gfs2_qd_shrinker); >> +    return 0; >> +} >> + >> +void gfs2_qd_shrinker_exit(void) >> +{ >> +    shrinker_unregister(gfs2_qd_shrinker); >> +} >>   static u64 qd2index(struct gfs2_quota_data *qd) >>   { >> diff --git a/fs/gfs2/quota.h b/fs/gfs2/quota.h >> index 21ada332d555..f9cb863373f7 100644 >> --- a/fs/gfs2/quota.h >> +++ b/fs/gfs2/quota.h >> @@ -59,7 +59,8 @@ static inline int gfs2_quota_lock_check(struct >> gfs2_inode *ip, >>   } >>   extern const struct quotactl_ops gfs2_quotactl_ops; >> -extern struct shrinker gfs2_qd_shrinker; >> +int gfs2_qd_shrinker_init(void); >> +void gfs2_qd_shrinker_exit(void); >>   extern struct list_lru gfs2_qd_lru; >>   extern void __init gfs2_quota_hash_init(void); >