From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16641C001DF for ; Thu, 3 Aug 2023 13:08:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94536280253; Thu, 3 Aug 2023 09:08:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4F028022C; Thu, 3 Aug 2023 09:08:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79641280253; Thu, 3 Aug 2023 09:08:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 669E428022C for ; Thu, 3 Aug 2023 09:08:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3896C1C9B7A for ; Thu, 3 Aug 2023 13:08:48 +0000 (UTC) X-FDA: 81082823136.13.8B0F1A5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id BBAFD100006 for ; Thu, 3 Aug 2023 13:08:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EsqkwByx; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691068125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mWJpN+HPR5XbieLWrsaf/wc4LSMCej6l0uwrl1WLeOM=; b=WP/EniJ3ajMxWgXz2bWpfG0vb1QWai7Ei8Je7YoUpaFmPEQ/t1pGu7XzGJiYvBjsP9+LgZ ACKkgzI6LvTk8KJyhFuiCvHUeqJo1vqmP2KljMLWm5SsNmnvZQh+oCFCjBuD979f1XQj5l jwM4HBxpsShAqQlVnLhZXW++qFqd9Dg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EsqkwByx; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691068125; a=rsa-sha256; cv=none; b=bwLRURZOcgHJxhhWRhCEBXTHw8NTmxopnWREDK4NxbhdtQmQCQZRXhn5mFGwJgfIthdSKL HUb5Uui6N9EYm7QvUuA9dpdBKEakUFTXX2rU3DO8XCB0VeOoW4HdObdtbEgogZ605vsTPb 1prtT6Oa3O30BVuuP4zrzdwSOVcUJrE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691068124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mWJpN+HPR5XbieLWrsaf/wc4LSMCej6l0uwrl1WLeOM=; b=EsqkwByxsUb5HesDmcRAgI8hUZ0Po/EmNR7nO6p82/Ztlt3JNi4VfDsFyguyT/f+GmkD/D UWH2XhcR1JhseFF1mdQF3Tbikhd4Ah/e4FIJlZF9c4KgdcIvnQXiVQpPoBXzxB1XLS34jz LOzEoVVlDxDWNPVoScOyk7qpn3wd/60= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-nfX-bvQaObmEL83R9Mc0nQ-1; Thu, 03 Aug 2023 09:08:43 -0400 X-MC-Unique: nfX-bvQaObmEL83R9Mc0nQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fe52cd625aso856221e87.0 for ; Thu, 03 Aug 2023 06:08:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691068122; x=1691672922; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mWJpN+HPR5XbieLWrsaf/wc4LSMCej6l0uwrl1WLeOM=; b=P9ZRo/HsB7dC2bXBV1KH1+as7L8eKFvzG2/7I0za35Hjfmu5s4RMxPOSwNT1l51MsC m0g2fWBTSXTXPa61J3ceJ4cMdkNFx7m8phyNXb596Tcn6G3obu7PrcD9MKVUZZ8cjIRQ OxsoOu/TmJhbzK2VfEr0lZXrDBCL3p1woUI/F32zT2QX2geSuDINTmTSxTlaDAL49pAy 1UwNer+LRAqM0yYsYBAVWos9I7usXmrRlQj9pAm/G8+JL7YQdcynsmIqPPezFbTBCkQd 7+PYHH54k+zMp9fIV7L3rtTUlWfV+yRsoZFGSksqUsTpptueMPAdTdZpVuaqahSXp/fb WZmg== X-Gm-Message-State: ABy/qLaMoA7vJ2o/KGSpoCOVS7WMDJyt3c2/bcScOkU6RFBzw+Bw0pHT o3QyjxaU0mQb1ZtU9l/74rlMmpqRkikihbL9orrH0BpRxqVVTWv/07fpW/DC6q1wROm7pNLCs1Y OstPKWkXo6LI= X-Received: by 2002:a19:6755:0:b0:4fd:f827:30b with SMTP id e21-20020a196755000000b004fdf827030bmr7342433lfj.52.1691068122154; Thu, 03 Aug 2023 06:08:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGoiryrzC2ismKdxunCzFCJbRLM7B25sgKcD3Fj2CBZ+zQ84LB/yLC18zq1S8f/iT9Vy5HxEg== X-Received: by 2002:a19:6755:0:b0:4fd:f827:30b with SMTP id e21-20020a196755000000b004fdf827030bmr7342419lfj.52.1691068121772; Thu, 03 Aug 2023 06:08:41 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:9a00:a5f5:5315:b9fa:64df? (p200300cbc7189a00a5f55315b9fa64df.dip0.t-ipconnect.de. [2003:cb:c718:9a00:a5f5:5315:b9fa:64df]) by smtp.gmail.com with ESMTPSA id l7-20020a1c7907000000b003fbb5506e54sm4194333wme.29.2023.08.03.06.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 06:08:41 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 15:08:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/page_alloc: remove unneeded variable base To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230803114934.693989-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230803114934.693989-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BBAFD100006 X-Rspam-User: X-Stat-Signature: gg64wokdsjr8t1pa7gb18qmsb9icad8b X-Rspamd-Server: rspam01 X-HE-Tag: 1691068125-616793 X-HE-Meta: U2FsdGVkX19SeiS+NZ9ICR8nCUibK/ScS6/40PCQQiTBD7buq6S2avbkj0uTz2KPEGrj/Vpa89pXO552OTbsMkA7hrmGjkc7OZrYm246PHyBU2u3KORADObR6OEZqMTvJkBrMp1gqJOyWX8jr88SlDG8nueZNHgRzTodMxu4dV3a3+5aSRZKJEms2paC++ARX3MHkHSsukvKvHW87l/FXCPJT8V4LJ1m5hNdjvAZsizovyIn8B/9bgvn7A1YfifTl4mE3RuQpIOxAxcuPdUyT7qC0lNXfyat9Z2P0VofFqpIV/C0o0eb9IdYOUUump2IsrxqvifW1ZwJJzkPLsQYfvoAJpCEae8urMbifccsSDqh+y61qYolOvAEy96TiXV4kwsW2uFOkDaWvrlzSj8woQE/4scKq/u0q2KxSTb73cvOTCGM7zeEKfCrZ6/jcA43HwBo12SgGKadaArJ7qKDWSZWXrKBn1Xw1iPcPYMgxGvRK3Ej9ptJEkNCs+QbJuE4O/n/ZEX92dzON1G4QSWrm4QdULVwmqSsCMShvADMOobqiR/0mLK7U8liv+RtnD0Lafxc3e+GKl3ttkpciErL1xjf23HLomb9e7SkThCpw+xFIOD5r15UzhO9hn/FKaKT/7RKmtTItq+b9pOFFtaEJ4qmW6ex1SAHTkUBAKfyw77dW5uQmZ/SVpudlA2mXr5o6gyZ0YUg86UbSXf9hOXr/CP/jjJXLs1ano7Nvyqrcrz9Mx9TY5WyGrfJgT6JKW2AZhDkIYBrmUlaff2NZ5CAJbvdh1oI+BLRQYGT8Mr6REVfGg7Zdz5GFtnumVDpPnrOZQMghXf7ji83/ZX/87VLk5SIeByIxPiUtwuEmalJqLotjw06Fev7kfKpWhR48XH5nAcxd9H8dYCWB3iFUQTfYYRVoh4S4wpmk77PlycinGzkDlLgiSj+eki+Npio8f8uf0yqYMUG2WWk6lQmvYX XRKsCvoB xYwqSTOrKmsmr0sQUY8hlnEa3MtBixuc/7MJjZXsgSyhdnTj8bApMGG5ZtYdi7mdJIMTujM/N8fvHdzNNg7tyX6WFmiMSNxAhTdIbukPdMt5UHo/0AnTF7wffWllNxRJqLCOoOuAkJ6t5U2yK7pmfIUoCOrXVQNkHATp6lwRuyLoXgmWAfYgCBEuvobzFwEXiX7VNLpOw764Ze6m5LzNYgyvNGQkJ7Qj+QHXwpNSliAvltoYQJHXcjMEka/5ZIB6VIrXJQiB997hOGtADhkNrNcb59oKbrUmulFUwYbLkja/jCEt28gJa41UcvTxQTEIxhQ154NrqZbJ+Nl7MCb8De+2palQkgvEHhucMVc8OMsVxfpiAAujl1EhkIohPzXSw/VxTcHRYSaSOzasaKkLVPzl9UQewIocCnVkl/p+tqBZ22PTxd8kZd2KNjON2rXlj/NaVFDT+p+RPEYRc82C2mQJokn6GGwHu5XrC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.08.23 13:49, Miaohe Lin wrote: > Since commit 5d0a661d808f ("mm/page_alloc: use only one PCP list for > THP-sized allocations"), local variable base is just as same as order. > So remove it. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index d7a357cb21ee..96b7c1a7d1f2 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -538,8 +538,6 @@ static void bad_page(struct page *page, const char *reason) > > static inline unsigned int order_to_pindex(int migratetype, int order) > { > - int base = order; > - > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > if (order > PAGE_ALLOC_COSTLY_ORDER) { > VM_BUG_ON(order != pageblock_order); > @@ -549,7 +547,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order) > VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER); > #endif > > - return (MIGRATE_PCPTYPES * base) + migratetype; > + return (MIGRATE_PCPTYPES * order) + migratetype; > } > > static inline int pindex_to_order(unsigned int pindex) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb