From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40A28C433DB for ; Tue, 9 Feb 2021 14:30:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ADE1864E6C for ; Tue, 9 Feb 2021 14:30:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADE1864E6C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 30CED6B0074; Tue, 9 Feb 2021 09:30:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BD0B6B0075; Tue, 9 Feb 2021 09:30:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 184AA6B0078; Tue, 9 Feb 2021 09:30:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F34B96B0074 for ; Tue, 9 Feb 2021 09:30:17 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9E1ED180AE81F for ; Tue, 9 Feb 2021 14:30:17 +0000 (UTC) X-FDA: 77798964474.14.cork50_4a17ad927608 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 7441918009D31 for ; Tue, 9 Feb 2021 14:30:17 +0000 (UTC) X-HE-Tag: cork50_4a17ad927608 X-Filterd-Recvd-Size: 3438 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 14:30:16 +0000 (UTC) Received: by mail-il1-f172.google.com with SMTP id a16so16240860ilq.5 for ; Tue, 09 Feb 2021 06:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cab2YQDGLwQqWKzHUVaQ5OkMysUjTn1iQdHgNt5AU6I=; b=BXyVFZsCRu+Kw/ULnfMl3jHNP++xqpSxBDCwAKnXdPEfZ5QyLIf/rqmQ4wQcJlFjVp 7BqM6UOA4weKXs5adGLh0cAptrOqRCSXX9yaNDh9iz1bN6Y9Neiy/6ZIEy4KOCkLhUdO hqx1gixQ9PAcGFBoamEHhgy7CBFYofbBeyV/zu980vmjxRrbcR8Wz9N9v6m3pX7OzUD6 RBN32yFPjFrTXr8Xd5A9iz+A5ebJPD0eCNlmiHqHqztI8N1y5yM3MUUaArBQ3AtLjObT xOMFev/YKeEjBIvxxmCzZLwCrzb0oz5/MOryc79jfQDPjLZPnYZggNFbqc5rjxT8wbx+ twcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cab2YQDGLwQqWKzHUVaQ5OkMysUjTn1iQdHgNt5AU6I=; b=oCeog5UiSrwG+u+nOqmhJU3uPZInBOB3nu49av8tPFUvtn2seXaWV+mkrimkeD4NZ6 6aUx9xXrbwnrPk3lTLs/r/4vAGXtu3i8OSmeEWLgK72o2S8AHkOBbUJ0aTkHQDk0owEW hW3HMvw2RVqngj/0Cv+XFb28zDhAyK+ofhcRQ7cU0K4HFVE/fjJO2tlXbrngvir78n73 mZkOKcBhuMPvDdDl27gBZdPGW1QKLqAPU/ZvBi+H7iTnqN5Q1mbr7S+7WHxWsF5BCl58 SnZHgK779tjYoqsa0i3TMEpCPxQAeFfFOyThtUbOzBbFHg6s4PTwK75l1BCUSoZvXRXY 0gzw== X-Gm-Message-State: AOAM531QtawrKq2YiPp/fE8hhRuO+XGEmi3u5z7HpIxuOKrBe52YdX7h gTa0tODOLIDJpp6z7/Er09GU7A== X-Google-Smtp-Source: ABdhPJyoGFhnjkcWAQUqBZpzFSz9mw3XkGxPt4DVU65yx179ebu5GXPI0y+kXGO5OvMzCMaPtTlMrA== X-Received: by 2002:a05:6e02:180d:: with SMTP id a13mr19950864ilv.156.1612881016215; Tue, 09 Feb 2021 06:30:16 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id k8sm10249656ilu.4.2021.02.09.06.30.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 06:30:15 -0800 (PST) Subject: Re: [PATCH 1/3] mm: provide filemap_range_needs_writeback() helper To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org References: <20210209023008.76263-1-axboe@kernel.dk> <20210209023008.76263-2-axboe@kernel.dk> <20210209074723.GA1696555@infradead.org> From: Jens Axboe Message-ID: Date: Tue, 9 Feb 2021 07:30:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210209074723.GA1696555@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/9/21 12:47 AM, Christoph Hellwig wrote: >> +extern bool filemap_range_needs_writeback(struct address_space *, >> + loff_t lstart, loff_t lend); > > no need for the extern. Just following the style in the file. -- Jens Axboe