From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ED401039895 for ; Fri, 27 Feb 2026 20:39:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C89006B00E6; Fri, 27 Feb 2026 15:39:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C617D6B00EB; Fri, 27 Feb 2026 15:39:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B398C6B00EC; Fri, 27 Feb 2026 15:39:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A18466B00E6 for ; Fri, 27 Feb 2026 15:39:54 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5DA651408AC for ; Fri, 27 Feb 2026 20:39:54 +0000 (UTC) X-FDA: 84491403108.17.A599836 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 8D1D41C0007 for ; Fri, 27 Feb 2026 20:39:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RxJ5UGqT; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1772224792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YGi3bxBcCHARaFdNByMk5N/7ChiuaoCfCBiv8JgqY9M=; b=IXC4M/tsiOnRVTUgK4gnqZSVIukLJw7wYetZfoSRc0/vYBT0Zvh/syRjxx1UyTTWvo0+Y6 3rtnArBypOAslvDs3hKMtupgGBNop8xll+wo+pa9ogPS3cg4KegXsE/RnSq07JzSyYid85 CuK9TYpbCc9L+RhGHYs6bd1WQZul8GY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1772224792; a=rsa-sha256; cv=none; b=fAFnZLS7fTX1D7bx1QcZiMYB/Hi6p3jssaPIRldH0zpS841eLCUQ2X3AycfD1lYE0lz6q9 7XkmJ+a50hE9CeOlpIy+awDuvOsjZiO4Ob/0HLSCMxB4F9WHso8IfiQZDJjn4zcsHHmhOy ioJ/xXPb7HV7aMK5QPonGWcek5kuaSg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RxJ5UGqT; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of david@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=david@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BE5FA4443E; Fri, 27 Feb 2026 20:39:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A931CC2BC87; Fri, 27 Feb 2026 20:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772224791; bh=6KccSK+/RNVKVO6WapQi1OO/X6L6RhvwEhhnUVSuMAk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RxJ5UGqTMhNKcz3e5zUuS7yqBpKIKGYKnFYDUOtnD5ZGQYiDfsCs3wCJeST9JFUvq sHSPFQSEqskEEwbbJoyQ88m8jLoOqmfJfyN1omaSGxymfsx8E/0r9sYdLTnB1Hw0Cu 5JpRAAhg7lQtSdbScJWLdwmqVjf4LuXHQFaFbHzrA3dG5b2kmC7Mb2pnvgsCAIDTv1 cowpF/r/IiyD25YGy6faI6nHyxgGfu3ZQkrjKakFTJYana7ctcU0BXfvDurL0DwtTC JqWRfL6dzb9UhizOZkPWHGkGcxraV9ms7id1GN/HxwvK+TWTMu45VPdiY4/OgRIude EwKBgaQ0Od9lw== Message-ID: Date: Fri, 27 Feb 2026 21:39:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] mm: convert compaction to zone lock wrappers To: Dmitry Ilvokhin , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Brendan Jackman , Johannes Weiner , Zi Yan , Oscar Salvador , Qi Zheng , Shakeel Butt Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-cxl@vger.kernel.orgkernel-team"@meta.com References: <3a09e46f52cf9f709b0725bc2b648cc5212843b2.1772206930.git.d@ilvokhin.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <3a09e46f52cf9f709b0725bc2b648cc5212843b2.1772206930.git.d@ilvokhin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8D1D41C0007 X-Stat-Signature: ryntszbohyze1ef134pxgw89x66ib9nz X-Rspam-User: X-HE-Tag: 1772224792-594736 X-HE-Meta: U2FsdGVkX1/tIzWoGg0u8EwO1zox81kckSVTeSoup4bvgyl4ARQ6YRJ+zTQOrANEdJiiVxIRjwFU4/HU8TJHp9znVJfw7hkP3X6rHkAYHTpBF/4s8qpIfRwn+LF4JmWhqAQyrzO8TjZIJNT7rDdInGr8K+KOjXifYFkgmAQeIPU9pQEWX1T9NK4dPerHpBoSprAo0jSCFBZxRPhkP0Y3J9Y4dhISKK0OAX7UqKYjjf0G2xJ1t4VJYmV6XS2crE7jNZLRM/mlQA/MWOawoYp4W2cOO2Y42FIAHPG70SnwlUeWYic+gYY9rZD3yHBkSTDHvH6JjKykexVphY+h3xD3DeDZqOygBT6gh/OdaW6259XlWJeqkjWBpygp2BhRFWqZbPl4mHdcAAFuCf6AeFH5c4Iq7RIwtdG/6JWL6XjA8K7l05Zm3E6I7yk995ghWhDCfMEWKWuE1P3QpoLV/MnE27WnyaL+1yjUDFsUf6nSSc8Zn2B0uXZqx5kc3ce7HgGhI8giHBNxJpeOElZK+H404/B394S5zI/qMCBj06DHxt3fVJHyG7fAlNqiO/sab69ojp5/2Lrw1qlyH/Z6eO7ZebDZlDWhVQqxidLKeRzUY7jJ3LkA8SmbsVDqoCVbWf7idHtEVasSwoQ/K5xGE6lvhbZiPOes6jVV1APK1aUEursQRqve4WpLB8EwPxgCNA+n8Zx1wA8ohU/HHZRI1JgeFCi/StCD87fA5RA2RAh/P+6oG/2cti2q2Zl+ylxU1MHXp1reS30ZP5hLL7XGqVuWRgcso2yDDwAOaFNgE+QUtJ3GGGx/e4DPn4cBnPhhaQmIvGNSgonLjRyuVcVJaxQcxvFwzNej/Wak5FAA8lJ/2a/fd3T1tOX7vpu63Gyci2632TjBY3qgO96zWjK/CZAk6wnx+Q1pwwknhD5412xO9O6ySzjoG4S/2Ed8+0ot+QedZ1JcnHKCPQZ7NMHZWLN C1ABL1CW buEd9xUamFELj7tIiK5ZGx323HUpP4hJ7g/rdRp7V2muu4TKO5UUU9/6juUeerpktMAwDn0VZar+//oR1tqQVDPadRVUFz3q0GjhpDRR/LAQ9NETFdY2fwToMtwPZudFotRw24B6rVTnpUlzVdJluw6LU93IBO1nD35YqSPj8fknWjcjDzXugiW2P/5cbKP/b4UNXNHOwjRHOxx7Rfz79IpNWoLp3NCci1IOa2hXIWQqODQwx5ft8+AF473GdPD11TD07lnENL0kH8lo5lSkRvjx/OcJzTAgO4e36J1YfGsVns/B1rpEmyznDf3fY7C4caxCFFqnanaRA9uAqAGvBoONZUA== Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/27/26 17:00, Dmitry Ilvokhin wrote: > Compaction uses compact_lock_irqsave(), which currently operates > on a raw spinlock_t pointer so it can be used for both zone->lock > and lruvec->lru_lock. Since zone lock operations are now wrapped, > compact_lock_irqsave() can no longer directly operate on a > spinlock_t when the lock belongs to a zone. > > Split the helper into compact_zone_lock_irqsave() and > compact_lruvec_lock_irqsave(), duplicating the small amount of > shared logic. As there are only two call sites and both statically > know the lock type, this avoids introducing additional abstraction > or runtime dispatch in the compaction path. > > No functional change intended. > > Signed-off-by: Dmitry Ilvokhin > Acked-by: Shakeel Butt > --- > mm/compaction.c | 33 ++++++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index fa0e332a8a92..c68fcc416fc7 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -503,19 +503,36 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page) > * > * Always returns true which makes it easier to track lock state in callers. > */ > -static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, > - struct compact_control *cc) > - __acquires(lock) > +static bool compact_zone_lock_irqsave(struct zone *zone, > + unsigned long *flags, > + struct compact_control *cc) ... two tabs :) Acked-by: David Hildenbrand (Arm) -- Cheers, David