From: David Hildenbrand <david@redhat.com>
To: Dev Jain <dev.jain@arm.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Ingo Molnar <mingo@redhat.com>, Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH v1] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem
Date: Fri, 9 May 2025 09:33:38 +0200 [thread overview]
Message-ID: <d91f6f10-a17e-4bbc-94a1-41b43b41c1ec@redhat.com> (raw)
In-Reply-To: <ecd0bc7e-8af5-40d6-b118-1604d2851f6b@arm.com>
On 09.05.25 07:35, Dev Jain wrote:
>
>
> On 09/05/25 3:50 am, David Hildenbrand wrote:
>> Let's test some basic functionality using /dev/mem. These tests will
>> implicitly cover some PAT (Page Attribute Handling) handling on x86.
>>
>> These tests will only run when /dev/mem access to the first two pages
>> in physical address space is possible and allowed; otherwise, the tests
>> are skipped.
>
Hi Dev,
> Some generic comments:
> 1. I think you should also update .gitignore?
I wonder if we could add a checkpatch warning for that, it keeps on
happening :)
> 2. You can use ksft_exit_fail_perror() for wherever you want to print
> strerror(errno).
Makes sense, thanks!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-05-09 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 22:20 David Hildenbrand
2025-05-09 5:35 ` Dev Jain
2025-05-09 7:33 ` David Hildenbrand [this message]
2025-05-09 9:49 ` Lorenzo Stoakes
2025-05-09 10:18 ` David Hildenbrand
2025-05-09 10:43 ` David Hildenbrand
2025-05-09 10:47 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d91f6f10-a17e-4bbc-94a1-41b43b41c1ec@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dev.jain@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mingo@redhat.com \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox