From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12AFFC54798 for ; Mon, 26 Feb 2024 02:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D99094000B; Sun, 25 Feb 2024 21:43:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8621F940008; Sun, 25 Feb 2024 21:43:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7026E94000B; Sun, 25 Feb 2024 21:43:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5C71E940008 for ; Sun, 25 Feb 2024 21:43:01 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 10C181405E5 for ; Mon, 26 Feb 2024 02:43:01 +0000 (UTC) X-FDA: 81832407762.20.C407FBF Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf21.hostedemail.com (Postfix) with ESMTP id 381871C0008 for ; Mon, 26 Feb 2024 02:42:58 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bFjm+vRc; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708915379; a=rsa-sha256; cv=none; b=nOf7gpBBnuhjiHaZgX/86fXzp+yOJljeeaihdgXHzUdHfw2EOGF+5e//MWeOFDpL5k553D ZMCwqaQZjDzCKqGvB546yxwtql4jM8O3EMSR6Onjtqi5IS7Bl3CHKhagWSC3b8ej2bGp+w /W4w8A0wpFNMEye0MIOxZPGSSrx48dk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bFjm+vRc; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708915379; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C2IqjWh/yWi1m79mN9dV+v0YZlblGMbjVM2Q3IOYH54=; b=ZZXhFUvN96xMGwPzVTWvGidbzJepyOS/aDVabGzxxnvgMaZlhBFjz85gr7Sdp64Pa/JT6g 8sv+yM6elkIT6n6fevS0jKF+Xhgnjfl/NhIIzdcOY1E/ALeCX0uKdNdO7YbWVLxc2VfjyK Fk595Lq4fIf66GHNkVq4rXXHCHnJDRE= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708915377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C2IqjWh/yWi1m79mN9dV+v0YZlblGMbjVM2Q3IOYH54=; b=bFjm+vRcwNAtPWIpm6XptVUfBkkdjZv+25Ep9G6sX9r6KFFQB87NTpRlbyYXzkys+APTEZ wby50uKxS+kra1tcTtwwYRz+2+rj34wrnn6dvN6+dDALXzGoob2NpGB7GMqgjbKNnRkwWP G12RenC4deP0/e9e9BlKywLPj5jXa/Y= Date: Mon, 26 Feb 2024 10:42:27 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] ceph: remove SLAB_MEM_SPREAD flag usage Content-Language: en-US To: Xiubo Li , idryomov@gmail.com, jlayton@kernel.org Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev, Xiongwei.Song@windriver.com, Chengming Zhou References: <20240224134715.829225-1-chengming.zhou@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 381871C0008 X-Stat-Signature: k3cbgjjawggbjdzu6z8b9ar6hojz9rxj X-HE-Tag: 1708915378-927318 X-HE-Meta: U2FsdGVkX1/M4aVJpbkyYXTRzvFC0g/MQTbtiMiY4G375PscRBeP0mJaHNzvTNX2qoNyT4jnwPtOfukqVDzrtHsHKUxbwB9WjkByJ0fJbm3UZ6ecmIJi5epY0ZmV1MJzmjNQCwxXb4WQ0wHaeKPxzr4UOyGbv1w3WXh7kAnZAJcBb9pJRt2AhDfW/ZstQeh8LtvOQhHMU1gHVTtweKl/r6tLk6Khsx9lpo8I648q4SYJLHuR0Qu+w1VVH1x6yQDSpsA0XKUGchFEaNqvH2VElHWts8wPviRZbOfEF9IpANGiz98pGqTfdSIfNS43bYRkII+3EkmDNQEcpiuwREU6MoTL1dqKEIZoYqYwhSLqZqgVEiHcHU6OAx8LPabrL2DOvZNpfnoBNdbly4XvlNh/c61ht/KTfHmMbs+CrD73znLJGOpvENTTF7K4MwePDL8QoZJyRAPM1ZwbNxeS20nLLhloPhJFB+KRwQXycGOtXCw6FMgJCECnY4IGOgmSex4tj7eo9SH+h+u4QsRDS1FPYPXVHytbD0ZDvK58jM6j3BRqOu9NJABB8i23VuaFyEoS1Twz7tHtflBw/7/+L/UIOS24ekwsSHKB75GHCoV8mCMUepsF+n14rlh3oBjbq/9cOEA1sDY70cr939DllrYuzb4Qr8+UKin5vQ9H/zAtqiZLK77fi4al14lNS0ob7GtFamHTSPlHf77wgMXA1MiWTrxStUdLUy9Kdkh4ICkEYg5OwSMmZvutInUd+CisX4ypa/baD4AR56rfXPVBY8oYZivdtnmGDislgAwV3mfOMiuKpF+qrtv2UdBBxOxWP64jl6YIYLnRVNJvN2lVy3aKeXf9SlTX+daX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/26 09:43, Xiubo Li wrote: > Hi Chengming, > > Thanks for your patch. > > BTW, could you share the link of the relevant patches to mark this a no-op ? Update changelog to make it clearer: The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change. [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/ Thanks! > > Thanks > > - Xiubo > > On 2/24/24 21:47, chengming.zhou@linux.dev wrote: >> From: Chengming Zhou >> >> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove >> its usage so we can delete it from slab. No functional change. >> >> Signed-off-by: Chengming Zhou >> --- >>   fs/ceph/super.c | 18 +++++++++--------- >>   1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/fs/ceph/super.c b/fs/ceph/super.c >> index 5ec102f6b1ac..4dcbbaa297f6 100644 >> --- a/fs/ceph/super.c >> +++ b/fs/ceph/super.c >> @@ -928,36 +928,36 @@ static int __init init_caches(void) >>       ceph_inode_cachep = kmem_cache_create("ceph_inode_info", >>                         sizeof(struct ceph_inode_info), >>                         __alignof__(struct ceph_inode_info), >> -                      SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD| >> -                      SLAB_ACCOUNT, ceph_inode_init_once); >> +                      SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT, >> +                      ceph_inode_init_once); >>       if (!ceph_inode_cachep) >>           return -ENOMEM; >>   -    ceph_cap_cachep = KMEM_CACHE(ceph_cap, SLAB_MEM_SPREAD); >> +    ceph_cap_cachep = KMEM_CACHE(ceph_cap, 0); >>       if (!ceph_cap_cachep) >>           goto bad_cap; >> -    ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, SLAB_MEM_SPREAD); >> +    ceph_cap_snap_cachep = KMEM_CACHE(ceph_cap_snap, 0); >>       if (!ceph_cap_snap_cachep) >>           goto bad_cap_snap; >>       ceph_cap_flush_cachep = KMEM_CACHE(ceph_cap_flush, >> -                       SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); >> +                       SLAB_RECLAIM_ACCOUNT); >>       if (!ceph_cap_flush_cachep) >>           goto bad_cap_flush; >>         ceph_dentry_cachep = KMEM_CACHE(ceph_dentry_info, >> -                    SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD); >> +                    SLAB_RECLAIM_ACCOUNT); >>       if (!ceph_dentry_cachep) >>           goto bad_dentry; >>   -    ceph_file_cachep = KMEM_CACHE(ceph_file_info, SLAB_MEM_SPREAD); >> +    ceph_file_cachep = KMEM_CACHE(ceph_file_info, 0); >>       if (!ceph_file_cachep) >>           goto bad_file; >>   -    ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, SLAB_MEM_SPREAD); >> +    ceph_dir_file_cachep = KMEM_CACHE(ceph_dir_file_info, 0); >>       if (!ceph_dir_file_cachep) >>           goto bad_dir_file; >>   -    ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, SLAB_MEM_SPREAD); >> +    ceph_mds_request_cachep = KMEM_CACHE(ceph_mds_request, 0); >>       if (!ceph_mds_request_cachep) >>           goto bad_mds_req; >>   >