linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Gu Bowen <gubowen5@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Breno Leitao <leitao@debian.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Waiman Long <llong@redhat.com>, <stable@vger.kernel.org>,
	<linux-mm@kvack.org>, Lu Jialin <lujialin4@huawei.com>
Subject: Re: [PATCH] mm: Fix possible deadlock in console_trylock_spinning
Date: Tue, 5 Aug 2025 15:44:08 +0800	[thread overview]
Message-ID: <d9128aac-1731-4cf6-ae04-0a86bc761b5b@huawei.com> (raw)
In-Reply-To: <aJD72syGyJs203Mw@arm.com>



On 8/5/2025 2:28 AM, Catalin Marinas wrote:
> On Mon, Aug 04, 2025 at 05:34:10AM -0700, Breno Leitao wrote:
>> On Mon, Aug 04, 2025 at 01:08:15PM +0100, Catalin Marinas wrote:
>>
>> weird enought, lockdep never picked this issue, and I have a few set of
>> hosts running kmemleak and lockdep for a while.
>>
>> This time was different because I have decided to invstiage the code,
>> and found the deadlock. Still, no lockdep complain at all.
> 
> I guess it's because kmemleak is quiet in general, unless problems are
> found, and lockdep never registered this combination - printk() called
> with the kmemleak_lock held.

As you have guessed, this issue occurred right after the kmemleak warning.

Thanks for the reminder about printk_deferred_* and the suggestion 
regarding code comments..

I will send a new version after verification.

Best regards,
Guber


  reply	other threads:[~2025-08-05  7:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30  9:49 Gu Bowen
2025-08-01 22:33 ` Andrew Morton
2025-08-02  3:09   ` Waiman Long
2025-08-02  3:53     ` Andrew Morton
2025-08-04 12:08       ` Catalin Marinas
2025-08-04 12:34         ` Breno Leitao
2025-08-04 18:28           ` Catalin Marinas
2025-08-05  7:44             ` Gu Bowen [this message]
2025-08-06 15:34     ` John Ogness
2025-08-07  3:22       ` Gu Bowen
2025-08-01 23:52 ` Andrew Morton
2025-08-11 14:33   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9128aac-1731-4cf6-ae04-0a86bc761b5b@huawei.com \
    --to=gubowen5@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=leitao@debian.org \
    --cc=linux-mm@kvack.org \
    --cc=llong@redhat.com \
    --cc=lujialin4@huawei.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox