From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13540C6FD1D for ; Thu, 30 Mar 2023 19:36:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7D966B0072; Thu, 30 Mar 2023 15:36:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E076B0074; Thu, 30 Mar 2023 15:36:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D0036B0078; Thu, 30 Mar 2023 15:36:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 79C126B0072 for ; Thu, 30 Mar 2023 15:36:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 343C21A0966 for ; Thu, 30 Mar 2023 19:36:07 +0000 (UTC) X-FDA: 80626570374.02.14C652C Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by imf17.hostedemail.com (Postfix) with ESMTP id 63D2D40016 for ; Thu, 30 Mar 2023 19:36:05 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UoV0qj6H; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680204965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yjsyc1U/glH8MVNEKMozuzln3931VnrKfsax5D9QTMY=; b=fZwRI6BwzxeCH/Zs1/QSxwvKuIE+D4ANw4Qf3hxzggN7O8zqEyVkOPwac8owyciW7W1FpI YrcXa7bk1lCN0xKzzf/XT2NCrY6jvBECPCLkbeT2FqrpUN+II2t4Xn9oLxP/7A0iZPiv1n Sp0fznbnx0qN+N4urSxL0nIMtXAqAjM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=UoV0qj6H; spf=pass (imf17.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680204965; a=rsa-sha256; cv=none; b=G7xYs8udEtWoM+PA3785OoaCLiU7gP521is1ApcC3L5aINEhegvFPxUcZrpuf5afJZbuMj Y+qg3F3TvvxXjz7rGQsCCevUOvEKJbU9a5jjVT7Wr40678D7xrhBNQyUT1UnR0PosCf59h fH8Ek8oeD+k3VZmTS+erPwnZbkF6tts= Received: by mail-wm1-f50.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so12529877wms.1 for ; Thu, 30 Mar 2023 12:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680204964; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yjsyc1U/glH8MVNEKMozuzln3931VnrKfsax5D9QTMY=; b=UoV0qj6HTl4ymIm/xfu/pgW9DRIDmogqu+9W6be7Vl9ThOaapU8Ho7c7cBymRGFlX2 +vFnNuj2xIp8/iGAok4d1AvRZF380xuDHv0polBWOW874MtkvNCASUBXLfhK38ZASWA0 9Xw40Np9wfyFrvdoATfjNfQaCZN6IGzcoCPc88YSjmIxQnvfjNIJnhdJSojDlIOiDGHd 8fp5pNTnRVegh9x/ENYo6EPOZ2YSL96GddDDaHbf3ZHcNVpl6+N05kuuGRRVVq/LHLC1 eG72qZP7TFC8XOtNhGcM1+AyDkn1flEskYCCAgf5X4TxEWrKwagVxA6S6ncEEvrZiB3w Vm+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680204964; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yjsyc1U/glH8MVNEKMozuzln3931VnrKfsax5D9QTMY=; b=6LuPI/w6Toc42L1DpzYg+RURrUUMSwkSf6wpa29PxFePWlZpvFG0UPKUZZw23Njnuh 9FbkPE0G3ifvYSAuLGBTwARtJlrtFxqyLewIGKfiJyI4w9GJ252gx0h2KWuGYOfCAl0F JabtQsYU1SVBdzaYfRJGtJc6xFVKzM0cbyCv63JHNgh5HKOZw6DZC4zb2L1K1BX1KrgW 6Zg4ftTRyRLB4q8J6uOQZkOMQhj2tHILBwBLh9slMWejMy+vj91p8tpc7rLtDnK8vDyo pKuqFYD1V7fDakpkUc/SwnxitTWCaQggAOgVBqtrE5DxQ0LFkkVDSCWtRzuxGDgrS5TB A9aQ== X-Gm-Message-State: AO0yUKX5SCDu5i/4cChwH7UBizkHbwhhmnAuQmK7kBp9dZIIPOk6KsWu tMZoTlhc0y6UZdWzZsiXWXs= X-Google-Smtp-Source: AK7set+4PFx8cRO0C4wS+M8g73FWRWqW+wMdudO+G0U5womMPBMtiR2QwhTPdjknkiRzzKSSGbhRDA== X-Received: by 2002:a7b:cc98:0:b0:3eb:3945:d405 with SMTP id p24-20020a7bcc98000000b003eb3945d405mr18199969wma.38.1680204964086; Thu, 30 Mar 2023 12:36:04 -0700 (PDT) Received: from localhost (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.gmail.com with ESMTPSA id o9-20020a05600c4fc900b003ef6bc71cccsm7626096wmq.27.2023.03.30.12.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 12:36:03 -0700 (PDT) Date: Thu, 30 Mar 2023 20:36:02 +0100 From: Lorenzo Stoakes To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko Subject: Re: [PATCH v4 2/2] lib/test_vmalloc.c: Add vm_map_ram()/vm_unmap_ram() test case Message-ID: References: <20230330190639.431589-1-urezki@gmail.com> <20230330190639.431589-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330190639.431589-2-urezki@gmail.com> X-Stat-Signature: izcdr9h3drqkuytq9rktbiyfjasghm5e X-Rspam-User: X-Rspamd-Queue-Id: 63D2D40016 X-Rspamd-Server: rspam06 X-HE-Tag: 1680204965-447266 X-HE-Meta: U2FsdGVkX18JE2lYTC4twDSXGJhB5JAgwKHVCvMHxcWw2EbJ29XNc7/msylYcdxkAIEYgtIJo9XG7qlOPTBTFz1vlGjn3zs9vi6gmbnvTKcFc+idFFLyTA/kGDALtr1v+aLo4FgiKfOALIb+6A5chY8BT+o0ZmeT2iM2aWcgWYq9L3/GNxTqeqHOnR7MFSLMrthKzpsMPdhNjLCEXLRbDITF6AlWAs9i0SEx3FHcl/9je5eMYCrknrQ5HiB3Z7rGzzwbR2ms/D/kN6Zr7OH9Kjh7CL19wzkKc3oNT8alT6N/wjlLwQoGR6P7U4TjVWhpgGOHrL1qhPQEp39Mmz/1AEs05pfcki8kFtYgbw6cTEUKApSm9ZmGidehOXxseEaEav4dJheu1Zm3GS8PzmfyPisrHKIDrRk5ekEEpzUuMYx9vWJq5pmt5gqdEn924yncTJcvhiyRr/oqKnUoHbLnkik50EpwjdMZIz2M/kCx2cqAy6kc+o9mo6Y611/9A4GVoiHLSEifqHxEmH0Of3DRVlbYDjao+I9+/4xr5bxDNsT1eWtDds//SWjQkRK6VfX0KBuENFxRCUhBRnD8rGjEhfbf7aseSFYWNybw3WaqwM3EQk/lVxQImEuisb6J+Sc6MYcuziyLrh3i1LKzg3fyPw/isGzkrFrIvMUqWZ0krb53L/3zJ4ex+zCvCnmwqH1LIXxOAUGINFHSR2pzfg14rQCW28CFXIq7Eh09L4xe8t7QIFNvH9yeNFf1yT1eWzbF62yV6e1HPnKfIZm1bCDICplZkvAorruXZLzmLwp7FvuxsL6Jk5AJytyVB3XghGpqCH0rh5fE/6b6bhK/n8jIWFMva+U2t2I9qT3L1jje9THXfzb2DXO58KxdKt80OlervD8uP/pxVdehYrqsJbCBgEMDz/ZGqD9cNDeHBAOxbEG3ugyBBCpS8sX9nUR6+FcB4LXLv8BJubk23hw+lKh AJKWxgqV SfFyfA63wr5mdy+VLueMLSIffOWZR9NBZS/J49q1qIqzIkgKg1vGNy7KmLVyvHPyEvpfv4ptcl55WoLCfPSrtHouR07EaW8yXKeREkQdeVsHsdDnLrEithD/7ffcl/F62cKD7ouYiSDA0JD15UInxKr3KdmC7Q9zwSCTovdWnw+fJn7+phgVm1uYdsZpSejlMfQz+6sD8KdPuwxa2Je33XwyCLpMblb+MJKNM5uUcNFGH/r9RU3SO82rb0vy1DgIdimgROCqq8hO0UI/u0LEaapKQLqEoLz9GFKosEKLAZASwM7yuHyyoAgNszOVy2kHPVfAYBz7gF6nhK1biWuFDCMJq07A29FGQJgcV8rRNJLA00GUtmNIOUuS/tZf4C1MBLTW3EBL8PqXo3oz53C1D18CNJZ7+SDtPNJPtAefCypsiRmGP7urP5eYAvR+1+PZHu1XdT8s1n1pMiCgcENkvRTqKRuO7wLkEsi+W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 09:06:39PM +0200, Uladzislau Rezki (Sony) wrote: > Add vm_map_ram()/vm_unmap_ram() test case to our stress test-suite. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > lib/test_vmalloc.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > index cd2bdba6d3ed..1622f3f9ec23 100644 > --- a/lib/test_vmalloc.c > +++ b/lib/test_vmalloc.c > @@ -53,6 +53,7 @@ __param(int, run_test_mask, INT_MAX, > "\t\tid: 128, name: pcpu_alloc_test\n" > "\t\tid: 256, name: kvfree_rcu_1_arg_vmalloc_test\n" > "\t\tid: 512, name: kvfree_rcu_2_arg_vmalloc_test\n" > + "\t\tid: 1024, name: vm_map_ram_test\n" > /* Add a new test case description here. */ > ); > > @@ -358,6 +359,41 @@ kvfree_rcu_2_arg_vmalloc_test(void) > return 0; > } > > +static int > +vm_map_ram_test(void) > +{ > + unsigned long nr_allocated; > + unsigned int map_nr_pages; > + unsigned char *v_ptr; > + struct page **pages; > + int i; > + > + map_nr_pages = nr_pages > 0 ? nr_pages:1; > + pages = kmalloc(map_nr_pages * sizeof(struct page), GFP_KERNEL); > + if (!pages) > + return -1; > + > + nr_allocated = alloc_pages_bulk_array(GFP_KERNEL, map_nr_pages, pages); > + if (nr_allocated != map_nr_pages) > + goto cleanup; Nitty, but there's a whitespace error here, need to convert to tabs :) > + > + /* Run the test loop. */ > + for (i = 0; i < test_loop_count; i++) { > + v_ptr = vm_map_ram(pages, map_nr_pages, NUMA_NO_NODE); > + *v_ptr = 'a'; > + vm_unmap_ram(v_ptr, map_nr_pages); > + } > + > +cleanup: > + for (i = 0; i < nr_allocated; i++) > + __free_page(pages[i]); > + > + kfree(pages); > + > + /* 0 indicates success. */ > + return nr_allocated != map_nr_pages; > +} > + > struct test_case_desc { > const char *test_name; > int (*test_func)(void); > @@ -374,6 +410,7 @@ static struct test_case_desc test_case_array[] = { > { "pcpu_alloc_test", pcpu_alloc_test }, > { "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test }, > { "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test }, > + { "vm_map_ram_test", vm_map_ram_test }, > /* Add a new test case here. */ > }; > > -- > 2.30.2 > Other than the nit, Reviewed-by: Lorenzo Stoakes