From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C53C433DB for ; Thu, 28 Jan 2021 22:48:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE42F64D9E for ; Thu, 28 Jan 2021 22:48:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE42F64D9E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AF7206B0089; Thu, 28 Jan 2021 17:48:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7EDA6B008A; Thu, 28 Jan 2021 17:48:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FA4E6B008C; Thu, 28 Jan 2021 17:48:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 72E996B0089 for ; Thu, 28 Jan 2021 17:48:47 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3BAC0180AD817 for ; Thu, 28 Jan 2021 22:48:47 +0000 (UTC) X-FDA: 77756675094.20.class05_5d0ca98275a3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id F0C3D180C07A3 for ; Thu, 28 Jan 2021 22:48:46 +0000 (UTC) X-HE-Tag: class05_5d0ca98275a3 X-Filterd-Recvd-Size: 4630 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 22:48:46 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id 11so4981801pfu.4 for ; Thu, 28 Jan 2021 14:48:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=jRc+9koAFnFriBYMbCECl8bNtNHOFnGAZDdGQS3iVDU=; b=VX8To19226WV8RDTkFQ5ObLuNZF9XVTO28Kn6srr7oOvy3bJROldWKCMUzp1PQKXf9 DxW/pzBX8qvpyf9JYyEV0tsfWnIQwh8StSLFabjSv9bq/h+LrM8BcShVwk+8h5JEIVAC m7rR/FINIdZ5nzLJ4PtqwDLyuNTB4ApMNbGX1tO8SauTFQvq0jZUXb6tQjVnZTTurC4o JnT9bk1zHAxQ/KJOZ2l5CO8dDG2tvWtV2Yqs/XVrEpJuA4GCbDFdVRNie/dpc5yVuHhc 6tpUXWl/fB3cIiNkDeifZnbig6ARvwbuNY0PAKYEKLOUWsV+N9z5P3YBgnwxTr3v/Wvb uKpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=jRc+9koAFnFriBYMbCECl8bNtNHOFnGAZDdGQS3iVDU=; b=F6V2+4rX74m3gGrWzVnIPCgyB6WMTXzDCZHSrbXbC0YCPSSmCxB/RFzv7+FtbXO9Ze 8hcNo6kb9zejQJteb3S80xZ7GYx5cLeHBG8GAhSbl0W2bIVP6/gMyxiLucQnFmAIwVfZ cYTEJ+tWfvUuhWCBvbLSaGbOFfMToVx6WdXFQ9yHc9/++PsKbsQ5gpfKculK9HgJJwL9 7OKRfGvFAnctaubZDNlt3RG5mwQ7dgaAQxFIzV6NMzkJoaUPaRFCQv4FCfwD+waS9jQ0 NqFUmZ8FCL5WpzxN8aWM6NgUiVLJZL1fNfeWtLAkS9ZGLV+12GB75xCdMXEUX5r5zLHO kpiA== X-Gm-Message-State: AOAM532PSb7j/qEQMJBBrYtnN6YsMz9nqwBXAuAo2Ftib6YBGDlJckCS lwWQY24s6KbefbPrX7PZZ3uruw== X-Google-Smtp-Source: ABdhPJwBVbXS8W3fPe5c+jU1CL/MRyTOw1r5xPcMxMQku9sVK6cWDkTe2rvBDuGwi5tcagKuWF06SA== X-Received: by 2002:a62:f943:0:b029:1a5:43f9:9023 with SMTP id g3-20020a62f9430000b02901a543f99023mr1512252pfm.75.1611874125638; Thu, 28 Jan 2021 14:48:45 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id v1sm7110414pga.63.2021.01.28.14.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jan 2021 14:48:44 -0800 (PST) Date: Thu, 28 Jan 2021 14:48:43 -0800 (PST) From: David Rientjes To: Alexander Lobakin cc: "David S. Miller" , Jakub Kicinski , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved() In-Reply-To: <20210127201031.98544-4-alobakin@pm.me> Message-ID: References: <20210127201031.98544-1-alobakin@pm.me> <20210127201031.98544-4-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Jan 2021, Alexander Lobakin wrote: > A bunch of drivers test the page before reusing/recycling for two > common conditions: > - if a page was allocated under memory pressure (pfmemalloc page); > - if a page was allocated at a distant memory node (to exclude > slowdowns). > > Introduce and use a new common function for doing this and eliminate > all functions-duplicates from drivers. > > Suggested-by: David Rientjes > Signed-off-by: Alexander Lobakin Looks even better than I thought! (Since all of the changes are in drivers/net/ethernet/, I assume everything directly or indirectly includes skbuff.h already.) Acked-by: David Rientjes Thanks for doing this.