From: David Hildenbrand <david@redhat.com>
To: Jann Horn <jannh@google.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
kernel test robot <oliver.sang@intel.com>,
Dev Jain <dev.jain@arm.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Barry Song <baohua@kernel.org>, Pedro Falcato <pfalcato@suse.de>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Bang Li <libang.li@antgroup.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
bibo mao <maobibo@loongson.cn>, Hugh Dickins <hughd@google.com>,
Ingo Molnar <mingo@kernel.org>, Lance Yang <ioworker0@gmail.com>,
Liam Howlett <liam.howlett@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Peter Xu <peterx@redhat.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Yang Shi <yang@os.amperecomputing.com>, Zi Yan <ziy@nvidia.com>,
linux-mm@kvack.org
Subject: Re: [linus:master] [mm] f822a9a81a: stress-ng.bigheap.realloc_calls_per_sec 37.3% regression
Date: Thu, 7 Aug 2025 20:31:18 +0200 [thread overview]
Message-ID: <d8e0f3b3-6ea7-492b-bb94-4f5d1ab28ef2@redhat.com> (raw)
In-Reply-To: <CAG48ez1vM35DZ=kTSd4+ndgR6y33AodLLC2KbfbhGrkDaqdnNQ@mail.gmail.com>
On 07.08.25 20:07, Jann Horn wrote:
> On Thu, Aug 7, 2025 at 8:02 PM David Hildenbrand <david@redhat.com> wrote:
>> Sure, we could use pte_batch_hint(), but I'm curious if x86 would also
>> benefit with larger folios (e.g., 64K, 128K) with this patch.
>
> Where would you expect such a benefit to come from? This function is
> more or less a memcpy(), except it has to read PTEs with xchg(), write
> them atomically, and set softdirty flags. For x86, what the associated
> folios look like and whether the PTEs are contiguous shouldn't matter.
>
Good point, I was assuming TLB flushing as well, but that doesn't really
apply here because we are already batching that.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-08-07 18:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 8:17 kernel test robot
2025-08-07 8:27 ` Lorenzo Stoakes
2025-08-07 8:56 ` Dev Jain
2025-08-07 10:21 ` David Hildenbrand
2025-08-07 16:06 ` Dev Jain
2025-08-07 16:10 ` Lorenzo Stoakes
2025-08-07 16:16 ` Lorenzo Stoakes
2025-08-07 17:04 ` Dev Jain
2025-08-07 17:07 ` Lorenzo Stoakes
2025-08-07 17:11 ` Dev Jain
2025-08-07 17:37 ` Jann Horn
2025-08-07 17:41 ` Lorenzo Stoakes
2025-08-07 17:46 ` Jann Horn
2025-08-07 17:50 ` Dev Jain
2025-08-07 17:53 ` Lorenzo Stoakes
2025-08-07 17:51 ` Lorenzo Stoakes
2025-08-07 18:01 ` David Hildenbrand
2025-08-07 18:04 ` Lorenzo Stoakes
2025-08-07 18:13 ` David Hildenbrand
2025-08-07 18:07 ` Jann Horn
2025-08-07 18:31 ` David Hildenbrand [this message]
2025-08-07 19:52 ` Lorenzo Stoakes
2025-08-07 17:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8e0f3b3-6ea7-492b-bb94-4f5d1ab28ef2@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=jannh@google.com \
--cc=liam.howlett@oracle.com \
--cc=libang.li@antgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=maobibo@loongson.cn \
--cc=mingo@kernel.org \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=ryan.roberts@arm.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=zhengqi.arch@bytedance.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox