From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDAA2C2BB41 for ; Tue, 16 Aug 2022 10:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4630F8D0001; Tue, 16 Aug 2022 06:13:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4127C6B0075; Tue, 16 Aug 2022 06:13:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3012C8D0001; Tue, 16 Aug 2022 06:13:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1CBBB6B0073 for ; Tue, 16 Aug 2022 06:13:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F29F51A07E8 for ; Tue, 16 Aug 2022 10:13:32 +0000 (UTC) X-FDA: 79805043864.14.92A08B0 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf18.hostedemail.com (Postfix) with ESMTP id CF91D1C003A for ; Tue, 16 Aug 2022 10:13:30 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4M6RjD3CVYz1M914; Tue, 16 Aug 2022 18:10:08 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 16 Aug 2022 18:13:25 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 16 Aug 2022 18:13:24 +0800 Message-ID: Date: Tue, 16 Aug 2022 18:13:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] mm: memory-failure: cleanup try_to_split_thp_page() Content-Language: en-US To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: Miaohe Lin , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20220809111813.139690-1-wangkefeng.wang@huawei.com> <20220816054716.GA496220@hori.linux.bs1.fc.nec.co.jp> From: Kefeng Wang In-Reply-To: <20220816054716.GA496220@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660644811; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qmKf+/35oZ2enw8PUiOZ978D//pEG1GV3sMwyxs3+KU=; b=Jl91j12Ch3w0a6QMpKrjaimqCQD+c4XC4Tn+62pTBl4ZXNMXAu+UMZMl6UqA+B20PxBh9A riJgSnAHydxeypmSi0u5+vgoJaYGO2jBfKg+IO5ojbHgCqLRy7A1yTXPDMn5AYeQOea3Hv mDnRegEIG4xqY0wIap10tVMbac6hRu0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660644811; a=rsa-sha256; cv=none; b=RVzidjXJL3d35Ha3+ToQlCfCe6zsDdYZu3PIxE5b9mFNctLO4nDqRX7uC+gNczMxQSrHVj 0qAv4Qo/84ufuHWjL23DPNTlIwPfEl7+hitOTpgkWxTfhbNARvMHUB3HmUavYpTl6oAh3s CTm6qIlZSxq4/s3gLVRpBCo0qkyCHJM= Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com X-Rspam-User: X-Stat-Signature: rz6gjkwqnuw8e13f87edfan7xnw5txgf X-Rspamd-Queue-Id: CF91D1C003A X-Rspamd-Server: rspam11 X-HE-Tag: 1660644810-315671 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/16 13:47, HORIGUCHI NAOYA(堀口 直也) wrote: > On Tue, Aug 09, 2022 at 07:18:13PM +0800, Kefeng Wang wrote: >> Since commit 5d1fd5dc877b ("mm,hwpoison: introduce MF_MSG_UNSPLIT_THP"), >> the action_result(,MF_MSG_UNSPLIT_THP,) called to show memory error event >> in memory_failure(), so the pr_info() in try_to_split_thp_page() is only >> needed in soft_offline_in_use_page(). >> >> Meanwhile this could also fix the unexpected prefix for "thp split failed" >> due to commit 96f96763de26 ("mm: memory-failure: convert to pr_fmt()"). >> >> Signed-off-by: Kefeng Wang > # Sorry for my late reply, I'm back from summer holiday... > > Acked-by: Naoya Horiguchi Thanks Noaya.