From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C63CC4332F for ; Mon, 30 Oct 2023 16:32:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F0576B0249; Mon, 30 Oct 2023 12:32:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A0A46B024A; Mon, 30 Oct 2023 12:32:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 241BB6B024B; Mon, 30 Oct 2023 12:32:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 131976B0249 for ; Mon, 30 Oct 2023 12:32:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DF9211A0756 for ; Mon, 30 Oct 2023 16:32:32 +0000 (UTC) X-FDA: 81402670944.02.FAAFCCB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 859B3C002C for ; Mon, 30 Oct 2023 16:32:30 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ue/s4ZK6"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698683550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=suMe+oXOf55HyTRVf/6cG3zU0B2AMuaM1tYNWHrg7wI=; b=4e3iwJIsVIGgwNVVjNCDArVLMhQNJRl+B/yz9FZ7aZwxFeD6oZBu6KqyhKf8X+eSL1tGnd THESi+FJc8R1qKGirN8nT72v1HBgOj6Oa1EuC9EN+YRlds91qXZG96VMdBCLlr7ezEaI7O 8hUf2xzxwqvJJ3J4n9+RvBarCMwqEQE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ue/s4ZK6"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698683550; a=rsa-sha256; cv=none; b=jKPS/Pepy4+RHn84d0vkuyVnaSlfPbiiIR588A0R5/+Hxm6Aou86oNtPXHLHIbYVhNEIOt rYJZfgLvnI95dowA9fjX2qEf/KXy2ZADs5OB5oT/pa8YZQzMQvhpuVUZnopQseGHr+Nkx1 i1b35uk9Cx3ZMC0AUDCOf1M33jE3aM0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698683549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=suMe+oXOf55HyTRVf/6cG3zU0B2AMuaM1tYNWHrg7wI=; b=Ue/s4ZK6aRYhXvsM4NUIhyDudWEdVrptt1T+h134t75xYUHurUy1zlxJuZBUh12zjxSBcs v2uxqpsxjPSj+doI36DB1JwcC58XJJPgrInpEL2Pmd83Xmv6wsSwsOwjRCVXA13RvF1Kll 71mkZjpjN3swG73sEujj0L7KHN6lyHk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-OtrCm2D7OSuCQ7t0AOV_rA-1; Mon, 30 Oct 2023 12:32:23 -0400 X-MC-Unique: OtrCm2D7OSuCQ7t0AOV_rA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-408508aa81cso34912665e9.3 for ; Mon, 30 Oct 2023 09:32:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698683542; x=1699288342; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suMe+oXOf55HyTRVf/6cG3zU0B2AMuaM1tYNWHrg7wI=; b=Fn831B585t9DUHbHQXMYSwnDdvovGBHruBWRs2Q7jYeZj4r8dHDQb0p64uBiIBW/As JIhhgU951kge1rcNd+FhI6ehBVMCHxjxHMX1QeYEObDlovLFs3H76M/ksWJ5yS5u/0od m+11mx5JN8Ez3dsk73bhOIAeaJf/YLsZbnu1GT0h5ymdaLnMfs7Za2lIY2GVFgfclWJ5 OpcBe01ebtaWcHuMyBLjCMUy+piiDawMDZ8jQuBWLCuhB2UuFN5gyvjgDeXsVhMdcPqU 1aVtmldCvbe7UyC4RaMlbnxv8EMUIT+GrrNneU4xTxWGRaAVfBTkWG4tRiY29kPzxIMz anpg== X-Gm-Message-State: AOJu0YwB0eismN7QTRhsX4WPfHDZUccvZ5zJYKLjpIRuV1ZFq7mODyz0 6IAwlAr6JSMP7ks6AD+SCiwY0lwasrWTdQW7BGoecHaMXqfpfY/AyH2kqIr83h0xXhRgczV8zqN UuslUem0Ffvk= X-Received: by 2002:a05:600c:3b13:b0:405:3455:567e with SMTP id m19-20020a05600c3b1300b004053455567emr8362841wms.5.1698683542008; Mon, 30 Oct 2023 09:32:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDZDOW/lsNUlViCQl/v2D67qns2459L+Gxv9A0LHXp5fvgsr4HW0whpEQHCneGC4WxehQ40A== X-Received: by 2002:a05:600c:3b13:b0:405:3455:567e with SMTP id m19-20020a05600c3b1300b004053455567emr8362817wms.5.1698683541636; Mon, 30 Oct 2023 09:32:21 -0700 (PDT) Received: from [192.168.1.174] ([151.81.68.207]) by smtp.googlemail.com with ESMTPSA id k16-20020a05600c0b5000b0040586360a36sm12945400wmr.17.2023.10.30.09.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 09:32:20 -0700 (PDT) Message-ID: Date: Mon, 30 Oct 2023 17:32:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 04/35] KVM: WARN if there are dangling MMU invalidations at VM destruction To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-5-seanjc@google.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231027182217.3615211-5-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 859B3C002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 8zxmxfksqu1i3g9fwfe4wgru8hmstccy X-HE-Tag: 1698683550-333652 X-HE-Meta: U2FsdGVkX1+CbvsuKQXICn9vGEkeQX4n3g5ZFS4WaAJ4KzH0OE0J1sauWT9bgcIbIcZqVRGGHMOa4b67QAJDoyN4b6JaRmyyVpoZohUaOcvP25FuSqM6zv6UZq12mKDcb7Bb280m1o/DXNM9TsUOyaOQmdJyh5aUQ7ayMlc+n2YWuru+jYovshcJHn+enZOr2ZWF0f2gIQekp+dcq22A1tcrPOdMicyF6PnHAYslUFYlB6figniTjvIi5Wjam6f5iou6+/RhqZUvwK2cjPGdlaeZo/rxeD1lLWAlhaYk6YSbMTvFdTC3TVqX0FivdMJN7EsYI23Hov7aSpni4k+uqAuKFz4BeoG03RRMd+Yh00f//5ZwYobLnaRqOzo/W+Vh6qooHHF07J8K5gYXLsdmj3XYMI9pRlYgcDKp20IGPnT5dTpPHgV1jn50gZ91YI97Gr6vYo0tGSa6TftjDKvEVO/dG+SBj1F7aGo7UMDA2rAKjlp/ySMq+Nf/DU9/zSuTueU5L6FGittnvSErdFm1deyFd2z3tcKwbU/ICYzP47alem9PQQYhgaYxpdcvxoKWiU2gD5q/QKn4nS7U9aUrX2o4iETT2f4ESYwmyBzWoW22MdOdcqSXibNgmCpF5aOG3XHL1negqS1KXuZU2fTi8jnyT0uyz6eOOCQd0Y4yJxlLdBdfcGbHkHiVojr8oT3goskSyPv7xg1yDns3A/1D3NfKwwGNhSas0G8f9bTGX72Q11UaTnJYqt0sCUS59uiNXzh8k3FYoLlhQCS3UHsyimWxQcjfOSBT35brZ8rf/NHHU8zHzJepR/hBBYlE5gigpERTuJx1scPOqkdrrcIqwbBKjK6uOkDH8xEtnHV30kbzSbqB1ZXMD9UXzHAt+73bOWCKSyD1KvbrGKveVpDpbturfNm8vJBf4X212Ca1kd906FJePbAKB7TEZQKsMFEu5bup1TuQUWNUZzcTgUa +K6laHup jfIN5v99pQx1KJwq3Y6RGGNu5UWAsJlXyHMfiBUbWtr4xYO4iHTEyrCCvNSNTxxW4j4AJp66z73DR6ZmherDzcZLo8uQktpo93IfA8zX2vOarCxKkxYYu2BTetrniB5QMjG2/7kGso3YXyaRtQxScVYGf5bv0w/QllJyif4LV8CRAdplgOyGtIODtA3lmEctU2abwymRiIfmfdO3Lu9uF2HzTk9Xq1p/k1jsNOooZjC4D2ZHuA73Z880vjera0X7fakC9Yazr5kZR4WFNKKL6Y39kaO8txFOX0tFSkQuswnrKNvnYaFCyJHEIu4nKtINIS76SYm/T3Iu3yjjwxlxtTYfvZByWTZLErFKwP5sJTC/EVnheNnJXJfMAciVJtqnTjK6tLv3H4vtuF8pLVAXW6V24ACXzmykr0BhDSzg/OjsM4Fq31/Qx4P89W52lMUlCSSNFJp/yEyqqm7vcEqWU2HNqbX2WoQ7VCzanv4E5z9nBnHvcGZ+JvaXkp3V1fvwW9/xBjw0pFAcZ7J30QM+/5kfkumBkpYNSDs9MoFmeCGR9b+wqYp6Dw+MBEHKhrl+qxyj7CqpcUIhlEhmDcKHstaZ2KuAvBzhlH+gB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/23 20:21, Sean Christopherson wrote: > Add an assertion that there are no in-progress MMU invalidations when a > VM is being destroyed, with the exception of the scenario where KVM > unregisters its MMU notifier between an .invalidate_range_start() call > and the corresponding .invalidate_range_end(). KVM can't detect unpaired > calls from the mmu_notifier due to the above exception waiver, but the > assertion can detect KVM bugs, e.g. such as the bug that *almost* > escaped initial guest_memfd development. > > Link: https://lore.kernel.org/all/e397d30c-c6af-e68f-d18e-b4e3739c5389@linux.intel.com > Signed-off-by: Sean Christopherson Reviewed-by: Paolo Bonzini Paolo