From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66965C64ED6 for ; Mon, 27 Feb 2023 06:14:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD45A6B0072; Mon, 27 Feb 2023 01:14:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C83666B0073; Mon, 27 Feb 2023 01:14:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFCCD6B0074; Mon, 27 Feb 2023 01:14:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A0A0A6B0072 for ; Mon, 27 Feb 2023 01:14:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8AB78AA2C8 for ; Mon, 27 Feb 2023 06:14:18 +0000 (UTC) X-FDA: 80512056996.19.9D9428F Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf13.hostedemail.com (Postfix) with ESMTP id F2C102000E for ; Mon, 27 Feb 2023 06:14:13 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=U7E9aabv; spf=pass (imf13.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677478454; a=rsa-sha256; cv=fail; b=qWYlwa664yFRmlHolzXGObAXGQSSW9MuuSW2/Du0Q1MaR/FCak0fHwHm7B19U/VZAAo4Vm zn8Khq90UgHivAuEU7RE/fqryVobRZA5FEeAhFKmDyOvi2RFSGFJRy2I+uzsGwM+NNN2KX O0KTo6nFuePIWqkK2prQ58OXqDHnPSw= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=U7E9aabv; spf=pass (imf13.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677478454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4gQiqyeF0Hr0TokQhBLj633gMH4CYY0IxocXEc0voJI=; b=x1h7m8oVIfWvpl5Mu71buQX6Vds6SgCCXbySGhQsFi4KK05OJQgiq8/QSxJL0jNU0wvBkw mgDlMKZEZLLDGrFchjwqZLMHpYhucrEEJmLtPB75xDMEYxR4o23PfUikDEVZgMNPZCm44X OHpgNyjS98NaQuItSjN6qW6DFEdnR3c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677478454; x=1709014454; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=8lawEqKidRaS4mc653s/maf1UWkgTRNoXXi8/qOfwkc=; b=U7E9aabv8GnXwDlwLKaavm7FRyP8vA0/iNjD0x4HeZxJQ4Gjj2niF+YB GydyjdVer0D2mumBIvHk6dRNYppduPnMBAdBRpU4lIV5AkZagZOQGXjiA vXg9c/HxJGcIlcS6xunu99i3RhY+TrBRaETckp5xI4ROMAo/53B82JChT oNSLuYZdgnkO4tjb/+EIOCQP2DKUyav04APovkzRS0+Mwqn7uFCbst1Da 6Il4n8j1XFfjTD/CIPDx3zSuHqkSytImi978X5CLg9vD6BjdM0Z6YMaeI X/80UQO1dzIvNVqDH06uvoQZuBw9gTTjJ5xW/6oUz20gJ0khmEY0Awuab w==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="335266528" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="335266528" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2023 22:14:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="762534512" X-IronPort-AV: E=Sophos;i="5.97,331,1669104000"; d="scan'208";a="762534512" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP; 26 Feb 2023 22:14:12 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 22:14:11 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 26 Feb 2023 22:14:11 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 26 Feb 2023 22:14:11 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 26 Feb 2023 22:14:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+dd3CEOF2GRY1gAD5KjeFRv2nn572cprD21heD+7kN8lW16m9ZY15qouxpt6Dk3keSneFClCNsWUcZ6qDQ8xG2NRSd3j2RuZ+YmD9P4IHfQnUTTE7VCqDy+nkQCfmwV6PCavmP3CKXSs0A2F9O9C9LeGEaf4eiQhfo1v/bja8uQi873aLck+kGzCymeZo0Je1p6WPd/O+Oijq8qgPQmG3XfZogOv43j9so9Xt+Db6mOfPTwDAkzFDS1Z6El1PkmzdcPGXFqohqYj0LeTSF1AxPXwfTxvxy/a5HQZyVOFlie6o0OxYiXxGPCSDGSjyTRg3i6cI63zyyj9BfJkZjRew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4gQiqyeF0Hr0TokQhBLj633gMH4CYY0IxocXEc0voJI=; b=j/oEF0/JYySaDCyr5nkV2gk72QbIm6dSNgBXDvCf2SNm21hqD/qmywuqMYFMEKa1iRLowPBrzAWW54dpXDRga6P1gD11ZbyUSZY7kX5ZNeyTuZMuU6414rics0UXHMr3s5QbI7plwJaWHYFx94HEMrIv2UtcQ4h2hPTUyFtABAT94FktiVtqxVrjg/DiH8T0G4F1rppvBTLwp5piigSogCIF163waWgkCvMyc3yclz21yYvkjAiEcuBoGaH0IV98UUA8sUWQBYLh5HtTXzIYlJNB2D+g0noKy7J2e7+R0G6+5RXbMdDVJJXunM09kfj7GvGcU/idkjPdTk8gMETPmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by MW3PR11MB4619.namprd11.prod.outlook.com (2603:10b6:303:5b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Mon, 27 Feb 2023 06:14:09 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::8073:f55d:5f64:7c6%8]) with mapi id 15.20.6134.028; Mon, 27 Feb 2023 06:14:09 +0000 Message-ID: Date: Mon, 27 Feb 2023 14:14:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 1/2] mm: remove duplicated flush_dcache_folio() Content-Language: en-US To: Ira Weiny , , References: <20230216160528.2146188-1-fengwei.yin@intel.com> <20230216160528.2146188-2-fengwei.yin@intel.com> <63fc43c9a56c1_3fa02943c@iweiny-mobl.notmuch> From: "Yin, Fengwei" In-Reply-To: <63fc43c9a56c1_3fa02943c@iweiny-mobl.notmuch> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR03CA0131.apcprd03.prod.outlook.com (2603:1096:4:91::35) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|MW3PR11MB4619:EE_ X-MS-Office365-Filtering-Correlation-Id: ea16ead6-4de2-4208-6b5d-08db1889d632 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fFXyQISinrHExhmnHC3AXpTsLoSp+A42jhXZPvReMDAf6aKdRU6299FvUjxVHiQHpN5Xdn51AdjmkwweBH246dM6/PWEpze6TUr8pKCSsJlZUlw7TBD1443NqYlajyGsR7OEpMHXUHVBJzifZuv0dJYJG9AmacuMWJOzpRQnZynUbhBxyEbwv62mBb7/7iVk98gK9IqoNkX0sZtoLz0soinBz/ojfqPIWNRqrw2n9Cff2zwUOso8xNjjqpjSCHVyGB2F5LqHSZAnZBV8w1e46V7SeuXOlS2nAIAps9/cRRGcQ9gPS7QQPu4hAQGU1J4WhBac+lBaFqs4rbnkBTdqG1h8FmlrrlMWovrw396CeeMS3Xppv5foCb2TSKnpwxmxuTLH5JElhFZs0DePCW92pHxbClh3U6NmdpIIhgqpIaQBuLIFAJFiPHoQcN3YhR1vZhB5iksPpbJ1BlXaOS8JgaJsXsV6N7Fw+pIxvp02R323zT5gSrEQTevVTpOskx0eQ/AheV69fYJW3OtPHYdhruKMAeR361qKpk7+qFh8hTDXDXGxnL4tqXaJTllmm4WESaC6Ze/ByDOQaiplLJvy21+OL0PWLs41zrWwuNhRxWEwevhd23fQu2bfDpFGnB9i8Mtx5xKkA3JGpAis7sk7jtlwtn1rCXqfzoiVnQHZb/Vgdnb1CNZWzhXYW74ryPD8p4jAErnfAV2EyHJVkhoDDW3jWCtc/g6R5NTeHkHaTxA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(136003)(396003)(39860400002)(376002)(346002)(451199018)(186003)(316002)(82960400001)(83380400001)(38100700002)(8676002)(8936002)(66476007)(66556008)(41300700001)(2906002)(66946007)(5660300002)(6506007)(6512007)(478600001)(53546011)(26005)(6666004)(2616005)(6486002)(36756003)(86362001)(31696002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFVKV1g3SllnbXFSNjF5YURGdlZZVVVtbXdnc2VJbXhSbmJySUVEdTNrK2ov?= =?utf-8?B?Y2luRTdySCtVWnZibWRudlJTNno1NW9pKzV3c2pGV2xhcmd6RjBObStYS2Ex?= =?utf-8?B?Tkl0ZnRDcXFGR3pUMmt1UnR3WW5Qb1hGVlZLWHRreVd2SGZPd2lhNlhHeE15?= =?utf-8?B?UzhKb1JtMzF5bzc3MFFhM25aR2E1SXoxUFo5cWZPdDdjTm51NTRHN1FvNVBa?= =?utf-8?B?dUY1bG9YSEY0djBjcWQ5RU1zdlIyWWxGbkVtZmd2SkJGQVpIbmk4NnRuT05w?= =?utf-8?B?aGRpcUk1ZXdsYU9OSWU0amM5cExVL25oTFhUaXlGbjZLV3NzOG1JL09qdXAx?= =?utf-8?B?TEE1Lzk0QVp1QndtTDdMWnByMkMrVld1ampUNVhVWGNOWUcvZEZCeHFCVHRR?= =?utf-8?B?bFdPbEF6ZW9XUFhFTVBGUWRVZWhyYmhTdVZKdnNEeWJMS2RpRU9sWTIyUjNi?= =?utf-8?B?djRUOFVoNXdjQ055T1NaUDlZQU1YUzcyUHI2ajU1NWNiYjFkRlhqdEZMWWtR?= =?utf-8?B?OUE0a29TaUQyemErNm1CT3RnbElZbmpTdHRVM21GYmdkSGs4SU9vK3NIZDMx?= =?utf-8?B?dEdMYWNwc2YvM0xtbVE4RmRYU2ZuY25NUDR5WXVnWmtEb3VrVFYzTXZwYnZm?= =?utf-8?B?cVN1TnhRMzErOWZKLzhxUHYxZEpFUk4yN3ZwaWM3VlFERFlqNWswT3lwWFRP?= =?utf-8?B?R0MrTmR1R0pMekd3d2d3bG1oWUY1VE04V1ROYWxyRnVWVmsyMXJ0MStWYkgw?= =?utf-8?B?am5LWUpEdFNLVDdUR0JQZGZlQ0k4aUJiam9mMnoxbDZhSzJNQnlydU1XUnlj?= =?utf-8?B?U2dJZFhKcHBZUVhUdEF6WHZEZnAxSHFiSTAvMGZ4M1RUYWx3N1RPajRjRHJi?= =?utf-8?B?V0t4YU05YWQxTkFId2NrbmxkSk9XeE45UTMrcVAvVmhtTHA2QUJNVjlaOXBJ?= =?utf-8?B?K2tpSElGZnFhdW1HeGJteWZTSnc5dDNzSjFqU0ZWRjVWV21vY3o2b0dPbzhH?= =?utf-8?B?SWg4dHVnMlNqYzV6S2F1NXZtczFRMCtOWTI1Q1Z5RkJ5VzlaYWhFTFMvdXpO?= =?utf-8?B?R3FpYnI1MXhuR25oRVlkc0dNbGJ5QVR4cU1LWm44VDRocDJseVB1bzdNODJ6?= =?utf-8?B?NlhDTGtxME53MFBMZEhtbTVaNmY5Q3V2dk9WeG1GcEQydE01RHZsdlNxMitk?= =?utf-8?B?R1orcUJPVGJMQ2w5TXlyZkZIWW1uSE8zR0lXWVd2cFI4R2U3T01aZisreU45?= =?utf-8?B?YTFGaGxtdThPOWlUVzQwRnBKdjI1a05Fc3pCb01yeVVQZ2lsOEoxNDFlb1Ja?= =?utf-8?B?ZzU0cHV2ay9lYktlZkc2eUZJU2ZEd21OTCttZ2FkZ1F0cjlodTQ1S25DQk5Z?= =?utf-8?B?clpaQnVGSzIzbk04WEJ1c3h3OEIrRVAvTGljcC9XbXdBSnVZV3h3M3d2N3FV?= =?utf-8?B?MllZaHdaMEw1dmhmdm94U1kwdmh1bnQyRU9iOVhTdEFPaTAvNDluOHJnQWxJ?= =?utf-8?B?R1B5T21nTHFDemhDRjlvMWYxSWxnOFpBeDM0TlJpeTlRQUdVRGxLd1BGQUdQ?= =?utf-8?B?Z0pYUHFKNGplRktXNDFlRVJvT1JYTE1ZL2hJWE9jQ29uWGozYVo0NDJCenN0?= =?utf-8?B?cVR4M3Y1b3ArVFFGN0JBZFZjT0E5MGR4Nks1bmc3NUd5Mkl3OGZ5Z1hBd0kz?= =?utf-8?B?WFhpeGZud243Z1J2U3A5YTBuTEFlaVB1RERmUmdCUmMzQWVIeXpHd05oK0tE?= =?utf-8?B?QzY4OHBRNVRtRnRFeXVwd1lYTU9ja0dtT0RqSmZ4M01NK1NCQnNVR1BQWlFV?= =?utf-8?B?RU5oclBqT1J1eU5uZlFxcVdlQVlwZWFEUHB0aFZVazJtMFJ3QkRGVDRvZ21v?= =?utf-8?B?RktXOXBWMDFLYmdjQ3BjTzdZdDVsZjhjRjVyVnYwTmNveDk3N05Ya1pwTDR0?= =?utf-8?B?cFE5MHRCVWFLbU1aRHZMZTZ4S0YxSTFjRGZsVGZnd3E1VG1JYjhaQmd0cUlD?= =?utf-8?B?UTg2bGNFMS96RVZOOFZaTlBEc3lDQTRBazMyQTZVSm1IYVpJbnh3V2FkN014?= =?utf-8?B?SlA4c0J5OEpWVEZVcm5DUXBvNWFEanZCcUl4SHJrTXdwb2g4M2d0dnlsQ0RP?= =?utf-8?Q?/O/+KD+Bin8waAfafCKbPbg7W?= X-MS-Exchange-CrossTenant-Network-Message-Id: ea16ead6-4de2-4208-6b5d-08db1889d632 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 06:14:09.0021 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XF+5zeYesSeQByMmeSSlPLI8mTA5JSSjW+h8KSkNl3h/6mhYSeAiIrrajcra1moBCE9ydMvWxMfkzDe+afc9+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4619 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: F2C102000E X-Rspamd-Server: rspam01 X-Stat-Signature: 7br6paei7r911p6dc7tkfkf4bk86xd3d X-HE-Tag: 1677478453-686323 X-HE-Meta: U2FsdGVkX19xwoKl2Gy6jPBpX1zl6t30GXq9ankndUoxDpixL10NcZ9A21NWMe4eaIfR6TV1tRVY1y5QWyNL+dOz4FnKKfkFD2rCMxCg2iosW6EvV3F0HXyOTFPhiRQ+MEurkuVPQwU/KJ+YXKJZIjOF+4DZHUwq63kNIOHEbTtyOuXkf497S2CX+G2qYtDMgIPXeDWcN5JuK/6zneI9+91gt58StkiU6XsLEd3c8DbfQFQHTlqnP1p+DaDDsRSphdgA50zYMO4RPgyxZRa6YifOYBxuUSb0rzdBVhGsQ4iAxWpr4Wk20+lu8/WxL8CCQPmj6mmngOarpw8h6M0T86LQ+Y919ijhCBYARvIBEkgNsbWbYoul/Mdl5S7Ph4CS2WjrR6Zt8HfRH/u4EAnsagSMv2rAWT9OwQ0kl4H2V3tgu1rzuH2M02pvQsurXpdrjAy2AD+qK802HBF8WKLmR1KTL0XjjpWWMMfhxcCpJ/HunB3T53ZjJq0hg2LvrqhlIpOWKeMb47zFeNq62ZE6zzxxFqdANS4wCE3S1wSzlwabYfdBvHscThbsBXvrhywc19sRj3S3AQ17cnxZGDqKlNWIssMppCjjUXcWRXdWajnCjgnPH9ZWdEKxCKECAmpX6nqvC6Vh33MRkRasDnk24AFNpLHb3FI9WjoEFQcW+jIOuoCY/Wglwz47O4XtI9Im6Ru3NP0vdykxFuyryU1XyzBB8PgmDhLQsqVKbe4hJiK09HCkJXeYe+RBHohhh/0Qedtge3TRPVQddjdqsZn8h4rgIcHfRAX91M5EnvwzMeFVXMKeLi4AfcAML2Tnqx9gGzNpYL40aNVbumAbtDHpeOcbpAbbu2/UR115w3AriCZ5+DsOCIChj8E0Fe8/nqWnjH7WeqEitCROKAwww0EjDPSpUOSPGOfs8TK9t6zDitW5ZFxwWZ5/1XUzTIXizsMtWgi5/g6Wj5Qkq7FgvxX eYRUjz8N zyVRZVfL9JcbcISKPfaNf5ki9fH1t1+IuTJ3LOgQ9wlM7OOnU8zT6H5dHkPf9lT4ua5l5sGFfIBZkwjO60j2UMVKN+NRu6dGm6TXy5dnjGtBNuxGW1Sqh/agsOWOD7h+MHzIT1OqKCAl+4aotNkldBNR0uyEvQ3ToFoLrAfft1V5CFHoXlBitH+7RKFFLEYrA6aIExKTu8porQDVkzxhfMuoOzOlMimZzSZEuC5AnSKqdQnMT6YFNRXZ51UoTy45rPEeNAYvnvbVtiHKv3LwUplxUkNEn0Al5/SwXd5MrFuZrYE/hQOffCJJyIZOCshxINPm4fn5wMIFDjwliL7TgWbksu++kJp62kGgrV+lvEZLJbuY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Ira, On 2/27/2023 1:46 PM, Ira Weiny wrote: > Yin Fengwei wrote: >> folio_zero_range() calls the flush_dcache_folio() already. Remove >> unnecessary flush_dcache_folio() call. > > The change is probably reasonable but this statement is not exactly true. > > The detail is that flush_dcache_page() is already called and another loop > through the folio pages is unneeded. Not to mention hiding these flush > calls is nice because it is so hard to know when to use them. Thanks again for checking the patch and sharing the comments. Yes. This patch mainly focus on the unneeded dcache flush when I checked the flush_dcache_folio() related code. Regards Yin, Fengwei > >> >> Signed-off-by: Yin Fengwei >> --- >> fs/libfs.c | 1 - >> mm/shmem.c | 7 +------ >> 2 files changed, 1 insertion(+), 7 deletions(-) >> >> diff --git a/fs/libfs.c b/fs/libfs.c >> index 4eda519c3002..d57370c8e382 100644 >> --- a/fs/libfs.c >> +++ b/fs/libfs.c >> @@ -543,7 +543,6 @@ EXPORT_SYMBOL(simple_setattr); >> static int simple_read_folio(struct file *file, struct folio *folio) >> { >> folio_zero_range(folio, 0, folio_size(folio)); >> - flush_dcache_folio(folio); >> folio_mark_uptodate(folio); >> folio_unlock(folio); >> return 0; >> diff --git a/mm/shmem.c b/mm/shmem.c >> index 448f393d8ab2..66e50f0a15ab 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -1401,7 +1401,6 @@ static int shmem_writepage(struct page *page, struct writeback_control *wbc) >> goto redirty; >> } >> folio_zero_range(folio, 0, folio_size(folio)); >> - flush_dcache_folio(folio); >> folio_mark_uptodate(folio); >> } >> >> @@ -2010,11 +2009,7 @@ static int shmem_get_folio_gfp(struct inode *inode, pgoff_t index, >> * it now, lest undo on failure cancel our earlier guarantee. >> */ >> if (sgp != SGP_WRITE && !folio_test_uptodate(folio)) { >> - long i, n = folio_nr_pages(folio); >> - >> - for (i = 0; i < n; i++) >> - clear_highpage(folio_page(folio, i)); >> - flush_dcache_folio(folio); >> + folio_zero_range(folio, 0, folio_size(folio)); > > This is a separate optimization from what your cover letter explained. > > Ira