From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53A88C433EF for ; Mon, 27 Jun 2022 02:12:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7A618E0001; Sun, 26 Jun 2022 22:12:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B29F86B0072; Sun, 26 Jun 2022 22:12:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F0AD8E0001; Sun, 26 Jun 2022 22:12:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8D5C56B0071 for ; Sun, 26 Jun 2022 22:12:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5C13133DE8 for ; Mon, 27 Jun 2022 02:12:58 +0000 (UTC) X-FDA: 79622392836.08.970AA93 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf26.hostedemail.com (Postfix) with ESMTP id 0F496140020 for ; Mon, 27 Jun 2022 02:12:57 +0000 (UTC) Received: by mail-lf1-f45.google.com with SMTP id a2so14172550lfg.5 for ; Sun, 26 Jun 2022 19:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=J1m6KgphNIic/L8WHuZiss6XcSSiZCMzYR1UJoO0HMc=; b=Kxte3o580Pu1piGMd/tMaeKLcaYVnazjes2jkA1MeRbEVwuAjE11CCbYmYRlNLpsTw ouDSlFLtVKYo+Ypvn/e4PTGdQBuBZSF8EMqVPtqqJKVIpYXcBsUFENRymu17f8RNCuqY Pm/82bhd295KDLa0ilJFqdTMh4JkoC+poaMfMlNN2V80LjCvpchBMl+H7N8FrRyJPJh+ nTSBgMNVuORpGb3zfKVzKxBUE8bd8rfxtdIgZUi1lUKL4fUx6ppsM0QVQldCU+CnZYsd ZJteSZJMdcqSyoMY+ubnkpFtWTm+0VbsbNradd5tM5mDISvt1wyV+NF6yVISG4BfRLXj XbrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=J1m6KgphNIic/L8WHuZiss6XcSSiZCMzYR1UJoO0HMc=; b=P18iXQpjiM7ahTzjDqFRy5knFmIsPwUbyTO4K76yM6xE93sAEC0xLvlg6X9V7pRD+M E2KA8g5PI1z1Jfv41EHwmUmNnKifL/INzdvlZvSm9OP1ayqfoiCisu+pazvyB9aO5kjG LSnxzP6+BptuBVPF06pzhSAaWxAXtpKVD+FMboZSpUqAlEpg1Bu5jQCIMKcjvMFhD6sL KuyClZZCQQ8s8yTIZMSWSGqp0nNi5yiWtKGYqspJOdZ5skk0Vx7fpyUlIRYfcss1sxxP vS0cDUClWdQ+t0ZzQQ9K7AHJbwuga4kyC8rHxvhRKtHuaDh+b3ke5MGHvePAdjhk7lhZ ZF7Q== X-Gm-Message-State: AJIora+9+tbLWpSbykkoJlrwCL7aT8L3V34CCgYdrcA1e9MuXnytT+P8 uvuHc9jEwKseAt5y5pXxhL7+3Q== X-Google-Smtp-Source: AGRyM1vr0Ly7U9f3BihWY/5DMiX9z0MJzNTrfnMnO4tWxm9I/+S2YyaWNHAxkerzErA1L2jM03KzDg== X-Received: by 2002:a05:6512:1288:b0:47f:b7a6:221d with SMTP id u8-20020a056512128800b0047fb7a6221dmr7602818lfs.236.1656295976649; Sun, 26 Jun 2022 19:12:56 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id g20-20020a2ea4b4000000b002554f044e1asm1206501ljm.116.2022.06.26.19.12.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jun 2022 19:12:56 -0700 (PDT) Message-ID: Date: Mon, 27 Jun 2022 05:12:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Vasily Averin Subject: [PATCH cgroup] cgroup: set the correct return code if hierarchy limits are reached To: Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Michal Hocko , Tejun Heo , Zefan Li , Johannes Weiner Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Vlastimil Babka , Muchun Song , cgroups@vger.kernel.org References: <186d5b5b-a082-3814-9963-bf57dfe08511@openvz.org> Content-Language: en-US In-Reply-To: <186d5b5b-a082-3814-9963-bf57dfe08511@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656295978; a=rsa-sha256; cv=none; b=uJxK6rd0ExlFEOFxKt/jli2ax2BfO/nlk6R0AFSH/I5HeUQ0lJeFSq387shM8XTSx2cTAX 7EZuLzXaEsFinqRPsZhAxDdn0FNeB5SmZ9zYkBjk7lNz/ZMuJ2880aTRMES8VUrCrTrVyt j5zRxtOZM28FlzOq7Qw4/QvJ5ay6FlA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656295978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J1m6KgphNIic/L8WHuZiss6XcSSiZCMzYR1UJoO0HMc=; b=IOa2VFeKPuLUvFEF2eaJDJEQby8F2gZJ8uMGfPaI9LnJDUzNHFzEG7bZ6v4aXjvhy6FZfw yX4AsJV4gZjVIM6OzedcU2ORNFknVFe+2vPDPydtG4VRYJ2xuCohBo5B3mVrr2jozV3vSz WFoNsW8nt8q2X3CBE8OB9FYFNVcRJ+s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=Kxte3o58; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf26.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.45 as permitted sender) smtp.mailfrom=vvs@openvz.org X-Stat-Signature: ghcbh1s1os37mgfentfokhxnpbpqq13g X-Rspamd-Queue-Id: 0F496140020 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=Kxte3o58; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf26.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.45 as permitted sender) smtp.mailfrom=vvs@openvz.org X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1656295977-956549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When cgroup_mkdir reaches the limits of the cgroup hierarchy, it should not return -EAGAIN, but instead react similarly to reaching the global limit. Signed-off-by: Vasily Averin --- kernel/cgroup/cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 1be0f81fe8e1..243239553ea3 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -5495,7 +5495,7 @@ int cgroup_mkdir(struct kernfs_node *parent_kn, const char *name, umode_t mode) return -ENODEV; if (!cgroup_check_hierarchy_limits(parent)) { - ret = -EAGAIN; + ret = -ENOSPC; goto out_unlock; } -- 2.36.1