From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8331FC54E4A for ; Mon, 26 Feb 2024 14:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3B40440170; Mon, 26 Feb 2024 09:31:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC40F440147; Mon, 26 Feb 2024 09:31:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D16EC440170; Mon, 26 Feb 2024 09:31:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BB44B440147 for ; Mon, 26 Feb 2024 09:31:37 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7F52A1408F0 for ; Mon, 26 Feb 2024 14:31:37 +0000 (UTC) X-FDA: 81834193434.24.1C5CC87 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id 02258140029 for ; Mon, 26 Feb 2024 14:31:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=s3LB6WwA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PYurhS4h; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SFvcoWun; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CjlFK5sf; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708957894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W4akfkc1Kw2e9YyWEpsf9c0Y76JydMXyZR2TAfFVmJg=; b=xDYyXKYzDBFyn1V7Y2itLKXRzbFVNqMNFi62kKpNG86P2pqkPu4MsDcpXCRmVok/2HqR2U qFubwm9LvH/MJEFJS3Vc4aittxGKC/KfgOQMWY5saaijbyjBQNpK2+oxlMYkjDVWPG3Vc0 U9CXfYzOH+L4KnCyo3xSPKyJMULWi2A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708957894; a=rsa-sha256; cv=none; b=xo0YrG+GzsCeMRZvIVH83OtoJzQgx+Xrq/fbx28nRN5UeztFN7CVGkfGFIp6ixuZt2ZXV8 JgH04zifhgId2FnZQGVH+ae/IPkXEvm++mCjE76F7/v5Fs//y4ezse9hvD/AVKc7vP73Pt U2JbNqD1j9Qs/VkTycdiiPguKlwuGV8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=s3LB6WwA; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PYurhS4h; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SFvcoWun; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CjlFK5sf; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 452E4224F2; Mon, 26 Feb 2024 14:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708957892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4akfkc1Kw2e9YyWEpsf9c0Y76JydMXyZR2TAfFVmJg=; b=s3LB6WwAVt/EKwD7kJfsNbn71XtbwBFK1/9n4wFveoyb9Waj6EPPt5rWu1p8+FYQXg7uSq Etyh6ho5v40CfyfTuY0CR6QPgFH2hUlOqyMyOG3ZpA30la2xu6/JlVXrQeDKLwbL5iNRXZ IPicVeKidvxxyWldx3pjACo2ana9u0o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708957892; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4akfkc1Kw2e9YyWEpsf9c0Y76JydMXyZR2TAfFVmJg=; b=PYurhS4hkcO2U2pXeQaLQVQilCZXbjA3RQZf6enw7WwsHRhov2BwDu3y+iZFdZnQ34lLql SwhF5sPmIIt2wLDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708957890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4akfkc1Kw2e9YyWEpsf9c0Y76JydMXyZR2TAfFVmJg=; b=SFvcoWunXAD5czuNTyZ6mcV5PqVCkfIz77swvk47XOQRUrm2nfI+UT1W4d6KRhZ8Q0kKSV uk3fVyLBzjEqamS9OFsgc0BxLC5UJGnVfrw1LY4/Q6x6KKC8MinPWQ8+DeqMucf9DIGsyU 2AybUrKzXXpgdqGeIOYm9sOcG8hAjcE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708957890; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W4akfkc1Kw2e9YyWEpsf9c0Y76JydMXyZR2TAfFVmJg=; b=CjlFK5sfFrdmbcv4e0AyRWrrHwI4xEzQUQL9DJjvYfttGtrtvvNGoZSx3INuMj6wYtTx/C MMbGei+nQENXDpDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9FCE813A58; Mon, 26 Feb 2024 14:31:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id T+5WJsGg3GV9bwAAD6G6ig (envelope-from ); Mon, 26 Feb 2024 14:31:29 +0000 Message-ID: Date: Mon, 26 Feb 2024 15:31:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/36] mm/slub: Mark slab_free_freelist_hook() __always_inline To: Suren Baghdasaryan , Pasha Tatashin Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-4-surenb@google.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: dkcqz83633hjimkoh3pcinpxzbwi3oyj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 02258140029 X-Rspam-User: X-HE-Tag: 1708957893-27918 X-HE-Meta: U2FsdGVkX1+LOBayUDrGhoPPhRW417mU2OjDeUzMuj1mk9gtUQ4hlss4osOw5bgPXAkwFOlcVI3L9t4MeBpH4YewR64wLzYigwizBQ51KgWXiUOOxCtc31VQgxdPRm7tDT/qrqvl1lhdpaKrLFfyMH+KQtq7/y7HmMos5Ew5UesI/3GmnooDwQibHctJ64RopRAr1IFzeFNod2O0ATCfzcCNNcv6uWxdjLhy6/CyiBIEJwwLDFMGrWorfig1dTQxd/0ukDCCd70+oaMaVSs/UuRdcN+VD3FbKjyHFGUCKt/hcXNEJHr4PyLG/RYrQOYbOZSi8Q3SR65135/tz2k7cidNKlCG5TwAOeyda4+yFdum4jcjfIAbvC0CpVj9dqzJ4b2LMJE0JlDH7QjdPldlpU7tS/zsc1mmWpV/ny9peVccxuMSzeFvlzqsmjS3h9EAUiIrx91SgJ126NN4qKRc9chUUAxoTbKC30zVs58K0HRYOfVrLeWu49UKaAeIkdO043BBUWVlXCE19ChY2BTxxKIvbOe9qwnW/FCvYKc7FQ6qjFatAh3pFQ0nvnQsfGg4Yes6d6o240xHuNebUKlhaSPB2yE17Wocrs+hoWzGC+cWHYZJ0/4/781VR6IiSgsaB4iYcCbWQ2vvJpvXW6Mn42gNVxtQYw8QTxLgEVZvK7zBb/deb7L3mB7rlrspNjVxKXfHrk/XfYyZuyM9XUWSDbhcL6UWJMMDFxJGPhdmxfGad1dGiA5mgvwrEn5HdtrQZH14XL1w3MrWu0H0KqsKsWOOAJ09fSD6JEpJ2bCL0KNDFetd6h9nL/3tE0nLK0rIFp/Nl8F/FCm/BNzaRkNqlSRLNgw/8fEbVQLLwZrkSA22u6Ceg98/66c2zJZXjC3iW1QYBahPvWbU0EcnPlJH2vPssKacKH3h2Ku8aYeSP0MPTXzlqTiIqM1G5fNyjqiMrcLFZVhdPrr8lM9DL1h ddhhAAZ+ y9K3bQTY2+AxOVRTv2sRDsdw2LaXrSp31lUuksB8cQqUZKz83mWRXk3zPhAaZK0XFOuaJNvdOV8yuyH8KF4Esdl4B52Biq8naUlfInf8BmgekQsbPX3DBaLqrI/34q4p1DzXU6dR/J50DASTOJSvJ/FBzUJF8dboKot4s1BFCjsB03BZusOVJvLt7U8SIBZECWg5ndei4NKE1HrjIGOCRxeC5m6ZGXGqGVOYXP9EMaIyeQsCLCrwObRP4PWecNIQRqrfZE/crEK9B3M/44doPd+zdTr8opKDZEQH0vQMfYkkcQRzhOrbZXs8rTRG4NdI3eT2vEP2zxwDCdVnFXv8E5YvD8dsbkF/JW+w5Qox9TRwNXHhLyCvJZ3h3YUlEuXBKPEvIdpMA1qoSz+qjA0FD6nTHPK6rDOlaF1Op1ZhUXeKeQIyDIUt4T/vs95Wyd58fXE5vppQQHXk9a4JNWqh7+r8G7V1xDQQetYcFBcpW51nkftqK7LFMtjZUBLOwp5zWKgjwNKc1RKzeiSLF1DdBksu1OfMqFnA/6zpBsJAScFyLrWs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/24/24 03:02, Suren Baghdasaryan wrote: > On Wed, Feb 21, 2024 at 1:16 PM Pasha Tatashin > wrote: >> >> On Wed, Feb 21, 2024 at 2:41 PM Suren Baghdasaryan wrote: >> > >> > From: Kent Overstreet >> > >> > It seems we need to be more forceful with the compiler on this one. >> > This is done for performance reasons only. >> > >> > Signed-off-by: Kent Overstreet >> > Signed-off-by: Suren Baghdasaryan >> > Reviewed-by: Kees Cook >> > --- >> > mm/slub.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/mm/slub.c b/mm/slub.c >> > index 2ef88bbf56a3..d31b03a8d9d5 100644 >> > --- a/mm/slub.c >> > +++ b/mm/slub.c >> > @@ -2121,7 +2121,7 @@ bool slab_free_hook(struct kmem_cache *s, void *x, bool init) >> > return !kasan_slab_free(s, x, init); >> > } >> > >> > -static inline bool slab_free_freelist_hook(struct kmem_cache *s, >> > +static __always_inline bool slab_free_freelist_hook(struct kmem_cache *s, >> >> __fastpath_inline seems to me more appropriate here. It prioritizes >> memory vs performance. > > Hmm. AFAIKT this function is used only in one place and we do not add > any additional users, so I don't think changing to __fastpath_inline > here would gain us anything. It would have been more future-proof and self-documenting. But I don't insist. Reviewed-by: Vlastimil Babka >> >> > void **head, void **tail, >> > int *cnt) >> > { >> > -- >> > 2.44.0.rc0.258.g7320e95886-goog >> >