From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 715CDCA0EFB for ; Fri, 30 Aug 2024 09:53:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B8CB6B00E8; Fri, 30 Aug 2024 05:53:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 069D96B00E9; Fri, 30 Aug 2024 05:53:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD6EA6B00EA; Fri, 30 Aug 2024 05:53:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BEA0F6B00E8 for ; Fri, 30 Aug 2024 05:53:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 607281416AC for ; Fri, 30 Aug 2024 09:53:39 +0000 (UTC) X-FDA: 82508449758.04.DC470B4 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf26.hostedemail.com (Postfix) with ESMTP id 95492140012 for ; Fri, 30 Aug 2024 09:53:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=m3ZkJDRP; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf26.hostedemail.com: domain of yanfei.xu@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=yanfei.xu@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725011525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AOcu6TuPUZsQuIs8i0yQgeXM6KYb+pury+/BrK0b5n0=; b=29W/6C7houF+/XBg/V6nncwROT4rJV/qrrMcZZfuwojGDr/Ai3p3ZWE9biMF1qy9MG8uwM ME/TcEzqlUVyr8cIrom1Jtrs6a5HsYjnrn6FdylSaFdsc0sJWaztmEjnO5Fni6dvYx9MUI JuUHdrbV5JjszSfzr3s8lX1i5IB4eKI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725011525; a=rsa-sha256; cv=fail; b=gjWW04gIb1Dhsk/Vyym/PI5ZOgvm9j7z7nUxZLaoTFqfD4H4yUWZ3A+DbgBXTKvQNrZhR9 ychTpmHiM843Kom8p4MnII32QilRM/6vXJ2vDilnQRG5RHqE6o7akAi6NoLNyuAbSxOyi/ cdfTTf3tgyR8CrVkh1bae+2+0gK54dQ= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=m3ZkJDRP; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf26.hostedemail.com: domain of yanfei.xu@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=yanfei.xu@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725011614; x=1756547614; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ii5N6yQ5l3TErHvQCKRNYNMIJa21tOvxuBcZhLmo9qM=; b=m3ZkJDRPg0x/stjUEJizCRn+omuKZ25FaXgsP40EJF2mr0aJsJIA7LKP ct7G3HwTzm+2IzRULFglKy81VQwoHFNmT/jPYdOUtQqSHbiqW5eRTJfIY E5VAY7gCcKSiWZRI4iwX6od6Gxs0gfAYcciY0ZYJJ5/aSjwtnu6Hsq89F 9w18xFaZ8wBqhdeT7T5qAkp/e88EJ5HCc7ni9Z17hH695yMRb+hn8AA08 0dY4G4yAdSSoqgWStz06DSd2E4vPOkk8JsbFwbsLBDkPmZ9mxJBA/cu0h isHU2HIFUVpKMdEIgcRoJvMypYrpfP5ky6x4TWE4SG7ooYR+mUjENOe3q Q==; X-CSE-ConnectionGUID: Pz2uJ2lIQSCYaqtPDApOAw== X-CSE-MsgGUID: qQ0QDrAhT8ek5t1hNghhBw== X-IronPort-AV: E=McAfee;i="6700,10204,11179"; a="34216582" X-IronPort-AV: E=Sophos;i="6.10,188,1719903600"; d="scan'208";a="34216582" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2024 02:53:33 -0700 X-CSE-ConnectionGUID: SXZoXRl+QS+ISTKj88/6Mw== X-CSE-MsgGUID: clibv+aUQL2jGOf7t8yR1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,188,1719903600"; d="scan'208";a="63476843" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Aug 2024 02:53:33 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 30 Aug 2024 02:53:32 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 30 Aug 2024 02:53:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 30 Aug 2024 02:53:32 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 30 Aug 2024 02:53:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gx40rIHtEyBLetz65FnNrv1yaqQnNfvyBe0h7aBuyFZ2VlpIUtUA0pJTABo1ywUEnw9zDvWcI02lnvl42AjxA7SOw/+O6XUgRjSWw6EY17c1555Wnz4zc1tv6MDZ5630ex8SnDEXku2djva9Qga1Gr1TMqk2VEks1rgoBd3Db2klNf54fci2n6obk4J2+1EMGdo9mDUotrkzeBWFoe+ehAli0zbKZQfzRzEHAMwNkyvnD7WhUG/6t9SN1fMXNU6OCEDf634oGiYCf/81i2qZDLJyJQnblruMRRMdXYDEBFgNMZBWdh8gKMaND5EScP21zlzEJ/VpDji3jY/YBndh1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AOcu6TuPUZsQuIs8i0yQgeXM6KYb+pury+/BrK0b5n0=; b=TaKwZzn9KADtORRCHC09X+PjDKrZx3SHKB3NjxxKHP7tG6sNPyDYxmjVhjLntfEkH3Lb9CWpeJxFjviEl8KlQHOpc4y4P1LarAnBv/065DUUXZdDFe5e4i9S6leoIrbi002a9H+1D8QtQjsxxPGRvJop/dVU3xMsb7UN7Np7GMBj0nVJXLFTWx47T536S8WfNgQ/SRM1wXS3FQd1Z+WvNDfXwb7L4+kSPoWRFJQKxZQHrkctXdylQ3vqgf8MPR2nnHCsxj/HTFsBnCR28/c7t3ZYrQBN9MXS7GBvASjuas8/wq6u4cVyED7fXy682TOnPX0LmlEX/daE9BrItISx5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB7110.namprd11.prod.outlook.com (2603:10b6:806:2b3::19) by PH0PR11MB5080.namprd11.prod.outlook.com (2603:10b6:510:3f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.20; Fri, 30 Aug 2024 09:53:24 +0000 Received: from SA1PR11MB7110.namprd11.prod.outlook.com ([fe80::48e0:2fb8:7d8f:4a67]) by SA1PR11MB7110.namprd11.prod.outlook.com ([fe80::48e0:2fb8:7d8f:4a67%6]) with mapi id 15.20.7897.027; Fri, 30 Aug 2024 09:53:24 +0000 Message-ID: Date: Fri, 30 Aug 2024 17:53:15 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memory tier: fix deadlock warning while onlining pages To: "Huang, Ying" CC: , , , References: <20240827113614.1343049-1-yanfei.xu@intel.com> <87ed66h4d1.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Language: en-US From: Yanfei Xu In-Reply-To: <87ed66h4d1.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR04CA0208.apcprd04.prod.outlook.com (2603:1096:4:187::10) To SA1PR11MB7110.namprd11.prod.outlook.com (2603:10b6:806:2b3::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA1PR11MB7110:EE_|PH0PR11MB5080:EE_ X-MS-Office365-Filtering-Correlation-Id: f93e5d0b-2df2-4ef0-561e-08dcc8d996a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V0RyNDJCVWNzc2hTb3hvOXlkb0FTalpLNnhudjd5SHEzeVRuWFEzSkdjdW9Q?= =?utf-8?B?V3g4Y3VRYVk1SmlYamVqNk1zM2xweXgxZFg5d0ZIK3JJQVpzUEVpczhsZDBj?= =?utf-8?B?VjlUWVEwK1JSbUE2RUFiMEJVRXFRQUE1cVdDREdpNUI1ajR5bUxZV2RMQVdQ?= =?utf-8?B?eHUzdVMzQks4L2FFdkcyWGtEaFk2T1Z4WUg1bkVGUFNsV1VNZVlqSm95dWMw?= =?utf-8?B?Q1dkM3lDMjZyQXNGaFpFZENDTXBxUDBNRUtsMDBpTG5TNE1OU21tMHhNbnND?= =?utf-8?B?UWNNbTNuY0tFcnpLQlFwVjZ6YS83R1JiTVZJVEJCRzBJSkFyOUNrMXdNNXF4?= =?utf-8?B?cnZxaS9tMHg2cEI3YStEeFd5Yk9lSTc0a3hhU2dyMWlnVWtHQ0dsK2c0dUNQ?= =?utf-8?B?bGJUMDFqQU1ISVBZRUNNSjUrc0NUSGFGOU1sVWhhbXMxckdub254Tk8zK1Jz?= =?utf-8?B?S0M3YUlLbnlHRTZrR2JvNURkVUEzbnp5c0huNUZFQ1p2WDFlSjZXMExmSXZE?= =?utf-8?B?bmJhZmpmN2dQOGFpQkFlVFh3Ym12QUJ6d3cxTUFrMFJWdGpGKzZtVUtXT1pu?= =?utf-8?B?REFuK1h1WHNYbW9JY3RYM1V5SnlweitiVVFTekt6ZDc1eHFZQTNxT21TV0Ft?= =?utf-8?B?NGpleWxKMW5remNldEoxdmpYbkRRQWtUUFpBSGR0eDNJSm96bUZZWU44ZlpC?= =?utf-8?B?cjBsejErY0RMUnB3ajJ0ajZXaE1ISG12QjlaUXBUTGhaT1l6bWEyc1B5SFZC?= =?utf-8?B?ZjBNTW01Nmxoa2V1ekJSekRISERsZk5oSFNuUjVWaDRkUWUvNFBvWk9xdUJy?= =?utf-8?B?aVVkYk56VkVqR0FKQkhzZDFLOHBhSGRjcC9peU85Y1FNOW5vQ1RvWmQyMXFv?= =?utf-8?B?K3EzMmtSSEJodHVkSHlrRDR2UjNoS1V5WE9IV0RGZUE1TGNhQkpKZGZhYjZz?= =?utf-8?B?UjdCM0F2ZVVhTnhEMlR5WWRWVzRZMTkvNTRlYXVkUi9LVHUzcHFMMGhteEE5?= =?utf-8?B?REg0TlhnOWh3bENReUhHVE4vR1lpRXpDakp2VW1pYnluRE9ZRlNQYXk3S1FM?= =?utf-8?B?bGdrRkZiQnlYL0tvUERxdm9HenA0RHM2Qi93TFF2UGQ3blBSSGJveWk3VllL?= =?utf-8?B?YVVhb2dpT3BrSm9zdnJDZ1VKWGh0SGlkQ0RzRzV3di9aamNHYkNtU2EyUTAz?= =?utf-8?B?NU94TkUxQU54cHo5RkFSQXhGeDdaaGRzeU9rcjhiWG04WUN4cm9PYzNHbTkz?= =?utf-8?B?endIQVFxQ21ZUGZ5OWpnanN0Z0dzTCtQSGNpTGtjdUVkUnlvZ254N2FUaWZT?= =?utf-8?B?aWFFTWVpVWRIa3I1UkYzSFZ3S2MwZXNDVS8xd0t6OVhvam1hS3c5bzlxUGtG?= =?utf-8?B?V0ZjeEVmUGMrQUIxZDhBemJ3dmJ6eHBrbEpGdGViUG8vUCtVMW1WNDFmOWxl?= =?utf-8?B?cmFUVnFXZXEwU3BtajU0WDR5a3YrZ21yWk16WnBHTjRUbXhJdmRqdjNESEFh?= =?utf-8?B?cjR4QUFMMjVlVzQ3RnZOR3dVTGxBMndJT01uSGYvbUhwNG5HWmpWTHlTTTkr?= =?utf-8?B?S3RBR2Vub094VU5WcXFkekdrNUlhTVp6UlZwc20yR1ZIdEg1RmlmZUdYTXp5?= =?utf-8?B?TTFBWlRUMnEzVElma0lpZGhUZG56QVhyTXNCRmFGUDg2U0hSOEE3ekFMUlhG?= =?utf-8?B?NS85ZVAxbmZCSXFnbmdTN0FoQmlrOTNMYzMxVlZ0MGJlZ21oY2xieUVEZGZm?= =?utf-8?B?T2pqTnZweThwMUI1dmExdWlGcVdFRHVBMjNuTm9rWEhtak5BSkljUjdTNmRv?= =?utf-8?B?UjZiZ1h6eVNNNUFlT0s1Zz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB7110.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3cvMTdNWmJud0djWUhTZXhnZWJOZnR3N3RTMCtuOUl2Um84MWUyNHV3MUdG?= =?utf-8?B?WStXWTF4WU9XMHJhR0ZQVERTMWZsOHQ2cGdzekF1VFRDTlgrQUVYdnkvWExJ?= =?utf-8?B?eC9Ia2VranRVaDJlMTNIWjBCZ21JdjM3NUhjMU0xVGk0dVVUOHNBUGY2M2FZ?= =?utf-8?B?ZkFYa1RtdlhtQTZmcUJUbjBadWwzT2Rvd1R4OHRBd0xIWWNBV2x2ZU8zRkw3?= =?utf-8?B?ZGNvNXNQU09senVaK2NvbGl0T0VKNVJTQmxBcitDREIvZlVVTHlqT1Rha29K?= =?utf-8?B?dWdVM1ZBZUU0U2pPQlBTRFBONDI0WWRPQ2pKRmpqSUJjU0dIZFBwMHBBTFBt?= =?utf-8?B?UTNHTzA4R3JOekd1WU5yOUZMRmdOak9NY0N6YVZnbVhOR2J3NGpXNlkrTFgw?= =?utf-8?B?SnFhSVVKSXJmdmxVbXFJbis2dXJlOVc2WkhwZE44Yk5leU5pYkRYVVhkWmE5?= =?utf-8?B?M2NWQ24wNnFMOVpUWTZ6RVpvTnA2eXZtcmZrT0NoV2RJYVBYTkI0MWxPcmE4?= =?utf-8?B?Vk9uQ2U1eG1nQWhvWTMwUUZJc1grbngybUxkSmVpTHpQaGs4bktwcEJ5YkVW?= =?utf-8?B?b0pvNVpJdjIzZWZzRDFkVnZqcXEyQlFsamRCZHlHUitGK3pnTW1aUUozVjZF?= =?utf-8?B?VTl4Um4zWTJ0cXZDbDdIeGdGbkgyUUZ4SWRuU0VVdUpMQnp2WWpnaVBucFV0?= =?utf-8?B?M2ZSNTI1N1ZSOFBqbncxWkRXOHdJMVdFRHhjZzZzdUJ2OTNPeDF3a1JkUTFu?= =?utf-8?B?eDdpQmxvalQ3cy9QdnQ3anZUTVBoZ01HQzdnbzc1K0hQenhoVlJqNEwxeUpn?= =?utf-8?B?dkxoK2FKTVZaZFZOSm5icHJGQ0x1S09ocDBSQmMwWUE0R0VWbE1xMXFDeU1p?= =?utf-8?B?Wi9jRFlUdXcxUlBLckNvQlZtdk0vci9lemNzU1hBK1Y2dUFnNnN2Q0tnT3FG?= =?utf-8?B?eDNVeUcxYjhQZGdTaVhIYzNkYS93SndLU2dHbWtPdjBKdGZYZE9JcWV3b1Bn?= =?utf-8?B?UktHNU9QZ1BGV1NhUFIrZ2RlQVg4NFdZYWdLSXA4T1FYYUxhTVJua3FEZ1k2?= =?utf-8?B?WWhQMXJtakJ3UjRwUzJzdEhqem1jZ1VzU3cwU0ZKaklTaThmSjVjUFV3RDVQ?= =?utf-8?B?RUxIM2FNYkZ1NHg2TlExaXQ0SzNzOWpuc2g5alFPRjIvZjd1T0MrSXpob1Qv?= =?utf-8?B?YVpVWG84QUFtcnlhTjFybE9vNEtLN3hWblREWWJ1UEJiWnI4VGlrRVRhWDVG?= =?utf-8?B?Z05ldk9GOExNcm5YV3hlRnFWdnZNcFFNSVZzckZ5NjBycTJkQmR1Snk4T1NV?= =?utf-8?B?TmZTbkNzQUZZRkFOdWhHYWUwMlVleWxLcThrMWN5NjNRVExCODlHKzRqK2ZJ?= =?utf-8?B?MXdINkdpMCtwaXEyd1U2UzhkVlEvVysxeE8vdy90KzlYM0s4VXhuUmNLd3dF?= =?utf-8?B?U29YMVNZbWZVWW9TaUhJdjh5SW03cXhmNGZsS0pUUGRsZjlSN0YzOWtDQlRh?= =?utf-8?B?YnhHRUFsUnJnNkhQUWtxV2RkMlJjMDQreXZhLzNYTVVmL3pIQWZlaFFEU29m?= =?utf-8?B?eHJyeFMvc1doZmJVT1ZkSXZ5cHRZU0FUTHB5NkdEZGpPcjJUT3ZtZm1VeTVr?= =?utf-8?B?eGhOS1p6aHViZHI4WVBGckcyaGJhYmFhaHgvWkdhVlg2V3hqY0RiaVlDdzV5?= =?utf-8?B?c1pqbUxBS21sRGc3MUdnNEEvMG1iZUZta3ZpMWhyTUl4TDZqc3AzcysvRGRh?= =?utf-8?B?TFQ3UmZ0ZHg0Mnkra3BacU0yUVlCa0VOZXY5S3BpU1pDemN4YmFqZ3hZT1J6?= =?utf-8?B?WHJ3VHRzY2x5Qk1MWEJrMTFEenoxbDFqSkVsSC9rRXIrajRPWGxxNEtmWDQ0?= =?utf-8?B?bjd6dVpLOUgxR0hNQkM1bk5UTnNwRjVPVkxYUXRmTVM2MGg3OTB1aUFpaEJK?= =?utf-8?B?ODFzN2RuMnN5b3BxZXB3MS90R2FzZkF1NkV3cTJHeTBPOE9TTkVnNUFibnFz?= =?utf-8?B?NkhGYm9peXA4U0hNQ01TcWNybFNOOStwek1CbEkzVFY5dkpkN2xscXJWOURQ?= =?utf-8?B?cmsyclRsRXN6UlNQVjB6NEZRd1M4QjZ5UFBYWm1aYTJrdDJxQU5xZFFBRXRH?= =?utf-8?Q?KV140PYo6pHmtQbSgW0kyOSbK?= X-MS-Exchange-CrossTenant-Network-Message-Id: f93e5d0b-2df2-4ef0-561e-08dcc8d996a0 X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB7110.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2024 09:53:24.3373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KCGfFEYwEg+KDUTfj7NzyU+qJaWAFZczMGCteOpCCeskEiS/J4L49ukZu3iOP7y1e9DfuX+hFqrVHIYtvojdMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5080 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 95492140012 X-Stat-Signature: 5xiwj5y8fhxy46ywcezyb6c16qb9s3sx X-HE-Tag: 1725011614-66580 X-HE-Meta: U2FsdGVkX190kqveFr9mDKnzn0Gd6gkgOnlrBnOw+wE6uP2VAPWBCg+m26zk0ypUXZb1qaKU1Iru/110qzpqxqEAacp2UItsIyHhy1UANGrTCb4bwEfdQxYu3zOpv9CMpeYJpWhH8eUqv4bvMnbi2pMzc+Q89XW7gL4rrYJ6ET8Pvp8A4XGONGwOI8ydigz7r2Dg5DUN2u63lsf/tMoYF4bE+cqmzVpe+qaOq3I4ISukbpiqa2EBoAhsuIiGHw+XXWY4PKkPoGAxK/p2buXIXWg7qcVHVZ0b+z1NAVO/m1AdwlEEoJz5TtN4zYHbtgPGaf1m4BNlf26W4I+qqNTBHWPOGBFuzybzqrmfbZ7LABIoKjuyAv5jOt6f/pCIbDqkSJCccoKlOZLvZAhz659wfmi9GogI8tj+LRKiGOT2y5qG04Z0bMAR4AgztEHmeVJ1KAi29p5a+PkE6EtIFISsclDLVMXD3Yp9saQQExQxnl2pk37ei1pkjq5qGMrGRNESMF0NFqU+iCNz9dprLlbNKB1syt5GuuPMvXpj9QtbjHKyJuZwlKLrO4dzTn2BQiTkeFJ/jPMvqMo8cZSnvkZluECxB8PJF7tS02GNdDfWfh2M6/aJTMVYMck2BJ9uRR26DQV9I5l2m0dbNOEsLQOZ1cEElqXnH1gIbEr8hu5k13BpAP4UW6gX8vjDMq+C9P9gicHhqwwHbO0gCPWdCEMBcEGetTbUApCugMfiTdpi4zkkE1yQEXYcnnZV9GPQkmhiKmG9luIJOJjvRbqwpRWQDBnlB8Wf1hMNLTkBsqj21Fe1H/03xnTE5+v0DCIk6T7TvpTblTOpyRgIgktO5tirRoH6D+EKLXJubAY06dedlQJAve5A6bLPQoxW9KwgcgkHAKF/2X9es8/cJl75e/6tS8EZ9MDJj5iWs2mLrSayj3zSPnjdDZr4e2j8SasHvnW5YoKOeqDpm4qYzCkLcza l0u4p/h8 z2L4b58p2WW8r5kbcKDpInh5QG1XqvGHa/aBw/2fqVUsRte/Tg1OVKg1iYZnInYDJ6zqn0hdMXS5yMvDkHms9OfNS2zO4UQmTsMR7jse2a05GOPNGOBoyULael7dc0GagDZmQDkvz0uPq+2rPDxLUpJNETJ2H4PLKMpxsWgSGo4JG2XHDsb89l812VCBQzg94MLTQfrr/82zbzLtWbRDiHRxQSbNN5kuDfaIyXkZLckEVC9Zp+upHrIO6R+rpJEVC+/PW3RSez9CVdY7nGZSLKjy6Z8NpA/f4UAsUt3/26Ru2N+V+Enjf8wnwY+ldFJKZ8Ap5CxJ3JQElFqj5e9YjmTcf3Wd8eTruuExGHmJFhRQ74xe5ao6omMPEdgTBDMbxHegssQev30KPa5dS6nSmPFTc9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: [Snip] On 8/30/2024 3:11 PM, Huang, Ying wrote: >> Fixes: 823430c8e9d9 ("memory tier: consolidate the initialization of memory tiers") >> Signed-off-by: Yanfei Xu >> --- >> mm/memory-tiers.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c >> index 4775b3a3dabe..dddcd6b38e28 100644 >> --- a/mm/memory-tiers.c >> +++ b/mm/memory-tiers.c >> @@ -895,7 +895,6 @@ static int __init memory_tier_init(void) >> WARN_ON(!node_demotion); >> #endif >> >> - guard(mutex)(&memory_tier_lock); >> /* >> * For now we can have 4 faster memory tiers with smaller adistance >> * than default DRAM tier. > Although it's not absolutely necessary, I still think that it's better > to just revert the locking change of memory_tier_init() in commit > 823430c8e9d9 ("memory tier: consolidate the initialization of memory > tiers"). That is, to use mutex_lock/unlock() and exclude > hotplug_memory_notifier() from the locked region. Because we will > always hold memory_tier_lock when working on memory tier related data > structures in this way. Thanks for pointing out it. Will do it as below in v2. diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c index 4775b3a3dabe..ba3738b29cc5 100644 --- a/mm/memory-tiers.c +++ b/mm/memory-tiers.c @@ -895,13 +895,14 @@ static int __init memory_tier_init(void) WARN_ON(!node_demotion); #endif - guard(mutex)(&memory_tier_lock); + mutex_lock(&memory_tier_lock); /* * For now we can have 4 faster memory tiers with smaller adistance * than default DRAM tier. */ default_dram_type = mt_find_alloc_memory_type(MEMTIER_ADISTANCE_DRAM, &default_memory_types); + mutex_unlock(&memory_tier_lock); if (IS_ERR(default_dram_type)) panic("%s() failed to allocate default DRAM tier\n", __func__); Best Regards, Yanfei > > -- > Best Regards, > Huang, Ying