From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A14C4725D for ; Fri, 19 Jan 2024 17:16:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 849D26B007E; Fri, 19 Jan 2024 12:16:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F9F46B0081; Fri, 19 Jan 2024 12:16:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69A4D6B0082; Fri, 19 Jan 2024 12:16:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 57D726B007E for ; Fri, 19 Jan 2024 12:16:50 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 29D57401A7 for ; Fri, 19 Jan 2024 17:16:50 +0000 (UTC) X-FDA: 81696715380.06.6F07C9B Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf05.hostedemail.com (Postfix) with ESMTP id 80694100027 for ; Fri, 19 Jan 2024 17:16:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705684607; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WccHZtevh36Q68nlIwCeL4aylMukbYDvF4RnTnFhx+4=; b=4W7yVI+nEbUds8obQobsEt6vKJ6m6Ot3Gchd2imgsXKWiFxfD5judqcoDlKBXjBzugvH8m nbp/uottk+9IbzZVHyNvFHBr3xMAz7O1iHSlQUP4y1Xz1bGOKjobSCOVASGU4ofaPOIRtG PWsw4MNdR6DVYQqYMACaS+ynV7KsPks= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=none (imf05.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705684607; a=rsa-sha256; cv=none; b=e/LDqf/GrLLN4vpzAh6bH4NdziIgmaMBHA6dSzgl0nSlVgbGNm7n3zFwjYlFCXK6TJ8FCs CgIN6/2WL64ilwXoseBf4MKJWh8FMic/bVqH0hcPR5saBbHglSyLYQBAMetBNpHvAoMwr9 ryDmJjQzKMmwkjnXrCFHrrP8IBQCFjQ= Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1rQsTL-000000005Ma-3Z7s; Fri, 19 Jan 2024 12:16:03 -0500 Message-ID: Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit From: Rik van Riel To: Yang Shi , jirislaby@kernel.org, surenb@google.com, willy@infradead.org, cl@linux.com, akpm@linux-foundation.org Cc: yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Fri, 19 Jan 2024 12:16:03 -0500 In-Reply-To: <20240118133504.2910955-1-shy828301@gmail.com> References: <20240118133504.2910955-1-shy828301@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 80694100027 X-Stat-Signature: ry1ry15zkphe19jei9o8gb7kbgqj5dwc X-HE-Tag: 1705684607-160080 X-HE-Meta: U2FsdGVkX19N33OvRralUlaIfshLCZbSMtjQFW39PnRolDA3y8Xn481ZNE/ZjRT7HBOPXKI/BsukOyeT+mtHIIMPJNrUlbvvF5XFya6bCxCa7acmKQvErdfQErUZ1y3tyY9DKXlK7te88o11NNyGOeijv0cT25e7WvSF870sbSUkcP+suF5PI+Wbvi3A5kvFW+KM4qVMIZmpUblD+qGFVqmh3UGj3Pb3i4dbtwxTT1+3WjAO5LLL720LoUZNsdlsZxFRUc6b3iBJ00hYwmB9TU8R3lO3veJdIa9ycxeLtvTTMc4pElcCDiMZrsMeSpWjKwQWOlu4hXmElznmqMgoqiKPEr16cNWZMqAr+AvGcSdNbN1E4KyoYZWMC9vFNe0JaIiEwE9QVvqjG8t6dnmslKDgVcPh2h3OTDzrEmfV791BsERW8zMGD6eMJO2rda8HnMGVd990+K4HM6nypqMae4o9uK7uD3QkmOt1+7tG5nBYhyVaCs5qbzFCBWeHH7n25N3+uldWNnig5gAFgt+Q3g3vwMIa3dT2wwvw0f+SfVcBguMr0PPtbno4Y/kWFbt7c4bAajkRG/CDcnYs/s8hMJMXit7I7r9NunMDL8MzAUhN7ohuXIiuLB/t8tviBHOdEYJWn7UTrq5mzcwn6rE7+3RUc7g4URHw0+C5fVLAHKpYwRmbFnBOKKJM8hT3OtE9/Y14Y8E0EGERSmv9opcs++huTnJMtDleoyLW7kNXn/hrE9kXBrtRRKGTQkZXzMXlhJu3K6sJ6KVa9o8s6GmQFmP3dt9Fj32NB47rynnhuDQDQBE7OMoNPUojPFaslTH0AI/nJ7gQ2BkGSJfExWE+oiNgIQQxEfdC8ZLonBi9Oct6qYq5gxXVt8LGJWOpBKMpcf0gWnjdDwjMCL77bxYYc62xYq6KyPcIdtAsegyY0SiJinBfdZty8LapC1g5D0mQdd2QCcmDimZy5LNZ+47 XDf8Se63 aGsvF0YN4LSr/1YWs0j8IuvM9hiD7NbtVanPPqzQtt2e4KrYtnH7KwQfGPOQ0vULD8IBgJb3Q9Nt6rC79SIqAPdDK93RsTaxQXELKv4PsoUpSNbp1ELDAuD/nONIno83CPhGDA98vEty7RXzWpZiRFsybZiKJ3gZB3BDU7FI7qu9TX40qokXQjss9/A0X9jL9Co4JoZT0Q8DszruhW8lBtatorZMONhI59J6nF1zF7/YMJapu8xdUijks3wUu9es6LceamkjHdiUwDpAPxc5S57PMHkU6ZXWZJ2TBBTNeRljS7R03w8SUF5vMR0NoDdwPqd8ODfPXHHoepY2AUReM8BW/EoiZDC258iRtpPniN/mJpT3Qmrbp+ZnPgtCIVMUtt+36ML1S8Cq5QJQtKwhhT9zWLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-01-18 at 05:35 -0800, Yang Shi wrote: > From: Yang Shi >=20 > The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP > boundaries") caused two issues [1] [2] reported on 32 bit system or > compat > userspace. >=20 > It doesn't make too much sense to force huge page alignment on 32 bit > system due to the constrained virtual address space. >=20 > +++ b/mm/huge_memory.c >=20 > @@ -811,6 +812,14 @@ static unsigned long > __thp_get_unmapped_area(struct file *filp, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0loff_t off_align =3D roun= d_up(off, size); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0unsigned long len_pad, re= t; > =C2=A0 > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * It doesn't make too much se= nse to froce huge page > alignment on > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * 32 bit system or compat use= rspace due to the contrained > virtual > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * address space and address e= ntropy. > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (IS_ENABLED(CONFIG_32BIT) |= | in_compat_syscall()) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0return 0; > + > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (off_end <=3D off_alig= n || (off_end - off_align) < size) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0return 0; > =C2=A0 Reviewed-by: Rik van Riel --=20 All Rights Reversed.