From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5002AC27C53 for ; Fri, 7 Jun 2024 10:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6B526B00AC; Fri, 7 Jun 2024 06:37:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1C276B00AD; Fri, 7 Jun 2024 06:37:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B94DF6B00AE; Fri, 7 Jun 2024 06:37:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9C4EF6B00AC for ; Fri, 7 Jun 2024 06:37:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BC634C1866 for ; Fri, 7 Jun 2024 10:37:34 +0000 (UTC) X-FDA: 82203741228.29.8779E94 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 81BA140009 for ; Fri, 7 Jun 2024 10:37:32 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ctUi6Zad; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717756652; a=rsa-sha256; cv=none; b=WNY8KgHdH+f+XDnHf98LZglKFiwN24Jb/CbvOGah4O5b8PFtP/in+xvw9bN2rqsRWIjM3M z3GVdVGQWjb/00nr/UDEhuVDchRqv/yK9Hr11ejtVukg9wuiB+mrvY+PEDPunyBRxf1ZpK XuAKy+PV2Yl64qT9wGb/EPLOsY+/w8E= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ctUi6Zad; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717756652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4QB0cJiKlhTKWveDGQFpyqAZMakXc6usY9ryFqzBgo=; b=KtPLvMmAVgg+QNvDLBS+wV0M5YQ2OE3DOP4GUitoGg1r8NpQyjXb6M/6dYjq8S685/NATm dIaZv82P7bfO8u/ns48LWQvpQrzds40RtLTm+ENOwHOromrrVDAXmhtFyxB8fP5QT9/ANz zoHyQWPQpaAA/nVLdkXHX7Kn84NkMxU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717756651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q4QB0cJiKlhTKWveDGQFpyqAZMakXc6usY9ryFqzBgo=; b=ctUi6ZaddrvF6aoB7sEpoyNGUHoKRJ9erwkAflpW2pyy9XqQ+L/BEytmONu1X0TLYAeEUP 3LHgGytvivr/Wnllb2rp2DxHoUmF63uiFNfkzmVmi9DiKb8hlyrW3IV9xXCE9SDVrdKXzD GTFT2W/xKvlROzS6ba8SyiamWB9+QhE= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-eu0PE5ZYMZK4YZDnO4LNdg-1; Fri, 07 Jun 2024 06:37:30 -0400 X-MC-Unique: eu0PE5ZYMZK4YZDnO4LNdg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2eaa77740deso14829871fa.0 for ; Fri, 07 Jun 2024 03:37:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717756649; x=1718361449; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q4QB0cJiKlhTKWveDGQFpyqAZMakXc6usY9ryFqzBgo=; b=wWo7k0gAi4Tp5rDIe548OX2nXXZ34SnY/OhxrqrTDY/nup/vQNvoZmdQYKjqeHGqyz CTNhIfz7pjC4eCMZfhAYRTOYvCHvunoAUNHw/wuXDmuaKtMPlUNC8f9rGbYMhtkmo5Xm wXzU6c7XDOR59STYlgXa/y+0RXt1n0N2mvDHzDwxD/F8u0883q99MCtQ45XnYGdZavta hbuBPhmNhoyaeO6JZoiPzAPZCJ8SmGP39yUeSWz5ecZO4VTWUncMAEJJ91yyXBtrdTT8 qhQHBK6HxvMX21TBn8qqrd4cJGuTmof+t3GZoSk5YTneaJiyZvziKM3xtmJ6f4hZA9Sh uhZw== X-Forwarded-Encrypted: i=1; AJvYcCWoEjQFsNQjSbKcI+K7MnQftsfgCXRTWCiMohBEp1EX/ruj9qvW2RW76U7t0+Znsx1FvIdGMLKacjgGdCsM65/c15g= X-Gm-Message-State: AOJu0Yx6BAoPFwU5nzn+fNFbjVJU6L3JmceVWqis6tuz+b91pY6IbKx1 QtjCsqRCDb6ftJPeC34UfUb8rPHYHpetziAr6nWNUz85YgHmLXyVi5/3zRaJLCEPMRXzhlsbmu5 2i+OXWsdge3Qq1IReSfZD5Coea0r28rOrBDDQZFHQAzFtN6zr X-Received: by 2002:a2e:9990:0:b0:2ea:8291:c669 with SMTP id 38308e7fff4ca-2eadce86221mr12690001fa.44.1717756648785; Fri, 07 Jun 2024 03:37:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8JmmMYCq1eD/F2gccfs6dt/PjudHPyuoVOXxf+E6kBsPyzYnJcff6xTxfCUJnZaSJKXj46g== X-Received: by 2002:a2e:9990:0:b0:2ea:8291:c669 with SMTP id 38308e7fff4ca-2eadce86221mr12689871fa.44.1717756648317; Fri, 07 Jun 2024 03:37:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:2200:31c4:4d18:1bdd:fb7a? (p200300cbc71a220031c44d181bddfb7a.dip0.t-ipconnect.de. [2003:cb:c71a:2200:31c4:4d18:1bdd:fb7a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42161147811sm34313075e9.18.2024.06.07.03.37.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 03:37:27 -0700 (PDT) Message-ID: Date: Fri, 7 Jun 2024 12:37:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: fix possible OOB in numa_rebuild_large_mapping() To: Kefeng Wang , Andrew Morton Cc: ying.huang@intel.com, Baolin Wang , linux-mm@kvack.org, John Hubbard , Mel Gorman , Ryan Roberts , liushixin2@huawei.com References: <20240607103241.1298388-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240607103241.1298388-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 81BA140009 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: f5f6egcobotpfswx99fpdutxcbd58hz6 X-HE-Tag: 1717756652-179408 X-HE-Meta: U2FsdGVkX1+FIzTNPq2b+EfP9qz/XpAXt5oqjfxEEbUNw8Jr2jL7vhRP5ufedPWM/5fSXBw18E68AdzmBei8jyHLEiCEWNGf9PAJAGDtkdUTk7j/wzHds/Y+lK9h/PhM+zY4MO5DBCgKVOlzBsEQ4SzhpaErztWvPzmwb1b8o5Fe9/+qEtMO1A46gn0ww035ok4IladgXTVEPvREQ78rzAodqToezkI3wXkcAyhmjGqlmL0/cHgQHrXOjBSdhUuJu7+Uwql35GsN9oDUAHV1Ue85/1TG4dKTqB/T1I/Y4wYZATlE6k9l5mkNZuEtcb2Z3Uzy6jNUnGqsii+uFnn5Qt4kwwNqPcL/GDFrDk2P+5rkWq8RYNNWRvLTgIbBz/SFSROf+2To++PMJULbDfoJprtE97X6LXmGfU5OyqADers3iHOvoLcAob0JnipZ8K89TPCP7jqDTgOa+IuaYUH3tADTZsiIbxcuyHtNJkSbvuC1dF7/SaKvtow9JJNv0tSGvedasANMXhnvknKOB31BkxCWuFGztxupyZsFAX8wNeQxrjsmuG7zkfGbQyiIgxBSNfGRBLpO0KY/ZukOI94tbG38gfMJmjTB1wlPKXvm6UKLkQ1YFfkcQMM4L7r5FOgiERZrywbt3lgTWBRLaALtBN7sRees8ANnC+ihyO96tjaD7PwC6R/Wj9u6/SJ/L2OGbUNm7+yRXR5+8gurMI4F8vBCmxcvhcUMB0YAll+PhZL1GQYvfF0vcPC4+5AMx2EXDo5G/56U8IzfNuLhzIbfJ8zROcvyoUq2NlyqH24QWCnxFou9lECMSFo5Z+oTWS3TNRZxQ5zWusTExGY7hhx+jhx+2CoSMXvjvcJQfQEVwZKhe2cTeNTD4pZQGXdaBvgHHAArUzDQgap44fAEHvLfcUE1epZlw1oQ8JesT7iDtKtUc/OJlyUn8Cx2OXBq4p2vI0oSWVJKuhgCUhhJsVR 9BFC3RUJ 9SeAbs5RzHjRUUXxa5QQncFwSr/gnoK8GLhKUVtlNIa1sfxQoaoeNOKho5UI6rc4ycmkvPfFNbXE+WfUc3gjQEG8Hye9ewo8M8rh9TahlmoDnvLpSr8dkY2jRGb4mnqljK7Ss/zId/D8gx2RpwG8abvg7KzqtjCpqR8U5wO6CGWwxF9mlBBUAf4/ODwLITDzyWIPqJNq5iOAqVSWLz35wY4sOUFMHmcySGpHHOGWjPL51qAAS6VRXGInTTQiYtGuAcjcArH4FeuBxCcP+34XLBdAImSm7B22/6zLCJsMN33cZm1/m9LkJPRtmVuyZ0r6et/pYzPkt/HeWxaIAlurl8v+hYy95Clhku+QvQEFeFw8rxAqMl9yVvlPbarjj4yTxzQPEgWY56c4aRFrIUv4FggdofAK2CoRzRJaEBDcyBqhZqrAApW5zMIABULo0kYIoc00GsCylouI5hW9SSybYcM1f1gDpZNzpx9F4GKjc+OW8GQFwZI7yPY1S6VSUQziaVT3xnpSgjFtIPaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.06.24 12:32, Kefeng Wang wrote: > The large folio is mapped with folio size aligned virtual address during > the pagefault, eg, 'addr = ALIGN_DOWN(vmf->address, nr_pages * PAGE_SIZE)' > in do_anonymous_page(), but after the mremap(), the virtual address only > require PAGE_SIZE aligned, also pte is moved to new in move_page_tables(), > then traverse the new pte in numa_rebuild_large_mapping() will hint the > following issue, > > Unable to handle kernel paging request at virtual address 00000a80c021a788 > Mem abort info: > ESR = 0x0000000096000004 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x04: level 0 translation fault > Data abort info: > ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 > CM = 0, WnR = 0, TnD = 0, TagAccess = 0 > GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > user pgtable: 4k pages, 48-bit VAs, pgdp=00002040341a6000 > [00000a80c021a788] pgd=0000000000000000, p4d=0000000000000000 > Internal error: Oops: 0000000096000004 [#1] SMP > ... > CPU: 76 PID: 15187 Comm: git Kdump: loaded Tainted: G W 6.10.0-rc2+ #209 > Hardware name: Huawei TaiShan 2280 V2/BC82AMDD, BIOS 1.79 08/21/2021 > pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : numa_rebuild_large_mapping+0x338/0x638 > lr : numa_rebuild_large_mapping+0x320/0x638 > sp : ffff8000b41c3b00 > x29: ffff8000b41c3b30 x28: ffff8000812a0000 x27: 00000000000a8000 > x26: 00000000000000a8 x25: 0010000000000001 x24: ffff20401c7170f0 > x23: 0000ffff33a1e000 x22: 0000ffff33a76000 x21: ffff20400869eca0 > x20: 0000ffff33976000 x19: 00000000000000a8 x18: ffffffffffffffff > x17: 0000000000000000 x16: 0000000000000020 x15: ffff8000b41c36a8 > x14: 0000000000000000 x13: 205d373831353154 x12: 5b5d333331363732 > x11: 000000000011ff78 x10: 000000000011ff10 x9 : ffff800080273f30 > x8 : 000000320400869e x7 : c0000000ffffd87f x6 : 00000000001e6ba8 > x5 : ffff206f3fb5af88 x4 : 0000000000000000 x3 : 0000000000000000 > x2 : 0000000000000000 x1 : fffffdffc0000000 x0 : 00000a80c021a780 > Call trace: > numa_rebuild_large_mapping+0x338/0x638 > do_numa_page+0x3e4/0x4e0 > handle_pte_fault+0x1bc/0x238 > __handle_mm_fault+0x20c/0x400 > handle_mm_fault+0xa8/0x288 > do_page_fault+0x124/0x498 > do_translation_fault+0x54/0x80 > do_mem_abort+0x4c/0xa8 > el0_da+0x40/0x110 > el0t_64_sync_handler+0xe4/0x158 > el0t_64_sync+0x188/0x190 Do you have an easy reproducer that we can use to reproduce+verify this issue? The description above indicates to me that this should not be too complicated to write :) -- Cheers, David / dhildenb