From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5360CF648B for ; Fri, 27 Sep 2024 23:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E5946B015A; Fri, 27 Sep 2024 19:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7948B6B015B; Fri, 27 Sep 2024 19:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65BE86B015C; Fri, 27 Sep 2024 19:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4815D6B015A for ; Fri, 27 Sep 2024 19:22:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 056FC1A16EE for ; Fri, 27 Sep 2024 23:22:10 +0000 (UTC) X-FDA: 82612093620.01.C864F0B Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf18.hostedemail.com (Postfix) with ESMTP id 205661C0002 for ; Fri, 27 Sep 2024 23:22:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XUtl/dWd"; spf=pass (imf18.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727479266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7LAvOZp6Vqb9AO/+VS+wUvq7SL5EIr/lbn9RL5sF1d0=; b=lMc419zrnGCigIvIitZPHitnmMLIvQmAsrJPUkwZxByG2zAJYpI8h0qZis3G8CvQ1cXTio u4H+wxaGXDCsJkvaoaE//hErrqRJrRYw/ZjY0o2q/fqazYf24eqrbfA78mulMQRTpOWd/x j8op6AJObUFNxKvdf9LKmYaN/bq+5ks= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XUtl/dWd"; spf=pass (imf18.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727479266; a=rsa-sha256; cv=none; b=czLZOVP8u5LtC/0ZZVxhAQd9TYicfIIyenJTUGqmWzQeunXbgBPxHeso9iUYdDm/Bb9s0L ao3E9cvzj3Szsfxtq4uCU+RsO/iPhIqlpWcqx9ntsp0DRZnEU34nYV0S11/TU0wo/uEjta NjYgeJ/m1KxEg7Q0L6NM03jVwiXZj0s= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2053616fa36so34320625ad.0 for ; Fri, 27 Sep 2024 16:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727479327; x=1728084127; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=7LAvOZp6Vqb9AO/+VS+wUvq7SL5EIr/lbn9RL5sF1d0=; b=XUtl/dWdQtCWAGYrV33UPuJG3OejEt2mujEIFi8HuHkDHBAAWRWskBvByQpeUaBKgx Zs4D3rMkjmikL4tGAY3nYMIr0Ia4ZbOCwxSZhD6j58hvVlaqVmqui4skhkDmKkCE/0sk D9cEGHDmhh3lfCXHjUkM2v1mkvQ7gzJnoZljZimeU4ixu5kVu1ZmOZ86JorBn1LZJEQt g9vmz/W8uXVQW6XnKYL2gBsbDpJzSVgYsZB04eDRE9eBVOoF6IGSgGWQGj/JhymdSRoQ P7p1dDBdoF82YNM22yLijDW7D3vSxdMs+Xr0ex4Sp8g+Tw5RoQYkJdn7Lx1auKHzBdP6 qRCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727479327; x=1728084127; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7LAvOZp6Vqb9AO/+VS+wUvq7SL5EIr/lbn9RL5sF1d0=; b=IfoaqeO6mNJV7dT9iFEMbAJRLtxyFNPh4cQSGpg5RpvUmgGsBHOdSHKwrXuiLcMwBg HQgwwqQ7o0tGw4JpuBFIaaAUZWW/oa5tL5b6Q2MfsdVU/Z8wKXskDDXHj6VHmoTJ93iS YC2SJMZm7dOVh+lK7xfGYc3wpWnPEMOYZ8EVUv3OxkLl1ty2ZfU5FNLo1uI/E/XUZ/mr /Wff+IRTl/CtiivMtjrKIuHrsOpozEkKKwbEMxvt9Yj54xqsaIJ1dsVjrQJrsTZW7e4F GP6YXrlxTXlZvdaMkAtjsvDY+sI0u0dZPUIHCnKuQEVjqajhkb/oxrNnQwCnwxKEqGRn iAOg== X-Forwarded-Encrypted: i=1; AJvYcCVEHJHW0aMdS7nYplFqGHEwHsABhEAKij59e4D5hHKxzY+0jeQ15GjsjUy7GBem1olTURtxvpBcKg==@kvack.org X-Gm-Message-State: AOJu0Ywd/UtiTRoWjQcfM/GpvL/X1Wya0gYd8JcyBD89RknDpjBndVa1 SIHznHAvOy8YGXTpg7LMx4e8E8XBaT03U34RdAN+gtZtL34l905m X-Google-Smtp-Source: AGHT+IFXTEMtPJJpJatKRUAfPM6/3maacD+r+Yf+RlOH8FPWHZYjxB+hsah3pGiJOGYuet3l4rSHvQ== X-Received: by 2002:a17:902:e74e:b0:206:bbaa:84e9 with SMTP id d9443c01a7336-20b37b9b53cmr81601675ad.47.1727479326584; Fri, 27 Sep 2024 16:22:06 -0700 (PDT) Received: from [192.168.0.235] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e5169csm18253515ad.238.2024.09.27.16.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Sep 2024 16:22:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading From: Eduard Zingerman To: David Howells Cc: Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Date: Fri, 27 Sep 2024 16:22:01 -0700 In-Reply-To: <2668612.1727471502@warthog.procyon.org.uk> References: <55cef4bef5a14a70b97e104c4ddd8ef64430f168.camel@gmail.com> <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <2663729.1727470216@warthog.procyon.org.uk> <2668612.1727471502@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 205661C0002 X-Stat-Signature: m5zkbp6dnfyhn38jzc6nuhkazwnkpm3f X-HE-Tag: 1727479327-76331 X-HE-Meta: U2FsdGVkX19H6sf14EfZs2zK/z8qB0VwutCaS1V/BvcyBqQJB65D6pW1gtz7ebIGg63p4+75XlvjYKSpOUYprbxzd1VtSvhPJJJsbDXs5UpigeGq/8mx3NiKXnqgQBsD2D5IakzcBFMJNemoeMB1kTbiXgQGrVWnFOQZyKPCTauBipDXA323euyocvCV8sbEKDsEaGtbO28iJZ0g05beetFpeT0GxHw/p50fD57b1Fw3n70FQObLbyTixsnSqqe2yrfqXZ9T1FAaDKBKd/fSV66xJ/z/obnUrhZlVlUC0ydtzJ17o/DuNE1bfFxSxh6tJ8Nzx9GPgsb6BJfBxu3qk8/dS0yhQ43msFQA12uuNt+5JoeKg0sqDWQW4IzEYcNkW2kXE6NCGgH//bwXZdc4j0jqq2+lWY11YW2Pid1e33jbueqP82n7iNKsyxUMvCO/8zWLmrPGKcG0mZwFBz3B0OAnLqEBxdqim+se7ReM5cACQ2Ik0Hu6LfH2rhLeE4LMKVNlPxZy0Hk2hSMfbxO2uvlL3cSY5XWt5LFBLjymnYhURFJDPE3EBbF1wNi0HsGZDJg7dQTgcTe2FxMLofMVloi9qo0JoPXFdZ1RA5zfJzefcNSgwxC9/NKkWIGgZmCeM2E/qzF3/vIkXW5PATUnKbCVfKUwTtp+IgQS++263NC4UOsXcG2Ckt1lABNbrbWP6P9Bn7LfMmfWTBSb+4MiFxMDEuVOIO1jTfZDTBVaJL7Od1pC2T4cDN0OL5TO6pV2dILtZHMn3Q2Ba6pwnmyLJIHHNO0FWvDWBfehkQ4ghkwUa9lYjwwn2urjsUGETylhlJ+9Ro215PrPTyrIuu5ieLyNcZUVyHNYa+1Sxii8mZJp/rj4q3uHvsIDOVoe+KNrbRQ5t6aKrSkZJ662B9odOGJCT9xJuitof2GyqIFjAvOD5Teqqkv22S6RtgsNqVnUHNYK7XOZBFMRfTav6hd Y3SnNxgz RsYzPZl9IJnbuchE1sfL/xKC4EPTssN4AXESRnJ/VcHDemkKYNBPKh8xkvOEArtSRTNv5/mtTFXUBExsEzB2ABknPZOaOZ25zDzf7s6CAfSy1WhHr+qfbtEZnMeTdwVJAZw2BKBM3+S92704jAo+dGxNadLkFkurecivY/jhfqUAuiu9kYhSIu7lH02XmsoNdmhlFMj1tXNXsJx1mcIZcx4eJQg7oHKcjDQ1uzImOIsEpqe39P/u8Dzg13WS6H9O0F49MYgV7k8OrsROERFA8pL3OO0DvTkA2TbWkZegUG5QhA8VGpbWdrCXOjRsYWlKlyEKi3GNGQNiX3oVd9rW+gmnpp276EA31gcMQnS3Fq/eeuW+RA4x7xdg7qepBiZ48i5MxjAuWM84X2uj4jBWC8SZpol79zOadlyDS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-09-27 at 22:11 +0100, David Howells wrote: [...] > If you look here: >=20 > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/lo= g/?h=3Dnetfs-fixes >=20 > you can see some patches I've added. If you can try this branch or cherr= y > pick: >=20 > netfs: Fix write oops in generic/346 (9p) and generic/074 (cifs) > netfs: Advance iterator correctly rather than jumping it > netfs: Use a folio_queue allocation and free functions > netfs: Add a tracepoint to log the lifespan of folio_queue structs I used your branch netfs-fixes, namely at the following commit: 8e18fe180b0a ("netfs: Abstract out a rolling folio buffer implementation") > And then turn on the following "netfs" tracepoints: >=20 > read,sreq,rreq,failure,write,write_iter,folio,folioq,progress,donate > System can't boot, so I used the following kernel command line: ... trace_event=3D:netfs_read,:netfs_sreq,:netfs_rreq,:netfs_failure,:netfs= _write,:netfs_write_iter,:netfs_folio,:netfs_folioq,:netfs_progress,:netfs_= donate No warnings like "Failed to enable trace event ...", so I assume it worked as expected. A fresh dmesg is here: https://gist.github.com/eddyz87/e8f4780d833675a7e58854596394a70f Don't see any tracepoint output there, so something is probably missing. > > Alternatively I can pack this thing in a dockerfile, so that you would > > be able to reproduce locally (but that would have to wait till my eveni= ng). >=20 > I don't have Docker set up, so I'm not sure how easy that would be for me= to > use. What's your preferred setup for the repro?