From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1C9EB64DA for ; Sat, 8 Jul 2023 11:02:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DE818D0001; Sat, 8 Jul 2023 07:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1665F6B0072; Sat, 8 Jul 2023 07:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02E9B8D0001; Sat, 8 Jul 2023 07:02:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E48B86B0071 for ; Sat, 8 Jul 2023 07:02:49 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A49558016A for ; Sat, 8 Jul 2023 11:02:49 +0000 (UTC) X-FDA: 80988156858.16.52C0630 Received: from mout.web.de (mout.web.de [217.72.192.78]) by imf05.hostedemail.com (Postfix) with ESMTP id 679A9100020 for ; Sat, 8 Jul 2023 11:02:47 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=Tugwf3wT; dmarc=pass (policy=none) header.from=web.de; spf=pass (imf05.hostedemail.com: domain of Markus.Elfring@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688814167; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dX1+G8nk5ylZGBr7A7WdvgKE0D7jleY+YWaBz175cjc=; b=GawaK5nfo4mMalqcHIhYJS90XlWHNYNdCWoImAtG2/Hv1pBPPzscMWXaiteNdQ1DGHgl0I rT4i2eWGRCsDLnLmfQTEUrZ4agB4XLuFyIJ8QyQgsULOhxnrzofSns/rFfkCw53GJ/Yy7n EkZpwrU9rTmP87C6YBPLC1QgT7jXc/M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=Tugwf3wT; dmarc=pass (policy=none) header.from=web.de; spf=pass (imf05.hostedemail.com: domain of Markus.Elfring@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688814167; a=rsa-sha256; cv=none; b=bsm7uQhDtjgpgfo3NMC/15yTY4x1poFp8sqRqtUZJWjPnEtxukiqVtASGLa8o/yJcBNhPA pES++1C237u63Y1xzlMw38Fnev+F+o/zXpeY2tTonC08ru55D+F3mvFAwV9/74tILJaYRy YNWjDcuLT4XcJBeqXDe3G+DlQTFw9UA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688814162; x=1689418962; i=markus.elfring@web.de; bh=dX1+G8nk5ylZGBr7A7WdvgKE0D7jleY+YWaBz175cjc=; h=X-UI-Sender-Class:Date:To:Cc:References:Subject:From:In-Reply-To; b=Tugwf3wTlj2uAerZR2F0lo804rvH/IkhdMnMyPVeotIwPOUAcF0KFeR3Zmm+hIXDuxSmKFx CKuLq7Ex9490rxe6bp3NuJMmDpZx6fB+e2m2a2ai64buBCce8/8jJlL5X2jQ135I3voCjgpHE QnTpRpDaC8QhpbiWrl76jZvnWPP2k7JFax8aNqpmBEQhhLN4j0hPL3W7FeMpcgOjTW1vsG15o NdKCI6b3aSrmpaL+bDXYhNP+tVIcdory0JbbgIGDl1nCqxXmYEQhTXNZ/k4ObuHTUWY9xgcUX zeoQZpVVdIdVxEJz7HhrfvJ79jxxaHmjXWURm2FBSs62Ygm1Gujg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.83]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MxHU2-1q2mqY12aW-00xgqE; Sat, 08 Jul 2023 13:02:42 +0200 Message-ID: Date: Sat, 8 Jul 2023 13:02:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Miaohe Lin , linux-mm@kvack.org, kernel-janitors@vger.kernel.org, Andrew Morton , Naoya Horiguchi Cc: LKML References: <20230708085744.3599311-4-linmiaohe@huawei.com> Subject: Re: [PATCH 3/8] mm: memory-failure: Don't account hwpoison_filter() filtered pages Content-Language: en-GB From: Markus Elfring In-Reply-To: <20230708085744.3599311-4-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nzApzjDF5i7A+vPUF8FL5/6RwnbtxRfROFyoznCLbAw2eWj7JOY UTZ6r1O3dv3+fF08FxXrpJ50SUq31tATxu5HWs4xRoMFZYkq0m26WMKerwZ9muGwrOIQkwS 7bwWxJfvV3QIc0eXULagDeIzcrNC6tLE7R1D1N2FGMOvDfrJokFBxEjtQu/hf6F8Lrbtua0 CBoyeHhOaIFzssXPFLeDA== UI-OutboundReport: notjunk:1;M01:P0:oTycNIdtcxo=;oDCdja3m028/U6Q3rKvqysmiA/n pHNhERNgTmQdZoTGPpbzbUV1xNfO6EXZ+nPFBuJLXByw1TRmICDN/tkC50yrkdfxo7zj5FKpo Bu7RzA8JJK34MnTIi5d/ZDg4B8+PMkI83gfKf/I/AOBhsEIbeRcAUhsUWuM7bcZ3o60l4a2sK C+pgKqNyWQCdCRMQnfzbRxiXt/lyN2HPLklC750X76D4vnTpCr7NlfvG25dYzp71vZD66eYsY E6FhGfNprxm1v1W2xWt+8krGylMpHv9xA3XCD1fEeHaD0PIP4DGVgqapDOX1mBNfKW8H/rrMc 94mPGJvg7HtT7WQ1VtCHIqX4YgeB3+M7bLqky8WfjJALLIDqRX1VUkj+bvHmPycarhq1Cj+tW 11BVWbtNXbvfA8FXn/ctKOrQPVxta50JapBdEnlW1aMdITX4CEaTV5R9BS4ZjfXFYJEkzWJlJ UF+sVFNU9b0C0Y6qNmq1nb11UJSHobulj1OTls3MCqSGzLsAjN+y5lU7lAl/joh+p1Q2MuEyn 2DpYxx5RlBFEJcbGzXgHquJFX1BH1LgSxUYI6ypW3PCPxstOS4oOZbtGAVluBXVmLy4bIZhLO OqisqIj8RoPBYecJ4iA01vhHIgURBcgy3qAOfnJun10v25+G6QV2Lx7O5SdQWl8M0v+NcSfkA McDjcyQwXyXfAFya0aSnPuUcRN4NzigxnHQ/ixElDu8b+5wNfMxWVGnEvPVXRuya+/cuoyaWu RWfn6ogpyt3Lf9MFTH3oOJRX/R6rQsKivBGVMZCfGNMyan34AI4+5eP+BAs4x3YJmlSQqMM7p /6msEG7u6SydB5q/kyfAbaEluM7DJcfBO9TrX3lCBik8lti3H/PF/w15XE0cmArMNq8HUKgRJ M5E+1VCaK/xAGz8ELIWCoQX1MpZp1JFF2LFFfj+LfvM8PYI2gGfEzpZtsyZ3UJCr3RDV59qfk 7tHk2w== X-Rspam-User: X-Stat-Signature: 6iqrrdjm74koqgij3cdjy43w8o6m17e3 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 679A9100020 X-HE-Tag: 1688814167-875602 X-HE-Meta: U2FsdGVkX1+MCVcYOXjqnnQP5vRjxnhqc9+XolDn3jmfwbHSjXvuoOwRSksv+ssfSH8Gr9eb03BHYrVih+YMCuWX3o+U8uXPRKRSbnzW19ONUWt1t6eyJ/1fTAyaiqbMxQntg4OlMFAEm622J42OjTORY53VIbpD8hBoGa1hX4bKxeR9bdoe14mZ0h/Vl9lg/hXSM+pEVslDMZYC6aLfJco1CQqyO9VVPCaIjLYAuRF5vBenpMrHHelKQP8UqEVfXXaChHe8Bd1+nJMk42gD+oRFb+nEsDqO9odwZrNfXC6vtK2g8cYfQX4UhZIm4NGb4jKsrMZ6OWAd1WhVGqvwklPWVE4IzUYxXoisw8ViqEtCkDqx6IZZzmWJV+XpztGwyMWDzRiGXTZAozN1NDnLZcSFaVSqXx7yuRnfmaMJ5yUyrRlN5k1hcZNCOq6slIVaQRs/YTdTTnWhnu7hLSiC7yiMOT4Aw5gJMH0nOoscjum6HdNqj28LFqGq58uriSXJfoyn3l0vrX7V8UBEc3ztJcZTvoLpvpmudrxPsh0f1pp2Zv9rrwWOg1KOthsXLNBFCpqK8iMTTkar/NJir9J+i78C0Q4WVw3PObgnOysfHauqgcG0sNB+D1lxYssHjBOL5TJDU5v+y6Go2jlt4oWqevBAI7KK/w4UYSgouWtqYfv+lv4U8cfAvDin3HUttWQ6zYdqlPAZ7zEpWQe5gtCTdI9RGLms5GHg2aZZivuJUJykVhbedeBFvKkhTunoqGvG080AU56NLueHQUhHACT40vjlMESD0RZhmkKZLNwhPKo8rKgzrT9t1U+p2PNzsE8Xq+brHIYXZ5MtkbwGcZ1hnIxkAu4HeJikxHHOzNMZ4d9fNGLRQeifqTIShYMBxCQMQhojfjdDkBhvZxneAme2SIOeT7xy9j3gr+KvbovxjPpoGYQw131xkV8c1mMNAyJ2gsEzUygi8xKzUcS+Dfi EtFI6z4G wJbiOQtvcfRdR1EuXZWGSQNlhOCamsJfw/SKYx41g4qtfgyWgz5Jx8BGY/vnJ/pc1LFXbZgphSg/xbXAFrQezwrfgHT/3GNP9BxtPSAPq0HGfaU9ta5mxFoaPnK8sVC5f8NvZ/2UGbV4WY2q45z+F17+1natVetlxnvHntmRGw3VVXeW8KW/FhU9lHNeIAnO8N8qOrWiKX+6gJwnKwKVXXcCukdDXldTDJwBPjsmDEhA01ULoubGWRfwvi26lSotC2JR+bqErcFdWBrbZZ400WjGQJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > mf_generic_kill_procs() will return -EOPNOTSUPP when hwpoison_filter() > filtered dax page. In that case, action_result() isn't expected to be > called to update mf_stats. This will results in inaccurate but benign > memory failure handling statistics. Please choose another imperative change suggestion (also without a typo). See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94 Regards, Markus