From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C376EC27C6E for ; Thu, 13 Jun 2024 01:08:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 480B96B0083; Wed, 12 Jun 2024 21:08:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 430DA6B009A; Wed, 12 Jun 2024 21:08:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F8B56B009B; Wed, 12 Jun 2024 21:08:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 10EDF6B0083 for ; Wed, 12 Jun 2024 21:08:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B63584051F for ; Thu, 13 Jun 2024 01:08:45 +0000 (UTC) X-FDA: 82224080610.20.14C66D6 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf18.hostedemail.com (Postfix) with ESMTP id 809E41C0014 for ; Thu, 13 Jun 2024 01:08:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=MHC8fvCR; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718240923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=frrlRZLq7WnZ116ncXcEtLFOrq8M38OfqlEQUKfVJM0=; b=2kinWOwLz8R6+fRh1ch3fwv9V3QD7DMNMOw6u4GI8SmjQu9tOna1YVMo+YbJSKFR2Dm97h SAV6sXw3DjiMyIMQVgcgmlUSi8mttcxH8zkI5+VsKiimrwzHvnSHQm0p8fc4AMNRUFKwRI 1tPSg9E4HmWOk4QY3hC2UbHA1RQLyNg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=MHC8fvCR; spf=pass (imf18.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718240923; a=rsa-sha256; cv=none; b=UDPt5vCxoJu4oeffIzDWBAeePtifqPOyFK/1+3JfzrlF+ut5JfkpsV2XhiDUfiOIGhTHqy ZtzxB9DEWmU0imQhBuSF/TQP+NCDDDdh/9SPpyN60RrIx29lgzHk1+I8tiA05HFIGflP7/ QSYu5++joHoWOqt5iWVS3WR1XBID5tg= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718240919; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=frrlRZLq7WnZ116ncXcEtLFOrq8M38OfqlEQUKfVJM0=; b=MHC8fvCRfstHzOmAqcUgAv19TL/4OwV/kZjbRTxHOm1iTyb/Wvz4bjq+ZSToucKjUlYzC7a99ffYqJcvU9Of5NPaQ1VG8wwyifC1IQ5zNVZctNO2yPMt7rld9b6Al/S9vMqjVO3iBRDj3A0l+TYDT+YdA1ytf/DuC2wbRTEE3Is= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R461e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0W8M6-yY_1718240918; Received: from 30.97.56.57(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8M6-yY_1718240918) by smtp.aliyun-inc.com; Thu, 13 Jun 2024 09:08:39 +0800 Message-ID: Date: Thu, 13 Jun 2024 09:08:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/6] mm: shmem: add mTHP counters for anonymous shmem To: Lance Yang Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, da.gomez@samsung.com, p.raghav@samsung.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <4fd9e467d49ae4a747e428bcd821c7d13125ae67.1718090413.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 809E41C0014 X-Stat-Signature: 6kc8rxwg3w4hy99yrhnn4qhk8tw9xxms X-HE-Tag: 1718240922-721998 X-HE-Meta: U2FsdGVkX1+ACA4BV7PpD9uW3rErozykK33eSuMX0Rg7lIp5yU4tzaBpMXaYGfVirQo0XZFFHcj+4DchIlQMb3xCjb6JBYpUOq1q6CxIlPeCovmn9WK950zCUT9QHe7fsFxRMzpzjQgZ9YdI3Ry21UF5suvw49PVbgPVFZDM0PUelee+CooFYoO9sMxSDWXHSlvsTUJHJrzTbG8BC9yWHvvejU0WiAPAnhLy2xmlXd+OfZ3iOdL6Qidq8zFLl8eCGF87Rx3xJhUG5rQN5E+J4zeVyKbpNLpyRSem+6gp3b234i6UJB8SWsSvNZMxZlTguibgJzJEB81MuCmzh5eJTD1evPP+0g96Lo+DS4ZQHnX3vm57u5k8RYZsbxAh+VUO+ui6WdzlQ04ioHjPhwOhwV0RxKyOkfA4P2jT7nKyUxETpDKwpHJQv9BSrNW0wtsqBgPT/PZ5qukMuLevZEQQgogbhiVT2I3ap9KpC4SYEjieH9XtFxpAoSwljow0iZ6D+JAKvC3OYfYfZHx9+DGwa+8DZkNhQmYzWmuGz2PZnKKzi4raOVcFGEkNSG/U4oeDeWPjRBxqYSeEbKNEv6j2A/0x7+iu07hbkUmwv2LErH857tmbGNFbWvdVSkG8x0i96ZHrUSNIw5aLCGy0vDsXh5PbxB8AJlqZ0PN/vM+WIpQMzmsoCJbUo1OTFmDDt7UTnXCVQIztnY/wiS3VSjdLPRAnjmWBjyXdc1eFdtbzv2cyKyRVB7OcT9+pOGqE8sCkT1UH8ZwgjNsqTdolIat+EXSbE3ZVfw/6jjNg30cEJf9P4act1D7NTadqBvsDo77NPjgZKSfMFHus6/bdfhGD35hSOPqVtzXtgZ6ufvSSgiqk5vsAJxkrHDKfS1J5nJ1QYR9cRhfwxAH0KEQlo7jlYSNGLJXuq5d25ODQEc5BCb2wqB3lNJ1P6Lj+kEkFlJWiJ2f0gm6PvgTDs47wUPf B8+Ko8e/ pOR7IoUrMV87SIXVvEipVFOgz/36VOqk3leLlxYyUrd8zI9lODSjLiHUdHaC02y3CxeYz45b5j79l2GnDvbtTa9pqvjRPNGPCAB0pD+l0xzXOfJEL1VgH+0nCGYTY4wbf/1cjLfYanuSSS3xLtEb2etZBiM/iEnO+3HmHR2Obv9FX66DfK4Dh4cY8uj4O3t8OeTnOS9F/L93EDA/LJbl/I93JZ7S/d4xVcPEAsAQV0UJmWSecJC/TTHuP1npLx7CJ7ExhczYbXXOZs6j6z+udkHWeVUbbJNviwSRLE856eV7mOj89NKxvoyvDRp+rDzj5d4DQaZv+siUk5Y1qRbHqCy42FXVgYOfd8/cF0fjho20mXaTKphjZYlkfIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/12 22:18, Lance Yang wrote: > On Tue, Jun 11, 2024 at 6:11 PM Baolin Wang > wrote: >> >> Add mTHP counters for anonymous shmem. >> >> Signed-off-by: Baolin Wang > > LGTM. Feel free to add: > Reviewed-by: Lance Yang Thanks. > > Just a friendly reminder: We also need to update the documentation > for the counters in transhuge.rst. Indeed. Andrew, could you help to fold following changes into this patch? Thanks. diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst index e7232b46fe14..8f6ffbfc4b16 100644 --- a/Documentation/admin-guide/mm/transhuge.rst +++ b/Documentation/admin-guide/mm/transhuge.rst @@ -501,6 +501,19 @@ swpout_fallback Usually because failed to allocate some continuous swap space for the huge page. +file_alloc + is incremented every time a file huge page is successfully + allocated. + +file_fallback + is incremented if a file huge page is attempted to be allocated + but fails and instead falls back to using small pages. + +file_fallback_charge + is incremented if a file huge page cannot be charged and instead + falls back to using small pages even though the allocation was + successful. + As the system ages, allocating huge pages may be expensive as the system uses memory compaction to copy data around memory to free a huge page for use. There are some counters in ``/proc/vmstat`` to help