From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF847C02194 for ; Thu, 6 Feb 2025 11:00:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BFFB6B0083; Thu, 6 Feb 2025 06:00:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 549DC6B0085; Thu, 6 Feb 2025 06:00:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4104F6B0088; Thu, 6 Feb 2025 06:00:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2112D6B0083 for ; Thu, 6 Feb 2025 06:00:16 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9BFF1161070 for ; Thu, 6 Feb 2025 11:00:15 +0000 (UTC) X-FDA: 83089225590.02.E5E1865 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 4C9E414002D for ; Thu, 6 Feb 2025 11:00:13 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf26.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738839613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=61xoBgHVgQ+m9UNJQKQrr1AJ25msGS3tB5p3z5aGoF4=; b=TXPqs5KQcz7Y8b4kJzy1QIyiI+n3Axkzm/Y7wlZ4VNY7Tdq9nw4KWccooiCK0Vo8cosWqA 0Rrq34+6PFXtxCh99j1IicVDmNMs3jAL5Bir5oz0YG0b6gluwJy5vxHkCBCzVWX8ePyEoG 1pxW31SEVtK5UCTBJM5xg0Q7gWqwTuk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf26.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738839613; a=rsa-sha256; cv=none; b=40ttagIT/xYWTyMxSi6MAeNvDJUpIptGBQ93YFLB2Goxctznwb+x9QDjk3CgIUHkcZ3ojr /nNcNvma5SijlvqqHEHigQqgoBNYANfsPsEhr3dqSdsBoFz04nAAlRqhIFZR1nNSj9aE6m 2nLhBaCbbl4fBECB+wsaSpQZVNHxLVU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C1D9712FC; Thu, 6 Feb 2025 02:55:34 -0800 (PST) Received: from [10.163.34.115] (unknown [10.163.34.115]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7D6723F5A1; Thu, 6 Feb 2025 02:55:06 -0800 (PST) Message-ID: Date: Thu, 6 Feb 2025 16:25:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 05/16] mm/page_table_check: Batch-check pmds/puds just like ptes To: Ryan Roberts , Catalin Marinas , Will Deacon , Muchun Song , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Mark Rutland , Ard Biesheuvel , Dev Jain , Alexandre Ghiti , Steve Capper , Kevin Brodsky Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250205151003.88959-1-ryan.roberts@arm.com> <20250205151003.88959-6-ryan.roberts@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250205151003.88959-6-ryan.roberts@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4C9E414002D X-Stat-Signature: cj8gw16w6i9hop9rrtjk6foj5mz4n7ga X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738839613-805660 X-HE-Meta: U2FsdGVkX1+Yvt3AlFqJVBCwsV6TTYOX2No0grS968IDsHPiiz/qtQmitK96GRJaBb7FHi42LjPEiybh8azgwX/RUBqZ2EVDnjK8G6f2yORd9myY+Do5cuXmzrprdoTRgOFzSTy/84R0qDNRL7dP38Bie6GHb2SAM3HXAm5c2/O1druIfTijFCYLnIS31Vp5EcgPO7X28MRUGUXXsAOy1pwX4UUNQcfAhvXmIzPdHEMXaDTu9kg4zapiYCSxD/fG6EAxIq+UR3etP07w0ScZ6dCdhwMUhLdyhB0FaiAlUPLeGkq+ppegxTqVw+VwkgI07k9BFO2v9RbN8f94F5UPO2hZgejXsRo+rKI5tiQDfrZgu+e30H0zapnyU743U8rkF2O6+fH7Mqz49g6JVH5gne0Y07eGf18yQnqjGoKooMUNmEkRHu4WuQdlUCx4dp67htoMxIQs6j4eXZrmb9mca6q+9lFmirS+EVFJmO5ynFQJb1Z0pxRRpwzpsgjsQS4EqZWigZh8Ni9ToaV/78gXI26yWu/I+su1y7ses2B+ky3C/6S1U2nIa+PULR4vQVNrtOxZvtGnI/S9z79mUflqrg2JZWuXOMXBh+bWeANzel0f2YRKUMDvBgLa4TCIvpq/oJBKqRkAk8BpLl6mp7ejh2qOIA9XrXuH5Div729s7JaZx5OI5po0e/Fdidu6GZ6L8idaQXnbixbL9hZuQefZoS3R5AkWmTPCl5d4cj5lJ+yYutGmjl6446+6elmOeN3655V078hIy1QMvWxJ1dUZknBbIBxbRPKSinUQy4sk6VLW5nO6E6pksazSI3+GlHGxmE7FDWB37JojaIIIpH1Pm1KpGzbAekeN/BUEstBUM4Z67MBSDRBxq1h/Aj9ww1GpqrgnHaLP9ZhpDyy3EPQ1RKkY1GJ3HXFX3Rh+hW74UrxQNPQdSQDUDyWgkPx8Oi/xU+rQ+xgXlFdCy0xJ9YA JLVg2Hs9 6XNc8PtueG2tjxNThTxGp624Pjt4RPUHJFpwYWgZAOmsX7KKa+rEyW3Vgfk+tx1S3tisOFzU7PxThPBg9p83mtxHEeHWHdj7LwzOUfFt7tf0EW1FnDD+DoC+L5+vCaPi0srT/NjJRao+++IFcd2EpW0mR8LrM+LdLjD+q7/bIcua/O7UO9/KEJspNwano/FD9DMWE6QKYxp0Jmuwq9Z1luh7PTezb9Tx/B61qgrzbNawQBcPbIk1xUDrVXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/5/25 20:39, Ryan Roberts wrote: > Convert page_table_check_p[mu]d_set(...) to > page_table_check_p[mu]ds_set(..., nr) to allow checking a contiguous set > of pmds/puds in single batch. We retain page_table_check_p[mu]d_set(...) > as macros that call new batch functions with nr=1 for compatibility. > > arm64 is about to reorganise its pte/pmd/pud helpers to reuse more code > and to allow the implementation for huge_pte to more efficiently set > ptes/pmds/puds in batches. We need these batch-helpers to make the > refactoring possible. A very small nit. Although this justification here is reasonable enough but not sure if platform specific requirements, need to be spelled out in such detail for a generic MM change. > > Signed-off-by: Ryan Roberts > --- Regardless, LGTM. Reviewed-by: Anshuman Khandual > include/linux/page_table_check.h | 30 +++++++++++++++++----------- > mm/page_table_check.c | 34 +++++++++++++++++++------------- > 2 files changed, 38 insertions(+), 26 deletions(-) > > diff --git a/include/linux/page_table_check.h b/include/linux/page_table_check.h > index 6722941c7cb8..289620d4aad3 100644 > --- a/include/linux/page_table_check.h > +++ b/include/linux/page_table_check.h > @@ -19,8 +19,10 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, pmd_t pmd); > void __page_table_check_pud_clear(struct mm_struct *mm, pud_t pud); > void __page_table_check_ptes_set(struct mm_struct *mm, pte_t *ptep, pte_t pte, > unsigned int nr); > -void __page_table_check_pmd_set(struct mm_struct *mm, pmd_t *pmdp, pmd_t pmd); > -void __page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, pud_t pud); > +void __page_table_check_pmds_set(struct mm_struct *mm, pmd_t *pmdp, pmd_t pmd, > + unsigned int nr); > +void __page_table_check_puds_set(struct mm_struct *mm, pud_t *pudp, pud_t pud, > + unsigned int nr); > void __page_table_check_pte_clear_range(struct mm_struct *mm, > unsigned long addr, > pmd_t pmd); > @@ -74,22 +76,22 @@ static inline void page_table_check_ptes_set(struct mm_struct *mm, > __page_table_check_ptes_set(mm, ptep, pte, nr); > } > > -static inline void page_table_check_pmd_set(struct mm_struct *mm, pmd_t *pmdp, > - pmd_t pmd) > +static inline void page_table_check_pmds_set(struct mm_struct *mm, > + pmd_t *pmdp, pmd_t pmd, unsigned int nr) > { > if (static_branch_likely(&page_table_check_disabled)) > return; > > - __page_table_check_pmd_set(mm, pmdp, pmd); > + __page_table_check_pmds_set(mm, pmdp, pmd, nr); > } > > -static inline void page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, > - pud_t pud) > +static inline void page_table_check_puds_set(struct mm_struct *mm, > + pud_t *pudp, pud_t pud, unsigned int nr) > { > if (static_branch_likely(&page_table_check_disabled)) > return; > > - __page_table_check_pud_set(mm, pudp, pud); > + __page_table_check_puds_set(mm, pudp, pud, nr); > } > > static inline void page_table_check_pte_clear_range(struct mm_struct *mm, > @@ -129,13 +131,13 @@ static inline void page_table_check_ptes_set(struct mm_struct *mm, > { > } > > -static inline void page_table_check_pmd_set(struct mm_struct *mm, pmd_t *pmdp, > - pmd_t pmd) > +static inline void page_table_check_pmds_set(struct mm_struct *mm, > + pmd_t *pmdp, pmd_t pmd, unsigned int nr) > { > } > > -static inline void page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, > - pud_t pud) > +static inline void page_table_check_puds_set(struct mm_struct *mm, > + pud_t *pudp, pud_t pud, unsigned int nr) > { > } > > @@ -146,4 +148,8 @@ static inline void page_table_check_pte_clear_range(struct mm_struct *mm, > } > > #endif /* CONFIG_PAGE_TABLE_CHECK */ > + > +#define page_table_check_pmd_set(mm, pmdp, pmd) page_table_check_pmds_set(mm, pmdp, pmd, 1) > +#define page_table_check_pud_set(mm, pudp, pud) page_table_check_puds_set(mm, pudp, pud, 1) > + > #endif /* __LINUX_PAGE_TABLE_CHECK_H */ > diff --git a/mm/page_table_check.c b/mm/page_table_check.c > index 509c6ef8de40..dae4a7d776b3 100644 > --- a/mm/page_table_check.c > +++ b/mm/page_table_check.c > @@ -234,33 +234,39 @@ static inline void page_table_check_pmd_flags(pmd_t pmd) > WARN_ON_ONCE(swap_cached_writable(pmd_to_swp_entry(pmd))); > } > > -void __page_table_check_pmd_set(struct mm_struct *mm, pmd_t *pmdp, pmd_t pmd) > +void __page_table_check_pmds_set(struct mm_struct *mm, pmd_t *pmdp, pmd_t pmd, > + unsigned int nr) > { > + unsigned int i; > + unsigned long stride = PMD_SIZE >> PAGE_SHIFT; > + > if (&init_mm == mm) > return; > > page_table_check_pmd_flags(pmd); > > - __page_table_check_pmd_clear(mm, *pmdp); > - if (pmd_user_accessible_page(pmd)) { > - page_table_check_set(pmd_pfn(pmd), PMD_SIZE >> PAGE_SHIFT, > - pmd_write(pmd)); > - } > + for (i = 0; i < nr; i++) > + __page_table_check_pmd_clear(mm, *(pmdp + i)); > + if (pmd_user_accessible_page(pmd)) > + page_table_check_set(pmd_pfn(pmd), stride * nr, pmd_write(pmd)); > } > -EXPORT_SYMBOL(__page_table_check_pmd_set); > +EXPORT_SYMBOL(__page_table_check_pmds_set); > > -void __page_table_check_pud_set(struct mm_struct *mm, pud_t *pudp, pud_t pud) > +void __page_table_check_puds_set(struct mm_struct *mm, pud_t *pudp, pud_t pud, > + unsigned int nr) > { > + unsigned int i; > + unsigned long stride = PUD_SIZE >> PAGE_SHIFT; > + > if (&init_mm == mm) > return; > > - __page_table_check_pud_clear(mm, *pudp); > - if (pud_user_accessible_page(pud)) { > - page_table_check_set(pud_pfn(pud), PUD_SIZE >> PAGE_SHIFT, > - pud_write(pud)); > - } > + for (i = 0; i < nr; i++) > + __page_table_check_pud_clear(mm, *(pudp + i)); > + if (pud_user_accessible_page(pud)) > + page_table_check_set(pud_pfn(pud), stride * nr, pud_write(pud)); > } > -EXPORT_SYMBOL(__page_table_check_pud_set); > +EXPORT_SYMBOL(__page_table_check_puds_set); > > void __page_table_check_pte_clear_range(struct mm_struct *mm, > unsigned long addr,