From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64216EB64D7 for ; Fri, 23 Jun 2023 12:49:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD6F98D0002; Fri, 23 Jun 2023 08:49:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D86A48D0001; Fri, 23 Jun 2023 08:49:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4E698D0002; Fri, 23 Jun 2023 08:49:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B25C08D0001 for ; Fri, 23 Jun 2023 08:49:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 095651C8FAA for ; Fri, 23 Jun 2023 12:49:21 +0000 (UTC) X-FDA: 80933993322.14.166D6B1 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf17.hostedemail.com (Postfix) with ESMTP id 6772940006 for ; Fri, 23 Jun 2023 12:49:16 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=QGBZmpep; spf=pass (imf17.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687524558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N8pNNe3/2YXc1UbpwIO0yIQjjCMHlVzYoQIGO6mvjFk=; b=lGZtCx3m/g9v1DhB/HFlvCGeBb0KbqxY1Aj4MLVfIDnAwaJxQehDKNKRdtv20L3A4Egizz 7+gGgJ4O4cupX2j5cvBPc3IGAhdh2jPB3usoTxE7xmHmAF39szpOy3U9mkVvsWfZxyvWiZ fh7CzIicJMgJmOLIS9ZZCrzJ74IwkdA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687524558; a=rsa-sha256; cv=none; b=cTcS55MQwJ873Tny/0U0jGcAU+wd126LOoXLqAtEIbr7dtt8HjoMT/jZkBsFSb/uTXIDok P1EFXBaHmbBXwgT99e1011m6xbccw7lLZLNabQ/f4S/Sgkmb8M7wUwx9FpZGWyDTq79pC3 zXelNgwCKDe3TxaWXBTTTrASTI2COZY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=QGBZmpep; spf=pass (imf17.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-25e934f1e6cso131110a91.0 for ; Fri, 23 Jun 2023 05:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687524556; x=1690116556; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N8pNNe3/2YXc1UbpwIO0yIQjjCMHlVzYoQIGO6mvjFk=; b=QGBZmpep2cOxIyWlosUFsMcpQ9kg5K87eUwaCkoJh4THNNRNLwHsme8TdeLzEMWIeP VdLJNjtWaWRTs1BgqyEhXBtiEVFykoOa991SQObW/BJT+zi5DexUk11xpe7roRZxmWon 2pGVoZYSHZZ/jcf4PvMYbIbG4+IvNv5UsypZ1n69fFVKkkIf9VFUIy36CCJ41i5gEjmj pEUDPSL4513Qlt5OfOQBEaAkajaH6+U57PEpyNffGcW5GRaJN9aybo3oePHHyCF2AmXB fAsbevik08duVzt2PX0xDdykhFrKiqCqdIA2Nyt6p8FSXga6r8QFK1BCiiTQLBdQZfhD b2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687524556; x=1690116556; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N8pNNe3/2YXc1UbpwIO0yIQjjCMHlVzYoQIGO6mvjFk=; b=E8un/qxHpHcIAVeUi7CyWXDEWguIMZRAFsjVbX28rvQzrj5pANIgZqenjUc9dbSIis wNZxTsocMPnaSwycOXEjGkPWE9yoA33huGHvmQ2ur8QcuC05UM5+heUF0300za9r8Aka ZiNY/Ng6StR0Dwel4zLmEtzlu3QkUBkElnaTOJVLmMXFqWXeFfZ5JbhFdIxtlt9Ia8Ud dsaIpkciCuSezIIKu0vE2zYD/+NdoeuEl5830SN9a1aOCVQsfVPucYwaPTx7wonAu8St 7rQYmrCrA03KF35CvWp+IiopqRhY8wkqtX4ysF9ZLddn0y2oK2WDqdfiaiEkr/XC/UW2 D5pw== X-Gm-Message-State: AC+VfDykl2MQvHuQU1TOe+KcfFcNhj7gJhxQkm450IMVUbtmb8I89VAv 1LhEuBSXlOfV6DZdpZ8Ekz+3IA== X-Google-Smtp-Source: ACHHUZ6eQKAAK+mFZK9b/rl5yBeScp7LGUAVTtY7Qwt+jrMMbGjG/tQ037wkOBUmA1P5xX8mDtOLpg== X-Received: by 2002:a17:90b:350f:b0:258:d367:63c with SMTP id ls15-20020a17090b350f00b00258d367063cmr24920553pjb.1.1687524555690; Fri, 23 Jun 2023 05:49:15 -0700 (PDT) Received: from [10.4.168.167] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a001e00b0026135208e97sm1471795pja.19.2023.06.23.05.49.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 05:49:15 -0700 (PDT) Message-ID: Date: Fri, 23 Jun 2023 20:49:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 02/29] mm: vmscan: introduce some helpers for dynamically allocating shrinker Content-Language: en-US To: Dave Chinner Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-3-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 3get7hbsxkp4rsoapefmeyajcs45ga9z X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6772940006 X-Rspam-User: X-HE-Tag: 1687524556-813068 X-HE-Meta: U2FsdGVkX1+yFm41nIkH1uI1aUZtvGipUsQ4ots8tpCxKS+d+fi/48pe2aDhbo0e8F8FIV/7SZf44sUa4RIqLKYXusyndt2/4dyml9pvPyA2NWc0j97SLPcHfsW+eFefz2m5RdEVXZ4jN0NmOR2YzqJkBZc7ZfLWrvTP7/308NikLTIT86UJNhdHc6dPNahGIfLBQDsPkzgLW4PdYWvy9YABBxR2XZ9NS+1uBmZj/NeLuspbJxfxoU+PfhvQPN67uL5kZ6aO3wTJmPA0yHB2eDIqeZfEZRHXpz+bXvpMmzvUpZ1pLTJgfjhSf24Bn96dmGRp/S43Ub8bSZIaIrN4NDvav9rR+9DZDy6O9YJ8N70YcbZ484vaGMbYsNwoyGI/oqqBZSdGxg3moaIICBuGsO3E6M9NBgxTY2ln5nhP5UnBvqQYYlrsIm4Z2Uk7rkvCHb/uP8244VLHj8rR3z6W+B9rLudRJpNk6k/P0/0IK7uvR/I7xbNUKbpel00RLzTNc7dHVFSU5Zk4OziDcvZzJBBP8ZzMLWXYtmbR3lhv3QiuiqzygAMA69ppFvxIOpZstzuVwyy78pvTG0M+qkX9Rs+ijgLbEFrQwAzWBWtBwaXPl//WcueaS2NAxgi5/Mw1Jj7qok8QEyRdUvvlpTDeHYXsd1oAKJDhaR5aIM4QdxFgug2aOi1lo1Srbz9e+PwdZtS0chWMHZyNudMTGiBfM9t9yE78EwCuTp8pPGwwy3mgcpc6wr8IZYNGuduo7NB7dqPtfAl1J3Ie2mwOJmvRh00s1sSXOPFKTUSIIlPOfy1aTOzgCUQsUMNAPn3hEFLuno+QiFfeLuMsObrJc8lql88Wn9qkZmF02sZpyGdQru06lKiD7pP6zFNQqwAqizVRkmKDMamIOGO0Wdv5P/7DSuxJh2HMiNvRtSLRapF0+qnpYoLoNEWzQQ9YDy1cqL13lA4DfzNm+e+4cP0DPw8 HQUr6Q85 TkC8BP6I2sjLF+SrzxdfgoxChThLCMEVHYSnnSIGB0ao8oCJpkU4IVuo25vYsEn1L/JX5kCYsPAoNYEiAlx0FjkHOrVXyHOqNWO+Jcobycla0K771uuVqS4QdRWlFEfKaAefNuJoEpVumrSf+wN3L2evr60qy1UD08elAHkiGwM4S+O/73igXMV9OPSAxysdFQ95oZdlapily+DLkp4BB2GuupdCULjjF6hUphHWg7EhkKBKlgKxZKPoZKAuPTxTZV7X6RU7rGymBtin1oYGWchTQwsGvIL8RaPaoP76Uy08y44v1RByOpjdpeohmOaOshO5YTHZNmWl4wF29R0kcV8i9oUOvcrFrKSX+N+FMYTlayycyjvX71kba+y6Tq3CONp9SnAusFhkjtjckKTmXa3pHOfuUbyBvbJbTDtPcVLZ/0ZU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Dave, On 2023/6/23 14:12, Dave Chinner wrote: > On Thu, Jun 22, 2023 at 04:53:08PM +0800, Qi Zheng wrote: >> Introduce some helpers for dynamically allocating shrinker instance, >> and their uses are as follows: >> >> 1. shrinker_alloc_and_init() >> >> Used to allocate and initialize a shrinker instance, the priv_data >> parameter is used to pass the pointer of the previously embedded >> structure of the shrinker instance. >> >> 2. shrinker_free() >> >> Used to free the shrinker instance when the registration of shrinker >> fails. >> >> 3. unregister_and_free_shrinker() >> >> Used to unregister and free the shrinker instance, and the kfree() >> will be changed to kfree_rcu() later. >> >> Signed-off-by: Qi Zheng >> --- >> include/linux/shrinker.h | 12 ++++++++++++ >> mm/vmscan.c | 35 +++++++++++++++++++++++++++++++++++ >> 2 files changed, 47 insertions(+) >> >> diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h >> index 43e6fcabbf51..8e9ba6fa3fcc 100644 >> --- a/include/linux/shrinker.h >> +++ b/include/linux/shrinker.h >> @@ -107,6 +107,18 @@ extern void unregister_shrinker(struct shrinker *shrinker); >> extern void free_prealloced_shrinker(struct shrinker *shrinker); >> extern void synchronize_shrinkers(void); >> >> +typedef unsigned long (*count_objects_cb)(struct shrinker *s, >> + struct shrink_control *sc); >> +typedef unsigned long (*scan_objects_cb)(struct shrinker *s, >> + struct shrink_control *sc); >> + >> +struct shrinker *shrinker_alloc_and_init(count_objects_cb count, >> + scan_objects_cb scan, long batch, >> + int seeks, unsigned flags, >> + void *priv_data); >> +void shrinker_free(struct shrinker *shrinker); >> +void unregister_and_free_shrinker(struct shrinker *shrinker); > > Hmmmm. Not exactly how I envisioned this to be done. > > Ok, this will definitely work, but I don't think it is an > improvement. It's certainly not what I was thinking of when I > suggested dynamically allocating shrinkers. > > The main issue is that this doesn't simplify the API - it expands it > and creates a minefield of old and new functions that have to be > used in exactly the right order for the right things to happen. > > What I was thinking of was moving the entire shrinker setup code > over to the prealloc/register_prepared() algorithm, where the setup > is already separated from the activation of the shrinker. > > That is, we start by renaming prealloc_shrinker() to > shrinker_alloc(), adding a flags field to tell it everything that it > needs to alloc (i.e. the NUMA/MEMCG_AWARE flags) and having it > returned a fully allocated shrinker ready to register. Initially > this also contains an internal flag to say the shrinker was > allocated so that unregister_shrinker() knows to free it. > > The caller then fills out the shrinker functions, seeks, etc. just > like the do now, and then calls register_shrinker_prepared() to make > the shrinker active when it wants to turn it on. > > When it is time to tear down the shrinker, no API needs to change. > unregister_shrinker() does all the shutdown and frees all the > internal memory like it does now. If the shrinker is also marked as > allocated, it frees the shrinker via RCU, too. > > Once everything is converted to this API, we then remove > register_shrinker(), rename register_shrinker_prepared() to > shrinker_register(), rename unregister_shrinker to > shrinker_unregister(), get rid of the internal "allocated" flag > and always free the shrinker. IIUC, you mean that we also need to convert the original statically defined shrinker instances to dynamically allocated. I think this is a good idea, it helps to simplify the APIs and also remove special handling for case a and b (mentioned in cover letter). > > At the end of the patchset, every shrinker should be set > up in a manner like this: > > > sb->shrinker = shrinker_alloc(SHRINKER_MEMCG_AWARE|SHRINKER_NUMA_AWARE, > "sb-%s", type->name); > if (!sb->shrinker) > return -ENOMEM; > > sb->shrinker->count_objects = super_cache_count; > sb->shrinker->scan_objects = super_cache_scan; > sb->shrinker->batch = 1024; > sb->shrinker->private = sb; > > ..... > > shrinker_register(sb->shrinker); > > And teardown is just a call to shrinker_unregister(sb->shrinker) > as it is now. > > i.e. the entire shrinker regsitration API is now just three > functions, down from the current four, and much simpler than the > the seven functions this patch set results in... > > The other advantage of this is that it will break all the existing > out of tree code and third party modules using the old API and will > no longer work with a kernel using lockless slab shrinkers. They > need to break (both at the source and binary levels) to stop bad > things from happening due to using uncoverted shrinkers in the new > setup. Got it. And totally agree. I will do it in the v2. Thanks, Qi > > -Dave.