From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<kasan-dev@googlegroups.com>
Subject: Re: [PATCH] mm: kfence: Use PAGE_ALIGNED helper
Date: Mon, 23 May 2022 15:13:29 +0800 [thread overview]
Message-ID: <d857524f-1040-ec81-eac0-6e3a31f072c5@huawei.com> (raw)
In-Reply-To: <YostzHXNIE3qcgQt@FVFYT0MHHV2J.usts.net>
On 2022/5/23 14:46, Muchun Song wrote:
> On Mon, May 23, 2022 at 02:32:59PM +0800, Kefeng Wang wrote:
>> On 2022/5/20 18:26, Muchun Song wrote:
>>> On Fri, May 20, 2022 at 10:18:33AM +0800, Kefeng Wang wrote:
>>>> Use PAGE_ALIGNED macro instead of IS_ALIGNED and passing PAGE_SIZE.
>>>>
>>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> Acked-by: Muchun Song <songmuchun@bytedance.com>
>> Thanks,
>>> BTW, there is a similar case in page_fixed_fake_head(), woule you like to
>>> improve that as well?
>> IS_ALIGNED is defined in include/linux/align.h, but PAGE_ALIGNED is in include/linux/mm.h,
>> so better to keep unchanged in include/linux/page-flags.h.
>>
> Maybe we could move this macro to page-flags.h or align.h so that we could
> reuse it?
align.h is inappropriate, could be page-flags.h, but this could affect
the include of 'mm.h'，so I think it is unnecessary to move the
PAGE_ALIGNED(and there is a PAGE_ALIGN too, no need to move both of them).
> Thanks.
> .
prev parent reply other threads:[~2022-05-23 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 2:18 Kefeng Wang
2022-05-20 7:43 ` Marco Elver
2022-05-20 10:26 ` Muchun Song
2022-05-23 6:32 ` Kefeng Wang
2022-05-23 6:46 ` Muchun Song
2022-05-23 7:13 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d857524f-1040-ec81-eac0-6e3a31f072c5@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox