From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC018C433EF for ; Tue, 12 Jul 2022 08:45:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 002AF940057; Tue, 12 Jul 2022 04:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF46F940033; Tue, 12 Jul 2022 04:45:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBBF4940057; Tue, 12 Jul 2022 04:45:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CAA42940033 for ; Tue, 12 Jul 2022 04:45:02 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9EC7F32D7D for ; Tue, 12 Jul 2022 08:45:02 +0000 (UTC) X-FDA: 79677812844.17.D839AA6 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf18.hostedemail.com (Postfix) with ESMTP id 69A131C0073 for ; Tue, 12 Jul 2022 08:45:01 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id t5-20020a17090a6a0500b001ef965b262eso7282852pjj.5 for ; Tue, 12 Jul 2022 01:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=vmRTcATN38IxovHc4DjUAE7J63goQ3yrRauAK/eLtk8=; b=G3+Nad+oLl4aj0sg9qaEyCjZp/iTgAbNlDevJ6jUymxzdoNrQyx4Oo1ZZvs0Z7eAb2 54B6aae6Sz0AsLN6+7pDSRWVQArQ1Dyat3jxuAmolfirNzwvdheVX/QDpN8426b1ig9P 3Zh/INyHU1dW6Z8kvaQqeOsa8r7Yx7sTz6UMvzv9YfwvMJ3An2MH7HjvUkUt3cViqQDt QIvnV8q1/aABiRI2Y3XqPGJCTNE2I9NJX2/1ug1B6Y98A3IvMTXmUHdo5CMY5IIF2Tfq TxQzO48YEa3dEU6ZiQIfeb6Zu8C0mfS/AtaNtucZ0UoeKd0hpsgTWfDIFcmCNLCPGOUQ rLUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=vmRTcATN38IxovHc4DjUAE7J63goQ3yrRauAK/eLtk8=; b=1HCG5hUo8kGCmh7hAqoQZ8uBkKQQh12n5CWC5U5CnahmgSnPLGmzyCUvlYhGF+FrG4 NtbYmYmBoAD5E4BLkJnkgM2QTPhXbpptQBwSsgo+jVZ59aINFn7hmgKoulczJf4tdLjN 9qC0mNZJJ3iTfx6X1bcRTbitvO4+F8YwBeOutL47MYhIy7asB5zgBh3rr4CVwGKG/YYr jGLurLYE/1UA7vEO1LaqusROYvBIWKN+ELP4NrRZn9XWz5D4eIdoUgIDxf9Sr5cisWHg vVgdYom6e//LzC/gPG+Gv4E+Rbb37cqZbRvv9a4LTPJgENufj6tgm6CHl+31RfXT8OcM hLBw== X-Gm-Message-State: AJIora9fKSqZQq43ENyLfFgDwrIVotosU9r8ADLUfIpSi1js4wWySghq voR3JJg7alUg7+ALVjafTdW5Kw== X-Google-Smtp-Source: AGRyM1vjmlJiaBBcCpWRMLVB2IpvdCIr3Qu93X75MDmgwAbU4LZBmiuEa4mPYnryUiJEdLl2gfrmUQ== X-Received: by 2002:a17:90a:bd92:b0:1ef:82d8:f2b9 with SMTP id z18-20020a17090abd9200b001ef82d8f2b9mr2879763pjr.83.1657615500129; Tue, 12 Jul 2022 01:45:00 -0700 (PDT) Received: from [10.85.119.42] ([139.177.225.235]) by smtp.gmail.com with ESMTPSA id e20-20020aa79814000000b00528c7ac7f27sm6169609pfl.81.2022.07.12.01.44.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 01:44:59 -0700 (PDT) Message-ID: Date: Tue, 12 Jul 2022 16:44:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [External] Re: [PATCH] mm/compaction: fix set skip in fast_find_migrateblock To: Miaohe Lin , linux-mm@kvack.org Cc: Andrew Morton , linux-kernel References: <20220711123213.66068-1-zhouchuyi@bytedance.com> <8af11329-93d4-3bbd-fe4c-343663c00a1b@huawei.com> From: =?UTF-8?B?5ZGo5L+25piT?= In-Reply-To: <8af11329-93d4-3bbd-fe4c-343663c00a1b@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=G3+Nad+o; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of zhouchuyi@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=zhouchuyi@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657615502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vmRTcATN38IxovHc4DjUAE7J63goQ3yrRauAK/eLtk8=; b=cIMyFAMLQztOAprpz/9DSj0iwAY2XacslUhFc0MRNbGvWjsadqBMttmX7lJKrAXYom+8I1 XELMS588yMMc+U0cWG0PfFCq3YpuJ4iCyMZ18/wUTHONZXXC/6zU3WctqoJepZWEOrqxIn ioYURH8XNL8vsyOs3Ta4YxlIun0DZjw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657615502; a=rsa-sha256; cv=none; b=l0j2dVdjV2nLWdwZu9MeIr5rRBFf3vGP3QIkMupBktKanBNswgOMAKXc6WVv4lZut5OXEC jrnCtV3kJWuoWnL5XwDeIQ52UV41ctAfFcqyB+KqySYalBo8BZ1FVRVsYX3KeKG6cOqF99 4I2bnKNgRKtPUwoDWtYSP7L17lOquBM= Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=G3+Nad+o; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf18.hostedemail.com: domain of zhouchuyi@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=zhouchuyi@bytedance.com X-Stat-Signature: zjoao6sksy7wp1f1jn4hhhcdzini7785 X-Rspamd-Queue-Id: 69A131C0073 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1657615501-795436 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/7/12 上午10:26, Miaohe Lin 写道: > Add Cc Andrew and linux-kernel email list. > > On 2022/7/11 20:32, Zhou Chuyi wrote: >> From: zhouchuyi >> >> When we successfully find a pageblock in fast_find_migrateblock(), the block will be set skip-flag through set_pageblock_skip(). However, when entering isolate_migratepages_block(), the whole pageblock will be skipped due to the branch 'if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages))'. Eventually we will goto isolate_abort and isolate nothing. >> Signed-off-by: zhouchuyi > > It seems we should tweak the commit log to satisfy the checkpatch.pl first. > >> --- >> mm/compaction.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index 1f89b969c..a1a2b50c8 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -1852,7 +1852,6 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) >> pfn = cc->zone->zone_start_pfn; >> cc->fast_search_fail = 0; >> found_block = true; >> - set_pageblock_skip(freepage); > > This looks like a real problem. Should we add a Fixes tag here? What's the runtime effect of it? > > Thanks for your patch! sorry for this mistakes, I'm a beginner of Linux kernel. I will fix this problems in v2 > >> break; >> } >> } >> >