From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D61EC433FE for ; Wed, 12 Jan 2022 11:31:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A43E96B0144; Wed, 12 Jan 2022 06:31:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F37C6B0145; Wed, 12 Jan 2022 06:31:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BAE66B0146; Wed, 12 Jan 2022 06:31:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 7BF8C6B0144 for ; Wed, 12 Jan 2022 06:31:16 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 382F592E0D for ; Wed, 12 Jan 2022 11:31:16 +0000 (UTC) X-FDA: 79021418952.12.AB99114 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id B77E54000B for ; Wed, 12 Jan 2022 11:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641987075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C66zPnUJeDWEIlSEzKy00mOLRxBuQ1dDqv+Z3TGt8nE=; b=gCwekmY9z4X3y/HNPj4kXsjpMkr58qnPqwi/x3Y9FH1+8WVtaEugrxTbDxMn/ZlNkEF9Me jd7QsqN95dVpSxOiO+258PTv1UvMDchx7GQZPIgpvN3oLqwCnOBn9jlE1cRZuB8NksGTwc pds5ztywquMFdqXaPHv4UYp38WHWt4c= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-LTrtk0yGNPqOrgEh4uDgoQ-1; Wed, 12 Jan 2022 06:31:12 -0500 X-MC-Unique: LTrtk0yGNPqOrgEh4uDgoQ-1 Received: by mail-ed1-f71.google.com with SMTP id z10-20020a05640235ca00b003f8efab3342so2025669edc.2 for ; Wed, 12 Jan 2022 03:31:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=C66zPnUJeDWEIlSEzKy00mOLRxBuQ1dDqv+Z3TGt8nE=; b=Ic2Uio5TCStyxmnm+phCekz9gC+Kav+CbclYaq3HpbPhE/0RSUM8rofGn0t3wwzOED 0QfNKwQDAMDDTAhkoE2+H6RlB20YJW4n4pDlytYY1NNYly96Yy+ozLiJGSEuBZSmNYel cGgaf3b3by4il62KR24FAaqMNhBzV81dptpGuav/80OGQXrVOAH0TmAw9pJgNCpqQ1ND AM66YjZf4/UydpIanykEKEAjN7mGn5BXtZbMbumreJQKq5DQpocq3RBG71BmQiO3I3Gr rp/WWdih/U7xvzGtuWLxY9ajEhm98kPBsDQeeXgtp1gdE0gli9hSXVFZgjYGKu5Fep0V hqwA== X-Gm-Message-State: AOAM530YDl1CdgGi8xmaj8KGNc/0wkYjdJrz1KJss5UIjmqVyGe8PLVa hYnL0uZ1YsNNc4pQkuKLrz9dw7EqpQuMOaFtbtwRxWthUGZ4BFqQuWF+hUcP8ot5w/wF7zBzi8H wtaarNbqchQo= X-Received: by 2002:a17:906:f243:: with SMTP id gy3mr7322340ejb.432.1641987071759; Wed, 12 Jan 2022 03:31:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsE7p0G+4kzPLfTKaUz/IaDx53eZn3tKCrLaSx+D5x62EAUjJVBrepv4kYr8O17+iEwsPgQQ== X-Received: by 2002:a17:906:f243:: with SMTP id gy3mr7322324ejb.432.1641987071547; Wed, 12 Jan 2022 03:31:11 -0800 (PST) Received: from ?IPV6:2003:cb:c702:4700:e25f:39eb:3cb8:1dec? (p200300cbc7024700e25f39eb3cb81dec.dip0.t-ipconnect.de. [2003:cb:c702:4700:e25f:39eb:3cb8:1dec]) by smtp.gmail.com with ESMTPSA id r17sm409452edw.70.2022.01.12.03.31.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 03:31:11 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 12:31:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 To: Dave Hansen , "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220111113314.27173-1-kirill.shutemov@linux.intel.com> <20220111113314.27173-2-kirill.shutemov@linux.intel.com> <3a68fabd-eaff-2164-5609-3a71fd4a7257@intel.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCHv2 1/7] mm: Add support for unaccepted memory In-Reply-To: <3a68fabd-eaff-2164-5609-3a71fd4a7257@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B77E54000B X-Stat-Signature: 555xd43fpxnbpp6x34m7a8wr6b5dmkzd Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gCwekmY9; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1641987075-768266 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Looking at stuff like this, I can't help but think that a: > > #define PageOffline PageUnaccepted > > and some other renaming would be a fine idea. I get that the Offline > bit can be reused, but I'm not sure that the "Offline" *naming* should > be reused. What you're doing here is logically distinct from existing > offlining. Yes, or using a new pagetype bit to make the distinction clearer. Especially the function names like maybe_set_page_offline() et. Al are confusing IMHO. They are all about accepting unaccepted memory ... and should express that. I assume PageOffline() will be set only on the first sub-page of a high-order PageBuddy() page, correct? Then we'll have to monitor all PageOffline() users such that they can actually deal with PageBuddy() pages spanning *multiple* base pages for a PageBuddy() page. For now it's clear that if a page is PageOffline(), it cannot be PageBuddy() and cannot span more than one base page. E.g., fs/proc/kcore.c:read_kcore() assumes that PageOffline() is set on individual base pages. -- Thanks, David / dhildenb