From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A055C433DF for ; Wed, 20 May 2020 19:45:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F115207D8 for ; Wed, 20 May 2020 19:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fWRZRQBt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F115207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9AC6380007; Wed, 20 May 2020 15:45:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95E53900002; Wed, 20 May 2020 15:45:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8746C80007; Wed, 20 May 2020 15:45:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 6E04D900002 for ; Wed, 20 May 2020 15:45:53 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 281C8181AEF2A for ; Wed, 20 May 2020 19:45:53 +0000 (UTC) X-FDA: 76838127786.27.alarm99_8aa07b8c0fe43 X-HE-Tag: alarm99_8aa07b8c0fe43 X-Filterd-Recvd-Size: 4484 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 19:45:52 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04KJRr4m063954; Wed, 20 May 2020 19:45:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=uK5Lcdw4NGbEJFHC3Vv/WDvbuBjG0vtZ2idMT/tLedo=; b=fWRZRQBt2ZL6U+Dc1kee8uHj0a7B/lWVBTlYYS/wW47o9hDTAAiBW53+vF6djqgz/DdZ BedVe0daUpOj6iedd5CANaiTGY1x3Ha3eu03e6FGWscz4BbG5xdZRM4mJ781VDYowXI/ GNPROm6sp7JxMXGciSVDGUvFgR9zUI6j25L+AtBcg/PtCM6NDvjz/KgSov+lkrJ4hOjD Y4WLWflBe9fl73Be5p5zPBgoYh7WCUlgKS3/gEk+ipy8Rv4cb3O2X469A5S2qkv5RO1L ITnU09AkdwlPcQHzMx6S0MRUuFdo76jC7QAwc6rcE4f5I3oFNZf9UBTPc6Tu5Z4zcC6g ow== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 31284m52ra-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 May 2020 19:45:44 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04KJSeAC099029; Wed, 20 May 2020 19:43:44 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 313gj43u34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 20 May 2020 19:43:44 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 04KJev92134964; Wed, 20 May 2020 19:43:43 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 313gj43u13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 May 2020 19:43:43 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 04KJhftj025589; Wed, 20 May 2020 19:43:42 GMT Received: from [10.74.108.67] (/10.74.108.67) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 May 2020 12:43:41 -0700 Subject: Re: [PATCH] rds: fix crash in rds_info_getsockopt() To: John Hubbard , syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com Cc: akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, rds-devel@oss.oracle.com, syzkaller-bugs@googlegroups.com References: <00000000000000d71e05a6185662@google.com> <20200520194147.127137-1-jhubbard@nvidia.com> From: santosh.shilimkar@oracle.com Organization: Oracle Corporation Message-ID: Date: Wed, 20 May 2020 12:43:39 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200520194147.127137-1-jhubbard@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9627 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 cotscore=-2147483648 impostorscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005200155 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/20/20 12:41 PM, John Hubbard wrote: > The conversion to pin_user_pages() had a bug: it overlooked > the case of allocation of pages failing. Fix that by restoring > an equivalent check. > > Reported-by: syzbot+118ac0af4ac7f785a45b@syzkaller.appspotmail.com > Fixes: dbfe7d74376e ("rds: convert get_user_pages() --> pin_user_pages()") > > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Cc: rds-devel@oss.oracle.com > Signed-off-by: John Hubbard > --- Thanks John !! Acked-by: Santosh Shilimkar