From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B5BC47DDF for ; Wed, 31 Jan 2024 10:31:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77D8A6B0092; Wed, 31 Jan 2024 05:31:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72DAF6B0093; Wed, 31 Jan 2024 05:31:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CE7E6B0095; Wed, 31 Jan 2024 05:31:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4EBCF6B0092 for ; Wed, 31 Jan 2024 05:31:04 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2FCD9160CD7 for ; Wed, 31 Jan 2024 10:31:04 +0000 (UTC) X-FDA: 81739238448.12.68A55D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id E504CC0019 for ; Wed, 31 Jan 2024 10:31:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OnLVxjbi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706697062; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UInstdZhQE+a453eK6S1P4wqWFcC/n6gY2SHSSGA34Q=; b=Am/N0LcQ8zkDh3sCpBis7oMb1DlAfH4AXcYxfjXLoz8SCIHT/ggxIsiCv0f4OOy8bmQVKl k5ELqvyDAUBw/NYxrUYq++LytLQQYztOAPZGP6chYocZ24nQJdQem4ocdbZMilJ64iP2vg 0HHunMng75u1wIVHP2zo0oi3mfKda8s= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OnLVxjbi; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706697062; a=rsa-sha256; cv=none; b=evefrYsTX1tJ5m+LEZUTR68oenDpK/03mP7YYi+g9bAZsvVcbyCFraynHTCoQRtWNzMA/c tu+/F3BqtW1qPe4ED409C4xXWE3MdvmJDhF6QZBmvoC+ZTZdIlji60vz1xoLR7AuH1Pa4q 2ANSPM9nNsMcu6oa/eqoMlSU+wXIiG8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706697061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UInstdZhQE+a453eK6S1P4wqWFcC/n6gY2SHSSGA34Q=; b=OnLVxjbiOHPSlYlrZxdEg9fApHvOyKbhMuII44Ocf4cDsudm9UjVpYjNy7EyhlqsivKIIx YY81AWw0cV/Y47VdbeHuKGDyLmFHcgfZiABRufbH7BU2JNe9xMUD6qj//fLjGHTo8hYYAW AMduA3A8XJLV4FR3+l4I9Xwu8j8EfiI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-aiNTjjJEOMWzVzGiI62fiA-1; Wed, 31 Jan 2024 05:30:59 -0500 X-MC-Unique: aiNTjjJEOMWzVzGiI62fiA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40e74860cb0so35661425e9.3 for ; Wed, 31 Jan 2024 02:30:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706697058; x=1707301858; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UInstdZhQE+a453eK6S1P4wqWFcC/n6gY2SHSSGA34Q=; b=KtV/ZKAb+P7SgQCbCFPa94BjLGYEU8z65PB1wm953tlf3JB6yN/QMGtdtbc0LgaR9+ lSLtp3AA1qHtnofQVPqBSXFHukFZFbkH5wXtjazaxNi4hE+GAox0J5+rg/Ew87APsd+4 uvXRfPkuzziWwm5KyhRHYOeLDHo2R892Q/AuHYC24BiOyf0X0bH6EgA/aCkOsa9ZedyL N2/x3IU9yWUxXh5oPXWo8n6MV1/dbf5WCeCs8GI84TuTJJd7/5z+4LbAN/KbGLOVK6Vz AVTwydCHZ0FYUQy1fhMpG4ootOa7PL1N+BOYe7U/2burevwvoG/BMfA4a6f8tZYcoo1Z AOXw== X-Gm-Message-State: AOJu0YzzB4Z8NpotKkU7IyQrkDMGoWLflabQGV4AdCVYtj8bGa/2dt8C 4k522pHKXHsi1HbKYH7JXEs+jYkAsjCiNNGGbREDzcL5Gkr1Nw2/8Cvw0bJni9jzNXXqYOl1iNs yE9OjyE8EsocYskqAOd+bL7iGq06Xslog8upKW4W80//feem/ X-Received: by 2002:adf:e9c6:0:b0:33a:f661:3d1a with SMTP id l6-20020adfe9c6000000b0033af6613d1amr953870wrn.10.1706697058496; Wed, 31 Jan 2024 02:30:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5Sb0Jb4w17/coUITDgCJia4b1YbKMps2LHMgZku1PFk/xbZYgm0NcMrCsZJBCSNcc93/LFw== X-Received: by 2002:adf:e9c6:0:b0:33a:f661:3d1a with SMTP id l6-20020adfe9c6000000b0033af6613d1amr953850wrn.10.1706697058047; Wed, 31 Jan 2024 02:30:58 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id b7-20020adfe307000000b003392206c808sm12965676wrj.105.2024.01.31.02.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jan 2024 02:30:57 -0800 (PST) Message-ID: Date: Wed, 31 Jan 2024 11:30:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 9/9] mm/memory: optimize unmap/zap with PTE-mapped THP To: Yin Fengwei , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Catalin Marinas , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Peter Zijlstra , Michael Ellerman , Christophe Leroy , "Naveen N. Rao" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Arnd Bergmann , linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org References: <20240129143221.263763-1-david@redhat.com> <20240129143221.263763-10-david@redhat.com> <2375481c-9d61-4f06-9f96-232f25b0e49b@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2375481c-9d61-4f06-9f96-232f25b0e49b@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E504CC0019 X-Stat-Signature: 5qsyah89k89w4igxmtceqmmc4nc6udhq X-HE-Tag: 1706697061-861837 X-HE-Meta: U2FsdGVkX1+KBo+yFcJ3uQ1sdZJlKf4n9mxrFsU7r252GuWNWu1XHaC9Z+dprpTDNdSqJNYIGCaFw6kECZb/MFXFZYGicDGO+Kva+l/zI+mI4t4B8awABV86jYKRhaJrkh6TBg2aY9+9RB3aQoH9BtYBLKVArtakRUpdcHf0LOXTPkInowzfSdgjriwL3Y+W+dhadmsv5Re95zTJePayUf/62YUnlgIX5ryQoPnl4TxhiwxkUJJQEBa0XrMUTjmapqXpVr38rtP58Mh/ADPBiiZ+dkcroYF+aI/gyUMVLMOb2OPm+xrxpK5epCFXFK0UMi3ni3fV3wOV2+m8u5zygNHdaeL7yME/BIIh4x4dGls0TOCMTO4HfAVmPgIcFjYW7Tt1yv8qut6tut0CIQFJiaTKderQF0FK7qZKGLOkJoWdUpM9v4xQSdK+yDlVQc5+/I6iJQNmWNyDICBmkxldsai0jXdZ7+mFlZOYtMQAK1k2UBiy5ZQLxvJDw5I/h0g2GrgaXqhc5x2H/XNvNllIBNV/Lq5UfjEDQLZP6QRHruitQvtdzGA/6F0fz53w5KtZ5KJ3G4XHopHkUjU3PoH7gp/spCpxjVCjB5SviOQIb9jwKynhpOK5q3uoPn6zmU6Fnh7lZ0SyOXpjynYbcHerSfvz/fCUMSpDPRiPCMwhR0d/NRh8Kx4w95kqqEHTCLpLY7ggVLMTSp9uKAhX6YQ6A+Nx/PwC403dJIJTsGUeFCON2sBEv++e1LsLoUqFKFPD9CX7uT2iJ2t5+kiEr+/KIwu+mIroYM3db6sTEMYYcBjsNX3DQJpiC5lMTHnvZeNw5pwXQyAHRAhak9TYDiBe9p1eNk4GQprBY60btXm1s9JUlTmfFEFsQ0Fy6nHDfFhkurselnv8QKlD7v98uTRx3BCmgCnL3xSUytJ5nepl+6/dHwR4c7YZadjTGojh2PvwRjp/as4EkwQ96WEcPYl +ZpGfGmo 0q68tl3v41/3ZTO3D6oZTOqfBWI/2PR+pfbqiNEY0WJHbkf4/sUoa+uujJWmr1GmwjLX0R+FGgCZEqOaZLBwh55btmdEWWEWGOFOmb8kITFezLUdMis9ZUL8jg4Fr9ZLBb9Dk/KFv18qvDBdorIx/ztUoi81l9ZGVZEBETPMxWYDxqX3oqq67qATFlKv0CIycPpzbn3+4uDn8mebxaGGx/Ep6fRViP0xIKnqUo4RoqIiH8UgsW8p1r/Er4KZFoUfrHFXBEvuFAAjfjCkI294hYnxWRBgGj56SJsB/HpE1+hMhNQ5oIWsyOqm5/oVtdUnSJbQlgzGsFYY8pJDJmMnQjCpVHEIw/Jmdz5OlSxsxhVwhWONaNtyJwvTAZtDLbNFDa80FH21Er5C8iGqnT9eMYrfI5JvmAmNpRx3FFAiB4E9dTmhkENdcqsf20xzmAozzugeR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.01.24 03:30, Yin Fengwei wrote: > > > On 1/29/24 22:32, David Hildenbrand wrote: >> +static inline pte_t get_and_clear_full_ptes(struct mm_struct *mm, >> + unsigned long addr, pte_t *ptep, unsigned int nr, int full) >> +{ >> + pte_t pte, tmp_pte; >> + >> + pte = ptep_get_and_clear_full(mm, addr, ptep, full); >> + while (--nr) { >> + ptep++; >> + addr += PAGE_SIZE; >> + tmp_pte = ptep_get_and_clear_full(mm, addr, ptep, full); >> + if (pte_dirty(tmp_pte)) >> + pte = pte_mkdirty(pte); >> + if (pte_young(tmp_pte)) >> + pte = pte_mkyoung(pte); > I am wondering whether it's worthy to move the pte_mkdirty() and pte_mkyoung() > out of the loop and just do it one time if needed. The worst case is that they > are called nr - 1 time. Or it's just too micro? I also thought about just indicating "any_accessed" or "any_dirty" using flags to the caller, to avoid the PTE modifications completely. Felt a bit micro-optimized. Regarding your proposal: I thought about that as well, but my assumption was that dirty+young are "cheap" to be set. On x86, pte_mkyoung() is setting _PAGE_ACCESSED. pte_mkdirty() is setting _PAGE_DIRTY | _PAGE_SOFT_DIRTY, but it also has to handle the saveddirty handling, using some bit trickery. So at least for pte_mkyoung() there would be no real benefit as far as I can see (might be even worse). For pte_mkdirty() there might be a small benefit. Is it going to be measurable? Likely not. Am I missing something? Thanks! -- Cheers, David / dhildenb