linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: WangYuli <wangyuli@uniontech.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	akpm@linux-foundation.org, Liam.Howlett@oracle.com,
	jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, niecheng1@uniontech.com,
	guanwentao@uniontech.com, Jun Zhan <zhanjun@uniontech.com>,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] tools/testing/vma: Fix function parameter declarations for GCC 8.3 compatibility
Date: Fri, 1 Aug 2025 10:33:37 +0100	[thread overview]
Message-ID: <d8143801-0d4c-467d-a181-eb411ea8bb07@lucifer.local> (raw)
In-Reply-To: <E6DF1F491EEF7B1E+9ce0f7cf-7463-48cd-b80f-1fe0cb1ea70d@uniontech.com>

On Fri, Aug 01, 2025 at 05:26:50PM +0800, WangYuli wrote:
> Hi Lorenzo,
>
> Should I split this into two commits?
>
> As Vlastimil Babka suggested, perhaps it would be better to add both the
> |-std=gnu11| and |-Wno-unused-parameter| flags to
> |tools/testing/shared/shared.mk|.

Sure, perhaps 2 patches is best, 1 for changes to shared.mk and 1 for the
fixups to vma_internal.h.

Also note Vlasta's reply here, he suggested some other stuff.

Thanks very much for doing this, you're saving me some work by fixing up
the silly (void) stuff and I appreciate you fixing this for older gcc! :>)

I will make sure to review this once submitted.

Cheers, Lorenzo


  reply	other threads:[~2025-08-01  9:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  8:47 WangYuli
2025-07-29  9:06 ` Lorenzo Stoakes
2025-07-31  2:55   ` WangYuli
2025-07-31 10:24     ` Lorenzo Stoakes
2025-07-31 18:13       ` Vlastimil Babka
2025-08-01  5:14         ` Lorenzo Stoakes
2025-08-01  5:57           ` WangYuli
2025-08-01  8:04             ` Vlastimil Babka
2025-08-01  8:50               ` Lorenzo Stoakes
2025-08-01  9:22                 ` Vlastimil Babka
2025-08-01  9:26                 ` WangYuli
2025-08-01  9:33                   ` Lorenzo Stoakes [this message]
2025-08-01  9:48                     ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8143801-0d4c-467d-a181-eb411ea8bb07@lucifer.local \
    --to=lorenzo.stoakes@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=guanwentao@uniontech.com \
    --cc=jannh@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=niecheng1@uniontech.com \
    --cc=pfalcato@suse.de \
    --cc=vbabka@suse.cz \
    --cc=wangyuli@uniontech.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox