From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D92EEC4332F for ; Wed, 16 Nov 2022 11:28:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A08A6B0071; Wed, 16 Nov 2022 06:28:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 351036B0072; Wed, 16 Nov 2022 06:28:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F2B78E0002; Wed, 16 Nov 2022 06:28:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E9186B0071 for ; Wed, 16 Nov 2022 06:28:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D95551A02C3 for ; Wed, 16 Nov 2022 11:28:46 +0000 (UTC) X-FDA: 80139083052.16.9B0F9A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 620FB20005 for ; Wed, 16 Nov 2022 11:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668598125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1VQojSTl69umpLmMH43+9BkpSdHFQwxnTFgYvpcg2e8=; b=WmU/qWj44CIAApa1ZuQw8qCMgT4b25WuzA+3bWI34HnGzf7zwW4A9U66J875LDS4W+uhB5 xVvV6Vw8wPPzDJP/bIRI5QA4an0oyIlkg/V0Xh5L1XSArT6u8SxJ6abPCPGqUpG4ftp6nD DvDjVxLfh39/ZGpwZ0rswcgPPlhzU84= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-49-DGJGWYNVNom36TJM9b-Bsg-1; Wed, 16 Nov 2022 06:28:44 -0500 X-MC-Unique: DGJGWYNVNom36TJM9b-Bsg-1 Received: by mail-wr1-f71.google.com with SMTP id i12-20020adfaacc000000b0023cd08e3b56so3603397wrc.12 for ; Wed, 16 Nov 2022 03:28:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1VQojSTl69umpLmMH43+9BkpSdHFQwxnTFgYvpcg2e8=; b=OG7YIJXe8BFIugHFSXwtNekvNIHhHfQcw6c9XDSfh2mZocxCbHDbtRkos0dNXKKgQ1 kfRpMH2wfIzF4dXlvhuhoA9rRG6KIP/kR1v3iz1VdbHIBb1F2jIUvtvJtRxjvp8U5dk+ PChIxgtqmApXKwrUbrtFqnjyghv6c0PtL+1Mw5N7HfBuWDK6cKwTNmEHDmK6NQGnOYi/ E4y6EiF2As3HmvXxFd2HK+V8Xm30SnA97GLqMaAfIAjUwQ5QV+PToU/FEwfZ3/h/6AWl g88tNLhbVLoWaAGBRNC/jlZqQIuA3KAQWjIWCim0CNq6r0llT1W1n0R0MUAuSbry9OXq vXSg== X-Gm-Message-State: ANoB5plYFNkbGYgHcZg3IIddMxq3PCQwFwTP50YjEDXBJIQtSD0/whcD 4t1NCDTS4+lGebBN0WHcBOipMjMb560A5RAUms287Ie4H+DFGG5xU4CPfuAh9rHvKnrL9j3bzae cPPcm9fFa02I= X-Received: by 2002:adf:e0ce:0:b0:236:4c14:4e4c with SMTP id m14-20020adfe0ce000000b002364c144e4cmr13631422wri.634.1668598123338; Wed, 16 Nov 2022 03:28:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf6e1elsSkTG3wibaAG5hhsqopWoPQ9BVnWOuhu0PibIHa2gEBmHuSu+l8O0CstgpsJn73mbQw== X-Received: by 2002:adf:e0ce:0:b0:236:4c14:4e4c with SMTP id m14-20020adfe0ce000000b002364c144e4cmr13631403wri.634.1668598123006; Wed, 16 Nov 2022 03:28:43 -0800 (PST) Received: from ?IPV6:2003:cb:c704:9f00:a98d:4026:7c44:40fd? (p200300cbc7049f00a98d40267c4440fd.dip0.t-ipconnect.de. [2003:cb:c704:9f00:a98d:4026:7c44:40fd]) by smtp.gmail.com with ESMTPSA id r11-20020a5d694b000000b0023691d62cffsm14554511wrw.70.2022.11.16.03.28.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 03:28:42 -0800 (PST) Message-ID: Date: Wed, 16 Nov 2022 12:28:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: Test case for "mm/thp: carry over dirty bit when thp splits on pmd" To: Anatoly Pugachev , hev Cc: Peter Xu , Thorsten Leemhuis , Sparc kernel list , linux-mm References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668598126; a=rsa-sha256; cv=none; b=OOkW23w57eryNNbwSEk7/F1aw0k4ew15pzNoFZ4mQrRR8IQzlC1C4TiF2gHU+3/rDC5wif jQW81RNTsNcNpLvV8j5xG2fJwPk+6FPQLfeOqQ50fQplhsJ4J+5s1eCmBjUapfZxslPdQI Aod/JVqvdTL7HZMCFSO7HChxulR6jEA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="WmU/qWj4"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668598126; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1VQojSTl69umpLmMH43+9BkpSdHFQwxnTFgYvpcg2e8=; b=rtYNJMDqHrGDFBx3Xi3WhrxwJgoqEwwwKg0D9p4bbL5RGLlYLtdEW4//GUirKmebda13Qq DMa0VY1gBdCidTSAKr5bFFA4PC5oAAjYqBEAPLrO6jN5UJufxBhf/HcSLO+7bDHldEYIFQ ZI1RBAkYFET8lsbUXOf5QEseieeHIck= X-Stat-Signature: ue1igr6113qj4mithcyk3eqe4bcubn8r X-Rspamd-Queue-Id: 620FB20005 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="WmU/qWj4"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1668598126-89520 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001058, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.11.22 11:45, Anatoly Pugachev wrote: > On Wed, Nov 16, 2022 at 11:49 AM hev wrote: >> >> Hello Peter, >> >> I see a random crash issue on the LoongArch system, that is caused by >> commit 0ccf7f1 ("mm/thp: carry over dirty bit when thp splits on >> pmd"). >> >> Now, the thing is already resolved. The root cause is arch's mkdirty >> is set hardware writable bit in unconditional. That breaks >> write-protect and then breaks COW. Ehm, does this imply that pte = maybe_mkwrite(pte_mkdirty(pte), vma); will result in a writable PTE, even though the VMA does not include VM_WRITE? That would be really broken. -- Thanks, David / dhildenb