From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D8CCC47404 for ; Mon, 7 Oct 2019 14:45:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C5102064A for ; Mon, 7 Oct 2019 14:45:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C5102064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B70A48E0005; Mon, 7 Oct 2019 10:45:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF88D8E0003; Mon, 7 Oct 2019 10:45:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BFDB8E0005; Mon, 7 Oct 2019 10:45:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 75C8A8E0003 for ; Mon, 7 Oct 2019 10:45:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 1B90C824CA3B for ; Mon, 7 Oct 2019 14:45:53 +0000 (UTC) X-FDA: 76017262986.23.sleep15_506c63c8e4a39 X-HE-Tag: sleep15_506c63c8e4a39 X-Filterd-Recvd-Size: 4711 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Oct 2019 14:45:52 +0000 (UTC) Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E896757C0 for ; Mon, 7 Oct 2019 14:45:51 +0000 (UTC) Received: by mail-qk1-f197.google.com with SMTP id h4so15132330qkd.18 for ; Mon, 07 Oct 2019 07:45:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pAkWBhiPIf23Q3yen918L7S8GMw4Rv0tKaPiOqMHwe8=; b=flTYHycwL/ZdGYVaWKR1+5WxyfDhfav5F4vcK9WgyEXslvOsIM8JJTexXs9EciFvBO 5fTLlHVh0boWQAm8oAL3Mfr8+R7Aj1keWNt3jjootb4tWfhfiHmAnVHKXemICEMy8HWA pRbpiJzyQDu9TXmBBw99s+tNsuu3BjLP0vmYmA9FwaZTepNDEA3JSkdHrn3XRtmLhGzg lrS7du04MubQKUkGE6C0OfqRn3LspyHknFaI/qQXxHDNcKMapdqddEhKCXkVl6ra0Z2F ZZHyTg4YHenMdEmz8X4aaDKeAX6TTRkof7uAYAxs6rN/jXqdRZWU0sP6K1HAAsfNiuHa M9NA== X-Gm-Message-State: APjAAAU6BCebhsy87+sbLbkOyRamcpTrrBTb1rrV8pcyvFJ8BRGFUX3c 9w1Ne33EQ6nydm7wdpQaqs9XWNb99rFcWfYY304ViUqgHyQpNiOkKWAhi1KJ1O1C9gyP5PPYWiu 5Kgrg8pMuQZY= X-Received: by 2002:ac8:474c:: with SMTP id k12mr30797302qtp.319.1570459550256; Mon, 07 Oct 2019 07:45:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwnnI4w3osQ3PWAUY3wt0nD+Y39v32sP+fzXakxYjiq4ENdUdq2GU0Xq3j/fCwCVGC6ogmB/g== X-Received: by 2002:ac8:474c:: with SMTP id k12mr30797267qtp.319.1570459549869; Mon, 07 Oct 2019 07:45:49 -0700 (PDT) Received: from [192.168.1.157] (pool-96-235-39-235.pitbpa.fios.verizon.net. [96.235.39.235]) by smtp.gmail.com with ESMTPSA id u27sm11001486qta.90.2019.10.07.07.45.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2019 07:45:49 -0700 (PDT) Subject: Re: mount on tmpfs failing to parse context option From: Laura Abbott To: Alexander Viro , Hugh Dickins Cc: Linux-MM , Linux Kernel Mailing List , David Howells References: Message-ID: Date: Mon, 7 Oct 2019 10:45:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/30/19 12:07 PM, Laura Abbott wrote: > Hi, > > Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1757104 > of a failure to parse options with the context mount option. From the reporter: > > > $ unshare -rm mount -t tmpfs tmpfs /tmp -o 'context="system_u:object_r:container_file_t:s0:c475,c690"' > mount: /tmp: wrong fs type, bad option, bad superblock on tmpfs, missing codepage or helper program, or other error. > > > Sep 30 16:50:42 kernel: tmpfs: Unknown parameter 'c690"' > > I haven't asked the reporter to bisect yet but I'm suspecting one of the > conversion to the new mount API: > > $ git log --oneline v5.3..origin/master mm/shmem.c > edf445ad7c8d Merge branch 'hugepage-fallbacks' (hugepatch patches from David Rientjes) > 19deb7695e07 Revert "Revert "Revert "mm, thp: consolidate THP gfp handling into alloc_hugepage_direct_gfpmask"" > 28eb3c808719 shmem: fix obsolete comment in shmem_getpage_gfp() > 4101196b19d7 mm: page cache: store only head pages in i_pages > d8c6546b1aea mm: introduce compound_nr() > f32356261d44 vfs: Convert ramfs, shmem, tmpfs, devtmpfs, rootfs to use the new mount API > 626c3920aeb4 shmem_parse_one(): switch to use of fs_parse() > e04dc423ae2c shmem_parse_options(): take handling a single option into a helper > f6490b7fbb82 shmem_parse_options(): don't bother with mpol in separate variable > 0b5071dd323d shmem_parse_options(): use a separate structure to keep the results > 7e30d2a5eb0b make shmem_fill_super() static > > > I didn't find another report or a fix yet. Is it worth asking the reporter to bisect? > > Thanks, > Laura Ping again, I never heard anything back and I didn't see anything come in with -rc2