From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A0F0D1CDA0 for ; Tue, 22 Oct 2024 05:23:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF6246B0088; Tue, 22 Oct 2024 01:23:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA6916B0089; Tue, 22 Oct 2024 01:23:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9948E6B008A; Tue, 22 Oct 2024 01:23:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F4AA6B0088 for ; Tue, 22 Oct 2024 01:23:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D4FA7C0564 for ; Tue, 22 Oct 2024 05:23:08 +0000 (UTC) X-FDA: 82700094624.25.88B4395 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id EF54140010 for ; Tue, 22 Oct 2024 05:23:11 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729574453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b3F0OCQZwpjAGIxuQz+DKbwX7oNXt0OVtMvcO5GwWxQ=; b=kb03JmuSZcwX4h66Lu8n5+f6MhNGU2aYOyfYDx6m9H9vFHyXjITg+ew//Dz/E1PUeLc9EG JxYy8DtK5PS1J3xe+wSPFeNp51N5T35biPZP2fIJADqWh6SItRbUyotpXH/SNnDCKR1bfS SybPtvyeMEi1/MWQAq1WxuCHJRooEb4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729574453; a=rsa-sha256; cv=none; b=JgIrQ2oewHe+fpDO6PsTgJMGCI9RfKBThswEMhHF9IKC9WzU0JtO5K4UTZJaOeBxM6ZAM/ IPd3eTa5QWBM6xrNOPCwddVYtfbkkMlsRzdzIrEHOHZ1d88CYZg2cu8xOtvJllPKPveqAY Ipv/P+Ua77MjOp6hULVfst/ghmYPB0o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E483B497; Mon, 21 Oct 2024 22:23:52 -0700 (PDT) Received: from [10.163.41.149] (unknown [10.163.41.149]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C12E63F528; Mon, 21 Oct 2024 22:23:20 -0700 (PDT) Message-ID: Date: Tue, 22 Oct 2024 10:53:18 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Remove redundant condition for THP folio To: Dev Jain , akpm@linux-foundation.org, david@redhat.com, willy@infradead.org Cc: ziy@nvidia.com, ying.huang@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241018094151.3458-1-dev.jain@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241018094151.3458-1-dev.jain@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EF54140010 X-Stat-Signature: dy4hhfhp581ukbpemfqeta4cenap59ig X-HE-Tag: 1729574591-754880 X-HE-Meta: U2FsdGVkX1+1jtH1piT1Bq0MBdRIU5dLnedlIHXYZrXM9n9xIjau55wPRUmOaL1Lhfd0iz9TED0u3CbyZ1vRBA3Fu2q0Xl7H/QS0ZskGgc5eyw+pq4CgCZBd0ftfia9yrPRs0DXm+/Nx69zdXmKvty0+dYpvJal+13ErzB956TRqPpdxZsiS7WrTY415JMEuCfu1HLlwtrLYGdRQX13R+3pEBBAlZiTQz4UF/KYWHPKRDw+VncBeB4QkKaISV2QWDqIWeYSpQxz6VbNh7dpMjfe+X0rbRD8ucVy2qwTs2pxMTfZdOK8ZYAR0j03K3//14QT0IuHhnxrTx0Fk7aYafJ02LmOacS90G/Bu+0imqo5/SCqkfQ9ZqYniLOR7kopefKkEl26epAIKHnSX96fVtT6LAfQ6g+JtTlPabAo75BPxx62yEFD3w0kmI44Y0falG3HayM7U9oPigrb8uViXUFaQDM1tT05UA3s9efboF/XfJsYA1H3kMlqbcnl0y3UU5avJzZ5AzqRCUrF/AYIVMxjAy1f9z3h0YAxz2lSgHrxwr9WC/aUvp+xBh1ZyKC2jZwi3iu78xB7/gd8PSBrQEUIYhOpJD/JQl6XRVtk34SNjLsIP0Fb1LgTC9UmCFwXeH3b6oL0dBEFzhAGqciUEYaqJ5uVIcgdTfgbr1h33cedCGMDh21lcyzHnQDj4v/so1iPHw+TpV4FyK6t+LoOn6Y+zBy+CHEZNH/dY2ImdbBpWC2eruaNPwwJLx7COsmDjWpVgPNTukTd5Dz6C6C2a3c6GioXA/KYTz53r23UqKyfcti9xcLtTGoizRyrwZjOCUqUgcqeivyz7DZ4o3a/9FobfRsmGWlGRWXmCMdvpCGWMIJqbYVeHK/SpHWXhI1UCzoinFtRItKtN4bUgWCnfv1+RmvzAHMahjM0qFucmUCHNOcBGq5muod2r4kIaYiE6A1hq/R9hU040okOpmy4 bk1N/k3K ecppG3orfIXdNvDEom8ni8kAO+aElvU8YL9/AWcL7xX52jDv06jmgFXaKgzPfbN+8uxX0aEzo4FqC5c90m2tJvSjZZwWt3TdSQRHgtvXizRC2bV6xQz5x4jPoDJlDhBRfUjXmgbvZn1g5H3OXI2kTVCzcwe3lyrL+z7e+afgy3UJGpbqyVQNW45CV7JeQ+pprO261lXXrX+26rL8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/18/24 15:11, Dev Jain wrote: > folio_test_pmd_mappable() implies folio_test_large(), therefore, > simplify the expression for is_thp. > > Signed-off-by: Dev Jain > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index df91248755e4..b43e7b105559 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1731,7 +1731,7 @@ static int migrate_pages_batch(struct list_head *from, > > list_for_each_entry_safe(folio, folio2, from, lru) { > is_large = folio_test_large(folio); > - is_thp = is_large && folio_test_pmd_mappable(folio); > + is_thp = folio_test_pmd_mappable(folio); > nr_pages = folio_nr_pages(folio); > > cond_resched(); Reviewed-by: Anshuman Khandual