From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=7n0b=P6=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E9654C433F5
	for <linux-mm@archiver.kernel.org>; Thu, 11 Nov 2021 02:04:58 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 69EC4601FF
	for <linux-mm@archiver.kernel.org>; Thu, 11 Nov 2021 02:04:58 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 69EC4601FF
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org
Received: by kanga.kvack.org (Postfix)
	id E2D276B00BD; Wed, 10 Nov 2021 21:04:57 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id DB5CB6B00BF; Wed, 10 Nov 2021 21:04:57 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id C56946B00C0; Wed, 10 Nov 2021 21:04:57 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1])
	by kanga.kvack.org (Postfix) with ESMTP id AEE586B00BD
	for <linux-mm@kvack.org>; Wed, 10 Nov 2021 21:04:57 -0500 (EST)
Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay01.hostedemail.com (Postfix) with ESMTP id 690D018518F15
	for <linux-mm@kvack.org>; Thu, 11 Nov 2021 02:04:57 +0000 (UTC)
X-FDA: 78795006234.25.D14C9F2
Received: from out4436.biz.mail.alibaba.com (out4436.biz.mail.alibaba.com [47.88.44.36])
	by imf29.hostedemail.com (Postfix) with ESMTP id CBC7D9000270
	for <linux-mm@kvack.org>; Thu, 11 Nov 2021 02:04:55 +0000 (UTC)
X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0UvzWPag_1636596278;
Received: from B-X3VXMD6M-2058.local(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0UvzWPag_1636596278)
          by smtp.aliyun-inc.com(127.0.0.1);
          Thu, 11 Nov 2021 10:04:39 +0800
From: Xin Hao <xhao@linux.alibaba.com>
Reply-To: xhao@linux.alibaba.com
Subject: Re: [PATCH V1 2/2] mm/damon: Add 'age' of region tracepoint support
To: SeongJae Park <sj@kernel.org>
Cc: sjpark@amazon.de, akpm@linux-foundation.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
References: <20211110131621.18221-1-sj@kernel.org>
Message-ID: <d7edb182-7d49-712e-2d21-7b9f7ae2e4f1@linux.alibaba.com>
Date: Thu, 11 Nov 2021 10:04:38 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20211110131621.18221-1-sj@kernel.org>
Content-Type: multipart/alternative;
 boundary="------------6A02A84B8DAD67C8E65AC789"
X-Rspamd-Server: rspam02
X-Rspamd-Queue-Id: CBC7D9000270
X-Stat-Signature: 5si1drprfxqe4uhwjwnbydkshb67h7pm
Authentication-Results: imf29.hostedemail.com;
	dkim=none;
	dmarc=pass (policy=none) header.from=alibaba.com;
	spf=pass (imf29.hostedemail.com: domain of xhao@linux.alibaba.com designates 47.88.44.36 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com
X-HE-Tag: 1636596295-670897
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

This is a multi-part message in MIME format.
--------------6A02A84B8DAD67C8E65AC789
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi Park:

On 2021/11/10 =E4=B8=8B=E5=8D=889:16, SeongJae Park wrote:
> On Wed, 10 Nov 2021 20:13:14 +0800 Xin Hao <xhao@linux.alibaba.com> wro=
te:
>
>> In patch "mm/damon: add a tracepoint", it adds a
>> tracepoint for DAMON, it can monitor each region
>> for each aggregation interval, Now the region add
>> a new 'age' variable, some primitive would calculate
>> the priority of each region as a weight, there put it
>> into tracepoint, so we can easily track the change of
>> its value through perf or damon-tools.
> DAMON calculates the age using the address range and nr_accesses of the=
 region,
> which are already in the tracepoint.  In other words, user space can ca=
lculate
> the age on their own.  Therefore I thought putting age in the tracepoin=
t as
> adding unnecessary information, at the moment of the implementation.
>
> Of course, I would missing some use cases that need this information in=
 the
> tracepoint.  Furthermore, adding just one more value in the tracepoint =
wouldn't
> incur a real issue.  But, I'd like to know why this is necessary and ho=
w much
> benefit it provides.  Xin, could you please share that?

I think these two variables nr_access &=C2=A0 age have different meanings=
,=20
the nr_access only reflect the

period of=C2=A0 sample_interval,=C2=A0 We may be able to get the change o=
f age=20
through continuous long-term sampling,

But I think this is not very convenient.

We only need to observe the change of age value a small number of times=20
to replace the continue sampling of the region.

For example, age has been increasing to 141, but nr_access shows a value=20
of 0 at a certain time. Through this=EF=BC=8Cwe can

conclude that the region has a very low nr_access value for a long time.

This datas that=C2=A0 i used perf tool to record & script

*=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=A0 6=
64.187237: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 305254400-597266432: 0 1=
40**
**=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187237: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 597266432-900239360: 0 1=
40**
**=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187237: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 900239360-980148224: 0 1=
40*
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187238: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281471544459264-281471789129728: 0 1
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187238: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281471789129728-281472066732032: 0 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187238: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472066732032-281472281972736: 0 1
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187239: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472281972736-281472346124288: 1 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187239: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472346124288-281472379187200: 0 1
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187239: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472379187200-281472678154240: 1 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187239: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472678154240-281472951209984: 1 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187240: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472951209984-281473069228032: 2 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187240: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473069228032-281473299972096: 0 1
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187241: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473299972096-281473603727360: 0 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187241: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473603727360-281473611063296: 0 5
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.187242: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281474851557376-281474851692544: 0 140
*=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287642: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 4194304-305254400: 0 141=
*
*=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287643: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 305254400-597266432: 0 1=
41*
*=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287643: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 597266432-900239360: 0 1=
41*
*=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287650: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16 900239360-980148224: 0 1=
41*
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287650: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281471544459264-281471789129728: 0 2
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287651: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281471789129728-281472066732032: 0 1
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287651: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472066732032-281472349429760: 0 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287651: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472349429760-281472588464128: 0 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287652: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472588464128-281472678154240: 0 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287652: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472678154240-281472951209984: 0 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287652: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281472951209984-281473092300800: 1 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287653: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473092300800-281473299972096: 0 2
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287654: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473299972096-281473421471744: 0 1
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287654: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473421471744-281473603727360: 2 0
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287654: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281473603727360-281473611063296: 0 6
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=C2=
=A0 664.287655: damon:damon_aggregated:=20
target_id=3D18446462650354140800 nr_regions=3D16=20
281474851557376-281474851692544: 0 141

>
>
> Thanks,
> SJ
>
>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>> ---
>>   include/trace/events/damon.h | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/trace/events/damon.h b/include/trace/events/damon=
.h
>> index 2f422f4f1fb9..99ffa601e351 100644
>> --- a/include/trace/events/damon.h
>> +++ b/include/trace/events/damon.h
>> @@ -22,6 +22,7 @@ TRACE_EVENT(damon_aggregated,
>>   		__field(unsigned long, start)
>>   		__field(unsigned long, end)
>>   		__field(unsigned int, nr_accesses)
>> +		__field(unsigned int, age)
>>   	),
>>  =20
>>   	TP_fast_assign(
>> @@ -30,11 +31,13 @@ TRACE_EVENT(damon_aggregated,
>>   		__entry->start =3D r->ar.start;
>>   		__entry->end =3D r->ar.end;
>>   		__entry->nr_accesses =3D r->nr_accesses;
>> +		__entry->age =3D r->age;
>>   	),
>>  =20
>> -	TP_printk("target_id=3D%lu nr_regions=3D%u %lu-%lu: %u",
>> +	TP_printk("target_id=3D%lu nr_regions=3D%u %lu-%lu: %u %u",
>>   			__entry->target_id, __entry->nr_regions,
>> -			__entry->start, __entry->end, __entry->nr_accesses)
>> +			__entry->start, __entry->end,
>> +			__entry->nr_accesses, __entry->age)
>>   );
>>  =20
>>   #endif /* _TRACE_DAMON_H */
>> --=20
>> 2.31.0

--=20
Best Regards!
Xin Hao


--------------6A02A84B8DAD67C8E65AC789
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html>
  <head>
    <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF=
-8">
  </head>
  <body>
    <p>Hi Park:<br>
    </p>
    <div class=3D"moz-cite-prefix">On 2021/11/10 =E4=B8=8B=E5=8D=889:16, =
SeongJae Park
      wrote:<br>
    </div>
    <blockquote type=3D"cite"
      cite=3D"mid:20211110131621.18221-1-sj@kernel.org">
      <pre class=3D"moz-quote-pre" wrap=3D"">On Wed, 10 Nov 2021 20:13:14=
 +0800 Xin Hao <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:xhao@lin=
ux.alibaba.com">&lt;xhao@linux.alibaba.com&gt;</a> wrote:

</pre>
      <blockquote type=3D"cite">
        <pre class=3D"moz-quote-pre" wrap=3D"">In patch "mm/damon: add a =
tracepoint", it adds a
tracepoint for DAMON, it can monitor each region
for each aggregation interval, Now the region add
a new 'age' variable, some primitive would calculate
the priority of each region as a weight, there put it
into tracepoint, so we can easily track the change of
its value through perf or damon-tools.
</pre>
      </blockquote>
      <pre class=3D"moz-quote-pre" wrap=3D"">
DAMON calculates the age using the address range and nr_accesses of the r=
egion,
which are already in the tracepoint.  In other words, user space can calc=
ulate
the age on their own.  Therefore I thought putting age in the tracepoint =
as
adding unnecessary information, at the moment of the implementation.

Of course, I would missing some use cases that need this information in t=
he
tracepoint.  Furthermore, adding just one more value in the tracepoint wo=
uldn't
incur a real issue.  But, I'd like to know why this is necessary and how =
much
benefit it provides.  Xin, could you please share that?</pre>
    </blockquote>
    <p>I think these two variables nr_access &amp;=C2=A0 age have differe=
nt
      meanings, the nr_access only reflect the <br>
    </p>
    <p>period of=C2=A0 sample_interval,=C2=A0 We may be able to get the c=
hange of
      age through continuous long-term sampling,</p>
    <p>But I think this is not very convenient.</p>
    <p>We only need to observe the change of age value a small number of
      times to replace the continue sampling of the region. <br>
    </p>
    <p>For example, age has been increasing to 141, but nr_access shows
      a value of 0 at a certain time. Through this=EF=BC=8Cwe can <br>
    </p>
    <p>conclude that the region has a very low nr_access value for a
      long time.<br>
      <br>
    </p>
    <p>This datas that=C2=A0 i used perf tool to record &amp; script=C2=A0=
 <br>
    </p>
    <p><b>=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187237:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 305254400-597266432: 0 140</b><b><br>
      </b><b>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [0=
07]=C2=A0=C2=A0 664.187237:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 597266432-900239360: 0 140</b><b><br>
      </b><b>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [0=
07]=C2=A0=C2=A0 664.187237:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 900239360-980148224: 0 140</b><br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187238: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281471544459264-281471789129728: 0 1<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187238: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281471789129728-281472066732032: 0 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187238: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472066732032-281472281972736: 0 1<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187239: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472281972736-281472346124288: 1 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187239: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472346124288-281472379187200: 0 1<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187239: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472379187200-281472678154240: 1 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187239: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472678154240-281472951209984: 1 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187240: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472951209984-281473069228032: 2 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187240: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473069228032-281473299972096: 0 1<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187241: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473299972096-281473603727360: 0 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187241: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473603727360-281473611063296: 0 5<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.187242: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281474851557376-281474851692544: 0 140<br>
      <b>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=
=A0=C2=A0 664.287642:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 4194304-305254400: 0 141</b><br>
      <b>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=
=A0=C2=A0 664.287643:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 305254400-597266432: 0 141</b><br>
      <b>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=
=A0=C2=A0 664.287643:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 597266432-900239360: 0 141</b><br>
      <b>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=
=A0=C2=A0 664.287650:
        damon:damon_aggregated: target_id=3D18446462650354140800
        nr_regions=3D16 900239360-980148224: 0 141</b><br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287650: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281471544459264-281471789129728: 0 2<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287651: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281471789129728-281472066732032: 0 1<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287651: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472066732032-281472349429760: 0 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287651: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472349429760-281472588464128: 0 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287652: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472588464128-281472678154240: 0 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287652: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472678154240-281472951209984: 0 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287652: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281472951209984-281473092300800: 1 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287653: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473092300800-281473299972096: 0 2<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287654: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473299972096-281473421471744: 0 1<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287654: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473421471744-281473603727360: 2 0<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287654: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281473603727360-281473611063296: 0 6<br>
      =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kdamond.0=C2=A0 8282 [007]=C2=A0=
=C2=A0 664.287655: damon:damon_aggregated:
      target_id=3D18446462650354140800 nr_regions=3D16
      281474851557376-281474851692544: 0 141<br>
      <br>
    </p>
    <blockquote type=3D"cite"
      cite=3D"mid:20211110131621.18221-1-sj@kernel.org">
      <pre class=3D"moz-quote-pre" wrap=3D"">


Thanks,
SJ

</pre>
      <blockquote type=3D"cite">
        <pre class=3D"moz-quote-pre" wrap=3D"">
Signed-off-by: Xin Hao <a class=3D"moz-txt-link-rfc2396E" href=3D"mailto:=
xhao@linux.alibaba.com">&lt;xhao@linux.alibaba.com&gt;</a>
---
 include/trace/events/damon.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
index 2f422f4f1fb9..99ffa601e351 100644
--- a/include/trace/events/damon.h
+++ b/include/trace/events/damon.h
@@ -22,6 +22,7 @@ TRACE_EVENT(damon_aggregated,
 		__field(unsigned long, start)
 		__field(unsigned long, end)
 		__field(unsigned int, nr_accesses)
+		__field(unsigned int, age)
 	),
=20
 	TP_fast_assign(
@@ -30,11 +31,13 @@ TRACE_EVENT(damon_aggregated,
 		__entry-&gt;start =3D r-&gt;ar.start;
 		__entry-&gt;end =3D r-&gt;ar.end;
 		__entry-&gt;nr_accesses =3D r-&gt;nr_accesses;
+		__entry-&gt;age =3D r-&gt;age;
 	),
=20
-	TP_printk("target_id=3D%lu nr_regions=3D%u %lu-%lu: %u",
+	TP_printk("target_id=3D%lu nr_regions=3D%u %lu-%lu: %u %u",
 			__entry-&gt;target_id, __entry-&gt;nr_regions,
-			__entry-&gt;start, __entry-&gt;end, __entry-&gt;nr_accesses)
+			__entry-&gt;start, __entry-&gt;end,
+			__entry-&gt;nr_accesses, __entry-&gt;age)
 );
=20
 #endif /* _TRACE_DAMON_H */
--=20
2.31.0
</pre>
      </blockquote>
    </blockquote>
    <pre class=3D"moz-signature" cols=3D"72">--=20
Best Regards!
Xin Hao</pre>
  </body>
</html>

--------------6A02A84B8DAD67C8E65AC789--