From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26839C54EE9 for ; Tue, 13 Sep 2022 08:49:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 730D68D0001; Tue, 13 Sep 2022 04:49:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E0686B0073; Tue, 13 Sep 2022 04:49:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CF798D0001; Tue, 13 Sep 2022 04:49:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4BAEB6B0072 for ; Tue, 13 Sep 2022 04:49:11 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1FB90160533 for ; Tue, 13 Sep 2022 08:49:11 +0000 (UTC) X-FDA: 79906437702.11.38D51B5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP id AE8671400B3 for ; Tue, 13 Sep 2022 08:49:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7922EED1; Tue, 13 Sep 2022 01:49:16 -0700 (PDT) Received: from [10.162.42.9] (unknown [10.162.42.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E68CD3F73B; Tue, 13 Sep 2022 01:49:07 -0700 (PDT) Message-ID: Date: Tue, 13 Sep 2022 14:19:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 09/16] mm/page_alloc: use local variable zone_idx directly Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: david@redhat.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220909092451.24883-1-linmiaohe@huawei.com> <20220909092451.24883-10-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220909092451.24883-10-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663058950; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dkxtTACig3v6l6nvMm62nTWgQ5ZsLq+EMYS+DBQbM00=; b=pskHPyTdU+y0iIte5rlVYl1bhUjxWskjTE8NSJ4YNo5eaJJNpbrP+cZqd7Sg7vi0cweBmJ cbC8siwd+pK+IzbaArMtGowX6n2oPZAWJ75tcdi7ux8Zhx7Eb1XEiTQxcxIgzMYpDSk5pC m3vzR37x5Y7IH2EuK5byq6HfsOT/nQM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663058950; a=rsa-sha256; cv=none; b=QZTAg2N7OeDJI6gUkzBSUPALs83GvkPDKGcxMlfg7eBNNDi98xYBMsUByZv4fdBLOMB9AA Qs5JNmYdxYTSaaO+kU9K8qe2baAxy6tJiRDVhQgi7fVcmGe/FIEPb+qVbO9witTafnk2Uu N1bctbGAMwfV3/6o47E3lR8DDvdW/FE= X-Rspam-User: X-Stat-Signature: 1uws18411yfk7sgqcqzmccmkt7t99ooh X-Rspamd-Queue-Id: AE8671400B3 Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam08 X-HE-Tag: 1663058950-183797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/9/22 14:54, Miaohe Lin wrote: > Use local variable zone_idx directly since it holds the exact value of > zone_idx(). No functional change intended. > > Signed-off-by: Miaohe Lin Reviewed-by: Anshuman Khandual > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 94baf33da865..3417232afa45 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6878,7 +6878,7 @@ void __ref memmap_init_zone_device(struct zone *zone, > unsigned long start = jiffies; > int nid = pgdat->node_id; > > - if (WARN_ON_ONCE(!pgmap || zone_idx(zone) != ZONE_DEVICE)) > + if (WARN_ON_ONCE(!pgmap || zone_idx != ZONE_DEVICE)) > return; > > /*