From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D155C77B75 for ; Mon, 22 May 2023 11:33:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0439E900003; Mon, 22 May 2023 07:33:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F364B900002; Mon, 22 May 2023 07:33:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFD9E900003; Mon, 22 May 2023 07:33:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CA062900002 for ; Mon, 22 May 2023 07:33:40 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9679440D79 for ; Mon, 22 May 2023 11:33:40 +0000 (UTC) X-FDA: 80817681000.10.812F15F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 555B8C0011 for ; Mon, 22 May 2023 11:33:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dibw95oO; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684755218; a=rsa-sha256; cv=none; b=TyWB/Qy/KT1Bp8xNt/guYxWj+ULyfM5LeQFox78U1RPaOmInnTI1XKi2uvztxiDod8mnn9 WxrXdTNN728s0k6erMUichGUTIqg0STkH1Ib5gqamBiWjpWJN7rcPRpv+D9BS0utAfF9cr 7WjsOFY3fWEAEQFycJjDHxyONPTgXBg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dibw95oO; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684755218; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b4wlCqP/bAFdihLv2wSratormpoOv+1EUJpnr4J9d9g=; b=sMOCJBSM+JRxP52840d8Pjgtl8KXhb1KRTu+0o4Oi0JeFBOPaugAwgOn1Vil2RFmIqdi7c FI3wCIRHkMZdOxGryuodeg9evVNvw2ul7OnIuoeg9i4vHIUrwxT6s0DnPQYUUSagBjHxfT nA04w0RTTpZQ7RULIWRRJoRHlR4hidY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684755217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b4wlCqP/bAFdihLv2wSratormpoOv+1EUJpnr4J9d9g=; b=Dibw95oOkL6uX0BTbAafzNVnWsAQNN8QxWZfK9DPjlCf0iDfaG/ee1LoWnOYHA/ky7vecY /DnoEClqc44F9IIwe7tN7dUJinJ3S9dHjiMdnKZrA65Lkqc9r9BcYe563t5TnbW7W1DB4R Wmg6EKJoaRfPkDHAXYbRcm8V26W2xKY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-rtyBCzN0OmGtAVBRYN5BaA-1; Mon, 22 May 2023 07:33:36 -0400 X-MC-Unique: rtyBCzN0OmGtAVBRYN5BaA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f4245ffb03so35588185e9.3 for ; Mon, 22 May 2023 04:33:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684755215; x=1687347215; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b4wlCqP/bAFdihLv2wSratormpoOv+1EUJpnr4J9d9g=; b=VFDXHUkB69ab4Vg4mOAIki3ZeeaUgK8BXIkt0vdkRRtbM7o61DfMzipLRfUJh8VlHG CBgxpqMm5qTvJ3TLPJlc5CmCrwYuSeJYVcgIUvGafByqiLisL9lma9IDW4OtaHU55zuO 78iiuO4m5+GGabASQ0+RyASgKAci8amFUD6QS3OalVbpyunxGh3Bnd5GRc+w071PiO7U R2aXytQT9nAIJq8QdxRECwe/LonwZyONlkPCuuVeT6IlX6NxmW6OwgQnyvVCv3cuwOy+ Vd4kI2Nl96dpa3R+Ffu7QWbV221GnZeHizzkHNIwIshNRo8nbQdnV78GRQqExee5pK/o 95Ig== X-Gm-Message-State: AC+VfDzpOJmqPWS9Ls3G5IOFk/jWWlVoI3ZrqXd2Kf8AVSsKS0mnm63t Gqh7N5waHNz4LjLh538YiFpGYoYgHeU4ojxXaigSkNZLV2fop1XXltbRudt47bbZdEUq8WX16wb hSXgHBBrGQLM= X-Received: by 2002:a1c:7911:0:b0:3f6:76e:604b with SMTP id l17-20020a1c7911000000b003f6076e604bmr961853wme.0.1684755215402; Mon, 22 May 2023 04:33:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7sHQZ1W8KykgGRFIsxmPBxvnMRXc3F2kTr9pYA6l5VFdB/HgxcSkxAmsKOAKZ7xjEsdCyBgQ== X-Received: by 2002:a1c:7911:0:b0:3f6:76e:604b with SMTP id l17-20020a1c7911000000b003f6076e604bmr961839wme.0.1684755214999; Mon, 22 May 2023 04:33:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:c800:d74f:aec6:f8ac:558? (p200300cbc742c800d74faec6f8ac0558.dip0.t-ipconnect.de. [2003:cb:c742:c800:d74f:aec6:f8ac:558]) by smtp.gmail.com with ESMTPSA id c4-20020a7bc004000000b003f42461ac75sm11320613wmb.12.2023.05.22.04.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 04:33:34 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 13:33:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH mm-unstable 1/4] mm: multi-gen LRU: use macro for bitmap To: "T.J. Alumbaugh" , Andrew Morton Cc: Yuanchu Xie , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mm@google.com References: <20230522112058.2965866-1-talumbau@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230522112058.2965866-1-talumbau@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 555B8C0011 X-Stat-Signature: h4oxfuyzbyigzo7rz6qcojrjxdh64gxn X-Rspam-User: X-HE-Tag: 1684755218-991347 X-HE-Meta: U2FsdGVkX1+OnRxZ2JgdzHUnXOktw+LRmlKHZFca128O0QJl5aGykV803YgVrXO5Xe96ZAwed86MDwtWjLNFkbwsRPrTLTiHd0wwfQ8PKLZUSWh9JJodsb05UZXN/01idLdpMYjYpUHEJ52QrYSfK1XNSF4s0UdDd3mKk1jmUKK2dfUy4B9E22p7gdEY8QihwDYbICB3h3rZyCNkCwAgtUQItX6Y6j5n4HJGKwVOK3YICTzpGt4Jz91Ch/+k9ok3RJxE3plLysXZnfgABJGpWNYW6XQaFt7nZDmuzIm5bpdBRLCOmahWrWQLZXh2R/zvxRXMMGsFTB+DMz+/JRN39Vzfis7jU5fxmJfHsG6sCbA5EB8ww3JiljFoJQ1cHsQNU8w2nhA/Or1pP98ciIcrIhjYEMxS9PMMd+L4GxMgs6FkoZC8AeDL4k3tJ6w9Amgy0SYvftLqGAL+wpMxDANkobNeW982HwUwxvlBQMnu18lz1reozaqokndvgvMAp2UZZbkk53910R+VAQTpoEvl8EIy5w/F7jr+/4pEaQ+xz2EMPSH036Rl4dq1UUx/NOqPBdsCkN04fUbFzJ2yaAjJxh5mkOOWohJ729RYhQepKMoLhn93HGRVEPO76NWwUbdxh+DSAzcotPiHIkNiDuMtAdfUkxsbKwoM+lZFSbJC1W5jvwWMkwU768ilwyIWOWVzFsbzHLa2ftXVdT89XF6cC2umngqdGMhO+kg2SnbVpaOQdtmysF/GAbbRcfFpYOI/6u89BayRWUrogknbD58rHrJPlLpif7S3Tbiyf6PH5Uxw7CG+IVEMuXBWksb1ww0Lm7xrw50/YhXRmG/9krO082HW3vYOUBZXo+qKZHTlgZZ2W4TC/dq3fuW1QPEMlb+5UWtryE4CIE5wWTyTjR9uG9iYP5S2/uqRkdrlgH9Cb1trf9IjkNLR92HXAYoOrBRwXSBXSO0icLxFJNx3IXk f+kEaUjE +K60GoSEvixM1VnBpuGmhza7J1jDmEMwsgIvyUwJH7efdgFlsl6syi969CKI+PO2WTPKdLMmF1gxWC/g2rwJ04W2OF/mRsLfTnkOfy+L09XjckHKlkP83VCytjCg75FlEflIXuGk1pZIwF9cy89+VOTo6NVIDcS8ZH0FI/Z94sIIS5KqdIDLAJ55j/277pozTgJLwBP1FiLk0Fdv06N7Sa/dUfMeidTDiIRC+xrm8wpLAh5yRsNzoMeUZsLpcS+fIOvjD7d4EH4oUrk1R8dtkoj/Gy+afJCqc/W5iZApVEWyE41ETHLFXWzLXtQTiefz7v7oh6307Lf3pneQIFIxanmg8XcP0ukRKFx7gw6qlCBUZILyfArLJKzfcj+/IbdT8W033RaWM0TxE9Nk0/JlJaS3IrF2aKZ7g6D5k49KK4kV8CFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.05.23 13:20, T.J. Alumbaugh wrote: > Use DECLARE_BITMAP macro when possible. > > Signed-off-by: T.J. Alumbaugh > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 4637f6462e9c..cf18873a36b9 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4144,7 +4144,7 @@ static void walk_pmd_range(pud_t *pud, unsigned long start, unsigned long end, > unsigned long next; > unsigned long addr; > struct vm_area_struct *vma; > - unsigned long bitmap[BITS_TO_LONGS(MIN_LRU_BATCH)]; > + DECLARE_BITMAP(bitmap, MIN_LRU_BATCH); > unsigned long first = -1; > struct lru_gen_mm_walk *walk = args->private; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb