Re: [PATCH] mm/thp: dead code cleanup in Kconfig

Andrew Morton
2026-04-01T00:37:50Z

On Tue, 31 Mar 2026 08:22:32 +0100 "Lorenzo Stoakes (Oracle)" <ljs@kernel.org> wrote:

> On Tue, Mar 31, 2026 at 08:07:30AM +0100, Julian Braha wrote:
> > There is already an 'if TRANSPARENT_HUGEPAGE' condition wrapping several
> > config options e.g. 'READ_ONLY_THP_FOR_FS', making
> > the 'depends on' statement for each of these a duplicate dependency
> > (dead code).
> >
> > I propose leaving the outer 'if TRANSPARENT_HUGEPAGE...endif' and removing
> > the individual 'depends on TRANSPARENT_HUGEPAGE' statement from each
> > option.
> >
> > This dead code was found by kconfirm, a static analysis tool for Kconfig.
>
> Thanks for acking tooling used :) much appreciated.

OK, I give up. Where do I learn about kconfirm?

> >
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
>
> Unless there's some weird semantics I'm not aware of, this LGTM, so:
>
> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>

Thanks. I'll add this to my (small!) post-rc1 pile.