From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D64C5AE59 for ; Tue, 3 Jun 2025 20:18:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FEC76B050A; Tue, 3 Jun 2025 16:18:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D6446B050C; Tue, 3 Jun 2025 16:18:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ECDB6B050D; Tue, 3 Jun 2025 16:18:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E3C336B050A for ; Tue, 3 Jun 2025 16:18:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9328C121641 for ; Tue, 3 Jun 2025 20:18:40 +0000 (UTC) X-FDA: 83515202400.05.E30FAB4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 33D1680010 for ; Tue, 3 Jun 2025 20:18:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jDak6r9Z; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748981918; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dmdW4bmka8D9iCjUm0LgPnNY9QDzyr1/KIwj6yPU5Nc=; b=oR5O5iDkGvhoKOXUtaSRbT1b3weVlQdJx5zRhE3G87iyzEuABYS3Z9gV4VZ5Yq/BquvZTy P1Z0Y1nUXoIPFhFOOpDnHBpNtzbvVeU8lLDQQYj16R0fyS9ZgNBoSaoRGNootT/jBZaGcj dD0AXIPpZSF7ALd4Wj5xSVavUrjzdH4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jDak6r9Z; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748981918; a=rsa-sha256; cv=none; b=X5+8phIoD6lPXh/1ygu68cTqaLg2kRoag7DWMav9IWkG/LSkA0yiOSGG/68bR++F44ad0n p7ViwpiX5JTVkmzZfXrrPaTa8FoauQX1JwEWcDq9myBIf8Lp6o41ah6bcxDqd9FaC9ubYY fZikC+UqtCUPzjiKofH0o0lhJXRdL5U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748981917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dmdW4bmka8D9iCjUm0LgPnNY9QDzyr1/KIwj6yPU5Nc=; b=jDak6r9Zic24Q4eJ/gUPKjq584a7uQTuM77fZlS0XSMzHgJX8JuJc1nHnZSXVzpOyMKr8I nFqrFl0qkyzfOY87gNiUHEJn/4xKWPBCtJeFIX3xjmHeitjvCcsyRo55oIqaZt/P6AvJud JRLMpPhnwp29VacRgq8F6bZFezSzqu8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-OHcF1AEfNMKAgbxUlcF_yw-1; Tue, 03 Jun 2025 16:18:36 -0400 X-MC-Unique: OHcF1AEfNMKAgbxUlcF_yw-1 X-Mimecast-MFC-AGG-ID: OHcF1AEfNMKAgbxUlcF_yw_1748981915 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450df53d461so31954565e9.1 for ; Tue, 03 Jun 2025 13:18:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748981915; x=1749586715; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dmdW4bmka8D9iCjUm0LgPnNY9QDzyr1/KIwj6yPU5Nc=; b=S7lCIx5DRSYzAtrAulE+ef/OyP3nzQ2LCC2wyRpA2bUny3d3MUFtmFGgIjS5VzPoX2 +RhIK1Loh5W8siFxCj6ueRWjcmHdBQQT9qeMo5kTu6NcqoB3aQZdSPLmoPvvYN5+3WEi 4hsIF5wi4Ed4spbyz0cV2mx8AYjcoNgkXSeAVknVI7oX94UUAJvYMU44ID0s+jr94q7G 76anI48Vprm5yt4XcL5CFvmjHewNlyuzIWHzarrfPSN1CCqiM96K8iuWNWl4jB0MLMb3 1CqrTUoPxhw3R0lN0MlHXZh+Eo8b/eMjLLK75/nBcNLK+XANZJ35DvWkjy18t5Es9Cij d5qA== X-Forwarded-Encrypted: i=1; AJvYcCUpOX1es7Yb83A6i+AlRvRal5ozqGySYWahrHhgVtuPA8Aslr8mLLpn7Vgo9ymJQWAESj1dnL6MXw==@kvack.org X-Gm-Message-State: AOJu0YyJe/HPvUW3QgapFw/X041fCnlKqFBkwC/55aFVqSJbw1MjDZVS R09q85tGYMZZJCuifQ1G+1weguSJbeTXyHFpdo7GbkCL8U2ik4kZf4DjeDQHqc0I80EO2BNcxQh K3m1JGO6EMBmVKi3J92H8G9yAcayQGW8pBM+DkSKaRDMmOBP1px9u X-Gm-Gg: ASbGncst/UjDEU8jn9rrV0tAlDSrM9JANsD5/prv+/gnRVjqRkCjv4SJVWlmQlnglIf M7RPW9flJKSgmLy8l3B8fl6FDn/3M6oWZdAIhn4QT4uCTt+cni4g3bROCllwpCJmWo8WjQEFeIR ZGLXuKuY2rBZ+B/Ks5+sAVJDpITENipFZ2KT45YwoIGDLlKtFelk8mV23aNRiQBVg8IAUYc4J13 8Yk0Q9Xn5mCh7AF8LpdhPVSLGQ5OlCsPJFx8j9UfR79a9pjm+cyAMGzgojuBKVHdPz1+D7IaSmm +NreSWlwv1Y5RL2Mg2549fwtevHJh9KA5Fu7aymFbDwLFE2gdI517v5uLQWDri7E35sEge924rd pxqFbYpTpc13/jXmjn57jMjDG2i3T/7ircPFlXzfvCn0KZESnbQ== X-Received: by 2002:a05:600c:818e:b0:440:6a5f:c308 with SMTP id 5b1f17b1804b1-451f0a772b1mr800195e9.13.1748981915237; Tue, 03 Jun 2025 13:18:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFoZbzZ9OiBB+hfEam1+vq0MIwdg8ikG1TlX+hLCXBEfbkk5dPOMwLME6VFx/Iyp28v7K66w== X-Received: by 2002:a05:600c:818e:b0:440:6a5f:c308 with SMTP id 5b1f17b1804b1-451f0a772b1mr800135e9.13.1748981914874; Tue, 03 Jun 2025 13:18:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fb09a3sm171214265e9.24.2025.06.03.13.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 13:18:33 -0700 (PDT) Message-ID: Date: Tue, 3 Jun 2025 22:18:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] selftests/mm: Add helper for logging test start and results To: Mark Brown Cc: Andrew Morton , Shuah Khan , Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-2-ff198df8e38e@kernel.org> <63e00cf8-8592-4117-bb27-42bc8c1f8921@redhat.com> <5e00c276-2d3b-4004-9f98-4703e2d642f9@sirena.org.uk> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5e00c276-2d3b-4004-9f98-4703e2d642f9@sirena.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: R6wSqRpPRLpUoGy0ri5aLOxidiw96Y_8KJmu3IG7bgc_1748981915 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: a6f73gi7x63pjkhedt6rueuatmu1tzdo X-Rspamd-Queue-Id: 33D1680010 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1748981918-965399 X-HE-Meta: U2FsdGVkX197KbAkjJmjVnzbAXFLp3+aRPEo7Z6/0HYjCbDE8VltMHJ1dLaBPpD98Xihu+/jzSKyrr6yE/kJ86XrTBV8u/VWu+L5/RrtsAfdl1UERVupGDA5a///sdPq8yuEgj4pmCQMcKKa15Qoex2XUTyAX5sF7ifvEBtMHcw6VuSAuGvRL+TekJka2Cn3quXgBXWiyNDmf04dxVLJN3jCKeWwsao1wx1hiITGu8pQB5Yx4mtUiG+RvRPuO0Q+O5V6a2HkPQJWNCd0bUwaPvVY5BJhUKK5vsZd+bfjgUo1DGlShd7KW2dpQv5VsitjrjBfKU8yB7y9X5kqvTIUg77Q3wZ+MUfRlMj8MV24OSDk/kRnCo0IV6h8SC4NWBamOZLJZFTUbPeKyeoBKyPMd8YDkbKbYTlhOaDqpyxE43qAXIukfvDfWSHW6BuEhLH7/oa3h2monVkBoYH0FzNuon57qw6Ad78JRnnO4OFHkQfffMpcKjovLUFiEr36/aLT9Bw1Nhas47TKFvT9fL1LWA/DQcxePwXx4lAIr1/OXvYjp6e+DZZ19Rzgpp8Kxbj1KPDGl0syZCB86hPl10NvF9tXBU26XFV1IbFO0ndxAcPi8T6RSXtnnNLophYnJ167LafE93ylxmbU3CnLfzkj8or4H8291Y63/ShaiLoY9vjnLhI5OQxlezpWtQPKXfM+ku/Vub2yWAHqqexFrP/jW/hC/i1w8+89ba55fM1x6ezFfwhW7ZwevmhWRWT2zFpu/Doq1K0BAPsavz6vJb6Tr2LypRIrXVqyDv6sh81Cls6w6m7uOFjWZGTTR6i25JoBw4/Cg9KdG5dfO6xNoeRBWSO6A+CP/O9hMxaPH1puQHwEqfigAcFOHjgggj7Lh0B5chIw3rQihyhCQw84rUker/A706nRWW/SrMJ1zPKr9AJrCTJ4LHpWgvrxhhYe6ISJSPgsDP/nF9XJ7vO3a4u 5EA0O8QW RPnQJa5byqmx/GT4nbUhUnTUlTjgwYdvgs47V60hivxlPbp/zELI2SdhvsqsBNctq4HFFNGSG8YXhX4ElXeY6KepEVjizmMDrntd5K10lVRFAtXquK1PDO+4ms2SAI8PjEIIrIZcL66HQs0aovZ8+tnCz4ohD2Apr5feZTGbiLfc4VVrZrGjmNq1HeM9C95tAnF0+Hitlih902jF58/JZIHCEYa96W7Tp4mnTx6Ull0Udgqj5dvKZmKgU6RetuAeOOwFaSVYOpWDLmstguC5j3TXpdVRn/sz/9pZrCURfTDo/iTFgxa3J3iLbc+XQADWwYYcKSoPSeEsF/jUdb46IMBw6lyy9+alMGdueDKLxVmWl0rIdZd/NPAl1H63mVTzfGno1Zack3cpNyoDqqunedaNIaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.25 20:27, Mark Brown wrote: > On Tue, Jun 03, 2025 at 02:37:41PM +0200, David Hildenbrand wrote: >> On 27.05.25 18:04, Mark Brown wrote: > >>> +static char test_name[1024]; >>> + >>> +static inline void log_test_start(const char *name, ...) >>> +{ >>> + va_list args; >>> + va_start(args, name); >>> + >>> + vsnprintf(test_name, sizeof(test_name), name, args); >>> + ksft_print_msg("[RUN] %s\n", test_name); > >> We could allocate the array in log_test_start() and free it in >> log_test_result(). Then, we could assert more easily that we always have a >> log_test_result() follow exactly one log_test_start() etc. > > We could, however we don't have vasprintf() in nolibc and people have > been doing work towards making nolibc more generally useful as a libc > for the selftests (and/or the selftest interfaces more friendly to > nolibc). I don't really know what the end goal with that is but given > the fairly small gain and the hope that this won't be a long term > framework for anything I'd rather not add something that gets in the way > of whatever's going on there. > > Ideally the test programs would be refactored and these helpers deleted, > but as we said previously that's a bigger job that neither of us is > likely to get to in the short term :( Jup ... -- Cheers, David / dhildenb