From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22C23C2D0CD for ; Wed, 21 May 2025 13:44:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B8686B00A1; Wed, 21 May 2025 09:44:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 969826B00A2; Wed, 21 May 2025 09:44:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 831BD6B00A3; Wed, 21 May 2025 09:44:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 644386B00A1 for ; Wed, 21 May 2025 09:44:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 067FB14025E for ; Wed, 21 May 2025 13:44:43 +0000 (UTC) X-FDA: 83467035246.16.D3F8C75 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 5CB9214000C for ; Wed, 21 May 2025 13:44:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iZJNxTvF; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747835080; a=rsa-sha256; cv=none; b=H61bxw2snA/ZbqXluSWlhuhae5STvm/RoYgYaTMtj4Qq8SttE3U5c+YN2RdcyK4jmyfW4w 0QEXYd+fHJEjPopENjMdZf3HH0dfl9pkg46g1EKUjVcomjX3KvFl/lFiM/BJhyNhDmgvye wWLxBRbU/ww4bkPocs3q364RtqaQbFk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iZJNxTvF; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747835080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jPT7ti85BMXvw5SEl5t5/PrduEzVATIbbbTjYqzIvvk=; b=uS4HyMLGuPXWm3dd6bBZN2d+7QMcC2SIzqtMNzEYxzOslQG/Rt/ZwBtmJZ+EimkS78ff2w 5h3M+8og9K39Ckzqm+6TXerMoiWARuX62+/Uobr2iXmKD/KnHk8nfDvV2OTaheu7amWpDr kawe8F3IiGhtjStthwRA6yoyV1VkBfE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747835079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jPT7ti85BMXvw5SEl5t5/PrduEzVATIbbbTjYqzIvvk=; b=iZJNxTvFNf4RogAefCJAI55HfASdkn8M+gzA/J1Ph0/UOPrljc5GKMgZJG90LySWiemTrJ Ek7Yw+MBeTBAKTEG0Mzb0pEparuoYS4VddVp4smhnTL3/OJwS9A94zK/C2oCmwDk/RJnAU lyp7LH9Rb/Un4Hsb9S9DPDjpijvePkc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-440-WkXmZd08PYmr-4xmklRpwg-1; Wed, 21 May 2025 09:44:36 -0400 X-MC-Unique: WkXmZd08PYmr-4xmklRpwg-1 X-Mimecast-MFC-AGG-ID: WkXmZd08PYmr-4xmklRpwg_1747835075 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43cf172ffe1so50752535e9.3 for ; Wed, 21 May 2025 06:44:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747835075; x=1748439875; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jPT7ti85BMXvw5SEl5t5/PrduEzVATIbbbTjYqzIvvk=; b=w9yo5uMmt6OJKmxVkHM+DT/bJju+UDCKUqt/VzFMHAsprUFOtOEMFjogxtwBgFF4zF vTSXTMJrCh/l05ytaeffBkJ3Mv/8/gtMBGvuR2T3WXPSHTEGcI/KNOoK5SUfisiMvbUh k3z9X2A0SckLe+nZvXQQipzZWdAHsE9EMylZ3YSvObhlKiEAcA7EjBaegwh5ydfvDNp9 vlJ6otKnR26c7iZ10xpAB8JKRvRh9jtvScYOjdyyPPHaSPQOftkuNSYqIKy1VoghVXyb Tn+SVW/6eUK3tauXhWPJcx0FZKm3ftBn8LO7F1aZZXpsI6ainSKrBA+I4lN/sOiPvAWy uDoQ== X-Forwarded-Encrypted: i=1; AJvYcCVfj1DMhmIEZ1QRWqPz5YSEOEJ7RZxrKRCqliKkQJgaUi6p9qFcpHWIcz/PY2xjMbyTVM+kN4XoXA==@kvack.org X-Gm-Message-State: AOJu0YzCBi/TLQcWx0CSqRgSvoskoeG/ytZveQmqUk6H6TjuXwyeTIYq ivlHOMAf7X275OX/lwt+3ahUbGfL/n/ExMHgcM18bbcBKPbdKpuF7sFm01M3aHCnOKXOEwmE2YI yRybGG3rQ+x/5iwoD7YlYQ5paLa6YswDNcsKgMZ6Fb6cz9x7Gl7k6 X-Gm-Gg: ASbGnctOdwvIfEw6U3puwAuJFuoIWVDrMB6aXr0+qreieO0eaZmWl+ydppgFXASfx8o AKO5de6gk/fndBeiDSUD++imEi1jEcNl5HuVHrp8r93jK+lrF6YiCMOycrFu+CAEZMayOJRWngV S4ISTw5Km5IAZ2ToGl1cxEgBtkYwRnSG/tQ8LKXD1G5v1evJ5e2r7rsyQLVThfayjQydCRyX/xJ co4QbHfFWy1OJ4QgiTFLxSUXHfsmpnzV2P/nS64mbjKDglSfmLUqZH8jsbBGjnFU8smjExUSL5l Zl2yHtFW/x3RUeyxOrnFwgUNspeL7oXVVYshVqkT2laWqVLkXqfZDhy9oV8Jx5VSZJnk45Osq30 QYaAez1CNpJq+AsvKEZOqWIMJEOmzm+TA5WraCC8= X-Received: by 2002:a05:600c:a46:b0:441:d437:e3b8 with SMTP id 5b1f17b1804b1-442ff031619mr134358985e9.23.1747835075186; Wed, 21 May 2025 06:44:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFd3Ojd8iPiq35GYQnoNfvhzqWHrSnAPIoSti+hjHKiLprvvjzCqEHVWl48QW6W2jZvJChrJQ== X-Received: by 2002:a05:600c:a46:b0:441:d437:e3b8 with SMTP id 5b1f17b1804b1-442ff031619mr134358625e9.23.1747835074775; Wed, 21 May 2025 06:44:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:9c00:e2c7:6eb5:8a51:1c60? (p200300d82f259c00e2c76eb58a511c60.dip0.t-ipconnect.de. [2003:d8:2f25:9c00:e2c7:6eb5:8a51:1c60]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f7d975f4sm68860085e9.39.2025.05.21.06.44.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 06:44:33 -0700 (PDT) Message-ID: Date: Wed, 21 May 2025 15:44:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/memory_hotplug: PG_offline_skippable for offlining memory blocks with PageOffline pages To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , "Matthew Wilcox (Oracle)" References: <20250520164216.866543-1-david@redhat.com> <20250520164216.866543-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Lo_r8e5hWzw7EQyaM8E06j_uXi0oVE3VjQMtv_ZHwPQ_1747835075 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5CB9214000C X-Stat-Signature: 433kretdm4to4f5ajn19z3gtaz1m793n X-HE-Tag: 1747835080-292790 X-HE-Meta: U2FsdGVkX184BhlTVwayDOVi3AXp3vNuMZBo48Rhl5cwnvYKEDuYM2SrucHbK8U4VwQzrVbBF/3LG5eqIIls6wnHIQ6HjTxdznTo5oC5dz/OdKzRk/x8gzmTsKBnpUAWeR3VTul7Vj9rzEvoR5HrpwZ4gOhq1gqXb3BNZQNX/GDwr7YdsWnvT/nv9V60v0STaxgWPbVnwQszzGIkO5fJHhnhMqDk5BqoO25TA+6ejc+FHZIb9YM8c5kP17R1A14ZEWxRaqJ1EPLkGJVqDem27iyhGeOeya/YSFm8YHXnLoauzBzDi49flcGvJmleBKKFNJkr7gl/luF/EATpri1+seUvsuz3SYhAqitjeYK0uTOyPawZcaD9Rv0K4p2sfpvRkH6mqqdI+gvmtWUQRMGyETl6SExgFYz1+Bu1qs4h+7mXWofiDbR7XIv+dMaPU9fEgekPsU1dQ6b/xC7m3R+Wiu+1z9WEgO3q5e45WAA8j7ecOLFfFREte2iBSsyt1GZJmX45JYk+tB2e+VX1b/7sxpcnqYkD1Yww42Z7qn8Aw0WlZuj965dO3mwmtexmtoE8BFpnLAh4oaXt9VWymrktrK8cMBbmk5GXp5mx+IjGnoRiZNwRgbUrwlGAelIdJGsFJX7V7a6cfOix/BA4ezf+GbxER+rsuyIQEQzpGJZ0OwfzbfZFBBsL3+PLo6FZFkTc4ySumVd75X5wbJvXkwOJ6uiSyqJbF3XMk5vu3EZpOLSE+RbGFYm4kRB8PqBehlQ6qCzzEB69/PnH5Z2dN9mYI2cIIjlp7sCxgLWOeygZ0WxCKiOPf9A9WpMPFs2gLjoV919FMFoIKf7rv+l1uoBaMQMtYuUCHtLEsK7GfxZiW7YEVF3zu+dgHaYDLVhMGbdDLlXClOX2j+VqbbplGIq8quXVt/LNi8JQ8wPeXATzcq/fkcEHDkYPrxw2dLeoB1adcJzMX6TsTvfdWJvcwMc OorxCSP4 1IaP221x+f1QgeBBIK4yieLqPRdYJ/W9R7NuTCjWkbtfs0+omdpAP2YGQc4lkV18hoM16ElQ+kRGntRmxfZDIV6ufXCxNsPDCz9luioSl9vrbEZoqq02F4m2AC8n7RdjB2MnjKpYq41LKnyVCwDRY9CydkpJ3TCwxKM2TVnqYt9qF1j/15s4AwZst+QUNB7VPMy2V/TRZtit4WP0s3LxvQbEuJD/7feuCWO0cngxyKADevnf9SzHZxdDV5bXBiMj+pdZfW0mo4I+yc+ZW9XE5iGcDBpD393PP9rACTfcemU30E+39TvjDRG+O/Rl+a/VFEzVRUi48ef3AzqWHOy22u3WALdR+C5kk9bguBkJzdr3jT/d8OOEiN3m5IkSu3It5PnH6fm1W+7SQGfaJwlReYiA8Vnxq+bbM3cQNKLoHgLGbme/GJxnF/V5gSOSB0PFZaU/xiRGsFzVgp+Ty0zIxYTe8dAg7+DKPrUqG9VSiF8YS6o23wC5b6lXuDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >> Acked-by: Zi Yan >> Signed-off-by: David Hildenbrand > > Hi David, sorry for jumping in late Hi, not late at all :) > >> @@ -1157,6 +1083,7 @@ static void virtio_mem_set_fake_offline(unsigned long pfn, >> SetPageDirty(page); >> else >> __SetPageOffline(page); >> + __SetPageOfflineSkippable(page); >> VM_WARN_ON_ONCE(!PageOffline(page)); > > I think I am having some issues understanding this, let me see if I get > it. > > - virtio-mem defines PageOffline pages, which are logically-offlined > pages within an onlined memory-block PageOffline is a more generic concept also e.g., used by memory balloning. virtio-mem uses that concept, yes. > - PageOffline pages have a refcount of '0' once they are properly > initialized, meaning that refcount > 0 implies somebody is holding > a refcount and that should not really happen PageOffline pages currently always have a refcount > 0 (except temporarily in this special case we are removing here). In the future, it won't have a refcount at all. > - logically-offline pages belonging to onlined memory-blocks are marked PageDirty, > while logically-offlined pages we allocated via alloc_contig_range are marked > PageOffline (I am getting a bit lost between fake-online, fake-offline, my fault) No, the code is confusing. All pages are PageOffline. Only the ones that have not been onlined are *in addition* PageDirty. The relevant bit is documented in page-flags.h: "When a memory block gets onlined, all pages are initialized with a refcount of 1 and PageOffline(). generic_online_page() will take care of clearing PageOffline()." > - If we want to release logically-offline pages belonging to an onlined memory-block, > we ClearDirty them and be done PageOffline gets cleared in both cases: See the comment in virtio_mem_clear_fake_offline() "/* generic_online_page() will clear PageOffline(). */" I'll note that I am planning on removing that PageDirty() handling completely, and also letting handling PageOffline() clearing be always performed by memory freeing core (the latter is easier to achieve). > - If we want to release logically-offlined pages belonging we allocated > via alloc_contig_range, we clear PageOffline and be done Yes, in the future that clearing will be done by the core (so the plan). > - PageOfflineSkipabble are unmovable PageOffline pages, which cannot be migrated? Yes, but they can simply be skipped -- consider them memory holes we (the driver) can rediscover when re-onlining the memory. See below. > - So for a PageOffline to be able to be migrated away must be Movable or > marked PageOfflineSkipabble, making do_migrate_range ignore it Yes. > - PageOfflineSkipabble will be marked PageOffline upon re-onlining? Will > still be marked as PageOfflineSkipabble? When re-onlining, the core will set them all PageOffline, and virtio-mem will intercept page onlining using the page_online_cb. virtio-mem will then online the actually plugged parts (-> generic_online_page(), which clears PageOffline and exposes them to the buddy) and set the unplugged/hole parts as PageOfflineSkipabble again. That logic resides in virtio_mem_online_page_cb(). > >> + >> + /* >> + * Only PageOffline() pages that are marked "skippable" cannot >> + * be migrated but can be skipped when offlining. See > > It is probably me, and nevermind the comment but I somehow find > "PageOfflineSkipabble are not migrated but skipped when offlining" a bit > easier. Definitely. Thanks! -- Cheers, David / dhildenb