From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F61C3ABAC for ; Tue, 6 May 2025 16:07:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51DE26B0085; Tue, 6 May 2025 12:07:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC806B0088; Tue, 6 May 2025 12:07:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36CE76B0089; Tue, 6 May 2025 12:07:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 154286B0085 for ; Tue, 6 May 2025 12:07:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 67FCC1604C5 for ; Tue, 6 May 2025 16:07:17 +0000 (UTC) X-FDA: 83412962514.22.3EE56C3 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf22.hostedemail.com (Postfix) with ESMTP id 1C75DC000B for ; Tue, 6 May 2025 16:07:14 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=A0U9Kxam; dmarc=none; spf=pass (imf22.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746547635; a=rsa-sha256; cv=none; b=7pNBGKQp2uTZ6cK18xjaAtThq9sVHkLLYAUQB/007RMjTSyJOyAX2+9NjsCguXHnqkURBI Nf1x8c0tpLd4/iMRnNW9uvS39uV863cfouYvxoShPoUiciDIR0ScKSsuPmxWuL5jIUXlkf /XwIItPM9IJd7s7JaxgeE+PX9OFCcEc= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=A0U9Kxam; dmarc=none; spf=pass (imf22.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746547635; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+VZZVGzbcYYx5hdX5nvsFRseHivi3VPKSjmAFBb2pNs=; b=lfqAFMnLtqotZCRHOkcXlq41fWAbKMD49Kqkqjl/PAb/JbmLvUo0xq0n/+F5EbsQZVH8gK R+ZwHGcgRjQ5dn4M1oIP3LiYFORRQCNZSjBA2wwppdiqZv0bzpaNd7N9yNFclS4dynZOpe aPf0GlNF0qy7OWRVnEPJLefkoiwbb6o= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22e16234307so231035ad.0 for ; Tue, 06 May 2025 09:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746547634; x=1747152434; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=+VZZVGzbcYYx5hdX5nvsFRseHivi3VPKSjmAFBb2pNs=; b=A0U9KxamJF38CZhAsXPzyF1ETNNVNxrDy3a0B0J7CoiLH2N5ramM9eiM0m5vZF/I3v G3yqxBhKRsfDppIkbafXqzmj9Y5lQvsARYXsCG87Gi2uTmS5aHi+1Uu7PzVxKC2KCzjF 3bJkSXFWXj8WuYa3/Up96gmSm9HCmoiOAVOBev5jCzwdL0ZiXPYKUGJCJwqHKSZh10S/ mnWDJMr/ThweFrDVb46qpGM02Fx8X8YA7Lpbd9ZGFu9aqsTtEVkodr9vn/ZVlH2eJQVy hwIAK91ZjlfCK6iAVJ354kZPRdFCog1zs7OrJp0t/c74sFyCihu3nqM8rZROPhd+VNKy wJbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746547634; x=1747152434; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+VZZVGzbcYYx5hdX5nvsFRseHivi3VPKSjmAFBb2pNs=; b=Ym4rzRUh+fkPNv+9lV8EHJgGU6qbQ71uLHtZPNBftIhLUJ6TxHpHjPN83hj/FRZakV AAJEpu4X4q1iluHfHquuKWOLrnlZSEuvs88hp0J4KzYFundC1TtwY2OAuXmQsFQ5cPTQ xIDOSM6fBkm1lolUZRxFPKPcTO82d2RT3Ks1oaG/sMDPfsBeD/pJXMvMivwkX36H6q+b kohab9W7Rv0hPlatRONl40AEWwYS3yXQpU61f9UJlWvBvmIK3XH269q9S7EESM26mKus OMONfTqLIjALN5Z93hsC3i7QTJSWcKfPoN3V/8sjYNpqZ5k2AcdBNp38sndpIkXWGEg+ dGww== X-Forwarded-Encrypted: i=1; AJvYcCUBVdRZHZLvXeOEaqKfCDbOLJ/NTdaOM8pG4DvDZoHciUAzTwqMh7QShlwM01r2sRRQNVUydkVxPA==@kvack.org X-Gm-Message-State: AOJu0Yyt8UtOIFkw3eYo9brQdHW/Ak4XemIDWo2Ux2Dp6TM6sqZJgp0A ct8D9WusSgwH4nJH0KRR9tCtyoMc8h6YRTzYVWl7rStlSnVbxrbk X-Gm-Gg: ASbGncuMPtYzvDWpmpY27LScLLRAT+KKXDmFzAr7xS/6VynrpUYmX4G+OZqCUYF/KjV a34uxAmFl85MQ7PZa3qddaUKEyLcV3H6PgUXCPaArR60lElEX5URl1iAeLpKEScbkECL/SO/7cF 9JoHxrBA+Qzk0BVPES3Nvti1h8Y1uH9dOkkCxYWlXt1PlteR9EQPUIO/1p+xKs5I9kZh2JInQvi jC6MwfJMwXDjhEFDzNE5zrUQUAbyG0g4LNyMflcV1rVJSnfeLFxggXHzQ/m063vw8v1i0L//GBO 3bQCAqqtGcwPEklgcHj7Y7dbmDPino7sGLwic8zCj+jfoeOCJNIv3Xl5uN5VaDiYWIgSCJ7oXNl rwDp+sIynUhGHXQ== X-Google-Smtp-Source: AGHT+IEDY9vBp/pIzu68i4CFkgzkeq79wAIqKzRU7oNMRLAhiQ/uElBDfTlVuqGc6Qc1+lNzWzKU2Q== X-Received: by 2002:a17:903:41c1:b0:22e:5a9c:2853 with SMTP id d9443c01a7336-22e5d667e5bmr4368905ad.12.1746547633893; Tue, 06 May 2025 09:07:13 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74058db91dasm9091614b3a.44.2025.05.06.09.07.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 May 2025 09:07:12 -0700 (PDT) Message-ID: Date: Tue, 6 May 2025 09:07:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Fix up memory allocation tracing To: Vlastimil Babka , Christoph Lameter Cc: David Rientjes , Andrew Morton , Roman Gushchin , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Russell King , "linux-arm-kernel@lists.infradead.org" References: <20250506144531.3434190-1-linux@roeck-us.net> <62cf4450-c765-4641-b042-66cca71d5912@suse.cz> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <62cf4450-c765-4641-b042-66cca71d5912@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1C75DC000B X-Stat-Signature: jt5g9n6z14gosm1rwk9dyjm54kfbx9ku X-HE-Tag: 1746547634-421780 X-HE-Meta: U2FsdGVkX19tWGLzKJ1Xgcjv2dQUxKO90I31EeCCgXzGG0EEy1O6dZTJ6dNG4KcHPKlVMM1WGe5hjPQUp8yPFw/vfqa0x1fJ9nBm/620Cn5rqzwho3/rth9fKsHRKM9RhfQcMbGhWu1dNhylA1FxbNxn+p1Up3BnnfrKFnz9vjiJQ4P4LGD0MB3rX232CkN2KPDMhp7XSiNJDBnEG/5+qLUWFzBQgsYudv444teR6QZRuYw4Ek926dqh2hFFVy/mvm0D+GJ6gu6lKBiusS9CWruRXPIZIEUx1GaCZEouLl1t9AaoZ6RBwykWY9hx03wf6QDzGtvxmlJb1cJmq7tihvT8sNtI8Q5I3m3f1OiiKD3iIOhG8uW+jSg6v+j0SbGv198JQaIyg7ju9bhK25WJnSwUeKKQuPi+2EMG8JTrfQFHbgEljxw9m3dK8NjbxrFP2nbJ9auBmWbpD6fZT+dp9ASQ+EpjSiF269Aa9TtoW/lQuuiEsDkAF2NHdUWVWrZzreLH+UeT2JdDIG3uvK7tbGdkCIckVx0fFYvTpNnVwSeJUXh9aUYOYGqqmVvCeHcYgD2cs2wQ2CyQAkrreAJ6YEdZKCDBklC+l0Uu5MN2R3mxFhQ/mrDtam/7l37QC5DZMbgadjEoyJVYIK4Q/tNC0DSDtIniBpM/r1FUJmJU0SW4ptC1zfLmNgHcIxid9d5xDTi/3nRsYqBtGRucqIpWLqIbleXJY7k54Fvt2UDQZPt2Ht83prIVdf6Na7gYdZKHvWGUvvfsNITwit/45tDyKtdqks3xuymJmyc0w08DdEDVBAcbpX7V0ZVcjztzfdgD4bQOr258sOSlTKul4HCCeSsIgaeNH61IkxvgslK1q2HywB3I8a4qgfb1nd1IDrZGcx4miZzR4vTZ3dvzBBgUqnXhmFdpCu0SG2IoTgV6Q0h013thSFKsjIdlRZlgfJp9WDmEjbi/rBeHjEXngBJ 2Y+0XTUd +4LovN6FQPWMD2eMNVebsJr+PVpArVJQIzP3zbum8o5TXze0dD6B4XCBbdL7ZK8Yb8STq751LHk0KlaB7pqAM/3hpVSTIWKJkfJF5j8ev6kgYeRCvRs9M3Cn3z/rellxLlBcH3gEj3/5+c8be+qQSVtDFh+U4xownbKxSnJjMNFm3iFcxg1qSKUDfmpS3BmId3sFVkWGy1WkS8rln40hd5SzmK4lZrsIwW/7Kc+uEWAGcBEpCL5+H7fImwY+KuUJZvJBaioXlEba+97z3zSOfHS5LFh9Vx4QWPYwjxEaTGClIa/84Cnr6iMf5JjKuss2W3FV8pNCi3rFCU0A+do3EqaUzIzwrvmoATYqfZ57ibQ0W5GRVbkTheyCbbSSuvnVuq+262ZxQS6Zqz6cCj4NkEw6fQ4YevPYwkAXgRkDKt2yIsj28lJULCxi2XW8FsXUJNeN/XbyAH/puabYplxhqDsPG321HfDKU0pGkObWC6hAgXTcsD+slGslZGhC+vkCJW7hOXqXrF0f+Kjum+7+B4tiS0yP9YPnPiVt+4jJwQCVYxQo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/6/25 08:13, Vlastimil Babka wrote: > On 5/6/25 16:45, Guenter Roeck wrote: >> intcp_init_early() calls syscon_regmap_lookup_by_compatible() which in >> turn calls of_syscon_register(). This function allocates memory. > > CCing people for intcp_init_early() > >> intcp_init_early() is called well before kmalloc caches are initialized. >> As consequence, kmalloc_caches[] entries are NULL, and NULL is passed as >> kmem_cache argument to __kmalloc_cache_noprof(). While slab_alloc_node() >> handles this just fine, the trace code unconditionally dereferences it. >> This results in crashes such as > > OK, so we have crashes that are not deterministic. But also > intcp_init_early() deterministically fails, right? This means it's called > before mm_core_init(), and given the "_early" part of the name that's > probably expected (i.e. I don't think it's due to some random initcall Yes, it is called before mm_core_init(), from setup_arch(). And, yes, you are correct, the call to syscon_regmap_lookup_by_compatible() from intcp_init_early() does indeed fail with -ENOMEM. That is interesting; I did not realize that. Thanks a lot for noticing. Please forget this patch; I'll submit an alternative specifically th address the integratorcp problem. Sorry for the noise. Guenter