From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABBEC6FD19 for ; Thu, 16 Mar 2023 12:37:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D62F1900003; Thu, 16 Mar 2023 08:37:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEC1F900002; Thu, 16 Mar 2023 08:37:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8C47900003; Thu, 16 Mar 2023 08:37:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A8D15900002 for ; Thu, 16 Mar 2023 08:37:56 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7802D1213B9 for ; Thu, 16 Mar 2023 12:37:54 +0000 (UTC) X-FDA: 80574713268.04.055951D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 4DEF818001A for ; Thu, 16 Mar 2023 12:37:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jLMXF6ma; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678970271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9+hfNPh55s3QIpUAvR0km9DQY261PaQ6CD81XmL2nws=; b=0TZQcZdcRaoDyfVxCd+KBMk3WQfrAk9itRumpLhvsiV39t3ogOEa1+ZpsB3lWbVbvNIREY vrBKUKSq05D7yAVlSY+nnZgiCgiZZJsExsHhLS1thxFhT+jSUG4EZrubK1G7KugYHY6x2R Z5es8LioNJJdTAi6o66hz6c+LFNTCds= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jLMXF6ma; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678970271; a=rsa-sha256; cv=none; b=8RY8VomgPub5NSRfQ7as+7MxgQU1VZUnUBQHRbjp/qSI5iYbrD85l6FNtcK8kydpPUtj3s Db3ZBg46vhE8YdvvCuQ8vxncEb5DR+c1kNANmrXqM4MKZRfDpOyAdwJz6e6B3ZLi+7heF9 21n8PaW84052J50jLsfD1SvZC5ZGS3c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678970270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9+hfNPh55s3QIpUAvR0km9DQY261PaQ6CD81XmL2nws=; b=jLMXF6maTUK6OVZIZAclzkBm13gQ/C/4/1+4IUUpsxH+XlJtylEXXYJNsC8fJ/unNvUA8u aoenQd7YuOuSr1zzrzTHJc9Vsz4FX7vD1vkqn02xjV6eA3Srv2YwwVtiVF8Is7LLl+UvXY 8wvrgEnWOVlKDAG3TQ9q8UnxmpQZlZ8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-_ZmFIPmoM224ta_gUo6jjA-1; Thu, 16 Mar 2023 08:37:48 -0400 X-MC-Unique: _ZmFIPmoM224ta_gUo6jjA-1 Received: by mail-wm1-f71.google.com with SMTP id s18-20020a7bc392000000b003deaf780ab6so603836wmj.4 for ; Thu, 16 Mar 2023 05:37:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678970267; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9+hfNPh55s3QIpUAvR0km9DQY261PaQ6CD81XmL2nws=; b=pVJ8Gt+5BCPfwf5b+/DTFr36YUmqExSuf9EEnlSGQFzS5X1kh+fyIdsvuZ+jMK5Tkj 6u7xkGPOBhll1WcHiBwcPX9vwtlk5PVF4XkQ+giV9tX5fp4kHtMSzeD8eN6lX/iFo/VZ a48/Ow/TyJ7fuLUv+wIDinc8Rh+im6mvUP/l7nhlJWkp4CQtBsyNqruV2M4KD6IaKvG9 9vcVUclpeDj1EV9PbaWu36Y0TFahqhIRAQgZ9JFNq3dzD8peKcKb2z5oOX15Uce1BSzC CbY96ffx5etuZM2HzXTqu1NsKbwozAh/GA3VBbeo9QqhoK6Sl3gkpei/OpsD2PplHMAF GOHw== X-Gm-Message-State: AO0yUKV7GxVYuqVNlHSC0IPR9Eb6otzh5vHwuBEBc2NBCiz27t+sba7J OGXOlZzw4puyF3FJM8/W/ChF7kIMWsGnYmq5fEr6zuegjC9Li0nh9ZBTc83ohc0e6IAMJWIHR5r V3Lqc4EL6rsI= X-Received: by 2002:a05:600c:19c9:b0:3ed:31fa:f563 with SMTP id u9-20020a05600c19c900b003ed31faf563mr5633468wmq.20.1678970267660; Thu, 16 Mar 2023 05:37:47 -0700 (PDT) X-Google-Smtp-Source: AK7set909uXZKSW83RKxR+7Cr6bSKy6Ix/SZI1X9kWjaMkvkdqwheynIZDPY0NqDBlcgG3YwAwc/EA== X-Received: by 2002:a05:600c:19c9:b0:3ed:31fa:f563 with SMTP id u9-20020a05600c19c900b003ed31faf563mr5633453wmq.20.1678970267347; Thu, 16 Mar 2023 05:37:47 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id y16-20020a05600c365000b003ed23845666sm4764550wmq.45.2023.03.16.05.37.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Mar 2023 05:37:46 -0700 (PDT) Message-ID: Date: Thu, 16 Mar 2023 13:37:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v10 01/16] x86/tdx: Define TDX supported page sizes as macros To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, dave.hansen@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4DEF818001A X-Stat-Signature: pxqj7hyzyofsifz9tn94hzjchyrcqfri X-Rspam-User: X-HE-Tag: 1678970271-885746 X-HE-Meta: U2FsdGVkX1/TPy8/MxU0eIeB8W3ZJ9/oSWtqbv2n5ptYL2PPHqthzDlbR1P4x3W8UTrhPo/9LYQoV6+P6dGyAivGmUIs/fKIMb5bp1q8FpqnB9lmXWGF11fsTzyuz5cGm3CLhndsoLJ3dHKz/ib0EJwBK6NYvgbZIoLceMGyefa6kq6T4ZJjMH1Af/lStu5NIOwoP96aUVhDHXk5LIzukDlMML/PtpcfdrEU5OHgl2ocr+ygR+LbXypWqBLeF0sItM7Xg3FMO5aBPRSiGnRJRepC3m8j7oIAmrvojAyeATwnLMX335IdqyPrK3lHUZHbFAei5yPISiBavLwcIHTsMBUj4NLz2m8DlLhtqN89Xy0WCwWE/1Z9UNNZoMVFe5DJyMuvXrXYxWNFTirYQ5uSqQWaCpKt+moqkGO0dhjdbwn0JmTQp8g8/YiPx7xk1IhUK1FGgUTpkt2khp3ZdVLTT3JOQnMD8x3D6Wen1RhIUfViIkZRuJXeytIsA7QFZLNlydq/JFiQ1lHRP7W7ZyshPUDi0U/efpcktShAqcl8lgxS4mdLugClYkDvuAGCWZwMTafN8lbvA3Zh8uT+p64S8qZ6Yqsu8D+AN6ahuEn0JwVKtKC9fZZTGyvt8lFhLOl5X/6DkbYA/cwyXRFFKKZQXx2aeL5ojqr4jxK/Gta13wUymWOV8yjpaTwnhzkpjD7eRsVcVo1LsxSPctZ3xVu0aHrlKckepYSZfIQr/JAD89nEKm4kYzSETLyh3G7VYZ1g68VwFoqGMLdI+poU311wPbLw1onRadhnLfJPeMmAJYaUPdR76EtREOW2zgaxKgOvnuM29D8zurJsfi0alQBJkprDIZLVaJLGINz8SWUw7LoFeizE2hpKpO/NZ4yUKpAZvmwvkkUOsI89W+OIB8Lheyn2dwDgpk/848HUzJNzgqURwi60V6GKeZzzUiTPOlcNr/t4RB1O9zMfhCjdQ4+ wb7sDnoD KIoavjIr+CALhqvaMjVGwTr/ihWgWDkuh8iKvA622XvAefkaRtBdh6m5dT5A4SaFjQxcggyg8t+3JeDx+8e8NxbTLp6DNebZ6ASMhalRIyEwMtAmirGD/Stvpd7/vGWMdgowhUIswJNGfr82R0dg09/lsz0X4/ZA4QMzb4gCEJs4ivsKMygBh+ad0ylgpAsEXMlRLQ45e5bLgwHTKRuoFnmtEQ6vE39Yb3OpRZHHAuABuF/vPAySqZ6LQQTFQXz1yUTsRZc/GJM1dotS5tGlfDg+nDBLvtUK86pTQxy/WmYjR21bHhN77RpMEOe3ohWgjW4wbdx+NQ+A5b5b7ae8zIQryYxmTosda9PRQeFtwvyg4+mCA1Ug6Kc5AUkfmPN8BCXVTjiVUZ4qLX94fnAEAQhf+JbpBHBLOLeRZKAYxm4JPj1xFluRkQNiiRbLLtmSI9b97wYDb2amzS/N6IRLwPDbPBknkRpzLGiU1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000456, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.03.23 15:13, Kai Huang wrote: > TDX supports 4K, 2M and 1G page sizes. The corresponding values are > defined by the TDX module spec and used as TDX module ABI. Currently, > they are used in try_accept_one() when the TDX guest tries to accept a > page. However currently try_accept_one() uses hard-coded magic values. > > Define TDX supported page sizes as macros and get rid of the hard-coded > values in try_accept_one(). TDX host support will need to use them too. > > Signed-off-by: Kai Huang > Reviewed-by: Kirill A. Shutemov > Reviewed-by: Dave Hansen > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb