From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 777CCC4167B for ; Mon, 12 Dec 2022 11:41:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7AFD8E0003; Mon, 12 Dec 2022 06:41:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2BF68E0002; Mon, 12 Dec 2022 06:41:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F35B8E0003; Mon, 12 Dec 2022 06:41:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7F9DD8E0002 for ; Mon, 12 Dec 2022 06:41:41 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 564C5140B51 for ; Mon, 12 Dec 2022 11:41:41 +0000 (UTC) X-FDA: 80233464402.28.B16D9B4 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf23.hostedemail.com (Postfix) with ESMTP id 52174140004 for ; Mon, 12 Dec 2022 11:41:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670845299; a=rsa-sha256; cv=none; b=ee/D7iGWX51j5LBTXfuPJR60VUxQVh7VzPrAq9PRIVpLQMNEM6BLOmAfydygEuwCgbeciO OdR+9wuB0gheh1oXlOlBngAJirR0QjAZwqQJqV1gBUiwS3dptMtifzfxsDCSP0G9kK/wyi HlJQcegbEbGM66nuxJoRUfEhHxEZhoY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670845299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K1/JYJZ2lB3CexUb6QKL2+3tdjatHmwRBJvUDtWEFGc=; b=3qC3L8mOiE0hbSPff+dzU3M+pJ4WcR7KR0dl2jZ3coSWdpIt/PSwZ/5xiu7mPeV4DRCms+ eYwtww9inrOjF6rf/xerrbMPOZSwqfX2D4r8YR8GvwCORmgLxv1O0vUKIzlZnE3eklbxKk fWbO6oh+7bGD387rxZ+p6DaDEQj/zi0= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NW0785Sc0zmWfw; Mon, 12 Dec 2022 19:40:36 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 12 Dec 2022 19:41:32 +0800 Message-ID: Date: Mon, 12 Dec 2022 19:41:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next v2] mm: hwposion: support recovery from ksm_might_need_to_copy() Content-Language: en-US To: Miaohe Lin CC: , , HORIGUCHI NAOYA , Andrew Morton , Linux-MM References: <20221209021525.196276-1-wangkefeng.wang@huawei.com> <20221209072801.193221-1-wangkefeng.wang@huawei.com> <342f4d3f-7347-1615-7d63-cbdef4872629@huawei.com> From: Kefeng Wang In-Reply-To: <342f4d3f-7347-1615-7d63-cbdef4872629@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 52174140004 X-Rspamd-Server: rspam01 X-Stat-Signature: uywpa44dbei3ibas8nayhzuwz46sw4w4 X-HE-Tag: 1670845297-442290 X-HE-Meta: U2FsdGVkX1+E9GtfeZKkxdh9ZhtUxIK4yRkTwCW9aQXSRNt8l7ifTltsrktyFNhe1H9k4qJRjYVdF4mLTPoXJqU5dp+Eeh6sDeoCw90Q+4wSrvvL8oG9uc3HtXDLrZQ2YQLi/VVYWvlgBEH1q4qhE1uXv8t8ddN/G1s5WRCNzkXiZHkxTDR5syQlgZc6+9ncB6U+vFsAUqSpJmyk5RCPSCy7XjOsJJ13ExbQaUDjeQnIcjq1wtM54AiEQt+FaWGxHTtW6CeFX920qyEl5foUYsIMOw05/0IuWZy870NGFz3wD1d8GqQvJoijitLydXpkCSvY0tj7k06aAWGUfozPKHvWzJLJUXcHSf0ejhT5i80KirMFISEw9RfgivXTq9AIUBCl3Q9whmaIRcO6IXsQvgkRJDXZXMN0Ph60WB1I1MqztWwh9YC/deX/LkhEWnXTWWweCc24Hd6MpEKIl72Lx7wLNEHrrx2g2eyczCTFTWK5iP76nppFeWhWJeNcOQIl6YWoGSE80nP983RvQXgB/ysXVtji5xGuAplktkOO4qxCB+G5Pn7+6vOA02RtEfkYaJ0Zex/LHdfnd4cDclvjaoIVxCuiniFI+gkNhfmIKWeovHYyG8W0jZNkY0dvskTp/2PmxUHfQKJ8l6VsRZAl2pcr6E+YpjSoScoJa71c/t9NXUWxCMDWSbP0verP7pBWxRSQiE3StOBl4YVhmXw46u+n3N1GZMRQOQoQcPJuw7yOzuazo+pdfo9TEVPIcnZxrxVftiweAjmDFfonJtROKnRg7tzKIhJX2bQ0IR9DJD00rYjMXfadSsuBwrRywgyATdnY6zo0CntSSOEgaPOODlQ3MDdluY2yWdIvVbcsddl8DPmPKoquCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/12 10:36, Miaohe Lin wrote: > On 2022/12/9 15:28, Kefeng Wang wrote: >> When the kernel copy a page from ksm_might_need_to_copy(), but runs >> into an uncorrectable error, it will crash since poisoned page is >> consumed by kernel, this is similar to Copy-on-write poison recovery, >> When an error is detected during the page copy, return VM_FAULT_HWPOISON, >> which help us to avoid system crash. Note, memory failure on a KSM >> page will be skipped, but still call memory_failure_queue() to be >> consistent with general memory failure process. ... > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 908a529bca12..d479811bc311 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1767,7 +1767,7 @@ static int unuse_pte(struct vm_area_struct *vma, pmd_t *pmd, > > swapcache = page; > page = ksm_might_need_to_copy(page, vma, addr); > - if (unlikely(!page)) > + if (IS_ERR_OR_NULL(page)) > IMHO, it might be better to install a hwpoison entry here. Or later swapoff ops will trigger > the uncorrectable error again? Thanks for you suggestion, will do in v3. > Thanks, > Miaohe Lin >