From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF7EC021B3 for ; Mon, 24 Feb 2025 09:53:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86AF96B007B; Mon, 24 Feb 2025 04:53:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81A436B0083; Mon, 24 Feb 2025 04:53:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 694866B0085; Mon, 24 Feb 2025 04:53:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E80F6B007B for ; Mon, 24 Feb 2025 04:53:13 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 09F5F50962 for ; Mon, 24 Feb 2025 09:53:13 +0000 (UTC) X-FDA: 83154375066.25.FE537AF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id B0852180007 for ; Mon, 24 Feb 2025 09:53:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f80FM8nc; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740390790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IzxaqhQDxY+r+yPUc5i1Psk/kAs5imCOM+hrux7P+lA=; b=UP8bW/vtK2Ql2d2pE1xYg4doi3482aXdmKiIcEPwucZ3tenNRfYLPFRbjy5YdMfeWz25So +GUF2GA81vlkUYaJ2bljVf74FYLYZQl9mQbxEgsQh7ptZOOjlWmeGq86UkYMif2do5dbGS p1Zi8E3hBm0kqdbjDdabCPH8aXyZyA0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=f80FM8nc; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740390790; a=rsa-sha256; cv=none; b=BFhzKQK3KK0jC7jN1edRz2nHVXeyJ9Jv85mBi6zcrHFNxLRA3fPk0nd9/GvFsq5S910y0/ zspLKiC6g9p+DlNnVRcYPJl8doQ38Y1LMgdG4tXLA0siFNvvCmvlM8VtHs9Qirj0fcMjlK TicwGX+6elF9rREfvT4/Y6ybF72hXpQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740390790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IzxaqhQDxY+r+yPUc5i1Psk/kAs5imCOM+hrux7P+lA=; b=f80FM8ncLjGQJel6JlLvxUCiOb+OoCIwID94aLd/QhGV/VI7aydc/3qyEgMTmsZPdsmqom Ms/EO/HJ8LekxOwW4sA3KHV//FV0fs17e5tKGT0TMXXKMZ93x5aikuJ+umxEDpSsIARtQ+ R7NnS07XmCKllIqF9UDUcRuGWAGn5kA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-RGQRj6WePyCWt8nZaq1XFg-1; Mon, 24 Feb 2025 04:53:08 -0500 X-MC-Unique: RGQRj6WePyCWt8nZaq1XFg-1 X-Mimecast-MFC-AGG-ID: RGQRj6WePyCWt8nZaq1XFg_1740390787 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38f443b4949so1959229f8f.3 for ; Mon, 24 Feb 2025 01:53:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740390787; x=1740995587; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IzxaqhQDxY+r+yPUc5i1Psk/kAs5imCOM+hrux7P+lA=; b=EO/h+Oa1flq3vHos7KUx/33ettl/zmHRrhupswi5CtcXJLqUGcUqWutPMpNfjtjQNE 5gPVdEwOT2S4KxLRSxbRgNKJ88HMZAC/jdIM2IKXm9VZ0+MpjLN781utIILy6WZHACIa 34K+zTcRbUxKP876N3FVywXs0FBPaxu0blKgd647TLUvEeqOU4nDjX9ip+5RGHgT0oPV ajGrikiUkqNpB7SsaUmYPYMa+Dhab5YG+Q0/v3/5DGKVKMuwBoIWtPidaU6irkv7ztTn klMOlnY/b4mdUOU9PdkSDB1/LRwn3kv8gUog2891gF280aj+/YXKG+4J6qgrAYewO1GE s7gg== X-Forwarded-Encrypted: i=1; AJvYcCV/M7k//I30FYWZnbLGNOvPKzvf+mNwGEKjYB0bLG4ghzb/BBmVtUUFe4U5JtAHt8MrDrm0IepuSA==@kvack.org X-Gm-Message-State: AOJu0YxpHdEZfqNBeJGTeAZdieBf3L3QryJAETBPMfZsTEPYfEl4AM/s IbzLo66aXfZF9fa9+/O2/Cf/bcpJiKfMakSKzmt13CS6ZJpNzGyj7vLtUH576xoUpgypnONNnai eJLCtf7eHXMaCwW/OMH2h/w/W+XwS2HUGdleuxFZmZRxyc4+B X-Gm-Gg: ASbGnculxks1HynDatdJEDL2FK31BxL5WbK62LwvPjyEvnWvaPRPms9AAE6t3YJaJCP NwN87M9RrHgLhf+RduEPXt47D2g6AUNBf6tjreGtlae+tM2MkQ5Me9viJQwFQx3us/BDCJ6Cv2o sUGjvaskmsT+A0KHhVgroKpw1jLJxtcr+KIHjqlqQqfDfdznvPJMh9K+fNI4a5fog+MZf5l1qQQ At2uR6yDXL0eNkJfw20FI8FvnKJVfVKTVYTiMSjrMzqoRL1H6cvm3Jjz7SsZNqMVlqWDXe+EdxR iXFREc5pPebY2sv5/+s22MjKmuKdQHcd2mhavGUaIHl4y8irJAmTSbauqhVd0pMVwgGG4N2KQK9 ve0iNf3Dx5JBrNV8T1VY/sxP3kz2nYWTJUW3DaIcqvrg= X-Received: by 2002:a05:6000:184e:b0:38f:3009:61c1 with SMTP id ffacd0b85a97d-38f6e97ac11mr7808071f8f.26.1740390786856; Mon, 24 Feb 2025 01:53:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeU/VJhZcDbLTQQa0+pLuxIFtS3vPP37CcqaIrAqRIHtWdRR48GbaJ9OVar1JDYp8njh2LSg== X-Received: by 2002:a05:6000:184e:b0:38f:3009:61c1 with SMTP id ffacd0b85a97d-38f6e97ac11mr7808056f8f.26.1740390786544; Mon, 24 Feb 2025 01:53:06 -0800 (PST) Received: from ?IPV6:2003:cb:c735:1900:ac8b:7ae5:991f:54fc? (p200300cbc7351900ac8b7ae5991f54fc.dip0.t-ipconnect.de. [2003:cb:c735:1900:ac8b:7ae5:991f:54fc]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f259f7fe6sm30570796f8f.86.2025.02.24.01.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 01:53:06 -0800 (PST) Message-ID: Date: Mon, 24 Feb 2025 10:53:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Is uprobe_write_opcode() OK? To: Matthew Wilcox , linux-mm@kvack.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: t_IDDq60FowAXKMyK7Q_KjztVB2Ok85Z8CIOqNEyOxY_1740390787 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B0852180007 X-Stat-Signature: kgazxi4su35wixic43txbdy58rrkhw7s X-HE-Tag: 1740390790-820655 X-HE-Meta: U2FsdGVkX19A/Y1hR6Ns78BW3kct/SWFNWG1LYEfVKOEgP4hv9X7kWt3oyh8ast3ZnwHSAFBbpXWaqWdnSeWVH5eAK7bKvDy95E3oiaq1hv1WYBck31Rc5kpT96StypBlt3ajwOiKyrT2RYY0uXh/fz5Tor4sypgZNHSvIu56ZOg0OPB0IRXtrQ4yFs+Gcg7ckBO+21/O2NrC53M9MimNcAqoZOfo/2k15CkQpOwr+cr/7aFytNIznHedzbqnynkbGelLHqtJsBWtURoywpEE4bJl3jIWAxzNbN9efD7svfMW4VEusGgaZGrSTpxS1ZzSdLZp/WhF8VOo73u4LcvTYcHlWYJs9Ly7gR8Yp4HZFrsI82OQS4Sq/YHlutA1No64QfYDPGCLeKYqHW1hsFkKz4kmvKjuqf0EL9ysuumfmJJcGrjWRKksPrK5gQFzfS1GtNE7UdXn6AaH9W4+kevF+PwQaO6IUIgzcDIYK+GHRfFz5N8yysu0vWMd3feyE/uenx09VJpZd2cR1e6N3KizeQGHKSsKtx+fU049c+aSp35bBrefjGceKKtYGNg7mnoIpomcLjckBRL7CwwSJ8EDJDNMamRyA1aL/qv4H5t2mHmUp3TiQ+CHmqvusmgmoEL76FnNzIvZ3rJm+EAsS0rEPe5SQn4fOkXr3WGYWJhaSwGFvFqY0H+a0/6GTbe0oYcsgW15T/rhI6fF+QV+vcRS0ngWmvIB+0fd/nICfJ6tPMwWuOfupDckGVHzy8P8nmcAWA9fEOjzTakUFXmuCg0ocB6g+TXi1bLC7dDn3/zZ5SpRY3e3AewrDmbzEh52v2jAbrrhu2OmWnI0hWfEM7lYKZWj97+71u82JIj6LmyHwuipBVObMzK/KNfN7VLjZo6BH/xUkMFpfmylAUoQfelrXGU+Po2gaI2Kd/uN+Xbp2e0c8csi8Nb15oUVXljoOPPnOvxtmJq3idCbnPybs9 Gl1XTJiH oJ6728vZJVDlNW6bUVAUvxmynwLIAEYCvHPdaCICQXsPZaZkbLMZPrWSCMz4N6uEvzVBpnkt6lZljlf3nTmrBebIYZquvEa+Lf0rSQdFPrmOVdC1MBSqLkrDagPYX96qQOpFxV+9y3wVs36oDC4YZV1netz0nIG7gXHURtm7ORSMITXgM/P19NCZqdyJ+g9T91PpXGQ2Q6kKAtakPo/v+LlJbtl2F21VtKYktpo1RmerElDS2Lvbb5B2TmY8y7dmotNwg8w2aOqD4fb3+lwuRJDYzEOXPPBGU2avFwoC8worP8SHE90v7G9OCblJcuW5ch/4zWyFqjgi+Qupm8Rjr7jLuCYvdpjG2C54nuEX4GAsXZt8wIAUze6K6NCR5lg0Cy4Baqsmf8AF9ASNZqjJKYZRh+5Kjhbgt+TS/IliT/qz0/k21CshiQiVqMl8gp190hPuyd08rvuo5aOlHxMnBCVK9eMovWZgY3WsX82A3k3b5Ehx8BwTqbfuCubp9XyyNnPg+8aqKv4c/xVR2/WdkGRVWMQdmgjllLsQxnO+2Xtm29SJdrJQT25iqpV2TIJ/xO+yrwjK27d0EzUw5l4J0RfaBpUcpzyLXgInkDD+aQGAowhU2eu/6+y7KdFEkKoQwcz/GLVMbWekq50cwQNR/uwrLrg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.011935, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.02.25 21:29, Matthew Wilcox wrote: > I just wrote the patch below, but now I'm wondering if it's > perpetuating the mistake of not using our existing COW mechanism > to handle uprobes. Anyone looked at this code recently? I have a bigger rewrite in the queue: https://lore.kernel.org/linux-mm/20240604122548.359952-2-david@redhat.com/T/ That will do exactly that: leave COW to core MM. I'll respin that soonish. -- Cheers, David / dhildenb