From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86083C369D5 for ; Fri, 25 Apr 2025 11:04:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F41F6B0025; Fri, 25 Apr 2025 07:04:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A4626B0027; Fri, 25 Apr 2025 07:04:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E124E6B009C; Fri, 25 Apr 2025 07:04:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE9AE6B0025 for ; Fri, 25 Apr 2025 07:04:41 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 76C70160C33 for ; Fri, 25 Apr 2025 11:04:42 +0000 (UTC) X-FDA: 83372283204.07.2BA9F44 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 1A4DB10000E for ; Fri, 25 Apr 2025 11:04:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="STYEzj/5"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=vcUcscQb; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1745579079; a=rsa-sha256; cv=pass; b=Qo3gVyqGxgj1AAy6ZiAle2KoqButywOSDhoEXwcPCK7kmhN7CbVJWA02GJ+YX0aEnwKEW3 8ylHb883tlv0bXnmFLkl51x2DSJNsBCeiUb/PxfVs7HApjGc8avIwCzIDJ9oLAADtF6DuH cpZXMupygEolrY9mWVi95N7vvbTOURg= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="STYEzj/5"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=vcUcscQb; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745579079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ce/lLPiVFnM/6hTo5qGeVySHwKDAlrpbsIcEjL7tLXg=; b=WY0+1y2YMQmf6qntY/kh0/g29dlSaHTtpRkHUNCEa1kSoc49x3qCrET7BuNhXvfsdjETQM xQvpVD7S6Sfi8FG6n3gOgH00ljxhGlrWLyKlUny4u2DuJ4wHVtf41sMGNpnxayJXvGbM22 eprlyndM6EO+A17W1xa0q/fxxc6VsgU= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53PB205W031080; Fri, 25 Apr 2025 11:04:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=ce/lLPiVFnM/6hTo5qGeVySHwKDAlrpbsIcEjL7tLXg=; b= STYEzj/5xTsKaErr0Yi95NzBp50gMjWg1N0HPOqNIrigAm9a6Mzf3TLh9KZmiCKv NiijjcAYcOLMIIcapHnmF0Xaeb4gMc8yi3u5hoook1yI5vfhOAvkosp4klbR1+4T v0iGYp23aO2pLxrFDj3YVJCnn2Vyr5xUflyRfGyR/kJuJI8XbMhIBzwg9yVn1E0r h1I4ftXC1iugrS9mQfsgroq47d1YOStL6cnef2GlLMf0+ujAfFTLBrcPd2o+cbHz NnCPJADpq9CyiPGdcy6I/ojYCcC8IKWbd+5fbOzkJZIqG0mKQzYWeiW9EGxE6Dvx rUbqEv0jY3TpHJPcuevCag== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 46895kr15m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Apr 2025 11:04:34 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 53PAUnx3030926; Fri, 25 Apr 2025 11:04:22 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2172.outbound.protection.outlook.com [104.47.56.172]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 466k08fvwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Apr 2025 11:04:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zCqRuYnMBnXC6vfns92cOG6KVWUVVmOHKt1AxAAx1PfXbUP3CcpgTQRzPO9xB6LqHVCk6kIEV6Vd+KiHS7xncpjy26/T0XvoRxz7WoUv8S1Xv54ExJhfr1LS4jNI44sewYsela2ftJmxZztj8I8qxCRVwsI2Ni61qqheQ6xWvMSyhSJfjbeVo32Gxs9fAb0lNlq1F6BK1Fxv3IOqnoMKm39F1gWsBehgAzosFYsfWnVTpQ2APwjeAcXPUoP3U2TEo8N3CkCp0THvFtOjISOOVTiDSK2xkxHuZCHB5KkQ5bsGo7vn44Bu9TJ2FPG4Pa31uVlGHUT/4IpgI1M3+IvdfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ce/lLPiVFnM/6hTo5qGeVySHwKDAlrpbsIcEjL7tLXg=; b=gh85Xvpc/WMkQdaFggUGtJWJhj4Z3xmVg1dko6RiK6o1yr1OcvFDfx1s2a0vnaE1lgMxxMfln+YNZgCZXpj3pgpi0GrEfocCcHL/NLqV3NfBlITjx+wQR64tDjdIQZPKvW4YGTUcw+ZQHP5gEAacm3UQH3YfyGulK39ElIldDsOhXxZLhd0HIaGaGL/hDHlbf6SHA2eSkdXj2kut/LrQxy4Mlzl6+hgC/BucD6dK1w11YFp9UzFN5kcXmkhJHF/O7gHS374J56jftAl3qDqpmU/klOyUpqJG21e2j663nfuR3D5/IPvwO+e0I0Lvj7QjC3/kXZMdAwEWs1yoaKQ3sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ce/lLPiVFnM/6hTo5qGeVySHwKDAlrpbsIcEjL7tLXg=; b=vcUcscQbjJ2CNWeD8ZyogABhN8rhnDtUgk6sOWAvZ27FC5c47RsOXh1cBXd5rSfF5tU3LWUnMNtUKJ6eEGfiX8Eb2KhT/LqONNOZ5SIWIXjF26AfSCXTvhMgLgzDLOa7/UUWyKZFNq453pdUhJA2VCVcYtByyCjvGneW0FXanoQ= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by BN0PR10MB5205.namprd10.prod.outlook.com (2603:10b6:408:116::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8678.27; Fri, 25 Apr 2025 11:04:20 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%5]) with mapi id 15.20.8678.025; Fri, 25 Apr 2025 11:04:20 +0000 Date: Fri, 25 Apr 2025 12:04:18 +0100 From: Lorenzo Stoakes To: Suren Baghdasaryan Cc: David Hildenbrand , Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm: perform VMA allocation, freeing, duplication in mm Message-ID: References: <0f848d59f3eea3dd0c0cdc3920644222c40cffe6.1745528282.git.lorenzo.stoakes@oracle.com> <8ff17bd8-5cdd-49cd-ba71-b60abc1c99f6@redhat.com> <365487db-b829-47ee-8f5f-6cba873daae8@lucifer.local> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <365487db-b829-47ee-8f5f-6cba873daae8@lucifer.local> X-ClientProxiedBy: LO3P123CA0004.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::9) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|BN0PR10MB5205:EE_ X-MS-Office365-Filtering-Correlation-Id: 088a52a8-2844-48d9-1140-08dd83e8edda X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZUZqRG0remNkRENWczZWdTBDRXVqS0xlVmJtWFMwakIzRkNzRUFVYzBrUWRH?= =?utf-8?B?QzhNNHY4NHRmcWFldE56VFR1NHhjalRXU1lqSGIyV3dBTjR2QzI1MzJKZzBJ?= =?utf-8?B?VEMvRElrWHpzK2RDVGkzRWJRU2t6dGtjK1lyUlhYZVltSk9OSVVvK0l5dVph?= =?utf-8?B?YXJaa21rNnlvTjI4ZzlGK2tHMHk4dWlXQ1BXNWhYdFljVjZTbDNQbDAvZmVt?= =?utf-8?B?TytvMCtYMVd6MVFDaEJWaHdWWkdVdEZZcW80bGR1V2lobjRhUlBUKzFQS2xN?= =?utf-8?B?aExPVndpOW5kOHZFeU85QThsd3FmUUlzTUtha2lYRWkyWFluU0s0ZG5yNUNY?= =?utf-8?B?NzQzSGNjaWJiSVZPSHkvRDZXUkhsNUpEdU5xdmkwRzJkMzdkdUg5dVJ0UlVC?= =?utf-8?B?VXZLbnZSTUI5Y1pIWWFCQWk0TzFvTVpadjloVjlDamJOUjJ0M01rZ24rTFJI?= =?utf-8?B?ZDBuN0V5ZHIxN1BzUG1LSXp4aUZ5b0FMdUpmU0dqYXJpL2xRR2QyR0dpSEtL?= =?utf-8?B?S2RqVXlXbjFCNk4zZkphWGRsbEtycVFadkJ1ZCtyVjNVS0NiT1ZYd0h4b2xr?= =?utf-8?B?aFFuOG13clVaME5uN05yUjdQdFRvVytkWTZkbGVHenQ2L1hZVWVIWGdOODVy?= =?utf-8?B?KzFoWXFnR3g3L2huTTBwckNmZlpkV3hEa3FsUmJTcVlOcDB2UGVoN0ovTmhl?= =?utf-8?B?dEpheEJyaGR3aFNacEtOc21zVDgrdXJZcmVzTjlvQVNac1lNMnpZbTE2L1ly?= =?utf-8?B?OFE4bW16WHE0d2ZvcHlTNC9MSjd2TEwzT250WHZVNmRqK0dCR29reFIrTXdY?= =?utf-8?B?ZngycXV5VDRvWGExMUc3OU5EdmRJUnJjVnYrck1TQW1zNmZveGdzNkN1MTFq?= =?utf-8?B?VlRqYjQra3haeXdBbnVFY3phNTFFTlZIQ3Vlc1F5SWI4blN3T20wOFdQT0Qy?= =?utf-8?B?YmNHZlVVcng1N2NnMFlaSEY4Zko4Mk1zdUR0TE1vaEhsZFUraU52b2EzdXQy?= =?utf-8?B?Y25laEpGWVBobjFpRGM5aDlOUHhQQW1YWWRzSm5WaG9IMkFEZmNiUE1weTkw?= =?utf-8?B?RFVIM3lVdVFtOVYyMlBucWFaVWFsdys5U2NsdGVNY2JPd0c4WEJYNDRTRUlS?= =?utf-8?B?bWIxRWhlbU14TWtMTlFFRjRoWUMyZjFJQVAxcUw2R3RvVDBPUXV2Ny83QTds?= =?utf-8?B?aFpZaHhUeEZGTjRjUkUvd1pCQjYxWUJpNEJYUTROZ2lkWVVFMXRMc1hOUWdi?= =?utf-8?B?VUxmM0w1a3N1eWpISHA3NEFzdXMyQ2VRd3dIaUllSldoL1BldXdTMkNtZmRZ?= =?utf-8?B?eGc1bEpxSjRhTzZBVzZCMWpsZzhtS1JHakN4OEtGVkpqVnlubE5jdzFCdUxp?= =?utf-8?B?Y3cyQlRjbDR4d3RKZjFsaVJWSUFwRmc4VEJqdmVYMWYzT2VJYUhUc1hhQTQ4?= =?utf-8?B?dkVMZzIrWGhGbHpKR3BEdDR3YW9Rbms2eUNzVzZ6N3BLSHdMSWhERU1hcTRl?= =?utf-8?B?R3N5OElqVHdzZUxWTlcvZnFKbnhoNUswK0ZPcFQ5cGlsTVhVVUladk1zNmFz?= =?utf-8?B?aUpSSzNHMzhORi9vQklrcnUwNjdGQjIvZ1JEcDNuMzhQV2VEVjYwaTF5eEkx?= =?utf-8?B?dEZIaXZRVGpIbk9pQ0hPRmc3WjVwbEZma1liQzZ4a1h5YThLTnhmUUxFTjRC?= =?utf-8?B?WGREd3FaMlEzM0xxakY2V3pDaUFkU0M2VXUwb2JUV0tuUmI4ZzVIbWE3OTAr?= =?utf-8?B?Tyt6cE42cDVvR1JvZWFPSFpXanJrSHBZN3BrVjFPNDZNd2YxbHJsUW51UlV4?= =?utf-8?B?aVNOaUNHVzRZNlIxL090aHZKREJTNnh4WENGb0xLWlpBTUJQeFgzakhFem52?= =?utf-8?B?TjFLZm1iRFF1RHNwb3FaWEV0ajZ6ZFBBU3JFTDRZVU5pNlFicXAzbnhiTlhP?= =?utf-8?Q?kq/qcl2FwOU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7416014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGZhZUcydUY1ZHluVGloQXl6dGVxeWdWeG9ieDloYnNHUVJMaWliRmtTM2M4?= =?utf-8?B?azlvcEh6VzZzZlRFakJuaTd4c1JoUHg3aDY1RE9yK0cwQlJkdlI2R0ZqRkNJ?= =?utf-8?B?TlZDNlhqSW5zMTc4OGZkS09sbHJjNWhpVnR2Vk9KdllzMWxkNVM4TFQrL2c2?= =?utf-8?B?TlYwd0hKUVA5WjdNc0dRSW1NYjhubGlOUjhnb2sxRkttSFlub3FrVHVvQmNM?= =?utf-8?B?ZllWZGRWdmlOam8vblpjamNzL1NIcSt3V1lWQWZNb1pRci9xcTZLNjZaWGds?= =?utf-8?B?QmhwMnQxTUtNOG11RnZXdldWSkFvamxNdVh3aEdKc1FXVFF4YkFLRUFINWxS?= =?utf-8?B?TWFmbmI5SFFDbFJNTTUyck5NQy9rZngrYTI0MS9tYm9xT2RwUnBualljZ3dq?= =?utf-8?B?WnFjak9MMy9RS3FZVFgyeE1vWWV4aDNVVHV0QkJFa1VwTUNBRmc3SnZ3NDZs?= =?utf-8?B?MzR5aE9pODhWS2YzK2dJbWVwY3ZsVDFDcWxmTUFPZ1c4V2hZZXlGK2hZaTgw?= =?utf-8?B?czcwRHdZeTZHLzNHYnBjQ1Fod1lFV2Rha3llQ01wSDZaRXNpNkhrOHRzeWEr?= =?utf-8?B?Y0pNamFVeHI1SHo5OGF2dXVDeWJFWGI0NWViV2VOcGxXeWVucWZCaGN6ZVA1?= =?utf-8?B?dEFRYkd1bi9jVUxLVEo2aThKNC9PY2xqV2FWdlRmZlhxQkZ3TWRmYjNNY0xk?= =?utf-8?B?SzdlNVFRWkg1THdzVXl1TFZMWWhuSFhZUVZWWGpJZGxPNlFSaGpXY04yYS9v?= =?utf-8?B?VnFZQXQ2YlF1d1hWMytEZnhKQTNpQkpYT2lpbmQyaWN1YVVRRnRhaEJIcjdL?= =?utf-8?B?WVNzYWIwNTV0N3Q4Nk9yVEJ2MUpMNkpWbkxpanhya2pOdTV4WnMyaDRHUDVi?= =?utf-8?B?NWJ6bktPTUVndzg2N0JSbnMzWkE2TE1Vc09NdGFvdTVqTkZDVlVZRHdCbkJI?= =?utf-8?B?TU8xZ1RKa0VZMmZMdHBvOEJEN1ZaYit0bVFqdW5rbkV6c1ZWc2VEVlpsdXZs?= =?utf-8?B?YTE4SHJHRExSZlBCOEVoaGVIQTBzdnZicm1URTVKZUt3MG0wVTA4YkkxempF?= =?utf-8?B?aFJ5d0lMbXQ3UkZyWGNTZXJGWWRQdUhib3ZmaHBrYWhkRWFGYnhSdGJnZEkr?= =?utf-8?B?dnB0RjU4MzY3b3NBcWcwMVhmL1pQQUQvQlVLMnlCdWRPUWFIVkJidUJteG9Q?= =?utf-8?B?d2oyWUw0VlA4OU9DRGpvSGdPTWp2TXVGekFCK0NJRStWaVhLZWF2dE9jQ3Vk?= =?utf-8?B?RmZxekh2VXpQbmM2S0xRZ2RJWDNCZkVuMXBqTTlDL3d0dkt4M3A2em1kS1NY?= =?utf-8?B?TlRYQTBRZDczOFh1YlFWRmNNeTdtc0NZS0xrQXgyQ1U4Y0lqS3M1ZDNybXl2?= =?utf-8?B?MFhsNGRrWTlvT1RxdjBPSlBpWVJLSTRFQXgxYjgxOXd0RjZMZWl4N1Vhbk1k?= =?utf-8?B?am1CYUxnKzJNVGZwZThFa1dIM2dxTHFBR1Bud3pDNWlVclZKVDhkTUora0lh?= =?utf-8?B?c21sc29ha3ZXdHRJamFhSHpwbmt4ZTlraDRuQmxDUGdSVDVoRGI2MHQ0ZU93?= =?utf-8?B?SzVENnBzUm5JMjFXVXh5d2hEM0VBQm9oNXhTYWtVRzdEVU41TkNyQ25SdFFO?= =?utf-8?B?STFGZnRHK2lOd2t3cENHN0k4Q0ZDMWc2UU5USXVoRm9LY3hza0hhbGFaenRN?= =?utf-8?B?ZGRJbjZWajJDZ2hJNUpKNzFUaVBxdlFxREl4KzJPazVtSFl2S1QzT0EyOW4x?= =?utf-8?B?RW5xdThnTXpKajEyc1V3aFpkTnRrR1Q3eGhPUTJWamN6OWs2ZmQ3c2lQNHAw?= =?utf-8?B?NVdOVFN1dFk3TkJ0UFZMakxsalVnY3ZjemNtTXdiZ1QwVFlGUk5nQ1ZtSVgv?= =?utf-8?B?SUR2Z2NGYnBwbEFRTS9WZCt6MGdTRTVTN3lUTXhrMzZQSTNVZkxBdDUvbHVk?= =?utf-8?B?R1NQVXdDcHlJVDZKaSs3d2s2eG9JMW9tdUkyemh0b1E1Mncyc0tIUXlFcFNF?= =?utf-8?B?bnRaRHlaQ2dKZjVqQzc4MXE1US84ZG9hdk9RU0p4N3NneDRmdExEb2RQYVkx?= =?utf-8?B?QnlmaEU4akh0YjhpSWp5YUxCK1RkSWRWYmN2YTd1YW53MEZPRVF0c2ltMXFH?= =?utf-8?B?SHpiWS9tZ3BnNWN6dWVUcWtYMS9tcjRoYkFka3ltSlJ3Zk5kUVhzTGF3MjRm?= =?utf-8?B?cGc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KpOiut4wiwnWpNQdpHp8u8lsAAWA14FUgSu8nuOo8cWGuZivA4HBjJcrYC/5t1GN6QyYZeGzYUigZv5IjhFid/832NjYnstoJttNS9cR6PvkxktOiDgd6oPLPYzSmoscU87CKa0bGGnWYBnGVj1t9skbfg6F3/lHpUGxU8cJqMe0QRTbJOoMPLidk0TJg1txOpV1HCycZfPUobx4a73zAs5k+VaIGk8NYnGi16yeJWLiPjxWgo4hLosOe4JYlIqRAbPpEaTmTlIanIi2T9+RjMXeclQE106HHIlUDc6buXDa+SeasJrO2GkeznYfJdjRqeOAs/KHknxBgC/FKcw4/irKpWpx65TR22LM71H7xiT4sG3NYiEd19yNzP9pqaE/i+VudsD4ImI7bDHaMEhJjyAMZkpClKsKnbaJfBHFKxEWiip6wk6MGc3JFddZdqC/qMoRMj7VZgg4juEGL2vmpc41QXKVImFwkE/ge0XI4x2BSO2MJ2P3TxV5CgRnGV96Iqch7KcCVS4YYZcN5b8tOeO+T7UntW5Rnix+O+YS69K9ljZCLbbvF0oURcrD3sl+0vVqmQvX4285vAFRBwGERZjYr4Z5CWo6j0Ibp/ZQcVQ= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 088a52a8-2844-48d9-1140-08dd83e8edda X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2025 11:04:20.3253 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7IB2EIVd1NRlq/+LfgFOK98rgF/Kc56ryePUSBOKz0hCimcj2RtOMx+qitpo8qZxs72SiFEYPcwzey/d+A7f8OgiTwjLr6c+ut7+usJX7es= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5205 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-25_03,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2504070000 definitions=main-2504250080 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI1MDA4MCBTYWx0ZWRfX9qMoX5mMlqj6 tLFBJZTD92NU/1Bkr9L9FFCUZhsXp5gTJAnjsq6380YOF27BbM3OEt57Cx7+iQsooTAIR9vY4ii H33IDSiR8zE7Zw0FPRRsXX+MC2kjxr2wgoIBroYegqcfDS38RzCGe3/38AeRpRcoanCbim+Zu5J vc5c01XQXwMFI0UkEMwfCNEjw5DLop9siKuQBaPXn0g19b5SCxaigLrLUoVsYUkhxcAsIdMFupg UnekO4003zyv+Dj7NlL6h8cX/Ra90e1nNHSsSjqb7aNF7F7kIKauBqHFVHejD9s0smwIG7iUI1b iGAOdj3bq9PmxLN4SKvH+lTMNViNBm7tlL8HcgfpDu/BltZA8Rp2nBwJyIoLpwRu8AvYiLN32fL q9Z5F5Gs X-Proofpoint-ORIG-GUID: zSHD1jy7_jy3pZhNPJqmzE3H-KqbwhjP X-Proofpoint-GUID: zSHD1jy7_jy3pZhNPJqmzE3H-KqbwhjP X-Rspamd-Queue-Id: 1A4DB10000E X-Stat-Signature: tcc8ktxymak8ibaup8kk3oyd73kwc66i X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745579078-220040 X-HE-Meta: U2FsdGVkX1/hZyHwxZkw1NyTIZLrtdMCvpUMyCXVFKLJ2PVgIovUR7zZcJoIBzq06pIsMG3nGRC0q95KGOX43AsBTKXh0qKaiSnCjZ+w4UO6kpLAl9i8a288O1S8xJ88cXuxYP2GEYRG0QOf3fHhEqpHnFBEnQkB/LtgnU9GZprefWiDwgBc3Y2I+y+ItB5LZmiWlTmXDFmkfZG+1bbmuRplyhOZXcrYLl/PVgcsAbmHa5+8GhAHEKip++aZVOErI6DYt+t3IF8EBGrvsMOlCvGzPfmOeKwvfLm1h2LL+9jTGDgSV1FfVa45VuY7FHEnod8qo8NXXhqq4z5KQikXxcLapVZFoJ/nMwWqh0AYdCu9knHHtXPRr21OQAIYltcuLubxb8tQStNBa3i6RVsdtlP5BbhKAG6X4lleda78w4gl8hFyUJ71GJzjB/Zsu62HTzb3Xsv2dk78yPFomOtT+XrRvNuroInUAYRrpmisL25e4wmIS1q0GhjVB6fYnMr5r+QSXx1xQlL70RASE05gKMhbdRKHZzHPCV87asIJkvwbgNoVj1noG6bDj87ZpFoEVV2aREnFS4RB/z8Mgvp/RSNCae3N9++hC0P13ZnyOh7CH5hgiHqjF87Xoy9D5dxwm6vQwJlziX3+dpbrcJEdLzJdaq1/fwHEgPeomcDaQmNuW+URaN+CNN5UNR6+D9Xd8s9NMznGGVbfZgG7WdHyn3r8H8NrkODAOmxvs9/J6i5kxXmZbPa9dd8teFhPwnCBof19zguy4UIxQUset5M6mkPGHSlgNwhj4Ruuziuu60fO4oqyO6F9SSszvPkOb1Fkz7382uEmpjijmbrxsQCsMh7DVIwHyvQM6i7cX3Yrm9u6OwGa2RafR0sUJFQD3FqkcxPA29t0f5UZEofBn/vnfwK1ogUCP6oyTxnyFOo4lRULxcg57J+Quqx5Pc16up94FWaVW58KdCWuy70feAe i32LPyl0 zOUCppL7TcUuBkxJtkuXU3riHy29bm5ChVxLQvkvNdwZS0i4xo0X5aUkDPAwTL08EuwqzQwafjmw1M+YcTLV65A/v5+DBEfsofNWX/Q6VNdkKH+B6WIkggUOZdiRGb5zZJd4ftQrM+0vfykhMuYssujQnS1MUL3p1MhahcSIvzV8im0mnbdsMOWzp20wQKn+XSagTN1RtvSHfilqQqycQENPv0U5+0OAJw19chgYjtwWJmZrySazySrIREyN9BqGZiAKbJmDHWBujOqReODCSmKMGHLTVPwZHYw1lcFgnthr0AvcEyitDXoD6xMyAYwzHMaxH5ParrmhPxcjWIlYFfwi7tQk+B7XlWqdmTlV9c5W2vl4D1/GXOjfOCQezxRGP2yXMX7Eb7gqWebgV8eCAw+7TpXKI4jgTGPHLdWBh2FGoJUC/sZJ2A+SKy4V3dO9/eX2ccuvpbkN8aSD63rhJib77Mhm+lLcmm8fmlian9Q9VDouyGAeClLUFDaBt0AqlD/JOwHDZecnYEzPafuJQWCpr6VmqMXDmp32Tk/uIrzvRTB/UjrwcAGaOx2KvmlAGSM7D5vrstzqUeanfpytMGg7cdBEVLObkbYnlkgP0mHWAVJ40ausvJ+hn/n1rdu30rm1y+RZy/gtd62jta41OoU1R0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 25, 2025 at 11:10:00AM +0100, Lorenzo Stoakes wrote: > On Thu, Apr 24, 2025 at 06:37:39PM -0700, Suren Baghdasaryan wrote: > > On Thu, Apr 24, 2025 at 6:22 PM Suren Baghdasaryan wrote: > > > > > > On Thu, Apr 24, 2025 at 2:22 PM David Hildenbrand wrote: > > > > > > > > On 24.04.25 23:15, Lorenzo Stoakes wrote: > > > > > Right now these are performed in kernel/fork.c which is odd and a violation > > > > > of separation of concerns, as well as preventing us from integrating this > > > > > and related logic into userland VMA testing going forward, and perhaps more > > > > > importantly - enabling us to, in a subsequent commit, make VMA > > > > > allocation/freeing a purely internal mm operation. > > > > > > > > > > There is a fly in the ointment - nommu - mmap.c is not compiled if > > > > > CONFIG_MMU is not set, and there is no sensible place to put these outside > > > > > of that, so we are put in the position of having to duplication some logic > > > > > > s/to duplication/to duplicate > > > > > > > > here. > > > > > > > > > > This isn't ideal, but since nommu is a niche use-case, already duplicates a > > > > > great deal of mmu logic by its nature and we can eliminate code that is not > > > > > applicable to nommu, it seems a worthwhile trade-off. > > > > > > > > > > The intent is to move all this logic to vma.c in a subsequent commit, > > > > > rendering VMA allocation, freeing and duplication mm-internal-only and > > > > > userland testable. > > > > > > > > I'm pretty sure you tried it, but what's the big blocker to have patch > > > > #3 first, so we can avoid the temporary move of the code to mmap.c ? > > > > > > Completely agree with David. > > > I peeked into 4/4 and it seems you want to keep vma.c completely > > > CONFIG_MMU-centric. I know we treat NOMMU as an unwanted child but > > > IMHO it would be much cleaner to move these functions into vma.c from > > > the beginning and have an #ifdef CONFIG_MMU there like this: > > > > > > mm/vma.c > > > > > > /* Functions identical for MMU/NOMMU */ > > > struct vm_area_struct *vm_area_alloc(struct mm_struct *mm) {...} > > > void __init vma_state_init(void) {...} > > > > > > #ifdef CONFIG_MMU > > > static void vm_area_init_from(const struct vm_area_struct *src, > > > struct vm_area_struct *dest) {...} > > > struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) {...} > > > void vm_area_free(struct vm_area_struct *vma) {...} > > > #else /* CONFIG_MMU */ > > > static void vm_area_init_from(const struct vm_area_struct *src, > > > struct vm_area_struct *dest) {...} > > > struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) {...} > > > void vm_area_free(struct vm_area_struct *vma) {...} > > > #endif /* CONFIG_MMU */ > > > > 3/4 and 4/4 look reasonable but they can change substantially > > depending on your answer to my suggestion above, so I'll wait for your > > answer before moving forward. > > Thanks for doing this! > > Suren. > > You're welcome :) > > Well I will be fixing the issue David raised of course :) but as stated in > previous email, I don't feel it makes sense to put nommu stuff in vma.c really. UPDATE: As per discussions with Liam, will be going ahead with an alternative but equivalent approach. Thanks to both of you for your suggestions on this! Cheers, Lorenzo > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Cheers, > > > > > > > > David / dhildenb > > > >