From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A7DC3DA7F for ; Thu, 15 Aug 2024 17:10:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 855238D0007; Thu, 15 Aug 2024 13:10:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 805BA8D0002; Thu, 15 Aug 2024 13:10:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5088D0007; Thu, 15 Aug 2024 13:10:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 446FB8D0002 for ; Thu, 15 Aug 2024 13:10:17 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EDD651A1733 for ; Thu, 15 Aug 2024 17:10:16 +0000 (UTC) X-FDA: 82455118032.09.07DAC24 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf28.hostedemail.com (Postfix) with ESMTP id C9F19C002A for ; Thu, 15 Aug 2024 17:10:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XWUHHuYV; spf=pass (imf28.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723741717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wnlkNNJ+ob5CNDw8HCvYDtkEPjIKJqZQiv6kYJ2jfgs=; b=bl5Rs0x9J2zbakBLfKErtOuEib3iRvTBea0PzHhtr7OZYpTuW7JriHBcGNvQk008pQt+1q BxPDFYKPsNx17x+z86QFYxTdqhO0JXNKZ4krBbOc81LcikOUTqbwlcQSGYikI/JWT3aRIS dmKYVJ2XZAfcOCuYqLIZYqIU1Gdq7h0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XWUHHuYV; spf=pass (imf28.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723741717; a=rsa-sha256; cv=none; b=iUfZ5mSFDr4g9x0/3uONv+UjWPTkZAddtsiozd03XNwaw+/17YCEk4seuuCLnK672FZy8F KtXOn8ww/VbZQC/6goxo2SNhld16GOqo872pG/kDaEkvGXLERqz7ub8rtl2jAgptSggZbC gVFpf7LC43y0siBDjjF5HCX+hOkthzw= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-429c4a4c6a8so8028055e9.0 for ; Thu, 15 Aug 2024 10:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723741813; x=1724346613; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wnlkNNJ+ob5CNDw8HCvYDtkEPjIKJqZQiv6kYJ2jfgs=; b=XWUHHuYVWSAOp3INzD1+iNlh1zts/VE22nkdEFxaGF4c1rNUc1mi1MuecZ92eYT/yv WU8iGalbg8nYNR9Xoos64BGlW5PfLrR8x1nJXQ9pkBybGI9TlgppSqgbkot6kScNt9pN gTEwTtWkwIw2HGqxFSqPxa0SFIJz7eXMO6QC8lSRVaMaCZGnLAaEhS5b4XI1ZIWf2IKJ sschNrk3EL87+gcTabOIi6zDexcs8d4/DX6nPyRtxj2+EQTvsZXzBOKZfqPVmC/1fBA8 gus6UVJBnN4L9xM+KTUg867uhfmDd8Sjg2SUk+yMhNb/Zjk2UkDFgErKl2P3g+fJ94yL nfvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723741813; x=1724346613; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wnlkNNJ+ob5CNDw8HCvYDtkEPjIKJqZQiv6kYJ2jfgs=; b=VpnRIGVdizI0655OqTzNR3Tbkct5feIyNs6SFMQmp5GAFxC/L4pxEuQRGKB/v9fHTR IUM0JBBEpAA09ddFdXoTddLYD06bOOll8zILUb+iC5yc1uQ+BgB4DZrli4tDsMEmF4Nr PMfcPvOw5VeNp/5OPcKYQ7PtlC186NQQN6lxORL77QuW01X6r7Ky4CPkWtPR3dvXWsB8 U6FD4vb45VtB/u9laRlc4H4xWPMggAsV//RTr9YaWhXNoCOR2hj3u0BGTQXIVwdltPYV OWHSVuVNJg6scvRz2/ASG6Ci1a71xE2eh6XWP87uf7ZG1yGJxsF+s9iMd2JjVhnunOgY LZJw== X-Forwarded-Encrypted: i=1; AJvYcCVcBwm6JsAa5c1BVx76t4fEe9iW7qf13IIBQiSC+OsPmBJrpwZEt0kwTj13Qaj23AmrKL4otNfbRmfsU2b/oDpJTZg= X-Gm-Message-State: AOJu0YwYdUFCMYK4lXbznkX9fQVL3QFvhTYFYfIb+rxzRty2VWHQhiD6 tedVX39BW6WYw6RgF4q72slgoWeEaH+TzXlsYbOCarlphKDohqMd X-Google-Smtp-Source: AGHT+IFsB9XVZRB/XlsmdxaIb2xKgI0gDo3TvDW+JOSBryKjFBmMM2yfbb7n3rGPDerRr1UCxjYxDQ== X-Received: by 2002:a05:600c:35c5:b0:428:1a48:d5cf with SMTP id 5b1f17b1804b1-429ed7ba070mr139315e9.9.1723741812979; Thu, 15 Aug 2024 10:10:12 -0700 (PDT) Received: from ?IPV6:2a02:6b6f:e750:7600:c5:51ce:2b5:970b? ([2a02:6b6f:e750:7600:c5:51ce:2b5:970b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed650e21sm341915e9.20.2024.08.15.10.10.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2024 10:10:12 -0700 (PDT) Message-ID: Date: Thu, 15 Aug 2024 18:10:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] mm: Introduce a pageflag for partially mapped folios To: David Hildenbrand , akpm@linux-foundation.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com References: <20240813120328.1275952-1-usamaarif642@gmail.com> <20240813120328.1275952-5-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C9F19C002A X-Stat-Signature: bhg8szz9y4qqgdf7sgghf5knzujf8ig7 X-Rspam-User: X-HE-Tag: 1723741814-370357 X-HE-Meta: U2FsdGVkX1+xCpjLFancXF1t5LOhg+Lg2s9rJgbmPWY9I3VEx1WjbPO13FQ0L+yUmO+EGmA0TyHs0CkTA8OQg7bCAe8Z+pxyn3z5yu6pvlEEdEtCwyTCPHHjv1ChqLGNzwFeRhvEL98o9wilOpdXpGlD50LpL1t0+yfHasojSKVzV2LHx9gmwPpmgNohmZ5MiDuytuBS/BqxvuBQesDcw22IB0AgihKU/mMSqqWOx5PvFS5VRWPffX0IfNTKJ/PHTwOcqhE+C/++xI3wtq6YYuG5XF2kMRt+BWGzvQBE/KGyxLzoxQrLyAu2534koEUrfoJXXCpVpxe7+n+Dv2zWI/xa1pcdtnOW6Yzt3fa+RyGUXzV3bb0uHaAyvMgJHd5RWSgXSwFKrm7W0DQ19La9sW3uvPl5Jb+BMsJXpryHLPGDTPGcdR0pYQQLGVAoHRko6+3WnbhWG1g02hx65WzHJHQMx1ACFtJm7tm7O77H1vTn6SD9GdxTTL5rWn7cnXdF6OgiQTae4jZ6g6zOvWOVskP1v25+AdIrvBx9K1svZ01Ez1o5/x11+Eq3dw5bV92NOqwQ3DOjdcstCNdrpA9yXt6t+6q0VUSZaWOQqKg9ja0dEiTyhI+UISuonMoPa3CUMV7vIDxIDvk8CC42Jfhh9VM6V7TAfJhnBiEjPlHMhzwS7W0DqR2uvnFlX5rk1ftUihRPwo+zr+8weKu+UJm8T+LU57WjFjZGYURmJZCysCGXExTvVRxEUGZbMWONNFdzmTNZsIFn3Y+4qDMHZC04sWqqFNoYIkjz/yBZj/I5CTa3qWoXXBpRSAa1ZM3ngTl7qP/8hJewepWnjYiTyxl+ImP1geExtUmpn/ydlRmglqP8JXpkbgjlRTRS64oL/HSuh1epw6E0OXE+/HuiFdO+lHJYPnpe2C/GItfex/QCrWknf19qH1kof/5f6DXSH3prU4/QTTA0da6EQXrQnDX lcYg2HH2 e57jU1CR8x4WNODv6q47l3+GhsjJcKXDdcBCPdxj3h50SgIO5dOV0PHoZawo0UXZJlOzXzOCPC9njEPPiHehbKkeZJVJI0Msx0+/O8qGRyMx7W+LZFc2WQlklBSopjsYUbxKhDLHhc2FGsekQdrQcHVMqXnBwX6Zh89mJb4moaiC0OiSW39lFjlzGC426mPD4goGRgY5JlzsLrBC392qSNCy3R6cBMoWA7ENQp2MUDvPKOcI8ZOSFm5E+ubo7/rkM93aE1zsoWu+H6emK/32ne55gQ1KUA9uVrQJMhdDu5KbJX9VryfOnBM4VMcGqmSsx+o6NwK/NhqUN7jYjxz6bsO71xwXmK00Ey6acJOCna255KojqIN2qaAttGxL9oHNMWPyrjr6j2M2+xQ/RPCjpv6kGZcsg/8/9Dj7vFRoJhD33+RPCzXzmq8z40sy4XI3gdJhS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15/08/2024 17:33, David Hildenbrand wrote: >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 6df0e9f4f56c..c024ab0f745c 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -3397,6 +3397,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, >>                * page_deferred_list. >>                */ >>               list_del_init(&folio->_deferred_list); >> +            folio_clear_partially_mapped(folio); >>           } >>           spin_unlock(&ds_queue->split_queue_lock); >>           if (mapping) { >> @@ -3453,11 +3454,12 @@ void __folio_undo_large_rmappable(struct folio *folio) >>       if (!list_empty(&folio->_deferred_list)) { >>           ds_queue->split_queue_len--; >>           list_del_init(&folio->_deferred_list); >> +        folio_clear_partially_mapped(folio); >>       } >>       spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); >>   } >>   -void deferred_split_folio(struct folio *folio) >> +void deferred_split_folio(struct folio *folio, bool partially_mapped) >>   { >     /* We lost race with folio_put() */>            list_del_init(&folio->_deferred_list); Was there some comment here? I just see ">" remove from the start of /* We lost race with folio_put() */ >> +            folio_clear_partially_mapped(folio); >>               ds_queue->split_queue_len--; >>           } >>           if (!--sc->nr_to_scan) >> @@ -3558,7 +3564,6 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, >>   next: >>           folio_put(folio); >>       } >> - >>       spin_lock_irqsave(&ds_queue->split_queue_lock, flags); >>       list_splice_tail(&list, &ds_queue->split_queue); >>       spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index 1fdd9eab240c..2ae2d9a18e40 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1758,6 +1758,7 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, >>           free_gigantic_folio(folio, huge_page_order(h)); >>       } else { >>           INIT_LIST_HEAD(&folio->_deferred_list); >> +        folio_clear_partially_mapped(folio); >>           folio_put(folio); >>       } >>   } >> diff --git a/mm/internal.h b/mm/internal.h >> index 52f7fc4e8ac3..d64546b8d377 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -662,8 +662,10 @@ static inline void prep_compound_head(struct page *page, unsigned int order) >>       atomic_set(&folio->_entire_mapcount, -1); >>       atomic_set(&folio->_nr_pages_mapped, 0); >>       atomic_set(&folio->_pincount, 0); >> -    if (order > 1) >> +    if (order > 1) { >>           INIT_LIST_HEAD(&folio->_deferred_list); >> +        folio_clear_partially_mapped(folio); > > Can we use the non-atomic version here? > I believe we can use the non-atomic version in all places where set/clear is done as all set/clear are protected by ds_queue->split_queue_lock. So basically could replace all folio_set/clear_partially_mapped with __folio_set/clear_partially_mapped. But I guess its likely not going to make much difference? I will do it anyways in the next revision, rather than sending a fix patch. There haven't been any reviews for patch 5 so will wait a few days for any comments on that. Thanks