linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan.kim@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mel@csn.ul.ie>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Bob Liu <lliubbo@gmail.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Minchan Kim <minchan.kim@gmail.com>
Subject: [PATCH 6/6] Add comment in alloc_pages_exact_node
Date: Wed, 14 Apr 2010 00:25:03 +0900	[thread overview]
Message-ID: <d74305233536342dfeb1ca7ffe9e83495ce1f285.1271171877.git.minchan.kim@gmail.com> (raw)
In-Reply-To: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com>
In-Reply-To: <9918f566ab0259356cded31fd1dd80da6cae0c2b.1271171877.git.minchan.kim@gmail.com>

alloc_pages_exact_node naming makes some people misleading.
They considered it following as.
"This function will allocate pages from node which I wanted
exactly".
But it can allocate pages from fallback list if page allocator
can't find free page from node user wanted.

So let's comment this NOTE.

Actually I wanted to change naming with better.
ex) alloc_pages_explict_node.
But I changed my mind since the comment would be enough.

If anybody suggests better name, I will do with pleasure.

Cc: Mel Gorman <mel@csn.ul.ie>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Bob Liu <lliubbo@gmail.com>
Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
---
 include/linux/gfp.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/linux/gfp.h b/include/linux/gfp.h
index b65f003..7539c17 100644
--- a/include/linux/gfp.h
+++ b/include/linux/gfp.h
@@ -288,6 +288,11 @@ static inline struct page *alloc_pages_node(int nid, gfp_t gfp_mask,
 	return __alloc_pages(gfp_mask, order, node_zonelist(nid, gfp_mask));
 }
 
+/*
+ * NOTE : Allow page from fallback if page allocator can't find free page
+ * in your nid. Only if you want to allocate page from your nid, use
+ * __GFP_THISNODE flags with gfp_mask.
+ */
 static inline struct page *alloc_pages_exact_node(int nid, gfp_t gfp_mask,
 						unsigned int order)
 {
-- 
1.7.0.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-04-13 15:29 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 15:24 [PATCH 1/6] Remove node's validity check in alloc_pages Minchan Kim
2010-04-13 15:24 ` [PATCH 2/6] change alloc function in pcpu_alloc_pages Minchan Kim
2010-04-13 15:48   ` Mel Gorman
2010-04-14 23:39     ` Tejun Heo
2010-04-15  1:31       ` Minchan Kim
2010-04-15  7:21         ` Tejun Heo
2010-04-15  8:00           ` Minchan Kim
2010-04-15  8:15             ` Tejun Heo
2010-04-15  9:40               ` Minchan Kim
2010-04-15 10:08                 ` Tejun Heo
2010-04-15 10:21                   ` Minchan Kim
2010-04-15 10:33                     ` Minchan Kim
2010-04-15 11:43                     ` Tejun Heo
2010-04-15 11:49                       ` Minchan Kim
2010-04-16 16:07                         ` Christoph Lameter
2010-04-16 19:13                           ` Lee Schermerhorn
2010-04-18 15:55                             ` Minchan Kim
2010-04-18 15:54                           ` Minchan Kim
2010-04-18 21:22                             ` Tejun Heo
2010-04-19  0:03                               ` Minchan Kim
2010-04-19 17:45                                 ` Christoph Lameter
2010-04-20  0:20                                   ` Minchan Kim
2010-04-19 17:38                             ` Christoph Lameter
2010-04-19 22:27                               ` Tejun Heo
2010-04-20 15:05                                 ` Mel Gorman
2010-04-21 10:48                                   ` Tejun Heo
2010-04-22 10:15                                     ` Minchan Kim
2010-04-21 14:15                                   ` Christoph Lameter
2010-04-21 17:06                                     ` Minchan Kim
2010-04-13 15:25 ` [PATCH 3/6] change alloc function in alloc_slab_page Minchan Kim
2010-04-13 15:52   ` Mel Gorman
2010-04-13 16:01     ` Minchan Kim
2010-04-13 16:14       ` Mel Gorman
2010-04-13 21:37   ` David Rientjes
2010-04-13 23:40     ` Minchan Kim
2010-04-13 23:55       ` David Rientjes
2010-04-14  0:02         ` Minchan Kim
2010-04-14  0:18   ` KAMEZAWA Hiroyuki
2010-04-14 12:23     ` Pekka Enberg
2010-04-16 16:10       ` Christoph Lameter
2010-04-18 18:49         ` Pekka Enberg
2010-04-19  9:05         ` Mel Gorman
2010-04-13 15:25 ` [PATCH 4/6] change alloc function in vmemmap_alloc_block Minchan Kim
2010-04-13 15:59   ` Mel Gorman
2010-04-14  0:19   ` KAMEZAWA Hiroyuki
2010-04-13 15:25 ` [PATCH 5/6] change alloc function in __vmalloc_area_node Minchan Kim
2010-04-13 16:02   ` Mel Gorman
2010-04-14  0:22   ` KAMEZAWA Hiroyuki
2010-04-14  0:33     ` Minchan Kim
2010-04-13 15:25 ` Minchan Kim [this message]
2010-04-13 16:13   ` [PATCH 6/6] Add comment in alloc_pages_exact_node Mel Gorman
2010-04-13 16:20     ` Minchan Kim
2010-04-13 15:32 ` [PATCH 1/6] Remove node's validity check in alloc_pages Mel Gorman
2010-04-14  0:04 ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d74305233536342dfeb1ca7ffe9e83495ce1f285.1271171877.git.minchan.kim@gmail.com \
    --to=minchan.kim@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lliubbo@gmail.com \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox