From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A11BC3DA49 for ; Fri, 26 Jul 2024 21:46:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE7B36B0082; Fri, 26 Jul 2024 17:46:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D977B6B0083; Fri, 26 Jul 2024 17:46:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5ED26B0088; Fri, 26 Jul 2024 17:46:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A80C96B0082 for ; Fri, 26 Jul 2024 17:46:47 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 50D2A1A0173 for ; Fri, 26 Jul 2024 21:46:47 +0000 (UTC) X-FDA: 82383238854.25.50056D7 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 2A24080013 for ; Fri, 26 Jul 2024 21:46:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=s1zeGHlU; spf=pass (imf02.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722030355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TlhKPvCXZ2wElRTCBv/YFUrEL+eyae5eBT+lyjEKXCI=; b=6wbwxEiJD8BW2iae/fPhTcwl6TjgUeouluZ04XkgPRjzXw/9FDs5q8H1FGgejV0O9CmhqQ 32+kncxzY5gjGIbhC1LJhpsEAnsMHkcx6EcTmJ8fIxowzIt5gjSy3EF1w+2mqd4lyccCo7 NkGUGDJRlXKKG0Q/LYx7XG1PMxs1JSY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722030355; a=rsa-sha256; cv=none; b=xSAwybth3KHrcbjLJlM7J0Iive7Gy6qJijRtgA9b2zmUPuRxbOLybJ8ZkErSnQYMXn1d/M 9vCh0D/zpcnmrtBhT2enRA0Gxzk/7ridVDYFELwRw+bdngKL1rARI3GlRwMezr+coq6lU5 BZrxKsqs/E/jFz/NGlIfe/4um7Cxkaw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=s1zeGHlU; spf=pass (imf02.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.172 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-6e316754f65so82731a12.3 for ; Fri, 26 Jul 2024 14:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1722030403; x=1722635203; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TlhKPvCXZ2wElRTCBv/YFUrEL+eyae5eBT+lyjEKXCI=; b=s1zeGHlUSUPKST26orbyLlIxwPnE8V4pjDn4zRqdo1ZdMFm8jcmFGBC20nKjgICZmA KdQ9MX9DN27ngCHPAMZ4/VfN5W4ymxzh9ATCfo3GID7Oq3OIDjTeavy77thOwr3XrhUn nLWfa7KUPvcLgJ+kbM6267LgHqZ++QQJ0E2qCrnmrfK4MUqyzZvybkeqM9aZYZM6yVqo Q5RVVKdsupaU+2qphtPlKeE2+xb8fYjBsrNlfFnJny8EHMlZ/8c7gqwvfRIc7fcqM9Mv XIJET0LnxE/vMLktIfgNvVZR4y+L7dhlcWU3Z1097UUCozWFfU15Pg51Q2LtpVloadiL Cxqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722030403; x=1722635203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TlhKPvCXZ2wElRTCBv/YFUrEL+eyae5eBT+lyjEKXCI=; b=DhG/t6ZsJrvKduCFtD+9JLbbBV0aoyM3J9Sz1hingzLdlC0HqgWDg6TJfYUEkMA5SH jTVK27/p7qwlGJ/CAwEmFC2u5MIznq5ArMvILTMlDTaXU1CENM2A2cU9eBdiBxMp0GlW 8ZGvjWfPAzh/hrH18XWDPuYPYmxjIxefPkUmB6vb24zgFFiMzM6EMB2UUA30LdfvPFd0 rDuV7WkkA2dT+KKJP/d3lPl37sxD9a/MretY9gt+6EJIsDq+TuqnMjrk8EbP4jEuoohc crXJkzK2RD2mpX2pBY5QXoTEATlkKzN/EJPPTuNGo5OJYWPyAAZvGBSwI8PPebzC71Jj ig2w== X-Forwarded-Encrypted: i=1; AJvYcCVfyU8ATw0CTp5EOI4VQDCrqgocT+JWFkvLZ/2xmEVLVtSjTgSFkQDHfrBzGwSFY0VqvaJs8pvf3g==@kvack.org X-Gm-Message-State: AOJu0Yz9SRGg795RcRt5yabA4f6fsva/xXPqEiR1HBCXjiea39ZcGE5W 0Dnk+mFo0ypJVrXomQ9zL9+YP9T0Lrz7vD8qjaw50zLBMNGEivelvP7jftA3+pQ= X-Google-Smtp-Source: AGHT+IHGwtBo/qH3tT7DlAHVbb8azYkmAsAKECyqzxQ8mGgtGWJBjAW/jHuwtZ8+veNJkacFfDZIzA== X-Received: by 2002:a05:6a00:8592:b0:706:aadc:b0a7 with SMTP id d2e1a72fcca58-70eac9a15c0mr4737841b3a.1.1722030403481; Fri, 26 Jul 2024 14:46:43 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7a9f884997bsm2825761a12.43.2024.07.26.14.46.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 14:46:42 -0700 (PDT) Message-ID: Date: Fri, 26 Jul 2024 15:46:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: Linus Torvalds , Lorenzo Stoakes Cc: David Laight , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2A24080013 X-Stat-Signature: kiiwinqko3yp1zcjo6d7xg3edrebcr8p X-HE-Tag: 1722030404-953576 X-HE-Meta: U2FsdGVkX1/uFxf0869MGkQiaShnYQh8Du/eEAatvDs77bqdtwJ3iF1Fto4EtoBgeWBWQbB61xZQ8XGLW9wjBqHJg4AfnTYlrSYKrjifi6vA6srmsM+PO80xXmV4PTPCECY4MZXK+6RK5qrpFRDJ54BGvSwq6kxNdzlPyt+Tdo6jccLDZ52wgqzGdyXFFkp9LCqaikNFAlbZJnGSleVUhq6XoSX/HFHcZKo/BYiONs/xcnYnCo11jq1KKymG52oRZPB9APwRJbmtzOlDIUlJ3NN1OzrNkCeUFOZnwfiCx4ZHsc350NgA5WwHrecr99JSTmGNr3y43xD9ibw/UyY08MFD42bY4QHz8GtDJoXiTova+qSNxVLv6nFSDRWn+jB4+pN8aH3sPy8hE4if3fRFZvtoOze0jqWFYdeZiLz8/dxwxuhbTI2EiJXwBAf/J8n2RESWO+/9qrA+dSVpNRNxVfHioMAeyab/yux96z8TlFQVlcVBjf7BN6a8KGKTNgU7foqRo+YCuVUJbTK6vby4oeZP7qOErInGT36UYRyocQtnwZVNcf4lVNNkGRcvWB5xxzmiOs15ly8CYaYr4WgBrQMwsStFzEmYt6MzH0BF5DVU2HbUMAfw8t1K01x77q8zi9h+iXJh6m5k2thDJnZPCl27abKxyNA33Q/p2/E6V/Z8TAp9XWfT+IT5vMeSqooXO0yAv77MHj9pYeLnOG9JseAxTZmehllZ8EqnGgtYLGCfigmObgTMsEX3kb+l9aubgDhv0WOErzLMVlIaX9QldUd4RIqZTERkddSTvOYb5YNmsiLwd9oTr3X8E8srDJqvZaNn3ok2Xg1HiTilaXqR3A7SYD9T8Cw6Br9daHsu1JbZKKfsHZ/7/KTOrGTyvMyM7KJWkkzyS63CcBAacf221Orstxu68DLmuKyiqBQLp9/Nc8VnmLX7dcKkCZ4DSFuQVLYBWD2TJUWZ4k54YiM KwivrbNo c78D4wcnRZkrGlrfRPi16AKQPsdGo4ZWcLV6/u+cI6r4WiYqVRUyEuFLeQeyfxSx0XqIbyWeKxc4oSdgOlzXhzcYWkAjoF5ORI+EWizmcDBtwgMyzO9wvAtY6wpsLzOtMVzPhwfBZ7Jb7+4LpTRHmrezKpws8fTGDtvytjtVlkE9nMzM+bgCOd+zR/qtYcIUycjUVlH/7MCaoYInbaei9WOZ7xPDhfQO1eOTgNwoYJIWdPlB8eO7cLWjoilqnBeEZVB/0uRflbhAIIMp4faK9ObGXd+dbKwzuvTQZWmGEpXqv9lpy/x4F62Vbw3HhRlNr9AjDMHmnciEai57YC10eOy48YdvWk+Cg5cbHBo83Sr9/aWiq/k1+blOkkPhFlaFFtSewkkRGkpXtzbUGk4xKeMNqeI0rumoUKYV9k1v/UtBX6F3Z9YrfSFbovCqr4hh/UPDX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/26/24 3:36 PM, Linus Torvalds wrote: > Now, fixing that, and you end up with > > Longest line is 61861 (82kB) > > so it's now "only" 82kB in size, and that actually comes from > , which has this: > > static inline unsigned bio_segments(struct bio *bio) > { > ... > bio_for_each_segment(bv, bio, iter) > segs++; > > which looks very tame indeed, but it turns out that > "bio_for_each_segment()" expands to 82kB of code. > > Jens? Maybe time to look into this? Eek yes, that looks horrible. I'll take a look. -- Jens Axboe