From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F14E74AC8 for ; Tue, 3 Dec 2024 19:19:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B9AD6B0088; Tue, 3 Dec 2024 14:19:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16A7F6B0089; Tue, 3 Dec 2024 14:19:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7736B008A; Tue, 3 Dec 2024 14:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE4246B0088 for ; Tue, 3 Dec 2024 14:19:11 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 81EDC1C74F3 for ; Tue, 3 Dec 2024 19:19:11 +0000 (UTC) X-FDA: 82854610608.18.BC39023 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 48901A0019 for ; Tue, 3 Dec 2024 19:18:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SnmbFfEP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733253536; a=rsa-sha256; cv=none; b=kmse2kKoHBTcpoVfvn4EOpgKnJalzjCBnrAL3etxMqtCmVP/zaJgyvRSHMdKqWTU6y0Tml T4Y/pwfvOcbXBitVzr5fDLDLIB/BxJiZq66Te2WXeEkZlsWOSRYgo9g5k7hBM5LOGZURJI YK4gK42FAQNA73xjL3tpryLF1UoGyJA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SnmbFfEP; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733253536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4HYWX4lY+1zgmP6GYTzg/DCn9ab+q4upkCeyneBu0NI=; b=zc/0qq7Nru3QsUyzkhLX3A6fmahX5cYdw+0sBzx3wjT7GS0TfcaDjarAfzXTIorXOcvaG+ 9Pi5gvqDFGzedgOirw9AXUAO5+eQaIT+YXZGrcIEnXT7nl+zGDlu2cr0oIJeV6FI5E+sEg ZfCVramBVcSgI5yl4iS5XeEoE1vAFS0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733253548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4HYWX4lY+1zgmP6GYTzg/DCn9ab+q4upkCeyneBu0NI=; b=SnmbFfEPaltcmYu9k6nbL+NAQz+tu5y5IGNv2K6eMSR27jQ/UHU37FhGFT0o30neDRngOn j1jZZWjrzA91dUJJbz45aFXysnGRjq5KIQXi45BPQCJWKWkfuAqY656uw11eW9wrUeNLIL cFIElICbAIUclkFKm8jiJg8EWMUiUx0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-JA5MnpuYN66Zkz-T0Gb1aA-1; Tue, 03 Dec 2024 14:19:07 -0500 X-MC-Unique: JA5MnpuYN66Zkz-T0Gb1aA-1 X-Mimecast-MFC-AGG-ID: JA5MnpuYN66Zkz-T0Gb1aA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-434a90fecfeso43566175e9.1 for ; Tue, 03 Dec 2024 11:19:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733253546; x=1733858346; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4HYWX4lY+1zgmP6GYTzg/DCn9ab+q4upkCeyneBu0NI=; b=t5S/ht65DfsJwjye5a/thV5FkhsuWHs4JqhtK30YpgzZEffSde0M9rDBu7sgFxZ4nx DNVU1iRnF0ccbNPX8vef1NZIs1SqZlokIOpldikk9jwyVQgsKg1cQcNa1PD2oK630Dva lrUeaZu6u0XR14/4W0z8lQi2+cplc4I7Ktb4iahY+fmpBuvDfI+li8Bxbxz2wPvaLm3f 0ExjNuRsfhHdh7LPS9x6KQmvquIGMNrw+DAWxFi9jsAG5pWjiaGgRuVAEuJBai/rK8BH utaRgQML7t3oC36l+hkU35NvLO7jPHqNgz8kjixaXsYhMf+KHTZ1JOhxuO3VblHjV4FT C6eQ== X-Gm-Message-State: AOJu0YxB4olD//JwBxmYfCS660okUEsMQiHg30d85HUdZkDWOhUW50zs Fo7U2dUkuJYDCogTxWI8R9D/whpjT4xqGhfa32dyO5+FbSu6XWOooES3GTNAZ7rI1JS2a8QJUkJ mVxvaBCWlmn1D6plYzB+UfQyW0KsIVozOgDk16GFNAXXoV23f X-Gm-Gg: ASbGncum02g3/enqungWaHsbWJWfKRpBywXmRGPeXvEXUuBbq75oxyPIamCv5RC+XWW QDEOXHgGwFVVRqVC6WedAFSOUKJMxciyF96AEYUv4Wt75F4g3SrvY5rePYNbsm8jwp/iTxCX69a ay/dLIV3I0AuZdIoVvIWbDohh/2FUXlvSMvpjMUKC3VV9BBzJ9DdJgGgKXka+6VbYeC0+WKqxV4 2+L3qas8qdTheqYL1y8PXgrQ7AAL4iPqyGN2QfELxFk2bG6v6Av1EWVaaNhfSS5oJctiOG4tZUM JdAXDpEX0Rs9D0AHm9Mi61DfWPUm10ixc0TnwB8FAuvS8DM2JKIFhXK7wyrqCRFB7Cep2M3BuUH 47A== X-Received: by 2002:a05:600c:5125:b0:434:9da3:602b with SMTP id 5b1f17b1804b1-434d09affa9mr33331685e9.5.1733253546241; Tue, 03 Dec 2024 11:19:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhIUyp7FwdbibPnEWnU4E3YEQlfcnkhoAFOBhvJUKIYdte1NbCV16fBdAJsfpJijLKWBL2IA== X-Received: by 2002:a05:600c:5125:b0:434:9da3:602b with SMTP id 5b1f17b1804b1-434d09affa9mr33331445e9.5.1733253545832; Tue, 03 Dec 2024 11:19:05 -0800 (PST) Received: from ?IPV6:2003:cb:c746:1b00:fd9e:c26c:c552:1de7? (p200300cbc7461b00fd9ec26cc5521de7.dip0.t-ipconnect.de. [2003:cb:c746:1b00:fd9e:c26c:c552:1de7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa76b52bsm230954065e9.18.2024.12.03.11.19.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 11:19:04 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 20:19:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 4/6] mm/page_alloc: sort out the alloc_contig_range() gfp flags mess To: Vlastimil Babka , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Oscar Salvador , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-5-david@redhat.com> <96c92857-4850-4f85-9474-ac193c5ea48c@redhat.com> <04c1d28e-bbea-4499-9a6d-770f9ca53ba9@suse.cz> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <04c1d28e-bbea-4499-9a6d-770f9ca53ba9@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CCXsYLaFP7zhJRfRR-MNsFf7y450vF3zSDj3q0DscV8_1733253546 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 48901A0019 X-Stat-Signature: beh9e1wmfxgwrj3nz1pgw89z8qiqm7dr X-Rspam-User: X-HE-Tag: 1733253535-763914 X-HE-Meta: U2FsdGVkX19MLe0fxbkVqPyJ7rhLZNhojxy31cI29Obz8u/kl3GyUaP8dI46Ph7arOT9sSUcen9G5qJE8CYXaEi3+4iOAz5bZskcYp1C28Bb2lFSfnrBuQoZ9qYFks0O6cTUUSEmmpNNoFseu+qX22IRiY9s+KOhCIOEtj0aj28xoO7EQZO+V5LMRQ54Vved1YKmIN4pdduigyCjZP0NyIGVKrew3C5mRuqS+Nwf7oWUPmQjkG5xbmvu4wSmcpxXgPPtOtx7VQOfAypKSo68+z5mxenaH0VGMymO9P9fESN27k7NY24RezRwm7ybyzil8xevV0NpdVMc/J2Bc/eFW38XN3PHcvB9+yZwOXFgBv53ODQzIGuTH9O2+Ii/6bKVeG1agcdsVnwgXL0Fg2ubhjpcWD4K5/DGnj92wX8CrNI92Tq8C8B6xDKUxrSq5OjSWc1IDkB1yGSt2LekyGOLGNUOmy/Z0XJzZIqgOcDiKG5maDq3o1ziBJU1zFvEq37Xcg2UUH7bsu4AekblOr1gQvaGxs16hOr3IK5oEaLXWt2810jj7e6ggPWhS0C5DrcwkzhVRHo/1cc6LZFfq4C9XvKUc0SEscRV4TzyadLXNSYakXYhrZ0dypH4compkEwrmvs9DMrjYQbCMlXkIKutbHqcZEB2OGo9tR71ngCL2CHpY9B7Wop2WSW+mkI2vlPZnqHTvFDfQ5bEDuxhVTHLRnyJvRhYEGRYGHWHt3aHUDWo6cbmaoOa0e45FqABOPFGRuDsZdmOTII+09tTkn1WLryRIzO4XEKgEft9kRL9k2ekdboT2msLfDuAo+KC0rycLJBsob8MDGYUVEgkCMroTjCCggeO8JLchoBvuOirC0lkvMqAsRDuN6aX+Lwz9J2xZauYOcc9f84qTqdUSAgbXrTD6fK84gS7mqCspJo7kruP+b4+kwZ0H7sZl5BnHsE7UKQJ5lr80S/8mMhGn2D +ggB2pIn eQ0w1VwUG4zlKkP+wbVhWFCwFMFtor5NblSUsiNZ9ZcT/oqx6JDQKQfCN0WQK13VJw8Y9Y4r2Rj9bQqmyYikpJ9Ex4gKkzYobnS5AloH4ZPqmypALTZmtVkin/3xIcOANuLTfUPyyAYfNqX/1mfuhH+JvqEjuEAImA9svXS0ICVOo3e5knvWk94bs1MxdEb3JxG/oo1LKRFgRSAgdmc1wzDyet/mGl9FHs7eiWm0NNMtLV2lIRNg04+W/8RVE9AVShXOraaeFVIHSk/PT9orL8ZuUJ4mVLNb1ba5jiWkjyLXqMvQR7GFcgm7dISBiwyGvrI/1OjIGr97a/EtbNyqZwAYUMkHIIteDxD92FaonEsfFPqMvuJ42wo/6OgL+BdBlwH24Y1qZac0F+Ozxl45LkqyT3mtMFTvjW+WLzG0AEnTtQHzWYawcOCZyLF49vg8iHRHZBxrf8BsW2xr57dpAhD1PQPTB34a6Kv5lRExP6GomvufPswqxFZa7nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.12.24 15:24, Vlastimil Babka wrote: > On 12/3/24 15:12, David Hildenbrand wrote: >> On 03.12.24 14:55, Vlastimil Babka wrote: >>> On 12/3/24 10:47, David Hildenbrand wrote: >>>> It's all a bit complicated for alloc_contig_range(). For example, we don't >>>> support many flags, so let's start bailing out on unsupported >>>> ones -- ignoring the placement hints, as we are already given the range >>>> to allocate. >>>> >>>> While we currently set cc.gfp_mask, in __alloc_contig_migrate_range() we >>>> simply create yet another GFP mask whereby we ignore the reclaim flags >>>> specify by the caller. That looks very inconsistent. >>>> >>>> Let's clean it up, constructing the gfp flags used for >>>> compaction/migration exactly once. Update the documentation of the >>>> gfp_mask parameter for alloc_contig_range() and alloc_contig_pages(). >>>> >>>> Acked-by: Zi Yan >>>> Signed-off-by: David Hildenbrand >>> >>> Reviewed-by: Vlastimil Babka >>> >>>> + /* >>>> + * Flags to control page compaction/migration/reclaim, to free up our >>>> + * page range. Migratable pages are movable, __GFP_MOVABLE is implied >>>> + * for them. >>>> + * >>>> + * Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set, >>>> + * keep doing that to not degrade callers. >>>> + */ >>> >>> Wonder if we could revisit that eventually. Why limit migration targets by >>> cpuset via __GFP_HARDWALL if we were not called with __GFP_HARDWALL? And why >>> weaken the attempts with __GFP_RETRY_MAYFAIL if we didn't specify it? >> >> See below. >> >>> >>> Unless I'm missing something, cc->gfp is only checked for __GFP_FS and >>> __GFP_NOWARN in few places, so it's mostly migration_target_control the >>> callers could meaningfully influence. >> >> Note the fist change in the file, where we now use the mask instead of coming up >> with another one out of the blue. :) > > I know. What I wanted to say - cc->gfp is on its own only checked in few > places, but now since we also translate it to migration_target_control's > gfp_mask, it's mostly that part the caller might influence with the passed > flags. But we still impose own additions to it, limiting that influence. > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index ce7589a4ec01..54594cc4f650 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6294,7 +6294,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, >> int ret = 0; >> struct migration_target_control mtc = { >> .nid = zone_to_nid(cc->zone), >> - .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, >> + .gfp_mask = cc->gfp_mask, >> .reason = MR_CONTIG_RANGE, >> }; >> >> GFP_USER contains __GFP_HARDWALL. I am not sure if that matters here, but > > Yeah wonder if GFP_USER was used specifically for that part, or just randomly :) > >> likely the thing we are assuming here is that we are migrating a page, and >> usually, these are user allocation (except maybe balloon and some other non-lru >> movable things). > > Yeah and user allocations obey cpuset and mempolicies etc. But these are > likely somebody elses allocations that were done according to their > policies. With our migration we might be actually violating those, which > probably can't be helped (is at least migration within the same node > preferred? hmm). I would hope that we handle memory policies somehow (via VMAs? not sure). cpuset? I have no idea. But it doesn't seem to me that our caller's restrictions > (if those exist, would be enforced by __GFP_HARDWALL) are that relevant for > somebody else's pages? It was always set using "GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL", and I removed the same flag combination in #2 from memory offline code, and we do have the exact same thing in do_migrate_range() in mm/memory_hotplug.c. We should investigate if__GFP_HARDWALL is the right thing to use here, and if we can get rid of that by switching to GFP_KERNEL in all these places. I can look into it + send a follow-up patch. Thanks! -- Cheers, David / dhildenb