From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D112C6FD1C for ; Wed, 22 Mar 2023 14:49:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F98D6B0072; Wed, 22 Mar 2023 10:49:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0808E6B0075; Wed, 22 Mar 2023 10:49:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3B106B0078; Wed, 22 Mar 2023 10:49:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D1A5D6B0072 for ; Wed, 22 Mar 2023 10:49:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A0F181C5CE9 for ; Wed, 22 Mar 2023 14:49:35 +0000 (UTC) X-FDA: 80596817910.08.4924071 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf16.hostedemail.com (Postfix) with ESMTP id A1445180009 for ; Wed, 22 Mar 2023 14:49:33 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=X4fwNuM+; spf=pass (imf16.hostedemail.com: domain of philmd@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=philmd@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679496573; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QgpnOGjVLEuypN3ErDTiOI3NLlX/0j8wRBIzyu6JHTA=; b=hHVkrU8rKy2sUoWBTReaLgHkrQZeIfp8cVymIP4IReacCD3APv3YoNX0QjO8BKsFIa35jw 5LE7JXF/m/J4w/Rn0YWa62z3TXBg/jvIqTRcwW15NNtzr2kdSWbRpyNApVLqIoT9BBDq5s zX+QRQe2+yvg7jU8RYwIIGZkwOdw9m4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=X4fwNuM+; spf=pass (imf16.hostedemail.com: domain of philmd@linaro.org designates 209.85.128.42 as permitted sender) smtp.mailfrom=philmd@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679496573; a=rsa-sha256; cv=none; b=OznAOoLy4FgFqOXk3pbf3qS1LMJ2EUTJN5UDiY+8jzSnHtpFbJt9L1b/gycF6NmNlE9UQn I0fHwv7xAT3BI02YaI1BBJyUmxHHk19siPxxC6DMvpDxvHxMWDwcFrYnSPt4zpDFSR9j/G H0xQdqV1yfzxIWN9NgKv4c42nd/9VDQ= Received: by mail-wm1-f42.google.com with SMTP id w11so10665373wmo.2 for ; Wed, 22 Mar 2023 07:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679496572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QgpnOGjVLEuypN3ErDTiOI3NLlX/0j8wRBIzyu6JHTA=; b=X4fwNuM+lvoCT0eDdhrh8qu0d3y8CTVo2fmzUHYgTsVwCWryX5ksmhn3yTXvLSCuAr ZqLivJqI7xfK3Y/fQajsIQapKLatPD2OZA7WnIOmZqMJuX0vmG5fgBgAZAzfEjtFaqqF 0ygbTqiK1sWJZIVWPfCzGJ3yY0TtYjm00Tc03VMP5QMq8gsB0HJwcGgCTjAIh2niCs1R iYCu7tcRl135CP8hLfhfwt6i3Ux5cCOqF61Soa/Xii7F7h3ql5RG9mPYNgoR6Ffmnvbl gp0PojSSjNZQm3RnK3A5o2A4IOJH10vJouXGQlA1ZpTf5dW+cJBApJ0lHl2u1onEQiQz YKlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679496572; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QgpnOGjVLEuypN3ErDTiOI3NLlX/0j8wRBIzyu6JHTA=; b=6R6Vi9uwtij5IBQmtpl2xGIwhMo6+DDrmwYqQ/2cr0AeMQc20TNbFLMtnlkp++eEjR KsJAGaLEqllZIR2bfkvZ9G3OU8qGueUYfMZp/I1Y6zRM8U4LHLRsphiLrI+v/3FQZBGI vtNjR8upvxxusu/9X8v49ociEWZ3xjur8ULE/gxQE7X9c/O1FZeKSPJ/GzX9Kk51tkc7 EZuVJIGNKZkhFXL6fbmcwDIEp1UdZM3Lds3oD5W0QDoz0m7Rh6nFWDAz5lHRA8ozakiE DNCSYqT8Gi2171unYAuw7Bz94d8dvqgnXfKDV+HQoEoN6ao5l9hoQe4iW/Iuc70HbGFO 6cDQ== X-Gm-Message-State: AO0yUKWcv6l8kxpJtKRokKjv+F7ZUE3d/OqgoZuWgzZkFU8XyYmIj0lD CJXNufwT44+ZHGr3EicqV+skQw== X-Google-Smtp-Source: AK7set+9XZgGgwvM+OLoRVwuVwrg4HkIiNlpgiPve/1U/yoqf+U/sCmAPCSUxB1b4JfefI4G4O7OFQ== X-Received: by 2002:a7b:c7c4:0:b0:3ea:ed4d:38f6 with SMTP id z4-20020a7bc7c4000000b003eaed4d38f6mr5600772wmk.4.1679496572162; Wed, 22 Mar 2023 07:49:32 -0700 (PDT) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id p5-20020adfce05000000b002d64fcb362dsm8733633wrn.111.2023.03.22.07.49.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 07:49:31 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 15:49:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 01/14] mips: fix comment about pgtable_init() Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321144842.2401182-1-rppt@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230321144842.2401182-1-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 4q3awrnsrf9fywxwku4nkn5mytk7mh1y X-Rspam-User: X-Rspamd-Queue-Id: A1445180009 X-Rspamd-Server: rspam06 X-HE-Tag: 1679496573-114655 X-HE-Meta: U2FsdGVkX19FTpWwOR55uszFu0MM1JyKzZxFE3xCL7XRfM3ghfK2Zjq0jAuikXokJZ1C0rG2a4I2Gp8crluaMaPeAMIOz/oTX6WKGNCYzKtWWRHMtnPoy87izU1njn+F+1SCJm4RlIOsVOxMnVyjL1a4InGfGEi9z5IOb+rL1PKYzYe3GGOCs3RESU/+PEKRbsZa2aib/UPWdZV+rWdG77PcEla6hHTuafXdVozlQUkAWsgd9eZmuBM62EpsIprqliDBSRz0vJaR2OMSVq7I2wq6YFoHkDnM+b1bZ+HV/xN9AmKq+bDifciqekyV2l7xMNi5rbt3orjUxqRrTqHBa5MpaJIfX0kRDSw6ykRiYiy77qKaRFKKuB+S7yDs897LoJSWY7LN0ol5Vt0BnYlGm+oo0nclkjOg+JP01jqrfv/bFjdHtV4PBXh4Ajn9kfRO4YHABGLBIRVBsaUqRFh4X8Ous1DU4SdKkAQZEp9MaP6yfbFDW0nQdVVsLu3y5Rn7Cmu4zIwNCD7d1x2RQnbReGO1s25BlNrUw82Bc+mEbQW6XW6sjhz61Fi3BxJ9w0KrvX+hCBe9FkLPPAE6yffyKRDVBn0NfrKVt/DyAGYO/QyntHX+B43+IA7MVgS8eULo5q4WnywdINeZLtBsmD7xva/yZdCzMBbBi7zvnda2UmLrLI/fqM31+sKL/rqHG2UY4e0q9WEU6qKXbYiOMpAEhUuqFtVeCEiq78kI7Igp4yudDDrs4x4d/h7Q7h2QxuSJ7OE/IhBHwSaQyo5tV5ZqBbybQNL1EtZP8j9lvz/Z8ADqFtw2hJJp7UXUQTRIgujKjZO+Rgfej6Eqc2XAGsLCegF1yJqONT57n8CIPC8OiEvo0kge3rLfC4tEWue9uxO4PTlSQ2zGZI/w4I/utB1vE1NdUNT9TPpHC37gYTPUyhQpD/xder46TzxnuGDSnJJ2AuR/yhdnerkh9X1IwCp B/iHtlHY QIQ78OEt5dFd3ApBA7YjcU7142NEbdZEmM0gwXty9JTpx1OtDj5yjXrYa2YlaA2HpoagHwALSswsUFXZXxcpylgAzMMs9xc7ioqePO7Vr90+8PEAMTXFYErWQYkeD16mmLmbeDJnrRsNZc+wt/04WU2oW2cBqMtwj2p0IibGVzaIYYRasn24gWh48e2pmdawzYRapq1+Usvel9nvxBDMGLAth91SDhA5qSnSNM6nJ56qMG4ZgQUzISxjhHFnm6zJfoT1jzdoeFx+6D7gcvcnsyV5TXhWuuMVj7d25f24U6iuNhVv8c7E9+dNotkgYXmRTw19aWaaqHLlVZx+xaB5rocF6F/C7eS2xu9woVePJzofZZ+/w0Tmwcbjo2ON8hyga2sHIlagcxdVHVKEuEC0F5tip8w3LHBYcTRzycuzzL6guCUB7mnGPzSNCpIFcLmGhCu69sjiiaODg/bUvzcKd9o28Mtq5UrfUb5cNpJ2YhalbejC6wuyZNh1u5KDqw9VCUIoZQwEf9BS5UXYeR83S0Xl7tEg0bcoN1EdXqNkRPO17atwUqkp8UhrpVS9LaRW3Gqn/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21/3/23 15:48, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Comment about fixrange_init() says that its called from pgtable_init() > while the actual caller is pagetabe_init(). > > Update comment to match the code. > > Signed-off-by: Mike Rapoport (IBM) > Reviewed-by: David Hildenbrand > --- > arch/mips/include/asm/fixmap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/fixmap.h b/arch/mips/include/asm/fixmap.h > index beea14761cef..b037718d7e8b 100644 > --- a/arch/mips/include/asm/fixmap.h > +++ b/arch/mips/include/asm/fixmap.h > @@ -70,7 +70,7 @@ enum fixed_addresses { > #include > > /* > - * Called from pgtable_init() > + * Called from pagetable_init() I'm not sure about the usefulness of this comment; I suppose it predates git-grep. Anyhow, Reviewed-by: Philippe Mathieu-Daudé > */ > extern void fixrange_init(unsigned long start, unsigned long end, > pgd_t *pgd_base);