From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC24EC5B549 for ; Wed, 4 Jun 2025 11:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 697416B05AA; Wed, 4 Jun 2025 07:44:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6472E6B05AC; Wed, 4 Jun 2025 07:44:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50ECC6B05AD; Wed, 4 Jun 2025 07:44:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 32DBB6B05AA for ; Wed, 4 Jun 2025 07:44:28 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C7F351411DD for ; Wed, 4 Jun 2025 11:44:27 +0000 (UTC) X-FDA: 83517535374.04.D4804CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id EA0F780002 for ; Wed, 4 Jun 2025 11:44:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K2sBq3Wl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749037465; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lAZ6PoM2yHxT2XxiC3h9Ua+Sq3PY55BOVc0a18RVQnA=; b=yTOvMf1tAVcmkXo9MJx9qMvg2cJPp5BLK07PHVv2lMie+YNQuTgtEAPaSfax31zHMdrZHw M+9KAC+4CUrOXk7xQ6hkQxmy3m/Y7TpWwICTOdXbE+o7eGS1P3GVwTsAIQMNIuzRcYbIVd iBkEdrQ417ZooA8f3bVuG5LtsljPSxo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749037465; a=rsa-sha256; cv=none; b=MvX9Gln8rKq1XeblXSftjy4Sn5n2ixxUqvqiD0NdbHIDuyNKNBgcoAAt4XdVqMxRd0cJj6 J6zIUPA27jiMSv4tSKYxkIpT66KJ0PMRasECOYLKsadlGyq4XkdvOmTowJqbyunL45Qoxd 6fYHQ6HLgYek5IQdAMcMsiPEbjlxGFo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K2sBq3Wl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749037464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lAZ6PoM2yHxT2XxiC3h9Ua+Sq3PY55BOVc0a18RVQnA=; b=K2sBq3Wl4b8PrOMoRVqeB1hVwWjy+hlfb+X/TEJ+EHjU4jv+LNBt7Ghco8i7GhphYdQrJI aNGIQUNe+H7M9PdmQEF+TkVIT4YuN4+z5RO9bl6H1MS5OEa62zusVfz2Cs9K3Qo0aWvjwZ G0ROQo26x/0j/aQEQkQNK0CVTj6oBzc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-eTZDY5ApMC-VaZQdgnxt_g-1; Wed, 04 Jun 2025 07:44:21 -0400 X-MC-Unique: eTZDY5ApMC-VaZQdgnxt_g-1 X-Mimecast-MFC-AGG-ID: eTZDY5ApMC-VaZQdgnxt_g_1749037461 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a4f6ba526eso3692629f8f.1 for ; Wed, 04 Jun 2025 04:44:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749037460; x=1749642260; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lAZ6PoM2yHxT2XxiC3h9Ua+Sq3PY55BOVc0a18RVQnA=; b=uIYGw8GP4DxbUAcz6+7/K0oujIjhyGX1rchtt6NfIMX3lbhVPxZeiGYA4D4tb3jgvd lhVX544R7MxWRvunEi2p40FQN0Y07w9cBNsFqvx7wycE/fbO92HfqhwgWOdPiPlKBHiV /cOXwMzNo6+wgIo/iY/JIBv4i/uwYFKFWrsKz3xwG1kXz0GfdEu4FpX6q5QuOd1LEhbL DVI53UWqC+rzFW8Vo6eji2VkelguQ6OSY3nsyKYywhc+9slge8VreQQM76Jo6M6bun8d C0OPwGmQwZADlZMow6loX7/QACQWsEf+zfcmRVRz5Ip64jY2sAecNzlniEbppmvHN/1V 03mg== X-Forwarded-Encrypted: i=1; AJvYcCUTWmujM4Eajt+D1zrznjdBz5ATIBO9K6mVAOhBuYBPyJTB9vr+TXGcXn2tccbwKrNwXy7Au4S2zA==@kvack.org X-Gm-Message-State: AOJu0Yyq4b8Rund1EABFLNK0+gdh8Sv5JYThtq8LKPyMXyEoFWnTn/FM ++o72RmNHBbeIaQ1CCrEDdYiHTQl8+4CTZl7de+bGyIWC5DXTU6p7ZbPUhI/Vq7qSEv9J0OaMmT x8NmsyqjTT5HlQNUJz5UXL87P8VX9oQC5w0KMB3UrxR7iI/h4gcSv X-Gm-Gg: ASbGncvp/3TqBa0Hqola60UQ0Fzsi91mEtebacLRAgQ1BMEOdCtFPU0I9IA81w6KkBM 4qkjRVSYbio6sLbzhnxVmKIDLy+1ABzCY65eYhmbD/2VAd3ZEd4yhSceb4PkAW/wUHekH2khyt1 7EFhsnyfkxn8VVtoI9rCjc8T4A7hMMqs/2d6knt1kPjKZXqC0+d/Y5o+7PBIVdWgqOiXNCkU1c9 yvMMmqjrSd13xExyUv7jmIQL3FXdGjGDRZkjfK1e1LsRk/3bhRGkL1jo1B5ehfG9062J3mVQa3g E3Tsonf22xfLucQvIdLM/PShi6wN88K8G4WHtzbkeSB8zc/JycceTOmWOteFYphFe5VwIb/id4W pthvf3+m+DiIQdjM6P+SqWCrN4+/aLptJdjEhwCM= X-Received: by 2002:a5d:5f95:0:b0:3a4:ed62:c7e1 with SMTP id ffacd0b85a97d-3a51d8f59cfmr1948560f8f.12.1749037460514; Wed, 04 Jun 2025 04:44:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTk+ZZ/txMdPYiZPbWtN+UTbUQiFhEQ2KYLiZED5o28ZN+uPzMH8V5s47pXStLZWFaTG3UiA== X-Received: by 2002:a5d:5f95:0:b0:3a4:ed62:c7e1 with SMTP id ffacd0b85a97d-3a51d8f59cfmr1948538f8f.12.1749037460114; Wed, 04 Jun 2025 04:44:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451e505c350sm51456695e9.0.2025.06.04.04.44.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 04:44:19 -0700 (PDT) Message-ID: Date: Wed, 4 Jun 2025 13:44:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] mm: Optimize mprotect() by batch-skipping PTEs To: Dev Jain , akpm@linux-foundation.org Cc: ryan.roberts@arm.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com References: <20250519074824.42909-1-dev.jain@arm.com> <20250519074824.42909-2-dev.jain@arm.com> <912757c0-8a75-4307-a0bd-8755f6135b5a@redhat.com> <76afb4f3-79b5-4126-b408-614bb6202526@arm.com> <25c0c700-656c-4a8a-8ef1-5093581cf25c@redhat.com> <4f97491c-b0dd-406a-9ddb-4f4424571704@arm.com> <8c389ee5-f7a4-44f6-a0d6-cc01c3da4d91@redhat.com> <92cc1bfb-ab7a-4abc-afd0-49f8f2d12da0@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <92cc1bfb-ab7a-4abc-afd0-49f8f2d12da0@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C0K_JaSITZB0PZ309c4Hmgq0VEinLT4vPi7i2z-3vQI_1749037461 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EA0F780002 X-Stat-Signature: oxdtu5d4ncsm47p4pz7magxon9hdy7of X-Rspam-User: X-HE-Tag: 1749037464-127320 X-HE-Meta: U2FsdGVkX19JjrfLXP1HaKune5yaFv4o02KNb7+A2Wuy2NvZhe07WGtm5kZ4BvUmUE2ZnG+pzJyNWKeoD6rf+cg2jy97POMXu9b4KnCc/APrp4QR+XbR1QX/6RqhX/ZKWgnY1aCnyhuV6ugvyIq42nA8sLZtIGTlJ3pfg5ts0n4zu0yd5UiqvH8xquZLhsOxZo6ZsfOI1jIDVZ3jshrImNEzmIdsaHKXT2VycLFMncNv0v4w/or0RKM96HLFQi937KkCYNIqf9A+/AwHz+nrW5hxokV1LqNPtm+BWjBTwPx24TdBjww+cehF9F07fLzjlQbY7GgHMn5Jp3q68v6xZ5QvxTyV1RiXNKw0//epTcpVanXRVEIAGsZJGPT0nd0AhxL5tPEXRYaZsaNTgS1NV6flc6ItfJqnzKNwK3dQiSl093bucB9225cBekG25RCXeFlqPShsgUMh9y2OFj0/0XZv6vKxqDiXNfN/q/pPmfjwmn6k9oEcVN19gdc/5awalZ1gmx5+iDqfbIdR5y0GAFYMvq+riyEJ//KoOUzu2sdKWkiGdzEssZNTMa2vwRVU0eq/KQGUa+BQCxMAvfvXoR1r5CLKz7Dh8/T24hauJGr7g1B2m4GHg0FICebFopSnaydlrEZvoMuK+bAT1OHcNBzgnCuJJvEfv7RGmaEbi8FAMmXbwnWx02wgVVNpzG9vH1NvmsHY2Rq990jtTK2WEdQ/RPjxoDu7AKCk+sF/AxGxKjVUXokBI/txj9mQRrUZ6h53FFldRm+uq3PC0LgDU2tkQ0SaXbo9Tpq2LuX2exvC+NPYTdtiFLN/cbCYY4yyfYkhpbxpCJPWBMSyv2pl37jYntDaMMiAFpnj6bN6CSsV2SObTG8/McFCJ4DxIBOoZIZvDHckomWuQ1pA40nQwGpWDosl5H/4aPfQNbtOGCIrMrNMFHk2PTTxWZ9CmjA71rIuwzv/50A7bDnQ1Cw Lm/W7Cwc y5KLZ5dBlUMibeG0qBzXn+IpNiBFqdsiih/fgYmD9r/ECDQi7QAeGiELXvAWrz9OjxVn5VpUc5YzUfHosHq5ipwPnppZTx1Uou8T6I9mei75ZGiCq3vDGqoCYLis53p16r7rE1JEkqBC2WFJkQfnrW6A41sZ44aq0U6Tb15WMn/bwaqEhnQ1OaI2xHfMdd+0iyk0YnvjhwfxYdAbJA9r6lqxmWlwz8XZepUCRzsKzf9iNWK8LABlLE+nS/hYp+eM+6we5hI4ViikzF/9p5g8yRXefkV5KmeRPv0tUGd16qmq4LI4AFr4zkM+0RDzu7tYJH29gpxn9smwRgcsRTAY3EYqOHpTY+rL/WW8AuM1py+2G83fU1lUVEcbTPLx0kCjQKfTarI2W+A78XkMu3s8XmcuPFV9/iHlkqJNQ1tFua4soTWk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 12:38, Dev Jain wrote: > > On 22/05/25 9:48 pm, David Hildenbrand wrote: >> On 22.05.25 09:47, Dev Jain wrote: >>> >>> On 22/05/25 12:43 pm, David Hildenbrand wrote: >>>> >>>>>> ... likely with a better function name, >>>>> >>>>> >>>>> I want to be able to reuse the folio from vm_normal_folio(), and we >>>>> also >>>>> need >>>>> >>>>> nr_ptes to know how much to skip, so if there is no objection in >>>>> passing >>>>> int *nr_ptes, >>>>> >>>>> or struct folio **foliop to this new function, then I'll carry on with >>>>> your suggestion :) >>>> >>>> Can you quickly prototype what you have in mind and paste it here? >>>> Will make it easier :) >>> >>> >>> if (prot_numa) >>> >>>       func(vma, addr, oldpte, &nr); >> >> I'd probably return "nr_ptes" and return the folio using a &folio >> instead. >> >> That way, you can easily extend the function to return the folio in >> the patch where you really need it (not this patch IIUR :) ) > > Just confirming, you mean to return nr_ptes and get the folio by passing > &folio, and the function parameter will be struct folio **foliop? Yes. -- Cheers, David / dhildenb