From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15DF5C433F5 for ; Fri, 18 Mar 2022 02:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 629B78D0002; Thu, 17 Mar 2022 22:24:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D7E58D0001; Thu, 17 Mar 2022 22:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 478AE8D0002; Thu, 17 Mar 2022 22:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 37ED78D0001 for ; Thu, 17 Mar 2022 22:24:24 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D2D1EA3EFC for ; Fri, 18 Mar 2022 02:24:23 +0000 (UTC) X-FDA: 79255912806.22.1FCBA39 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf14.hostedemail.com (Postfix) with ESMTP id DB245100016 for ; Fri, 18 Mar 2022 02:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647570262; x=1679106262; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=Q7hisbvBGNfj5YC4rXo2BpgMWBUIyBvckqTBdnQku9o=; b=kHveFZyRIPhNIMjge4qOfHKFl3ijje1Ln9imNxUtPcLAXNYTuo1o8nzS bgIhb7qny6kXkeEGzoEpIr4OXd7T/SfFxS/jIZMDqgVibhOdnzxo58Inz M1x23oDRzEVn/QGCzidcwRJ4dUiZtF6hZiGRFiOlYxvXHBM5n++pe9Ziy YCu7C2GUCxTBPWGpbFJOV/1J3Kn8qoQ30tDaaTYwn0yj7jq48hknscIuA 5MbBzAvFI9sP6+h1pmB9l9m5AXlbDq9htCmYBMReE8MFSh/eDvIpXdnaw 8UhsjmlhgM+gePKPowgQLMfDkOJUU+BHjRyv28aOjyC7lDjjSul9ptKvg A==; X-IronPort-AV: E=McAfee;i="6200,9189,10289"; a="236976013" X-IronPort-AV: E=Sophos;i="5.90,191,1643702400"; d="scan'208";a="236976013" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 19:24:21 -0700 X-IronPort-AV: E=Sophos;i="5.90,191,1643702400"; d="scan'208";a="558206106" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.255.29.89]) ([10.255.29.89]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2022 19:24:19 -0700 Subject: Re: [kbuild-all] Re: [linux-next:master 4103/11953] arch/arm/kernel/ftrace.c:229:6: warning: no previous prototype for function 'prepare_ftrace_return' To: Steven Rostedt , kernel test robot Cc: Ard Biesheuvel , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List References: <202203110903.3xDyTUVl-lkp@intel.com> <20220310210404.7c47aa47@gandalf.local.home> From: "Chen, Rong A" Message-ID: Date: Fri, 18 Mar 2022 10:24:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20220310210404.7c47aa47@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DB245100016 X-Stat-Signature: zh5x617yngn897h8f4cow5ikjbs4yoju X-Rspam-User: Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kHveFZyR; spf=none (imf14.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 192.55.52.136) smtp.mailfrom=rong.a.chen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1647570262-513127 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/11/2022 10:04 AM, Steven Rostedt wrote: > On Fri, 11 Mar 2022 09:44:11 +0800 > kernel test robot wrote: > >> Hi Ard, >> >> FYI, the error/warning still remains. >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >> head: 71941773e143369a73c9c4a3b62fbb60736a1182 >> commit: 41918ec82eb6f80c8b401422f27ca76c85aa0cb7 [4103/11953] ARM: ftrace: enable the graph tracer with the EABI unwinder >> config: arm-aspeed_g4_defconfig (https://download.01.org/0day-ci/archive/20220311/202203110903.3xDyTUVl-lkp@intel.com/config) >> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install arm cross compiling tool for clang build >> # apt-get install binutils-arm-linux-gnueabi >> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=41918ec82eb6f80c8b401422f27ca76c85aa0cb7 >> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >> git fetch --no-tags linux-next master >> git checkout 41918ec82eb6f80c8b401422f27ca76c85aa0cb7 >> # save the config file to linux build tree >> mkdir build_dir >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/kernel/ >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> >>>> arch/arm/kernel/ftrace.c:229:6: warning: no previous prototype for function 'prepare_ftrace_return' [-Wmissing-prototypes] >> void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, >> ^ >> arch/arm/kernel/ftrace.c:229:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >> void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, >> ^ >> static >> 1 warning generated. >> > > Hmm, this is only called from assembly code, which doesn't care about > prototypes. Is there a way to quiet this warning to say "this is called > only by assembly"? > > Or do we just add a useless prototype to shut it up? > > -- Steve Hi Steve, Sorry for the inconvenience, it's a duplicate false positive: https://lore.kernel.org/linux-mm/2db6ea89-846a-8d4e-a5c3-954411332029@intel.com/ please ignore the report, we are still working on it. Best Regards, Rong Chen > > >> >> vim +/prepare_ftrace_return +229 arch/arm/kernel/ftrace.c >> >> 376cfa8730c08c Tim Bird 2010-10-09 226 >> 376cfa8730c08c Tim Bird 2010-10-09 227 #ifdef CONFIG_FUNCTION_GRAPH_TRACER >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 228 asmlinkage >> 376cfa8730c08c Tim Bird 2010-10-09 @229 void prepare_ftrace_return(unsigned long *parent, unsigned long self_addr, >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 230 unsigned long frame_pointer, >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 231 unsigned long stack_pointer) >> 376cfa8730c08c Tim Bird 2010-10-09 232 { >> 376cfa8730c08c Tim Bird 2010-10-09 233 unsigned long return_hooker = (unsigned long) &return_to_handler; >> 376cfa8730c08c Tim Bird 2010-10-09 234 unsigned long old; >> 376cfa8730c08c Tim Bird 2010-10-09 235 >> 376cfa8730c08c Tim Bird 2010-10-09 236 if (unlikely(atomic_read(¤t->tracing_graph_pause))) >> 376cfa8730c08c Tim Bird 2010-10-09 237 return; >> 376cfa8730c08c Tim Bird 2010-10-09 238 >> 953f534a7ed6b7 Ard Biesheuvel 2022-01-25 239 if (IS_ENABLED(CONFIG_UNWINDER_FRAME_POINTER)) { >> 953f534a7ed6b7 Ard Biesheuvel 2022-01-25 240 /* FP points one word below parent's top of stack */ >> 953f534a7ed6b7 Ard Biesheuvel 2022-01-25 241 frame_pointer += 4; >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 242 } else { >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 243 struct stackframe frame = { >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 244 .fp = frame_pointer, >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 245 .sp = stack_pointer, >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 246 .lr = self_addr, >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 247 .pc = self_addr, >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 248 }; >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 249 if (unwind_frame(&frame) < 0) >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 250 return; >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 251 if (frame.lr != self_addr) >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 252 parent = frame.lr_addr; >> 41918ec82eb6f8 Ard Biesheuvel 2022-01-25 253 frame_pointer = frame.sp; >> 953f534a7ed6b7 Ard Biesheuvel 2022-01-25 254 } >> 953f534a7ed6b7 Ard Biesheuvel 2022-01-25 255 >> 376cfa8730c08c Tim Bird 2010-10-09 256 old = *parent; >> 376cfa8730c08c Tim Bird 2010-10-09 257 *parent = return_hooker; >> 376cfa8730c08c Tim Bird 2010-10-09 258 >> f1f5b14afd7cce Steven Rostedt (VMware 2018-11-18 259) if (function_graph_enter(old, self_addr, frame_pointer, NULL)) >> 376cfa8730c08c Tim Bird 2010-10-09 260 *parent = old; >> 376cfa8730c08c Tim Bird 2010-10-09 261 } >> dd686eb13959e4 Rabin Vincent 2010-11-06 262 >> >> :::::: The code at line 229 was first introduced by commit >> :::::: 376cfa8730c08c0394d0aa1d4a80fd8c9971f323 ARM: ftrace: function graph tracer support >> >> :::::: TO: Tim Bird >> :::::: CC: Rabin Vincent >> >> --- >> 0-DAY CI Kernel Test Service >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org >